[INFO] crate fuzzyrusty 0.1.0 is already in cache [INFO] extracting crate fuzzyrusty 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/fuzzyrusty/0.1.0 [INFO] extracting crate fuzzyrusty 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fuzzyrusty/0.1.0 [INFO] validating manifest of fuzzyrusty-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fuzzyrusty-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fuzzyrusty-0.1.0 [INFO] finished frobbing fuzzyrusty-0.1.0 [INFO] frobbed toml for fuzzyrusty-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/fuzzyrusty/0.1.0/Cargo.toml [INFO] started frobbing fuzzyrusty-0.1.0 [INFO] finished frobbing fuzzyrusty-0.1.0 [INFO] frobbed toml for fuzzyrusty-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fuzzyrusty/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fuzzyrusty-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fuzzyrusty/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a7e052eaed6b6e39944933f9f93703556a310d9c29d3c16e0c74533772eb6445 [INFO] running `"docker" "start" "-a" "a7e052eaed6b6e39944933f9f93703556a310d9c29d3c16e0c74533772eb6445"` [INFO] [stderr] Checking fuzzyrusty v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt::is_ascii': use inherent methods instead [INFO] [stderr] --> src/utils.rs:6:40 [INFO] [stderr] | [INFO] [stderr] 6 | result = result.chars().filter(AsciiExt::is_ascii).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/utils.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | for size in (1..slen + 1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: use: `(1..=slen)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/utils.rs:34:22 [INFO] [stderr] | [INFO] [stderr] 34 | for start in 0..slen - size + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `0..=slen - size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/utils.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt::is_ascii': use inherent methods instead [INFO] [stderr] --> src/utils.rs:6:40 [INFO] [stderr] | [INFO] [stderr] 6 | result = result.chars().filter(AsciiExt::is_ascii).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/fuzz.rs:86:28 [INFO] [stderr] | [INFO] [stderr] 86 | let combined_1to2 = if diff1to2_str.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!diff1to2_str.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/fuzz.rs:91:28 [INFO] [stderr] | [INFO] [stderr] 91 | let combined_2to1 = if diff2to1_str.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!diff2to1_str.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/fuzz.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | / vec![partial_ratio(&intersect_str, &combined_1to2), [INFO] [stderr] 98 | | partial_ratio(&intersect_str, &combined_2to1), [INFO] [stderr] 99 | | partial_ratio(&combined_1to2, &combined_2to1)] [INFO] [stderr] 100 | | .iter() [INFO] [stderr] 101 | | .max() [INFO] [stderr] 102 | | .unwrap() [INFO] [stderr] 103 | | .clone() [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 97 | *vec![partial_ratio(&intersect_str, &combined_1to2), [INFO] [stderr] 98 | partial_ratio(&intersect_str, &combined_2to1), [INFO] [stderr] 99 | partial_ratio(&combined_1to2, &combined_2to1)] [INFO] [stderr] 100 | .iter() [INFO] [stderr] 101 | .max() [INFO] [stderr] 102 | .unwrap() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/fuzz.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | / vec![ratio(&intersect_str, &combined_1to2), [INFO] [stderr] 106 | | ratio(&intersect_str, &combined_2to1), [INFO] [stderr] 107 | | ratio(&combined_1to2, &combined_2to1)] [INFO] [stderr] 108 | | .iter() [INFO] [stderr] 109 | | .max() [INFO] [stderr] 110 | | .unwrap() [INFO] [stderr] 111 | | .clone() [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 105 | *vec![ratio(&intersect_str, &combined_1to2), [INFO] [stderr] 106 | ratio(&intersect_str, &combined_2to1), [INFO] [stderr] 107 | ratio(&combined_1to2, &combined_2to1)] [INFO] [stderr] 108 | .iter() [INFO] [stderr] 109 | .max() [INFO] [stderr] 110 | .unwrap() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/utils.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | for size in (1..slen + 1).rev() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: use: `(1..=slen)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/utils.rs:34:22 [INFO] [stderr] | [INFO] [stderr] 34 | for start in 0..slen - size + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `0..=slen - size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/fuzz.rs:86:28 [INFO] [stderr] | [INFO] [stderr] 86 | let combined_1to2 = if diff1to2_str.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!diff1to2_str.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/fuzz.rs:91:28 [INFO] [stderr] | [INFO] [stderr] 91 | let combined_2to1 = if diff2to1_str.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!diff2to1_str.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/fuzz.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | / vec![partial_ratio(&intersect_str, &combined_1to2), [INFO] [stderr] 98 | | partial_ratio(&intersect_str, &combined_2to1), [INFO] [stderr] 99 | | partial_ratio(&combined_1to2, &combined_2to1)] [INFO] [stderr] 100 | | .iter() [INFO] [stderr] 101 | | .max() [INFO] [stderr] 102 | | .unwrap() [INFO] [stderr] 103 | | .clone() [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 97 | *vec![partial_ratio(&intersect_str, &combined_1to2), [INFO] [stderr] 98 | partial_ratio(&intersect_str, &combined_2to1), [INFO] [stderr] 99 | partial_ratio(&combined_1to2, &combined_2to1)] [INFO] [stderr] 100 | .iter() [INFO] [stderr] 101 | .max() [INFO] [stderr] 102 | .unwrap() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/fuzz.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | / vec![ratio(&intersect_str, &combined_1to2), [INFO] [stderr] 106 | | ratio(&intersect_str, &combined_2to1), [INFO] [stderr] 107 | | ratio(&combined_1to2, &combined_2to1)] [INFO] [stderr] 108 | | .iter() [INFO] [stderr] 109 | | .max() [INFO] [stderr] 110 | | .unwrap() [INFO] [stderr] 111 | | .clone() [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 105 | *vec![ratio(&intersect_str, &combined_1to2), [INFO] [stderr] 106 | ratio(&intersect_str, &combined_2to1), [INFO] [stderr] 107 | ratio(&combined_1to2, &combined_2to1)] [INFO] [stderr] 108 | .iter() [INFO] [stderr] 109 | .max() [INFO] [stderr] 110 | .unwrap() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.02s [INFO] running `"docker" "inspect" "a7e052eaed6b6e39944933f9f93703556a310d9c29d3c16e0c74533772eb6445"` [INFO] running `"docker" "rm" "-f" "a7e052eaed6b6e39944933f9f93703556a310d9c29d3c16e0c74533772eb6445"` [INFO] [stdout] a7e052eaed6b6e39944933f9f93703556a310d9c29d3c16e0c74533772eb6445