[INFO] crate funfsm 0.2.1 is already in cache [INFO] extracting crate funfsm 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/funfsm/0.2.1 [INFO] extracting crate funfsm 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/funfsm/0.2.1 [INFO] validating manifest of funfsm-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of funfsm-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing funfsm-0.2.1 [INFO] finished frobbing funfsm-0.2.1 [INFO] frobbed toml for funfsm-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/funfsm/0.2.1/Cargo.toml [INFO] started frobbing funfsm-0.2.1 [INFO] finished frobbing funfsm-0.2.1 [INFO] frobbed toml for funfsm-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/funfsm/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting funfsm-0.2.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/funfsm/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 368d1812782fc383dea16ae563ea28e6d0d52a97f9aa8ef9e800fea4fef7fcfc [INFO] running `"docker" "start" "-a" "368d1812782fc383dea16ae563ea28e6d0d52a97f9aa8ef9e800fea4fef7fcfc"` [INFO] [stderr] Checking funfsm v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fsm.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fsm.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | ctx: ctx [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fsm_check.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | constraints: constraints [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `constraints` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fsm.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fsm.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | ctx: ctx [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fsm_check.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | constraints: constraints [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `constraints` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/fsm.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn(&mut T::Context, T::Msg) -> (StateFn, Vec) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> src/constraints.rs:4:18 [INFO] [stderr] | [INFO] [stderr] 4 | pub type Pred = Box bool>; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(type_alias_bounds)] on by default [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] help: use fully disambiguated paths (i.e., `::Assoc`) to refer to associated types in type aliases [INFO] [stderr] --> src/constraints.rs:4:38 [INFO] [stderr] | [INFO] [stderr] 4 | pub type Pred = Box bool>; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> src/constraints.rs:5:29 [INFO] [stderr] | [INFO] [stderr] 5 | pub type TransitionCheck [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] help: use fully disambiguated paths (i.e., `::Assoc`) to refer to associated types in type aliases [INFO] [stderr] --> src/constraints.rs:6:11 [INFO] [stderr] | [INFO] [stderr] 6 | = fn(&T::Context, &T::Context, &T::Msg, &Vec) -> Result<(), String>; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] help: use fully disambiguated paths (i.e., `::Assoc`) to refer to associated types in type aliases [INFO] [stderr] --> src/constraints.rs:6:24 [INFO] [stderr] | [INFO] [stderr] 6 | = fn(&T::Context, &T::Context, &T::Msg, &Vec) -> Result<(), String>; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] help: use fully disambiguated paths (i.e., `::Assoc`) to refer to associated types in type aliases [INFO] [stderr] --> src/constraints.rs:6:37 [INFO] [stderr] | [INFO] [stderr] 6 | = fn(&T::Context, &T::Context, &T::Msg, &Vec) -> Result<(), String>; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: use fully disambiguated paths (i.e., `::Assoc`) to refer to associated types in type aliases [INFO] [stderr] --> src/constraints.rs:6:50 [INFO] [stderr] | [INFO] [stderr] 6 | = fn(&T::Context, &T::Context, &T::Msg, &Vec) -> Result<(), String>; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `constraints::Constraints` [INFO] [stderr] --> src/constraints.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Constraints { [INFO] [stderr] 16 | | Constraints { [INFO] [stderr] 17 | | preconditions: HashMap::new(), [INFO] [stderr] 18 | | invariants: Vec::new(), [INFO] [stderr] 19 | | transitions: HashMap::new() [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/constraints.rs:47:37 [INFO] [stderr] | [INFO] [stderr] 47 | output: &Vec) -> Result<(), String> [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[T::Output]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/constraints.rs:68:23 [INFO] [stderr] | [INFO] [stderr] 68 | fn check_vec(vec: &Vec<(Pred, String)>, ctx: &T::Context) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(Pred, String)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/fsm_check.rs:34:41 [INFO] [stderr] | [INFO] [stderr] 34 | output: &Vec) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[T::Output]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/fsm.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn(&mut T::Context, T::Msg) -> (StateFn, Vec) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> src/constraints.rs:4:18 [INFO] [stderr] | [INFO] [stderr] 4 | pub type Pred = Box bool>; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(type_alias_bounds)] on by default [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] help: use fully disambiguated paths (i.e., `::Assoc`) to refer to associated types in type aliases [INFO] [stderr] --> src/constraints.rs:4:38 [INFO] [stderr] | [INFO] [stderr] 4 | pub type Pred = Box bool>; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> src/constraints.rs:5:29 [INFO] [stderr] | [INFO] [stderr] 5 | pub type TransitionCheck [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] help: use fully disambiguated paths (i.e., `::Assoc`) to refer to associated types in type aliases [INFO] [stderr] --> src/constraints.rs:6:11 [INFO] [stderr] | [INFO] [stderr] 6 | = fn(&T::Context, &T::Context, &T::Msg, &Vec) -> Result<(), String>; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] help: use fully disambiguated paths (i.e., `::Assoc`) to refer to associated types in type aliases [INFO] [stderr] --> src/constraints.rs:6:24 [INFO] [stderr] | [INFO] [stderr] 6 | = fn(&T::Context, &T::Context, &T::Msg, &Vec) -> Result<(), String>; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] help: use fully disambiguated paths (i.e., `::Assoc`) to refer to associated types in type aliases [INFO] [stderr] --> src/constraints.rs:6:37 [INFO] [stderr] | [INFO] [stderr] 6 | = fn(&T::Context, &T::Context, &T::Msg, &Vec) -> Result<(), String>; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: use fully disambiguated paths (i.e., `::Assoc`) to refer to associated types in type aliases [INFO] [stderr] --> src/constraints.rs:6:50 [INFO] [stderr] | [INFO] [stderr] 6 | = fn(&T::Context, &T::Context, &T::Msg, &Vec) -> Result<(), String>; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `constraints::Constraints` [INFO] [stderr] --> src/constraints.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Constraints { [INFO] [stderr] 16 | | Constraints { [INFO] [stderr] 17 | | preconditions: HashMap::new(), [INFO] [stderr] 18 | | invariants: Vec::new(), [INFO] [stderr] 19 | | transitions: HashMap::new() [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/constraints.rs:47:37 [INFO] [stderr] | [INFO] [stderr] 47 | output: &Vec) -> Result<(), String> [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[T::Output]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/constraints.rs:68:23 [INFO] [stderr] | [INFO] [stderr] 68 | fn check_vec(vec: &Vec<(Pred, String)>, ctx: &T::Context) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(Pred, String)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/fsm_check.rs:34:41 [INFO] [stderr] | [INFO] [stderr] 34 | output: &Vec) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[T::Output]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Context` [INFO] [stderr] --> tests/bowl_fsm.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / pub fn new() -> Context { [INFO] [stderr] 29 | | Context { [INFO] [stderr] 30 | | contents: 0, // The bowl starts off empty [INFO] [stderr] 31 | | reserves: MAX_RESERVES, [INFO] [stderr] 32 | | } [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> tests/bowl_fsm.rs:175:27 [INFO] [stderr] | [INFO] [stderr] 175 | _output: &Vec) -> Result<(), String> [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[StoreReq]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> tests/bowl_fsm.rs:192:27 [INFO] [stderr] | [INFO] [stderr] 192 | _output: &Vec) -> Result<(), String> [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[StoreReq]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.11s [INFO] running `"docker" "inspect" "368d1812782fc383dea16ae563ea28e6d0d52a97f9aa8ef9e800fea4fef7fcfc"` [INFO] running `"docker" "rm" "-f" "368d1812782fc383dea16ae563ea28e6d0d52a97f9aa8ef9e800fea4fef7fcfc"` [INFO] [stdout] 368d1812782fc383dea16ae563ea28e6d0d52a97f9aa8ef9e800fea4fef7fcfc