[INFO] crate frontmatter 0.3.0 is already in cache [INFO] extracting crate frontmatter 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/frontmatter/0.3.0 [INFO] extracting crate frontmatter 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/frontmatter/0.3.0 [INFO] validating manifest of frontmatter-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of frontmatter-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing frontmatter-0.3.0 [INFO] finished frobbing frontmatter-0.3.0 [INFO] frobbed toml for frontmatter-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/frontmatter/0.3.0/Cargo.toml [INFO] started frobbing frontmatter-0.3.0 [INFO] finished frobbing frontmatter-0.3.0 [INFO] frobbed toml for frontmatter-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/frontmatter/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting frontmatter-0.3.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/frontmatter/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 514fce174cd5c7264d3a2f75601a99db21c8efe848de7ba92bc12c7f37faae18 [INFO] running `"docker" "start" "-a" "514fce174cd5c7264d3a2f75601a99db21c8efe848de7ba92bc12c7f37faae18"` [INFO] [stderr] Checking frontmatter v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / match text.starts_with("---\n") { [INFO] [stderr] 9 | | true => { [INFO] [stderr] 10 | | let slice_after_marker = &text[4..]; [INFO] [stderr] 11 | | let fm_end = slice_after_marker.find("---\n"); [INFO] [stderr] ... | [INFO] [stderr] 19 | | false => None [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 8 | if text.starts_with("---\n") { [INFO] [stderr] 9 | let slice_after_marker = &text[4..]; [INFO] [stderr] 10 | let fm_end = slice_after_marker.find("---\n"); [INFO] [stderr] 11 | if fm_end.is_none() { [INFO] [stderr] 12 | return None [INFO] [stderr] 13 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/lib.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | / if fm_end.is_none() { [INFO] [stderr] 13 | | return None [INFO] [stderr] 14 | | }; [INFO] [stderr] | |_____________^ help: replace_it_with: `fm_end?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / match text.starts_with("---\n") { [INFO] [stderr] 9 | | true => { [INFO] [stderr] 10 | | let slice_after_marker = &text[4..]; [INFO] [stderr] 11 | | let fm_end = slice_after_marker.find("---\n"); [INFO] [stderr] ... | [INFO] [stderr] 19 | | false => None [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 8 | if text.starts_with("---\n") { [INFO] [stderr] 9 | let slice_after_marker = &text[4..]; [INFO] [stderr] 10 | let fm_end = slice_after_marker.find("---\n"); [INFO] [stderr] 11 | if fm_end.is_none() { [INFO] [stderr] 12 | return None [INFO] [stderr] 13 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/lib.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | / if fm_end.is_none() { [INFO] [stderr] 13 | | return None [INFO] [stderr] 14 | | }; [INFO] [stderr] | |_____________^ help: replace_it_with: `fm_end?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | assert!(stripped_string.to_string() == test_string[31..].to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `stripped_string` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:69:44 [INFO] [stderr] | [INFO] [stderr] 69 | assert!(stripped_string.to_string() == test_string[31..].to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `test_string[31..]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | assert!(stripped_string.to_string() == test_string); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `stripped_string` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | assert!(stripped_string.to_string() == test_string[8..]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `stripped_string` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.64s [INFO] running `"docker" "inspect" "514fce174cd5c7264d3a2f75601a99db21c8efe848de7ba92bc12c7f37faae18"` [INFO] running `"docker" "rm" "-f" "514fce174cd5c7264d3a2f75601a99db21c8efe848de7ba92bc12c7f37faae18"` [INFO] [stdout] 514fce174cd5c7264d3a2f75601a99db21c8efe848de7ba92bc12c7f37faae18