[INFO] crate from_int_derive 0.1.2 is already in cache [INFO] extracting crate from_int_derive 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/from_int_derive/0.1.2 [INFO] extracting crate from_int_derive 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/from_int_derive/0.1.2 [INFO] validating manifest of from_int_derive-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of from_int_derive-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing from_int_derive-0.1.2 [INFO] finished frobbing from_int_derive-0.1.2 [INFO] frobbed toml for from_int_derive-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/from_int_derive/0.1.2/Cargo.toml [INFO] started frobbing from_int_derive-0.1.2 [INFO] finished frobbing from_int_derive-0.1.2 [INFO] frobbed toml for from_int_derive-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/from_int_derive/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting from_int_derive-0.1.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/from_int_derive/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 51b9901d27b7f30dce35b9d3d1fceb716bc3394b0d9222dc835b356c417d8b0b [INFO] running `"docker" "start" "-a" "51b9901d27b7f30dce35b9d3d1fceb716bc3394b0d9222dc835b356c417d8b0b"` [INFO] [stderr] Checking proc-macro2 v0.2.3 [INFO] [stderr] Checking quote v0.4.2 [INFO] [stderr] Checking syn v0.12.15 [INFO] [stderr] Checking from_int_derive v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:49:11 [INFO] [stderr] | [INFO] [stderr] 49 | name: &syn::Ident, [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `syn::Ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | / match &variant.discriminant { [INFO] [stderr] 61 | | &Some((_, syn::Expr::Lit(ref lit))) => { // extract inner data [INFO] [stderr] 62 | | match lit.lit { [INFO] [stderr] 63 | | syn::Lit::Int(ref _lit) => { [INFO] [stderr] ... | [INFO] [stderr] 74 | | _ => panic!("from_int: Enum variants must be literal integers!") [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 60 | match variant.discriminant { [INFO] [stderr] 61 | Some((_, syn::Expr::Lit(ref lit))) => { // extract inner data [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:49:11 [INFO] [stderr] | [INFO] [stderr] 49 | name: &syn::Ident, [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `syn::Ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | / match &variant.discriminant { [INFO] [stderr] 61 | | &Some((_, syn::Expr::Lit(ref lit))) => { // extract inner data [INFO] [stderr] 62 | | match lit.lit { [INFO] [stderr] 63 | | syn::Lit::Int(ref _lit) => { [INFO] [stderr] ... | [INFO] [stderr] 74 | | _ => panic!("from_int: Enum variants must be literal integers!") [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 60 | match variant.discriminant { [INFO] [stderr] 61 | Some((_, syn::Expr::Lit(ref lit))) => { // extract inner data [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.10s [INFO] running `"docker" "inspect" "51b9901d27b7f30dce35b9d3d1fceb716bc3394b0d9222dc835b356c417d8b0b"` [INFO] running `"docker" "rm" "-f" "51b9901d27b7f30dce35b9d3d1fceb716bc3394b0d9222dc835b356c417d8b0b"` [INFO] [stdout] 51b9901d27b7f30dce35b9d3d1fceb716bc3394b0d9222dc835b356c417d8b0b