[INFO] crate from_hashmap 0.1.0 is already in cache [INFO] extracting crate from_hashmap 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/from_hashmap/0.1.0 [INFO] extracting crate from_hashmap 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/from_hashmap/0.1.0 [INFO] validating manifest of from_hashmap-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of from_hashmap-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing from_hashmap-0.1.0 [INFO] finished frobbing from_hashmap-0.1.0 [INFO] frobbed toml for from_hashmap-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/from_hashmap/0.1.0/Cargo.toml [INFO] started frobbing from_hashmap-0.1.0 [INFO] finished frobbing from_hashmap-0.1.0 [INFO] frobbed toml for from_hashmap-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/from_hashmap/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting from_hashmap-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/from_hashmap/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 67df41a61ea84e7c1b7e3f788d385e80133c9390483e71017a5849f525f44998 [INFO] running `"docker" "start" "-a" "67df41a61ea84e7c1b7e3f788d385e80133c9390483e71017a5849f525f44998"` [INFO] [stderr] Checking from_hashmap v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:26:25 [INFO] [stderr] | [INFO] [stderr] 26 | for ref field in fields.iter() { [INFO] [stderr] | ^^^^^^^^^ ------------- help: try: `let field = &fields.iter();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:27:25 [INFO] [stderr] | [INFO] [stderr] 27 | / match &field.ident { [INFO] [stderr] 28 | | &Some(ref ident) => idents.push(ident.clone()), [INFO] [stderr] 29 | | &None => panic!("Your struct is missing a field identity!"), [INFO] [stderr] 30 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 27 | match field.ident { [INFO] [stderr] 28 | Some(ref ident) => idents.push(ident.clone()), [INFO] [stderr] 29 | None => panic!("Your struct is missing a field identity!"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:26:25 [INFO] [stderr] | [INFO] [stderr] 26 | for ref field in fields.iter() { [INFO] [stderr] | ^^^^^^^^^ ------------- help: try: `let field = &fields.iter();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:27:25 [INFO] [stderr] | [INFO] [stderr] 27 | / match &field.ident { [INFO] [stderr] 28 | | &Some(ref ident) => idents.push(ident.clone()), [INFO] [stderr] 29 | | &None => panic!("Your struct is missing a field identity!"), [INFO] [stderr] 30 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 27 | match field.ident { [INFO] [stderr] 28 | Some(ref ident) => idents.push(ident.clone()), [INFO] [stderr] 29 | None => panic!("Your struct is missing a field identity!"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.98s [INFO] running `"docker" "inspect" "67df41a61ea84e7c1b7e3f788d385e80133c9390483e71017a5849f525f44998"` [INFO] running `"docker" "rm" "-f" "67df41a61ea84e7c1b7e3f788d385e80133c9390483e71017a5849f525f44998"` [INFO] [stdout] 67df41a61ea84e7c1b7e3f788d385e80133c9390483e71017a5849f525f44998