[INFO] crate format_escape_default 0.1.1 is already in cache [INFO] extracting crate format_escape_default 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/format_escape_default/0.1.1 [INFO] extracting crate format_escape_default 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/format_escape_default/0.1.1 [INFO] validating manifest of format_escape_default-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of format_escape_default-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing format_escape_default-0.1.1 [INFO] finished frobbing format_escape_default-0.1.1 [INFO] frobbed toml for format_escape_default-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/format_escape_default/0.1.1/Cargo.toml [INFO] started frobbing format_escape_default-0.1.1 [INFO] finished frobbing format_escape_default-0.1.1 [INFO] frobbed toml for format_escape_default-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/format_escape_default/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting format_escape_default-0.1.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/format_escape_default/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0471da27186e60505e04a29d4288a5d0ee8c1f9407b1c04bfb9ecec3faf35c12 [INFO] running `"docker" "start" "-a" "0471da27186e60505e04a29d4288a5d0ee8c1f9407b1c04bfb9ecec3faf35c12"` [INFO] [stderr] Checking format_escape_default v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:24:67 [INFO] [stderr] | [INFO] [stderr] 24 | write!(f, "{}", unsafe { char::from_u32_unchecked(esc_ch as u32) })?; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(esc_ch)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:45:1 [INFO] [stderr] | [INFO] [stderr] 45 | / pub fn format_escape_default<'a>(i: &'a [u8]) -> EscapeDefaultFmt<'a> { [INFO] [stderr] 46 | | EscapeDefaultFmt { inner: i } [INFO] [stderr] 47 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:24:67 [INFO] [stderr] | [INFO] [stderr] 24 | write!(f, "{}", unsafe { char::from_u32_unchecked(esc_ch as u32) })?; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(esc_ch)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:45:1 [INFO] [stderr] | [INFO] [stderr] 45 | / pub fn format_escape_default<'a>(i: &'a [u8]) -> EscapeDefaultFmt<'a> { [INFO] [stderr] 46 | | EscapeDefaultFmt { inner: i } [INFO] [stderr] 47 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.71s [INFO] running `"docker" "inspect" "0471da27186e60505e04a29d4288a5d0ee8c1f9407b1c04bfb9ecec3faf35c12"` [INFO] running `"docker" "rm" "-f" "0471da27186e60505e04a29d4288a5d0ee8c1f9407b1c04bfb9ecec3faf35c12"` [INFO] [stdout] 0471da27186e60505e04a29d4288a5d0ee8c1f9407b1c04bfb9ecec3faf35c12