[INFO] crate flexible-locks_derive 0.1.0 is already in cache [INFO] extracting crate flexible-locks_derive 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/flexible-locks_derive/0.1.0 [INFO] extracting crate flexible-locks_derive 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/flexible-locks_derive/0.1.0 [INFO] validating manifest of flexible-locks_derive-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of flexible-locks_derive-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing flexible-locks_derive-0.1.0 [INFO] finished frobbing flexible-locks_derive-0.1.0 [INFO] frobbed toml for flexible-locks_derive-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/flexible-locks_derive/0.1.0/Cargo.toml [INFO] started frobbing flexible-locks_derive-0.1.0 [INFO] finished frobbing flexible-locks_derive-0.1.0 [INFO] frobbed toml for flexible-locks_derive-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/flexible-locks_derive/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting flexible-locks_derive-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/flexible-locks_derive/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c50d5eeda1f6d32614cbd087c724c18278dd6c44de7f085b73011c77a0bc5b62 [INFO] running `"docker" "start" "-a" "c50d5eeda1f6d32614cbd087c724c18278dd6c44de7f085b73011c77a0bc5b62"` [INFO] [stderr] Checking syn v0.13.11 [INFO] [stderr] Checking flexible-locks_derive v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | / match self { [INFO] [stderr] 40 | | &StructField::Numbered(_, ref f) => f, [INFO] [stderr] 41 | | &StructField::Named(ref f) => f, [INFO] [stderr] 42 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 39 | match *self { [INFO] [stderr] 40 | StructField::Numbered(_, ref f) => f, [INFO] [stderr] 41 | StructField::Named(ref f) => f, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:48:27 [INFO] [stderr] | [INFO] [stderr] 48 | tokens.append_all(match self { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 49 | | &StructField::Numbered(ref n, _) => quote! { #n }, [INFO] [stderr] 50 | | &StructField::Named(&Field { [INFO] [stderr] 51 | | ident: Some(ref i), .. [INFO] [stderr] 52 | | }) => quote! { #i }, [INFO] [stderr] 53 | | _ => unreachable!(), [INFO] [stderr] 54 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 48 | tokens.append_all(match *self { [INFO] [stderr] 49 | StructField::Numbered(ref n, _) => quote! { #n }, [INFO] [stderr] 50 | StructField::Named(&Field { [INFO] [stderr] 51 | ident: Some(ref i), .. [INFO] [stderr] 52 | }) => quote! { #i }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | / match self { [INFO] [stderr] 40 | | &StructField::Numbered(_, ref f) => f, [INFO] [stderr] 41 | | &StructField::Named(ref f) => f, [INFO] [stderr] 42 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 39 | match *self { [INFO] [stderr] 40 | StructField::Numbered(_, ref f) => f, [INFO] [stderr] 41 | StructField::Named(ref f) => f, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:48:27 [INFO] [stderr] | [INFO] [stderr] 48 | tokens.append_all(match self { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 49 | | &StructField::Numbered(ref n, _) => quote! { #n }, [INFO] [stderr] 50 | | &StructField::Named(&Field { [INFO] [stderr] 51 | | ident: Some(ref i), .. [INFO] [stderr] 52 | | }) => quote! { #i }, [INFO] [stderr] 53 | | _ => unreachable!(), [INFO] [stderr] 54 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 48 | tokens.append_all(match *self { [INFO] [stderr] 49 | StructField::Numbered(ref n, _) => quote! { #n }, [INFO] [stderr] 50 | StructField::Named(&Field { [INFO] [stderr] 51 | ident: Some(ref i), .. [INFO] [stderr] 52 | }) => quote! { #i }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.22s [INFO] running `"docker" "inspect" "c50d5eeda1f6d32614cbd087c724c18278dd6c44de7f085b73011c77a0bc5b62"` [INFO] running `"docker" "rm" "-f" "c50d5eeda1f6d32614cbd087c724c18278dd6c44de7f085b73011c77a0bc5b62"` [INFO] [stdout] c50d5eeda1f6d32614cbd087c724c18278dd6c44de7f085b73011c77a0bc5b62