[INFO] crate fletcher 0.0.1 is already in cache [INFO] extracting crate fletcher 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/fletcher/0.0.1 [INFO] extracting crate fletcher 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fletcher/0.0.1 [INFO] validating manifest of fletcher-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fletcher-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fletcher-0.0.1 [INFO] finished frobbing fletcher-0.0.1 [INFO] frobbed toml for fletcher-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/fletcher/0.0.1/Cargo.toml [INFO] started frobbing fletcher-0.0.1 [INFO] finished frobbing fletcher-0.0.1 [INFO] frobbed toml for fletcher-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fletcher/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fletcher-0.0.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fletcher/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b6e55d4e2d1eed52a54112cf5917f981578092f6cd117b121bb8c300a6193543 [INFO] running `"docker" "start" "-a" "b6e55d4e2d1eed52a54112cf5917f981578092f6cd117b121bb8c300a6193543"` [INFO] [stderr] Checking fletcher v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fletcher32.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | 0x0000ffff [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fletcher64.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | 0x00000000ffffffff [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0000_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fletcher64.rs:20:17 [INFO] [stderr] | [INFO] [stderr] 20 | (self & 0xffffffff) + (self >> 32) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fletcher32.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | 0x0000ffff [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fletcher64.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | 0x00000000ffffffff [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0000_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fletcher64.rs:20:17 [INFO] [stderr] | [INFO] [stderr] 20 | (self & 0xffffffff) + (self >> 32) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:19:29 [INFO] [stderr] | [INFO] [stderr] 19 | let zeros = vec![0; 200000usize]; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `200_000usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:27:32 [INFO] [stderr] | [INFO] [stderr] 27 | let zeros = vec![0xff; 200000usize]; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `200_000usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:40:37 [INFO] [stderr] | [INFO] [stderr] 40 | assert!(checksum.value() == 0xdcf30fb3); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdcf3_0fb3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:45:29 [INFO] [stderr] | [INFO] [stderr] 45 | let zeros = vec![0; 200000usize]; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `200_000usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:48:37 [INFO] [stderr] | [INFO] [stderr] 48 | assert!(checksum.value() == 0xffffffff); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:53:34 [INFO] [stderr] | [INFO] [stderr] 53 | let zeros = vec![0xffff; 200000usize]; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `200_000usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:56:37 [INFO] [stderr] | [INFO] [stderr] 56 | assert!(checksum.value() == 0xffffffff); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:61:29 [INFO] [stderr] | [INFO] [stderr] 61 | let zeros = vec![0; 200000usize]; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `200_000usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:64:37 [INFO] [stderr] | [INFO] [stderr] 64 | assert!(checksum.value() == 0xffffffffffffffff); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:69:26 [INFO] [stderr] | [INFO] [stderr] 69 | let zeros = vec![0xffffffff; 200000usize]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:69:38 [INFO] [stderr] | [INFO] [stderr] 69 | let zeros = vec![0xffffffff; 200000usize]; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `200_000usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:72:37 [INFO] [stderr] | [INFO] [stderr] 72 | assert!(checksum.value() == 0xffffffffffffffff); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `generic_fletcher::Fletcher` [INFO] [stderr] --> src/generic_fletcher.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | / pub fn new() -> Fletcher { [INFO] [stderr] 25 | | Fletcher { [INFO] [stderr] 26 | | a: T::default_value(), [INFO] [stderr] 27 | | b: T::default_value(), [INFO] [stderr] 28 | | phantom: PhantomData, [INFO] [stderr] 29 | | } [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 19 | impl Default for generic_fletcher::Fletcher { [INFO] [stderr] 20 | fn default() -> Self { [INFO] [stderr] 21 | Self::new() [INFO] [stderr] 22 | } [INFO] [stderr] 23 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `generic_fletcher::Fletcher` [INFO] [stderr] --> src/generic_fletcher.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | / pub fn new() -> Fletcher { [INFO] [stderr] 25 | | Fletcher { [INFO] [stderr] 26 | | a: T::default_value(), [INFO] [stderr] 27 | | b: T::default_value(), [INFO] [stderr] 28 | | phantom: PhantomData, [INFO] [stderr] 29 | | } [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 19 | impl Default for generic_fletcher::Fletcher { [INFO] [stderr] 20 | fn default() -> Self { [INFO] [stderr] 21 | Self::new() [INFO] [stderr] 22 | } [INFO] [stderr] 23 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.75s [INFO] running `"docker" "inspect" "b6e55d4e2d1eed52a54112cf5917f981578092f6cd117b121bb8c300a6193543"` [INFO] running `"docker" "rm" "-f" "b6e55d4e2d1eed52a54112cf5917f981578092f6cd117b121bb8c300a6193543"` [INFO] [stdout] b6e55d4e2d1eed52a54112cf5917f981578092f6cd117b121bb8c300a6193543