[INFO] crate fix_checksum 0.0.1 is already in cache [INFO] extracting crate fix_checksum 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/fix_checksum/0.0.1 [INFO] extracting crate fix_checksum 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fix_checksum/0.0.1 [INFO] validating manifest of fix_checksum-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fix_checksum-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fix_checksum-0.0.1 [INFO] finished frobbing fix_checksum-0.0.1 [INFO] frobbed toml for fix_checksum-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/fix_checksum/0.0.1/Cargo.toml [INFO] started frobbing fix_checksum-0.0.1 [INFO] finished frobbing fix_checksum-0.0.1 [INFO] frobbed toml for fix_checksum-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fix_checksum/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fix_checksum-0.0.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fix_checksum/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 97c60e6718ab305d84445081996961e475f6e00f12ddda11dd5cd3395e5bc624 [INFO] running `"docker" "start" "-a" "97c60e6718ab305d84445081996961e475f6e00f12ddda11dd5cd3395e5bc624"` [INFO] [stderr] Checking fix_checksum v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:36:28 [INFO] [stderr] | [INFO] [stderr] 36 | const FIX_CHECKSUM_FIELD: &'static str = "\x31\x30\x3D"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:44:3 [INFO] [stderr] | [INFO] [stderr] 44 | return cs; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `cs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:41:11 [INFO] [stderr] | [INFO] [stderr] 41 | cs += *b as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(*b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:36:28 [INFO] [stderr] | [INFO] [stderr] 36 | const FIX_CHECKSUM_FIELD: &'static str = "\x31\x30\x3D"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:44:3 [INFO] [stderr] | [INFO] [stderr] 44 | return cs; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `cs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:179:5 [INFO] [stderr] | [INFO] [stderr] 179 | / return message_parts [INFO] [stderr] 180 | | .iter() [INFO] [stderr] 181 | | .fold(String::new(), |message, message_part| message.to_string() + message_part + delimiter); [INFO] [stderr] | |___________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 179 | message_parts [INFO] [stderr] 180 | .iter() [INFO] [stderr] 181 | .fold(String::new(), |message, message_part| message.to_string() + message_part + delimiter) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:41:11 [INFO] [stderr] | [INFO] [stderr] 41 | cs += *b as u32; [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(*b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> tests/lib.rs:8:3 [INFO] [stderr] | [INFO] [stderr] 8 | / return message_parts [INFO] [stderr] 9 | | .iter() [INFO] [stderr] 10 | | .fold(String::new(), |message, message_part| message.to_string() + message_part + delimiter); [INFO] [stderr] | |_________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 8 | message_parts [INFO] [stderr] 9 | .iter() [INFO] [stderr] 10 | .fold(String::new(), |message, message_part| message.to_string() + message_part + delimiter) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.98s [INFO] running `"docker" "inspect" "97c60e6718ab305d84445081996961e475f6e00f12ddda11dd5cd3395e5bc624"` [INFO] running `"docker" "rm" "-f" "97c60e6718ab305d84445081996961e475f6e00f12ddda11dd5cd3395e5bc624"` [INFO] [stdout] 97c60e6718ab305d84445081996961e475f6e00f12ddda11dd5cd3395e5bc624