[INFO] crate file-utils 0.1.5 is already in cache [INFO] extracting crate file-utils 0.1.5 into work/ex/clippy-test-run/sources/stable/reg/file-utils/0.1.5 [INFO] extracting crate file-utils 0.1.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/file-utils/0.1.5 [INFO] validating manifest of file-utils-0.1.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of file-utils-0.1.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing file-utils-0.1.5 [INFO] finished frobbing file-utils-0.1.5 [INFO] frobbed toml for file-utils-0.1.5 written to work/ex/clippy-test-run/sources/stable/reg/file-utils/0.1.5/Cargo.toml [INFO] started frobbing file-utils-0.1.5 [INFO] finished frobbing file-utils-0.1.5 [INFO] frobbed toml for file-utils-0.1.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/file-utils/0.1.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting file-utils-0.1.5 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/file-utils/0.1.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 486fcf08b675d39ef983e282cdd5368e02e87799b210ca66186227685aaf50b7 [INFO] running `"docker" "start" "-a" "486fcf08b675d39ef983e282cdd5368e02e87799b210ca66186227685aaf50b7"` [INFO] [stderr] Checking file-utils v0.1.5 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/conversions/u.rs:11:24 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn bytes_to_u16(x: &[u8; 2]) -> u16 [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 2]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/conversions/u.rs:13:6 [INFO] [stderr] | [INFO] [stderr] 13 | ((x[1] as u16) << 8) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(x[1])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(x[0] as u16)` [INFO] [stderr] --> src/conversions/u.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | ((x[0] as u16) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/conversions/u.rs:14:6 [INFO] [stderr] | [INFO] [stderr] 14 | ((x[0] as u16) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(x[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/conversions/u.rs:27:24 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn bytes_to_u32(x: &[u8; 4]) -> u32 [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/conversions/u.rs:29:6 [INFO] [stderr] | [INFO] [stderr] 29 | ((x[3] as u32) << 24) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(x[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/conversions/u.rs:30:6 [INFO] [stderr] | [INFO] [stderr] 30 | ((x[2] as u32) << 16) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(x[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/conversions/u.rs:31:6 [INFO] [stderr] | [INFO] [stderr] 31 | ((x[1] as u32) << 8) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(x[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(x[0] as u32)` [INFO] [stderr] --> src/conversions/u.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | ((x[0] as u32) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/conversions/u.rs:32:6 [INFO] [stderr] | [INFO] [stderr] 32 | ((x[0] as u32) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(x[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/conversions/u.rs:49:24 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn bytes_to_u64(x: &[u8; 8]) -> u64 [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/conversions/u.rs:51:6 [INFO] [stderr] | [INFO] [stderr] 51 | ((x[7] as u64) << 56) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(x[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/conversions/u.rs:52:6 [INFO] [stderr] | [INFO] [stderr] 52 | ((x[6] as u64) << 48) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(x[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/conversions/u.rs:53:6 [INFO] [stderr] | [INFO] [stderr] 53 | ((x[5] as u64) << 40) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(x[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/conversions/u.rs:54:6 [INFO] [stderr] | [INFO] [stderr] 54 | ((x[4] as u64) << 32) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(x[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/conversions/u.rs:55:6 [INFO] [stderr] | [INFO] [stderr] 55 | ((x[3] as u64) << 24) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(x[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/conversions/u.rs:56:6 [INFO] [stderr] | [INFO] [stderr] 56 | ((x[2] as u64) << 16) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(x[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/conversions/u.rs:57:6 [INFO] [stderr] | [INFO] [stderr] 57 | ((x[1] as u64) << 8) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(x[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(x[0] as u64)` [INFO] [stderr] --> src/conversions/u.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | ((x[0] as u64) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/conversions/u.rs:58:6 [INFO] [stderr] | [INFO] [stderr] 58 | ((x[0] as u64) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(x[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/conversions/u.rs:76:4 [INFO] [stderr] | [INFO] [stderr] 76 | ((x >> 0) & 0xff) as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/conversions/u.rs:96:4 [INFO] [stderr] | [INFO] [stderr] 96 | ((x >> 0) & 0xff) as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/conversions/u.rs:122:4 [INFO] [stderr] | [INFO] [stderr] 122 | ((x >> 0) & 0xff) as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/conversions/i.rs:9:24 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn bytes_to_i16(x: &[u8; 2]) -> i16 [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/conversions/i.rs:11:6 [INFO] [stderr] | [INFO] [stderr] 11 | ((x[1] as i16) << 8) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i16::from(x[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(x[0] as i16)` [INFO] [stderr] --> src/conversions/i.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | ((x[0] as i16) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/conversions/i.rs:12:6 [INFO] [stderr] | [INFO] [stderr] 12 | ((x[0] as i16) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i16::from(x[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/conversions/i.rs:25:24 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn bytes_to_i32(x: &[u8; 4]) -> i32 [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/conversions/i.rs:27:6 [INFO] [stderr] | [INFO] [stderr] 27 | ((x[3] as i32) << 24) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(x[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/conversions/i.rs:28:6 [INFO] [stderr] | [INFO] [stderr] 28 | ((x[2] as i32) << 16) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(x[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/conversions/i.rs:29:6 [INFO] [stderr] | [INFO] [stderr] 29 | ((x[1] as i32) << 8) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(x[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(x[0] as i32)` [INFO] [stderr] --> src/conversions/i.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | ((x[0] as i32) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/conversions/i.rs:30:6 [INFO] [stderr] | [INFO] [stderr] 30 | ((x[0] as i32) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(x[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/conversions/i.rs:47:24 [INFO] [stderr] | [INFO] [stderr] 47 | pub fn bytes_to_i64(x: &[u8; 8]) -> i64 [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/conversions/i.rs:49:6 [INFO] [stderr] | [INFO] [stderr] 49 | ((x[7] as i64) << 56) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(x[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/conversions/i.rs:50:6 [INFO] [stderr] | [INFO] [stderr] 50 | ((x[6] as i64) << 48) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(x[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/conversions/i.rs:51:6 [INFO] [stderr] | [INFO] [stderr] 51 | ((x[5] as i64) << 40) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(x[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/conversions/i.rs:52:6 [INFO] [stderr] | [INFO] [stderr] 52 | ((x[4] as i64) << 32) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(x[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/conversions/i.rs:53:6 [INFO] [stderr] | [INFO] [stderr] 53 | ((x[3] as i64) << 24) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(x[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/conversions/i.rs:54:6 [INFO] [stderr] | [INFO] [stderr] 54 | ((x[2] as i64) << 16) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(x[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/conversions/i.rs:55:6 [INFO] [stderr] | [INFO] [stderr] 55 | ((x[1] as i64) << 8) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(x[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(x[0] as i64)` [INFO] [stderr] --> src/conversions/i.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | ((x[0] as i64) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/conversions/i.rs:56:6 [INFO] [stderr] | [INFO] [stderr] 56 | ((x[0] as i64) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(x[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/conversions/i.rs:73:4 [INFO] [stderr] | [INFO] [stderr] 73 | ((x >> 0) & 0xff) as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/conversions/i.rs:93:4 [INFO] [stderr] | [INFO] [stderr] 93 | ((x >> 0) & 0xff) as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/conversions/i.rs:119:4 [INFO] [stderr] | [INFO] [stderr] 119 | ((x >> 0) & 0xff) as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/conversions/f.rs:15:24 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn bytes_to_f32(x: &[u8; 4]) -> f32 [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> src/conversions/f.rs:17:14 [INFO] [stderr] | [INFO] [stderr] 17 | unsafe { transmute(bytes_to_u32(&x)) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(bytes_to_u32(&x))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_int_to_float)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/conversions/f.rs:20:24 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn bytes_to_f64(x: &[u8; 8]) -> f64 [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u64` to a `f64` [INFO] [stderr] --> src/conversions/f.rs:22:14 [INFO] [stderr] | [INFO] [stderr] 22 | unsafe { transmute(bytes_to_u64(&x)) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f64::from_bits(bytes_to_u64(&x))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/conversions/u.rs:11:24 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn bytes_to_u16(x: &[u8; 2]) -> u16 [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 2]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/conversions/u.rs:13:6 [INFO] [stderr] | [INFO] [stderr] 13 | ((x[1] as u16) << 8) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(x[1])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(x[0] as u16)` [INFO] [stderr] --> src/conversions/u.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | ((x[0] as u16) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/conversions/u.rs:14:6 [INFO] [stderr] | [INFO] [stderr] 14 | ((x[0] as u16) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(x[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/conversions/u.rs:27:24 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn bytes_to_u32(x: &[u8; 4]) -> u32 [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/conversions/u.rs:29:6 [INFO] [stderr] | [INFO] [stderr] 29 | ((x[3] as u32) << 24) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(x[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/conversions/u.rs:30:6 [INFO] [stderr] | [INFO] [stderr] 30 | ((x[2] as u32) << 16) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(x[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/conversions/u.rs:31:6 [INFO] [stderr] | [INFO] [stderr] 31 | ((x[1] as u32) << 8) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(x[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(x[0] as u32)` [INFO] [stderr] --> src/conversions/u.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | ((x[0] as u32) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/conversions/u.rs:32:6 [INFO] [stderr] | [INFO] [stderr] 32 | ((x[0] as u32) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(x[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/conversions/u.rs:49:24 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn bytes_to_u64(x: &[u8; 8]) -> u64 [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/conversions/u.rs:51:6 [INFO] [stderr] | [INFO] [stderr] 51 | ((x[7] as u64) << 56) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(x[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/conversions/u.rs:52:6 [INFO] [stderr] | [INFO] [stderr] 52 | ((x[6] as u64) << 48) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(x[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/conversions/u.rs:53:6 [INFO] [stderr] | [INFO] [stderr] 53 | ((x[5] as u64) << 40) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(x[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/conversions/u.rs:54:6 [INFO] [stderr] | [INFO] [stderr] 54 | ((x[4] as u64) << 32) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(x[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/conversions/u.rs:55:6 [INFO] [stderr] | [INFO] [stderr] 55 | ((x[3] as u64) << 24) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(x[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/conversions/u.rs:56:6 [INFO] [stderr] | [INFO] [stderr] 56 | ((x[2] as u64) << 16) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(x[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/conversions/u.rs:57:6 [INFO] [stderr] | [INFO] [stderr] 57 | ((x[1] as u64) << 8) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(x[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(x[0] as u64)` [INFO] [stderr] --> src/conversions/u.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | ((x[0] as u64) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/conversions/u.rs:58:6 [INFO] [stderr] | [INFO] [stderr] 58 | ((x[0] as u64) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(x[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/conversions/u.rs:76:4 [INFO] [stderr] | [INFO] [stderr] 76 | ((x >> 0) & 0xff) as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/conversions/u.rs:96:4 [INFO] [stderr] | [INFO] [stderr] 96 | ((x >> 0) & 0xff) as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/conversions/u.rs:122:4 [INFO] [stderr] | [INFO] [stderr] 122 | ((x >> 0) & 0xff) as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/conversions/i.rs:9:24 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn bytes_to_i16(x: &[u8; 2]) -> i16 [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/conversions/i.rs:11:6 [INFO] [stderr] | [INFO] [stderr] 11 | ((x[1] as i16) << 8) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i16::from(x[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(x[0] as i16)` [INFO] [stderr] --> src/conversions/i.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | ((x[0] as i16) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/conversions/i.rs:12:6 [INFO] [stderr] | [INFO] [stderr] 12 | ((x[0] as i16) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i16::from(x[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/conversions/i.rs:25:24 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn bytes_to_i32(x: &[u8; 4]) -> i32 [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/conversions/i.rs:27:6 [INFO] [stderr] | [INFO] [stderr] 27 | ((x[3] as i32) << 24) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(x[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/conversions/i.rs:28:6 [INFO] [stderr] | [INFO] [stderr] 28 | ((x[2] as i32) << 16) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(x[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/conversions/i.rs:29:6 [INFO] [stderr] | [INFO] [stderr] 29 | ((x[1] as i32) << 8) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(x[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(x[0] as i32)` [INFO] [stderr] --> src/conversions/i.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | ((x[0] as i32) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/conversions/i.rs:30:6 [INFO] [stderr] | [INFO] [stderr] 30 | ((x[0] as i32) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(x[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/conversions/i.rs:47:24 [INFO] [stderr] | [INFO] [stderr] 47 | pub fn bytes_to_i64(x: &[u8; 8]) -> i64 [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/conversions/i.rs:49:6 [INFO] [stderr] | [INFO] [stderr] 49 | ((x[7] as i64) << 56) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(x[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/conversions/i.rs:50:6 [INFO] [stderr] | [INFO] [stderr] 50 | ((x[6] as i64) << 48) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(x[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/conversions/i.rs:51:6 [INFO] [stderr] | [INFO] [stderr] 51 | ((x[5] as i64) << 40) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(x[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/conversions/i.rs:52:6 [INFO] [stderr] | [INFO] [stderr] 52 | ((x[4] as i64) << 32) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(x[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/conversions/i.rs:53:6 [INFO] [stderr] | [INFO] [stderr] 53 | ((x[3] as i64) << 24) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(x[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/conversions/i.rs:54:6 [INFO] [stderr] | [INFO] [stderr] 54 | ((x[2] as i64) << 16) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(x[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/conversions/i.rs:55:6 [INFO] [stderr] | [INFO] [stderr] 55 | ((x[1] as i64) << 8) + [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(x[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(x[0] as i64)` [INFO] [stderr] --> src/conversions/i.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | ((x[0] as i64) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/conversions/i.rs:56:6 [INFO] [stderr] | [INFO] [stderr] 56 | ((x[0] as i64) << 0) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(x[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/conversions/i.rs:73:4 [INFO] [stderr] | [INFO] [stderr] 73 | ((x >> 0) & 0xff) as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/conversions/i.rs:93:4 [INFO] [stderr] | [INFO] [stderr] 93 | ((x >> 0) & 0xff) as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/conversions/i.rs:119:4 [INFO] [stderr] | [INFO] [stderr] 119 | ((x >> 0) & 0xff) as u8, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/conversions/f.rs:15:24 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn bytes_to_f32(x: &[u8; 4]) -> f32 [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> src/conversions/f.rs:17:14 [INFO] [stderr] | [INFO] [stderr] 17 | unsafe { transmute(bytes_to_u32(&x)) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(bytes_to_u32(&x))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_int_to_float)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/conversions/f.rs:20:24 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn bytes_to_f64(x: &[u8; 8]) -> f64 [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u64` to a `f64` [INFO] [stderr] --> src/conversions/f.rs:22:14 [INFO] [stderr] | [INFO] [stderr] 22 | unsafe { transmute(bytes_to_u64(&x)) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f64::from_bits(bytes_to_u64(&x))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/conversions.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | assert_eq!(4294967295, u); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_967_295` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/conversions.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | assert_eq!(252645135, i); [INFO] [stderr] | ^^^^^^^^^ help: consider: `252_645_135` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `file_utils::write::Write` [INFO] [stderr] --> tests/read_tests.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use file_utils::write::Write; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/read_tests.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | assert_eq!(16909184, c.read_u32().unwrap()); [INFO] [stderr] | ^^^^^^^^ help: consider: `16_909_184` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/read_tests.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | assert_eq!(16909184, c.read_i32().unwrap()); [INFO] [stderr] | ^^^^^^^^ help: consider: `16_909_184` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> tests/conversions.rs:40:23 [INFO] [stderr] | [INFO] [stderr] 40 | let b = f32_to_bytes(3.14); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> tests/conversions.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | assert_eq!(3.14, f); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> tests/conversions.rs:43:2 [INFO] [stderr] | [INFO] [stderr] 43 | assert_eq!(3.14, f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> tests/conversions.rs:43:2 [INFO] [stderr] | [INFO] [stderr] 43 | assert_eq!(3.14, f); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `file-utils`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "486fcf08b675d39ef983e282cdd5368e02e87799b210ca66186227685aaf50b7"` [INFO] running `"docker" "rm" "-f" "486fcf08b675d39ef983e282cdd5368e02e87799b210ca66186227685aaf50b7"` [INFO] [stdout] 486fcf08b675d39ef983e282cdd5368e02e87799b210ca66186227685aaf50b7