[INFO] crate field-ref 0.2.0 is already in cache [INFO] extracting crate field-ref 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/field-ref/0.2.0 [INFO] extracting crate field-ref 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/field-ref/0.2.0 [INFO] validating manifest of field-ref-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of field-ref-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing field-ref-0.2.0 [INFO] finished frobbing field-ref-0.2.0 [INFO] frobbed toml for field-ref-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/field-ref/0.2.0/Cargo.toml [INFO] started frobbing field-ref-0.2.0 [INFO] finished frobbing field-ref-0.2.0 [INFO] frobbed toml for field-ref-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/field-ref/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting field-ref-0.2.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/field-ref/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 89580adfc0b0ed0a9caf05945968f9f6e4a08c16986827c0a3cc94e284240331 [INFO] running `"docker" "start" "-a" "89580adfc0b0ed0a9caf05945968f9f6e4a08c16986827c0a3cc94e284240331"` [INFO] [stderr] Checking field-ref v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:173:19 [INFO] [stderr] | [INFO] [stderr] 173 | pub fn offset(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:246:21 [INFO] [stderr] | [INFO] [stderr] 246 | pub fn chain(&self, fr: FieldRef) -> FieldRef { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:251:29 [INFO] [stderr] | [INFO] [stderr] 251 | pub fn as_opt_field_ref(&self) -> FieldRefAsOptionFieldRef { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:173:19 [INFO] [stderr] | [INFO] [stderr] 173 | pub fn offset(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:246:21 [INFO] [stderr] | [INFO] [stderr] 246 | pub fn chain(&self, fr: FieldRef) -> FieldRef { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:251:29 [INFO] [stderr] | [INFO] [stderr] 251 | pub fn as_opt_field_ref(&self) -> FieldRefAsOptionFieldRef { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/lib.rs:688:17 [INFO] [stderr] | [INFO] [stderr] 688 | let mut foo = Foo(10, 20); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/lib.rs:703:13 [INFO] [stderr] | [INFO] [stderr] 703 | let bar = Bar{ foo: Foo(10, 20), x: 30 }; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:666:13 [INFO] [stderr] | [INFO] [stderr] 666 | |e| if let &$($mut)* $e { $f: ref $($mut)* x, .. } = e { [INFO] [stderr] | _____________^ [INFO] [stderr] 667 | | Some(&$($mut)*(*x) $(.$fs)*) [INFO] [stderr] 668 | | } else { [INFO] [stderr] 669 | | None [INFO] [stderr] 670 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 760 | let fr1 = opt_field_ref_of!(E::A{1}); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:666:13 [INFO] [stderr] | [INFO] [stderr] 666 | |e| if let &$($mut)* $e { $f: ref $($mut)* x, .. } = e { [INFO] [stderr] | _____________^ [INFO] [stderr] 667 | | Some(&$($mut)*(*x) $(.$fs)*) [INFO] [stderr] 668 | | } else { [INFO] [stderr] 669 | | None [INFO] [stderr] 670 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 760 | let fr1 = opt_field_ref_of!(E::A{1}); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:666:13 [INFO] [stderr] | [INFO] [stderr] 666 | |e| if let &$($mut)* $e { $f: ref $($mut)* x, .. } = e { [INFO] [stderr] | _____________^ [INFO] [stderr] 667 | | Some(&$($mut)*(*x) $(.$fs)*) [INFO] [stderr] 668 | | } else { [INFO] [stderr] 669 | | None [INFO] [stderr] 670 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 761 | let fr2 = opt_field_ref_of!(E::B{x}); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:666:13 [INFO] [stderr] | [INFO] [stderr] 666 | |e| if let &$($mut)* $e { $f: ref $($mut)* x, .. } = e { [INFO] [stderr] | _____________^ [INFO] [stderr] 667 | | Some(&$($mut)*(*x) $(.$fs)*) [INFO] [stderr] 668 | | } else { [INFO] [stderr] 669 | | None [INFO] [stderr] 670 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 761 | let fr2 = opt_field_ref_of!(E::B{x}); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:666:13 [INFO] [stderr] | [INFO] [stderr] 666 | |e| if let &$($mut)* $e { $f: ref $($mut)* x, .. } = e { [INFO] [stderr] | _____________^ [INFO] [stderr] 667 | | Some(&$($mut)*(*x) $(.$fs)*) [INFO] [stderr] 668 | | } else { [INFO] [stderr] 669 | | None [INFO] [stderr] 670 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 777 | let fr1 = opt_field_ref_of!(sub::E2::X{0}); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:666:13 [INFO] [stderr] | [INFO] [stderr] 666 | |e| if let &$($mut)* $e { $f: ref $($mut)* x, .. } = e { [INFO] [stderr] | _____________^ [INFO] [stderr] 667 | | Some(&$($mut)*(*x) $(.$fs)*) [INFO] [stderr] 668 | | } else { [INFO] [stderr] 669 | | None [INFO] [stderr] 670 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 777 | let fr1 = opt_field_ref_of!(sub::E2::X{0}); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.72s [INFO] running `"docker" "inspect" "89580adfc0b0ed0a9caf05945968f9f6e4a08c16986827c0a3cc94e284240331"` [INFO] running `"docker" "rm" "-f" "89580adfc0b0ed0a9caf05945968f9f6e4a08c16986827c0a3cc94e284240331"` [INFO] [stdout] 89580adfc0b0ed0a9caf05945968f9f6e4a08c16986827c0a3cc94e284240331