[INFO] crate falcon-mos6502 0.0.1 is already in cache [INFO] extracting crate falcon-mos6502 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/falcon-mos6502/0.0.1 [INFO] extracting crate falcon-mos6502 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/falcon-mos6502/0.0.1 [INFO] validating manifest of falcon-mos6502-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of falcon-mos6502-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing falcon-mos6502-0.0.1 [INFO] finished frobbing falcon-mos6502-0.0.1 [INFO] frobbed toml for falcon-mos6502-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/falcon-mos6502/0.0.1/Cargo.toml [INFO] started frobbing falcon-mos6502-0.0.1 [INFO] finished frobbing falcon-mos6502-0.0.1 [INFO] frobbed toml for falcon-mos6502-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/falcon-mos6502/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting falcon-mos6502-0.0.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/falcon-mos6502/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1cf08d893640a664e6dcb50b114d5ce4f4375588e449ad33e09870a35233e287 [INFO] running `"docker" "start" "-a" "1cf08d893640a664e6dcb50b114d5ce4f4375588e449ad33e09870a35233e287"` [INFO] [stderr] Checking falcon-mos6502 v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib/lib.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] --> lib/lib.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib/lib.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | operand: operand, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `operand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib/lib.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | operand: operand, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `operand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib/lib.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | size: size [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib/lib.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | size: size [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> lib/lib.rs:93:15 [INFO] [stderr] | [INFO] [stderr] 93 | Some(((buf.get(1)?.clone() as u16) << 8) | (buf.get(2)?.clone() as u16)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf.get(1)?.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> lib/lib.rs:93:16 [INFO] [stderr] | [INFO] [stderr] 93 | Some(((buf.get(1)?.clone() as u16) << 8) | (buf.get(2)?.clone() as u16)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*(buf.get(1)?)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> lib/lib.rs:93:52 [INFO] [stderr] | [INFO] [stderr] 93 | Some(((buf.get(1)?.clone() as u16) << 8) | (buf.get(2)?.clone() as u16)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf.get(2)?.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> lib/lib.rs:93:53 [INFO] [stderr] | [INFO] [stderr] 93 | Some(((buf.get(1)?.clone() as u16) << 8) | (buf.get(2)?.clone() as u16)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*(buf.get(2)?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> lib/lib.rs:97:14 [INFO] [stderr] | [INFO] [stderr] 97 | Some(buf.get(1)?.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*(buf.get(1)?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> lib/lib.rs:100:18 [INFO] [stderr] | [INFO] [stderr] 100 | let opcode = buf.get(0)?.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*(buf.get(0)?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> lib/lib.rs:93:15 [INFO] [stderr] | [INFO] [stderr] 93 | Some(((buf.get(1)?.clone() as u16) << 8) | (buf.get(2)?.clone() as u16)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf.get(1)?.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> lib/lib.rs:93:16 [INFO] [stderr] | [INFO] [stderr] 93 | Some(((buf.get(1)?.clone() as u16) << 8) | (buf.get(2)?.clone() as u16)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*(buf.get(1)?)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> lib/lib.rs:93:52 [INFO] [stderr] | [INFO] [stderr] 93 | Some(((buf.get(1)?.clone() as u16) << 8) | (buf.get(2)?.clone() as u16)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(buf.get(2)?.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> lib/lib.rs:93:53 [INFO] [stderr] | [INFO] [stderr] 93 | Some(((buf.get(1)?.clone() as u16) << 8) | (buf.get(2)?.clone() as u16)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*(buf.get(2)?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> lib/lib.rs:97:14 [INFO] [stderr] | [INFO] [stderr] 97 | Some(buf.get(1)?.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*(buf.get(1)?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> lib/lib.rs:100:18 [INFO] [stderr] | [INFO] [stderr] 100 | let opcode = buf.get(0)?.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*(buf.get(0)?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> example/main.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | / loop { [INFO] [stderr] 27 | | let slice = match bytes.get(offset..bytes.len()) { [INFO] [stderr] 28 | | Some(slice) => slice, [INFO] [stderr] 29 | | None => { break; } [INFO] [stderr] ... | [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(slice) = bytes.get(offset..bytes.len()) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> example/main.rs:34:17 [INFO] [stderr] | [INFO] [stderr] 34 | / (0..instruction.size()) [INFO] [stderr] 35 | | .into_iter() [INFO] [stderr] | |________________________________^ help: consider removing `.into_iter()`: `(0..instruction.size())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> example/main.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | / loop { [INFO] [stderr] 27 | | let slice = match bytes.get(offset..bytes.len()) { [INFO] [stderr] 28 | | Some(slice) => slice, [INFO] [stderr] 29 | | None => { break; } [INFO] [stderr] ... | [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(slice) = bytes.get(offset..bytes.len()) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> example/main.rs:34:17 [INFO] [stderr] | [INFO] [stderr] 34 | / (0..instruction.size()) [INFO] [stderr] 35 | | .into_iter() [INFO] [stderr] | |________________________________^ help: consider removing `.into_iter()`: `(0..instruction.size())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.00s [INFO] running `"docker" "inspect" "1cf08d893640a664e6dcb50b114d5ce4f4375588e449ad33e09870a35233e287"` [INFO] running `"docker" "rm" "-f" "1cf08d893640a664e6dcb50b114d5ce4f4375588e449ad33e09870a35233e287"` [INFO] [stdout] 1cf08d893640a664e6dcb50b114d5ce4f4375588e449ad33e09870a35233e287