[INFO] crate etag 1.0.2 is already in cache [INFO] extracting crate etag 1.0.2 into work/ex/clippy-test-run/sources/stable/reg/etag/1.0.2 [INFO] extracting crate etag 1.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/etag/1.0.2 [INFO] validating manifest of etag-1.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of etag-1.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing etag-1.0.2 [INFO] finished frobbing etag-1.0.2 [INFO] frobbed toml for etag-1.0.2 written to work/ex/clippy-test-run/sources/stable/reg/etag/1.0.2/Cargo.toml [INFO] started frobbing etag-1.0.2 [INFO] finished frobbing etag-1.0.2 [INFO] frobbed toml for etag-1.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/etag/1.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting etag-1.0.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/etag/1.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0c3b5cf9ef8c7a71d32541019875361631c30f192aee14c9be9102efdb6ca492 [INFO] running `"docker" "start" "-a" "0c3b5cf9ef8c7a71d32541019875361631c30f192aee14c9be9102efdb6ca492"` [INFO] [stderr] Checking etag v1.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | / match self.weak { [INFO] [stderr] 168 | | true => write!(f, "W/\"{}\"", self.tag), [INFO] [stderr] 169 | | false => write!(f, "\"{}\"", self.tag), [INFO] [stderr] 170 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.weak { write!(f, "W/\"{}\"", self.tag) } else { write!(f, "\"{}\"", self.tag) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:214:13 [INFO] [stderr] | [INFO] [stderr] 214 | / match slice.is_ascii() { [INFO] [stderr] 215 | | true => Ok(EntityTag::strong(slice.to_string())), [INFO] [stderr] 216 | | false => Err(ParseError::NotAscii) [INFO] [stderr] 217 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if slice.is_ascii() { Ok(EntityTag::strong(slice.to_string())) } else { Err(ParseError::NotAscii) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:220:13 [INFO] [stderr] | [INFO] [stderr] 220 | / match slice.is_ascii() { [INFO] [stderr] 221 | | true => Ok(EntityTag::weak(slice.to_string())), [INFO] [stderr] 222 | | false => Err(ParseError::NotAscii) [INFO] [stderr] 223 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if slice.is_ascii() { Ok(EntityTag::weak(slice.to_string())) } else { Err(ParseError::NotAscii) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | / match self.weak { [INFO] [stderr] 168 | | true => write!(f, "W/\"{}\"", self.tag), [INFO] [stderr] 169 | | false => write!(f, "\"{}\"", self.tag), [INFO] [stderr] 170 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.weak { write!(f, "W/\"{}\"", self.tag) } else { write!(f, "\"{}\"", self.tag) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:214:13 [INFO] [stderr] | [INFO] [stderr] 214 | / match slice.is_ascii() { [INFO] [stderr] 215 | | true => Ok(EntityTag::strong(slice.to_string())), [INFO] [stderr] 216 | | false => Err(ParseError::NotAscii) [INFO] [stderr] 217 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if slice.is_ascii() { Ok(EntityTag::strong(slice.to_string())) } else { Err(ParseError::NotAscii) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:220:13 [INFO] [stderr] | [INFO] [stderr] 220 | / match slice.is_ascii() { [INFO] [stderr] 221 | | true => Ok(EntityTag::weak(slice.to_string())), [INFO] [stderr] 222 | | false => Err(ParseError::NotAscii) [INFO] [stderr] 223 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if slice.is_ascii() { Ok(EntityTag::weak(slice.to_string())) } else { Err(ParseError::NotAscii) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/etag.rs:24:19 [INFO] [stderr] | [INFO] [stderr] 24 | const FIRST: &'static str = "FIRST"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/etag.rs:25:20 [INFO] [stderr] | [INFO] [stderr] 25 | const SECOND: &'static str = "SECOND"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.97s [INFO] running `"docker" "inspect" "0c3b5cf9ef8c7a71d32541019875361631c30f192aee14c9be9102efdb6ca492"` [INFO] running `"docker" "rm" "-f" "0c3b5cf9ef8c7a71d32541019875361631c30f192aee14c9be9102efdb6ca492"` [INFO] [stdout] 0c3b5cf9ef8c7a71d32541019875361631c30f192aee14c9be9102efdb6ca492