[INFO] crate enumflags_derive 0.4.1 is already in cache [INFO] extracting crate enumflags_derive 0.4.1 into work/ex/clippy-test-run/sources/stable/reg/enumflags_derive/0.4.1 [INFO] extracting crate enumflags_derive 0.4.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/enumflags_derive/0.4.1 [INFO] validating manifest of enumflags_derive-0.4.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of enumflags_derive-0.4.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing enumflags_derive-0.4.1 [INFO] finished frobbing enumflags_derive-0.4.1 [INFO] frobbed toml for enumflags_derive-0.4.1 written to work/ex/clippy-test-run/sources/stable/reg/enumflags_derive/0.4.1/Cargo.toml [INFO] started frobbing enumflags_derive-0.4.1 [INFO] finished frobbing enumflags_derive-0.4.1 [INFO] frobbed toml for enumflags_derive-0.4.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/enumflags_derive/0.4.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting enumflags_derive-0.4.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/enumflags_derive/0.4.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4f44384ffc643807befb2be83952a34116249eb95ca6f1840dc750e1ff871d9c [INFO] running `"docker" "start" "-a" "4f44384ffc643807befb2be83952a34116249eb95ca6f1840dc750e1ff871d9c"` [INFO] [stderr] Checking syn v0.12.15 [INFO] [stderr] Checking enumflags_derive v0.4.1 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | / match expr{ [INFO] [stderr] 42 | | &Expr::Lit(ref expr_lit) => { [INFO] [stderr] 43 | | match expr_lit.lit { [INFO] [stderr] 44 | | syn::Lit::Int(ref lit_int) => lit_int.value(), [INFO] [stderr] ... | [INFO] [stderr] 57 | | _ => panic!("Only literals are supported") [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 41 | match *expr{ [INFO] [stderr] 42 | Expr::Lit(ref expr_lit) => { [INFO] [stderr] 43 | match expr_lit.lit { [INFO] [stderr] 44 | syn::Lit::Int(ref lit_int) => lit_int.value(), [INFO] [stderr] 45 | _ => panic!("Only Int literals are supported") [INFO] [stderr] 46 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:70:29 [INFO] [stderr] | [INFO] [stderr] 70 | / if let &syn::NestedMeta::Meta(syn::Meta::Word(ref ident)) = [INFO] [stderr] 71 | | mi [INFO] [stderr] 72 | | { [INFO] [stderr] 73 | | return Some(ident.clone()); [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 70 | if let syn::NestedMeta::Meta(syn::Meta::Word(ref ident)) = [INFO] [stderr] 71 | *mi [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:73:45 [INFO] [stderr] | [INFO] [stderr] 73 | return Some(ident.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:84:25 [INFO] [stderr] | [INFO] [stderr] 84 | fn gen_enumflags(ident: &Ident, item: &DeriveInput, data: &DataEnum, gen_std: bool) -> Tokens { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | / match expr{ [INFO] [stderr] 42 | | &Expr::Lit(ref expr_lit) => { [INFO] [stderr] 43 | | match expr_lit.lit { [INFO] [stderr] 44 | | syn::Lit::Int(ref lit_int) => lit_int.value(), [INFO] [stderr] ... | [INFO] [stderr] 57 | | _ => panic!("Only literals are supported") [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 41 | match *expr{ [INFO] [stderr] 42 | Expr::Lit(ref expr_lit) => { [INFO] [stderr] 43 | match expr_lit.lit { [INFO] [stderr] 44 | syn::Lit::Int(ref lit_int) => lit_int.value(), [INFO] [stderr] 45 | _ => panic!("Only Int literals are supported") [INFO] [stderr] 46 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:70:29 [INFO] [stderr] | [INFO] [stderr] 70 | / if let &syn::NestedMeta::Meta(syn::Meta::Word(ref ident)) = [INFO] [stderr] 71 | | mi [INFO] [stderr] 72 | | { [INFO] [stderr] 73 | | return Some(ident.clone()); [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 70 | if let syn::NestedMeta::Meta(syn::Meta::Word(ref ident)) = [INFO] [stderr] 71 | *mi [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:73:45 [INFO] [stderr] | [INFO] [stderr] 73 | return Some(ident.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*ident` [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] | [INFO] [stderr] --> src/lib.rs:86:57 [INFO] [stderr] | [INFO] [stderr] 86 | let variants: Vec<_> = data.variants.iter().map(|v| v.ident.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `v.ident` [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:96:52 [INFO] [stderr] | [INFO] [stderr] 96 | let names: Vec<_> = flag_values.iter().map(|_| ident.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:102:40 [INFO] [stderr] | [INFO] [stderr] 102 | let ty = extract_repr(&item.attrs).unwrap_or(Ident::new("usize", span)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Ident::new("usize", span))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:104:55 [INFO] [stderr] | [INFO] [stderr] 104 | let max_allowed_value = max_value_of(ty.as_ref()).expect(&format!("{} is not supported", ty)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("{} is not supported", ty))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | wrong_flag_values.len() == 0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `wrong_flag_values.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:84:25 [INFO] [stderr] | [INFO] [stderr] 84 | fn gen_enumflags(ident: &Ident, item: &DeriveInput, data: &DataEnum, gen_std: bool) -> Tokens { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:86:57 [INFO] [stderr] | [INFO] [stderr] 86 | let variants: Vec<_> = data.variants.iter().map(|v| v.ident.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `v.ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:96:52 [INFO] [stderr] | [INFO] [stderr] 96 | let names: Vec<_> = flag_values.iter().map(|_| ident.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:102:40 [INFO] [stderr] | [INFO] [stderr] 102 | let ty = extract_repr(&item.attrs).unwrap_or(Ident::new("usize", span)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Ident::new("usize", span))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:104:55 [INFO] [stderr] | [INFO] [stderr] 104 | let max_allowed_value = max_value_of(ty.as_ref()).expect(&format!("{} is not supported", ty)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("{} is not supported", ty))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | wrong_flag_values.len() == 0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `wrong_flag_values.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.05s [INFO] running `"docker" "inspect" "4f44384ffc643807befb2be83952a34116249eb95ca6f1840dc750e1ff871d9c"` [INFO] running `"docker" "rm" "-f" "4f44384ffc643807befb2be83952a34116249eb95ca6f1840dc750e1ff871d9c"` [INFO] [stdout] 4f44384ffc643807befb2be83952a34116249eb95ca6f1840dc750e1ff871d9c