[INFO] crate enum_traits_macros 2.0.0 is already in cache [INFO] extracting crate enum_traits_macros 2.0.0 into work/ex/clippy-test-run/sources/stable/reg/enum_traits_macros/2.0.0 [INFO] extracting crate enum_traits_macros 2.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/enum_traits_macros/2.0.0 [INFO] validating manifest of enum_traits_macros-2.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of enum_traits_macros-2.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing enum_traits_macros-2.0.0 [INFO] finished frobbing enum_traits_macros-2.0.0 [INFO] frobbed toml for enum_traits_macros-2.0.0 written to work/ex/clippy-test-run/sources/stable/reg/enum_traits_macros/2.0.0/Cargo.toml [INFO] started frobbing enum_traits_macros-2.0.0 [INFO] finished frobbing enum_traits_macros-2.0.0 [INFO] frobbed toml for enum_traits_macros-2.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/enum_traits_macros/2.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting enum_traits_macros-2.0.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/enum_traits_macros/2.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 69267fdfd0624321354c24d1e727f18947ba668fc37587b10e789d00e0c8230c [INFO] running `"docker" "start" "-a" "69267fdfd0624321354c24d1e727f18947ba668fc37587b10e789d00e0c8230c"` [INFO] [stderr] Checking enum_traits_macros v2.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:34:61 [INFO] [stderr] | [INFO] [stderr] 34 | MetaItem::List(ref ident,ref content) if ident=="repr" => match &content[0]{ [INFO] [stderr] | ___________________________________________________________________^ [INFO] [stderr] 35 | | &NestedMetaItem::MetaItem(MetaItem::Word(ref ty)) if ty!="C" => return Some(ty.clone()), [INFO] [stderr] 36 | | _ => continue, [INFO] [stderr] 37 | | }, [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 34 | MetaItem::List(ref ident,ref content) if ident=="repr" => match content[0]{ [INFO] [stderr] 35 | NestedMetaItem::MetaItem(MetaItem::Word(ref ty)) if ty!="C" => return Some(ty.clone()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:61:2 [INFO] [stderr] | [INFO] [stderr] 61 | format!("{}",quote_tokens.to_string()).parse().unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `to_string()` is enough: `quote_tokens.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:65:57 [INFO] [stderr] | [INFO] [stderr] 65 | fn minimum_type_containing_enum(item: &MacroInput,data: &Vec) -> syn::Ident{//TODO: Maybe useful to export? [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Variant]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:84:52 [INFO] [stderr] | [INFO] [stderr] 84 | fn gen_impl(ident: &Ident,item: &MacroInput,data: &Vec) -> Tokens{ [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Variant]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:101:52 [INFO] [stderr] | [INFO] [stderr] 101 | fn gen_impl(ident: &Ident,item: &MacroInput,data: &Vec) -> Tokens{ [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Variant]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:120:52 [INFO] [stderr] | [INFO] [stderr] 120 | fn gen_impl(ident: &Ident,item: &MacroInput,data: &Vec) -> Tokens{ [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Variant]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:183:52 [INFO] [stderr] | [INFO] [stderr] 183 | fn gen_impl(ident: &Ident,item: &MacroInput,data: &Vec) -> Tokens{ [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Variant]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:220:52 [INFO] [stderr] | [INFO] [stderr] 220 | fn gen_impl(ident: &Ident,item: &MacroInput,data: &Vec) -> Tokens{ [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Variant]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:244:52 [INFO] [stderr] | [INFO] [stderr] 244 | fn gen_impl(ident: &Ident,item: &MacroInput,data: &Vec) -> Tokens{ [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Variant]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:34:61 [INFO] [stderr] | [INFO] [stderr] 34 | MetaItem::List(ref ident,ref content) if ident=="repr" => match &content[0]{ [INFO] [stderr] | ___________________________________________________________________^ [INFO] [stderr] 35 | | &NestedMetaItem::MetaItem(MetaItem::Word(ref ty)) if ty!="C" => return Some(ty.clone()), [INFO] [stderr] 36 | | _ => continue, [INFO] [stderr] 37 | | }, [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 34 | MetaItem::List(ref ident,ref content) if ident=="repr" => match content[0]{ [INFO] [stderr] 35 | NestedMetaItem::MetaItem(MetaItem::Word(ref ty)) if ty!="C" => return Some(ty.clone()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:61:2 [INFO] [stderr] | [INFO] [stderr] 61 | format!("{}",quote_tokens.to_string()).parse().unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `to_string()` is enough: `quote_tokens.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:65:57 [INFO] [stderr] | [INFO] [stderr] 65 | fn minimum_type_containing_enum(item: &MacroInput,data: &Vec) -> syn::Ident{//TODO: Maybe useful to export? [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Variant]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:84:52 [INFO] [stderr] | [INFO] [stderr] 84 | fn gen_impl(ident: &Ident,item: &MacroInput,data: &Vec) -> Tokens{ [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Variant]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:101:52 [INFO] [stderr] | [INFO] [stderr] 101 | fn gen_impl(ident: &Ident,item: &MacroInput,data: &Vec) -> Tokens{ [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Variant]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:120:52 [INFO] [stderr] | [INFO] [stderr] 120 | fn gen_impl(ident: &Ident,item: &MacroInput,data: &Vec) -> Tokens{ [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Variant]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:414:52 [INFO] [stderr] | [INFO] [stderr] 414 | fn gen_impl(ident: &Ident,item: &MacroInput,data: &Vec) -> Tokens{ [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Variant]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:183:52 [INFO] [stderr] | [INFO] [stderr] 183 | fn gen_impl(ident: &Ident,item: &MacroInput,data: &Vec) -> Tokens{ [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Variant]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:220:52 [INFO] [stderr] | [INFO] [stderr] 220 | fn gen_impl(ident: &Ident,item: &MacroInput,data: &Vec) -> Tokens{ [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Variant]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:244:52 [INFO] [stderr] | [INFO] [stderr] 244 | fn gen_impl(ident: &Ident,item: &MacroInput,data: &Vec) -> Tokens{ [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Variant]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:539:52 [INFO] [stderr] | [INFO] [stderr] 539 | fn gen_impl(ident: &Ident,item: &MacroInput,data: &Vec) -> Tokens{ [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Variant]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:569:51 [INFO] [stderr] | [INFO] [stderr] 569 | let ty = type_from_repr_attr(item.attrs.iter()).unwrap_or(Ident::from("usize")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Ident::from("usize"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:414:52 [INFO] [stderr] | [INFO] [stderr] 414 | fn gen_impl(ident: &Ident,item: &MacroInput,data: &Vec) -> Tokens{ [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Variant]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:539:52 [INFO] [stderr] | [INFO] [stderr] 539 | fn gen_impl(ident: &Ident,item: &MacroInput,data: &Vec) -> Tokens{ [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[Variant]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:569:51 [INFO] [stderr] | [INFO] [stderr] 569 | let ty = type_from_repr_attr(item.attrs.iter()).unwrap_or(Ident::from("usize")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Ident::from("usize"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.16s [INFO] running `"docker" "inspect" "69267fdfd0624321354c24d1e727f18947ba668fc37587b10e789d00e0c8230c"` [INFO] running `"docker" "rm" "-f" "69267fdfd0624321354c24d1e727f18947ba668fc37587b10e789d00e0c8230c"` [INFO] [stdout] 69267fdfd0624321354c24d1e727f18947ba668fc37587b10e789d00e0c8230c