[INFO] crate enum-kinds 0.4.1 is already in cache [INFO] extracting crate enum-kinds 0.4.1 into work/ex/clippy-test-run/sources/stable/reg/enum-kinds/0.4.1 [INFO] extracting crate enum-kinds 0.4.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/enum-kinds/0.4.1 [INFO] validating manifest of enum-kinds-0.4.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of enum-kinds-0.4.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing enum-kinds-0.4.1 [INFO] finished frobbing enum-kinds-0.4.1 [INFO] frobbed toml for enum-kinds-0.4.1 written to work/ex/clippy-test-run/sources/stable/reg/enum-kinds/0.4.1/Cargo.toml [INFO] started frobbing enum-kinds-0.4.1 [INFO] finished frobbing enum-kinds-0.4.1 [INFO] frobbed toml for enum-kinds-0.4.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/enum-kinds/0.4.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting enum-kinds-0.4.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/enum-kinds/0.4.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2fef953d41fd965507073325cb05ff303f906b7d6a45c392b3a1bd6c76e887cb [INFO] running `"docker" "start" "-a" "2fef953d41fd965507073325cb05ff303f906b7d6a45c392b3a1bd6c76e887cb"` [INFO] [stderr] Compiling proc-macro2 v0.4.26 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling ryu v0.2.7 [INFO] [stderr] Compiling serde v1.0.85 [INFO] [stderr] Checking enum-kinds v0.4.1 (/opt/crater/workdir) [INFO] [stderr] error[E0602]: unknown lint: `clippy::into_iter_on_array` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into_iter_on_array` [INFO] [stderr] [INFO] [stderr] error[E0602]: unknown lint: `clippy::into_iter_on_array` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into_iter_on_array` [INFO] [stderr] [INFO] [stderr] error[E0602]: unknown lint: `clippy::into_iter_on_array` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into_iter_on_array` [INFO] [stderr] [INFO] [stderr] error[E0602]: unknown lint: `clippy::into_iter_on_array` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into_iter_on_array` [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0602`. [INFO] [stderr] error: Could not compile `proc-macro2`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0602`. [INFO] [stderr] error: Could not compile `unicode-xid`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0602`. [INFO] [stderr] error: Could not compile `ryu`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0602`. [INFO] [stderr] error: Could not compile `serde`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:164:5 [INFO] [stderr] | [INFO] [stderr] 164 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:118:21 [INFO] [stderr] | [INFO] [stderr] 118 | / if let &NestedMeta::Meta(Meta::Word(ident)) = meta { [INFO] [stderr] 119 | | to_derive.push(ident.clone()); [INFO] [stderr] 120 | | } else { [INFO] [stderr] 121 | | panic!("#[enum_kind({}, derive(...))] attribute's derive specifier accepts only identifiers"); [INFO] [stderr] 122 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 118 | if let NestedMeta::Meta(Meta::Word(ident)) = *meta { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:119:40 [INFO] [stderr] | [INFO] [stderr] 119 | to_derive.push(ident.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you probably are missing some parameter in your format string [INFO] [stderr] --> src/lib.rs:121:32 [INFO] [stderr] | [INFO] [stderr] 121 | panic!("#[enum_kind({}, derive(...))] attribute's derive specifier accepts only identifiers"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::panic_params)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic_params [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:138:59 [INFO] [stderr] | [INFO] [stderr] 138 | fn create_kind_enum(definition: &DeriveInput, kind_ident: &Ident, traits: Vec) -> Tokens { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:139:26 [INFO] [stderr] | [INFO] [stderr] 139 | let variant_idents = match &definition.data { [INFO] [stderr] | __________________________^ [INFO] [stderr] 140 | | &Data::Enum(DataEnum { ref variants, .. }) => { [INFO] [stderr] 141 | | variants.iter().map(|ref v| v.ident.clone()) [INFO] [stderr] 142 | | } [INFO] [stderr] ... | [INFO] [stderr] 145 | | } [INFO] [stderr] 146 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 139 | let variant_idents = match definition.data { [INFO] [stderr] 140 | Data::Enum(DataEnum { ref variants, .. }) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:141:41 [INFO] [stderr] | [INFO] [stderr] 141 | variants.iter().map(|ref v| v.ident.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `v.ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:162:16 [INFO] [stderr] | [INFO] [stderr] 162 | return data.variants.len() == 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.variants.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:167:54 [INFO] [stderr] | [INFO] [stderr] 167 | fn create_impl(definition: &DeriveInput, kind_ident: &Ident) -> Tokens { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:171:16 [INFO] [stderr] | [INFO] [stderr] 171 | let arms = match &definition.data { [INFO] [stderr] | ________________^ [INFO] [stderr] 172 | | &Data::Enum(DataEnum { ref variants, .. }) => { [INFO] [stderr] 173 | | variants.iter().map(|ref v| { [INFO] [stderr] 174 | | let variant = &v.ident; [INFO] [stderr] ... | [INFO] [stderr] 190 | | } [INFO] [stderr] 191 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 171 | let arms = match definition.data { [INFO] [stderr] 172 | Data::Enum(DataEnum { ref variants, .. }) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:202:19 [INFO] [stderr] | [INFO] [stderr] 202 | .map(|ld| ld.lifetime.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `ld.lifetime` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "2fef953d41fd965507073325cb05ff303f906b7d6a45c392b3a1bd6c76e887cb"` [INFO] running `"docker" "rm" "-f" "2fef953d41fd965507073325cb05ff303f906b7d6a45c392b3a1bd6c76e887cb"` [INFO] [stdout] 2fef953d41fd965507073325cb05ff303f906b7d6a45c392b3a1bd6c76e887cb