[INFO] crate endianrw 0.2.2 is already in cache [INFO] extracting crate endianrw 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/endianrw/0.2.2 [INFO] extracting crate endianrw 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/endianrw/0.2.2 [INFO] validating manifest of endianrw-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of endianrw-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing endianrw-0.2.2 [INFO] finished frobbing endianrw-0.2.2 [INFO] frobbed toml for endianrw-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/endianrw/0.2.2/Cargo.toml [INFO] started frobbing endianrw-0.2.2 [INFO] finished frobbing endianrw-0.2.2 [INFO] frobbed toml for endianrw-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/endianrw/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting endianrw-0.2.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/endianrw/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2e5a812684163c25ad3bff3f4f00b84636d1b7bdbc1186e414e18123cfb3d2e7 [INFO] running `"docker" "start" "-a" "2e5a812684163c25ad3bff3f4f00b84636d1b7bdbc1186e414e18123cfb3d2e7"` [INFO] [stderr] Checking endianrw v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:202:27 [INFO] [stderr] | [INFO] [stderr] 202 | run_test!(u32, 4, 287454020, 1144201745); [INFO] [stderr] | ^^^^^^^^^ help: consider: `287_454_020` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:202:27 [INFO] [stderr] | [INFO] [stderr] 202 | run_test!(u32, 4, 287454020, 1144201745); [INFO] [stderr] | ^^^^^^^^^ help: consider: `287_454_020` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:202:38 [INFO] [stderr] | [INFO] [stderr] 202 | run_test!(u32, 4, 287454020, 1144201745); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_144_201_745` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:203:27 [INFO] [stderr] | [INFO] [stderr] 203 | run_test!(u64, 8, 1234605616436508552, 9833440827789222417); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `1_234_605_616_436_508_552` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:203:48 [INFO] [stderr] | [INFO] [stderr] 203 | run_test!(u64, 8, 1234605616436508552, 9833440827789222417); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_833_440_827_789_222_417` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:207:27 [INFO] [stderr] | [INFO] [stderr] 207 | run_test!(i32, 4, 287454020, 1144201745); [INFO] [stderr] | ^^^^^^^^^ help: consider: `287_454_020` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:207:38 [INFO] [stderr] | [INFO] [stderr] 207 | run_test!(i32, 4, 287454020, 1144201745); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_144_201_745` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:208:27 [INFO] [stderr] | [INFO] [stderr] 208 | run_test!(i64, 8, 1234605616436508552, -8613303245920329199); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `1_234_605_616_436_508_552` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:208:49 [INFO] [stderr] | [INFO] [stderr] 208 | run_test!(i64, 8, 1234605616436508552, -8613303245920329199); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `8_613_303_245_920_329_199` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:210:27 [INFO] [stderr] | [INFO] [stderr] 210 | run_test!(f32, 4, 1.2795344e-28, 7.165323e2); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1.279_534_4e-28` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:210:42 [INFO] [stderr] | [INFO] [stderr] 210 | run_test!(f32, 4, 1.2795344e-28, 7.165323e2); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `7.165_323e2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:211:27 [INFO] [stderr] | [INFO] [stderr] 211 | run_test!(f64, 8, 3.841412024471731e-226, -7.086876636573014e-268); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `3.841_412_024_471_731e-226` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:211:52 [INFO] [stderr] | [INFO] [stderr] 211 | run_test!(f64, 8, 3.841412024471731e-226, -7.086876636573014e-268); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `7.086_876_636_573_014e-268` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> src/lib.rs:111:26 [INFO] [stderr] | [INFO] [stderr] 111 | unsafe { transmute(transmute::<_, $convertas>(buf).$convertfn()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(transmute::<_, $convertas>(buf).$convertfn())` [INFO] [stderr] ... [INFO] [stderr] 128 | impl_bytetransform!(LittleEndian, to_le); [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_int_to_float)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u64` to a `f64` [INFO] [stderr] --> src/lib.rs:111:26 [INFO] [stderr] | [INFO] [stderr] 111 | unsafe { transmute(transmute::<_, $convertas>(buf).$convertfn()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f64::from_bits(transmute::<_, $convertas>(buf).$convertfn())` [INFO] [stderr] ... [INFO] [stderr] 128 | impl_bytetransform!(LittleEndian, to_le); [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> src/lib.rs:111:26 [INFO] [stderr] | [INFO] [stderr] 111 | unsafe { transmute(transmute::<_, $convertas>(buf).$convertfn()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(transmute::<_, $convertas>(buf).$convertfn())` [INFO] [stderr] ... [INFO] [stderr] 129 | impl_bytetransform!(BigEndian, to_be); [INFO] [stderr] | -------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u64` to a `f64` [INFO] [stderr] --> src/lib.rs:111:26 [INFO] [stderr] | [INFO] [stderr] 111 | unsafe { transmute(transmute::<_, $convertas>(buf).$convertfn()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f64::from_bits(transmute::<_, $convertas>(buf).$convertfn())` [INFO] [stderr] ... [INFO] [stderr] 129 | impl_bytetransform!(BigEndian, to_be); [INFO] [stderr] | -------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> src/lib.rs:111:26 [INFO] [stderr] | [INFO] [stderr] 111 | unsafe { transmute(transmute::<_, $convertas>(buf).$convertfn()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(transmute::<_, $convertas>(buf).$convertfn())` [INFO] [stderr] ... [INFO] [stderr] 128 | impl_bytetransform!(LittleEndian, to_le); [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_int_to_float)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u64` to a `f64` [INFO] [stderr] --> src/lib.rs:111:26 [INFO] [stderr] | [INFO] [stderr] 111 | unsafe { transmute(transmute::<_, $convertas>(buf).$convertfn()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f64::from_bits(transmute::<_, $convertas>(buf).$convertfn())` [INFO] [stderr] ... [INFO] [stderr] 128 | impl_bytetransform!(LittleEndian, to_le); [INFO] [stderr] | ----------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u32` to a `f32` [INFO] [stderr] --> src/lib.rs:111:26 [INFO] [stderr] | [INFO] [stderr] 111 | unsafe { transmute(transmute::<_, $convertas>(buf).$convertfn()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f32::from_bits(transmute::<_, $convertas>(buf).$convertfn())` [INFO] [stderr] ... [INFO] [stderr] 129 | impl_bytetransform!(BigEndian, to_be); [INFO] [stderr] | -------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: transmute from a `u64` to a `f64` [INFO] [stderr] --> src/lib.rs:111:26 [INFO] [stderr] | [INFO] [stderr] 111 | unsafe { transmute(transmute::<_, $convertas>(buf).$convertfn()) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f64::from_bits(transmute::<_, $convertas>(buf).$convertfn())` [INFO] [stderr] ... [INFO] [stderr] 129 | impl_bytetransform!(BigEndian, to_be); [INFO] [stderr] | -------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 41 [INFO] [stderr] --> src/lib.rs:169:5 [INFO] [stderr] | [INFO] [stderr] 169 | / fn test_all() { [INFO] [stderr] 170 | | let expected = [0x11, 0x22, 0x33, 0x44, 0x55, 0x66, 0x77, 0x88]; [INFO] [stderr] 171 | | [INFO] [stderr] 172 | | macro_rules! run_test { [INFO] [stderr] ... | [INFO] [stderr] 211 | | run_test!(f64, 8, 3.841412024471731e-226, -7.086876636573014e-268); [INFO] [stderr] 212 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:210:9 [INFO] [stderr] | [INFO] [stderr] 210 | run_test!(f32, 4, 1.2795344e-28, 7.165323e2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:210:9 [INFO] [stderr] | [INFO] [stderr] 210 | run_test!(f32, 4, 1.2795344e-28, 7.165323e2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:210:9 [INFO] [stderr] | [INFO] [stderr] 210 | run_test!(f32, 4, 1.2795344e-28, 7.165323e2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:210:9 [INFO] [stderr] | [INFO] [stderr] 210 | run_test!(f32, 4, 1.2795344e-28, 7.165323e2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:211:9 [INFO] [stderr] | [INFO] [stderr] 211 | run_test!(f64, 8, 3.841412024471731e-226, -7.086876636573014e-268); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:211:9 [INFO] [stderr] | [INFO] [stderr] 211 | run_test!(f64, 8, 3.841412024471731e-226, -7.086876636573014e-268); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:211:9 [INFO] [stderr] | [INFO] [stderr] 211 | run_test!(f64, 8, 3.841412024471731e-226, -7.086876636573014e-268); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:211:9 [INFO] [stderr] | [INFO] [stderr] 211 | run_test!(f64, 8, 3.841412024471731e-226, -7.086876636573014e-268); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `endianrw`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "2e5a812684163c25ad3bff3f4f00b84636d1b7bdbc1186e414e18123cfb3d2e7"` [INFO] running `"docker" "rm" "-f" "2e5a812684163c25ad3bff3f4f00b84636d1b7bdbc1186e414e18123cfb3d2e7"` [INFO] [stdout] 2e5a812684163c25ad3bff3f4f00b84636d1b7bdbc1186e414e18123cfb3d2e7