[INFO] crate encoding8 0.3.2 is already in cache [INFO] extracting crate encoding8 0.3.2 into work/ex/clippy-test-run/sources/stable/reg/encoding8/0.3.2 [INFO] extracting crate encoding8 0.3.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/encoding8/0.3.2 [INFO] validating manifest of encoding8-0.3.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of encoding8-0.3.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing encoding8-0.3.2 [INFO] finished frobbing encoding8-0.3.2 [INFO] frobbed toml for encoding8-0.3.2 written to work/ex/clippy-test-run/sources/stable/reg/encoding8/0.3.2/Cargo.toml [INFO] started frobbing encoding8-0.3.2 [INFO] finished frobbing encoding8-0.3.2 [INFO] frobbed toml for encoding8-0.3.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/encoding8/0.3.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting encoding8-0.3.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/encoding8/0.3.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ae9b32cd5e94d4df7001051728ccb44c135d177ada8b0bb8dacb7bb48b3347c0 [INFO] running `"docker" "start" "-a" "ae9b32cd5e94d4df7001051728ccb44c135d177ada8b0bb8dacb7bb48b3347c0"` [INFO] [stderr] Checking encoding8 v0.3.2 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ascii/mod.rs:369:5 [INFO] [stderr] | [INFO] [stderr] 369 | return !is_control(b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `!is_control(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ascii/mod.rs:369:5 [INFO] [stderr] | [INFO] [stderr] 369 | return !is_control(b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `!is_control(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/ascii/string.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | / pub fn from_str(s: &str) -> Option { [INFO] [stderr] 66 | | if s.bytes().all(|b| b & 0x80 == 0) { [INFO] [stderr] 67 | | Some(ASCII(s.to_string())) [INFO] [stderr] 68 | | } else { [INFO] [stderr] 69 | | None [INFO] [stderr] 70 | | } [INFO] [stderr] 71 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/ascii/string.rs:89:25 [INFO] [stderr] | [INFO] [stderr] 89 | pub fn to_lowercase(self) -> Self { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/ascii/string.rs:93:25 [INFO] [stderr] | [INFO] [stderr] 93 | pub fn to_uppercase(self) -> Self { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/ascii/string.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | / pub fn from_str(s: &str) -> Option { [INFO] [stderr] 66 | | if s.bytes().all(|b| b & 0x80 == 0) { [INFO] [stderr] 67 | | Some(ASCII(s.to_string())) [INFO] [stderr] 68 | | } else { [INFO] [stderr] 69 | | None [INFO] [stderr] 70 | | } [INFO] [stderr] 71 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/ascii/string.rs:89:25 [INFO] [stderr] | [INFO] [stderr] 89 | pub fn to_lowercase(self) -> Self { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/ascii/string.rs:93:25 [INFO] [stderr] | [INFO] [stderr] 93 | pub fn to_uppercase(self) -> Self { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.54s [INFO] running `"docker" "inspect" "ae9b32cd5e94d4df7001051728ccb44c135d177ada8b0bb8dacb7bb48b3347c0"` [INFO] running `"docker" "rm" "-f" "ae9b32cd5e94d4df7001051728ccb44c135d177ada8b0bb8dacb7bb48b3347c0"` [INFO] [stdout] ae9b32cd5e94d4df7001051728ccb44c135d177ada8b0bb8dacb7bb48b3347c0