[INFO] crate embedded-nrf24l01 0.1.0 is already in cache [INFO] extracting crate embedded-nrf24l01 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/embedded-nrf24l01/0.1.0 [INFO] extracting crate embedded-nrf24l01 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/embedded-nrf24l01/0.1.0 [INFO] validating manifest of embedded-nrf24l01-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of embedded-nrf24l01-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing embedded-nrf24l01-0.1.0 [INFO] finished frobbing embedded-nrf24l01-0.1.0 [INFO] frobbed toml for embedded-nrf24l01-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/embedded-nrf24l01/0.1.0/Cargo.toml [INFO] started frobbing embedded-nrf24l01-0.1.0 [INFO] finished frobbing embedded-nrf24l01-0.1.0 [INFO] frobbed toml for embedded-nrf24l01-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/embedded-nrf24l01/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting embedded-nrf24l01-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/embedded-nrf24l01/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 765a922e3e434c6f092be4567b675211867c59c030ef214235511d27e5bf4d7e [INFO] running `"docker" "start" "-a" "765a922e3e434c6f092be4567b675211867c59c030ef214235511d27e5bf4d7e"` [INFO] [stderr] Checking embedded-nrf24l01 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/config.rs:35:19 [INFO] [stderr] | [INFO] [stderr] 35 | fn set_config(&self, config: &mut Config) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/config.rs:92:32 [INFO] [stderr] | [INFO] [stderr] 92 | fn set_rf(&mut self, rate: &DataRate, power: u8) -> Result<(), <::Inner as Device>::Error> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `DataRate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/config.rs:111:33 [INFO] [stderr] | [INFO] [stderr] 111 | fn set_crc(&mut self, mode: &CrcMode) -> Result<(), <::Inner as Device>::Error> { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `CrcMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/config.rs:116:46 [INFO] [stderr] | [INFO] [stderr] 116 | fn set_pipes_rx_enable(&mut self, bools: &[bool; PIPES_COUNT]) -> Result<(), <::Inner as Device>::Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `[bool; PIPES_COUNT]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/config.rs:175:39 [INFO] [stderr] | [INFO] [stderr] 175 | fn set_auto_ack(&mut self, bools: &[bool; PIPES_COUNT]) -> Result<(), <::Inner as Device>::Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `[bool; PIPES_COUNT]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: item `payload::Payload` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/payload.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | / impl Payload { [INFO] [stderr] 13 | | /// Copy a slice [INFO] [stderr] 14 | | pub fn new(source: &[u8]) -> Self { [INFO] [stderr] 15 | | let mut data = [0; 32]; [INFO] [stderr] ... | [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/rx.rs:46:21 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn is_empty(&mut self) -> Result { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/rx.rs:52:20 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn is_full(&mut self) -> Result { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/tx.rs:44:21 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn is_empty(&mut self) -> Result { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/tx.rs:51:20 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn is_full(&mut self) -> Result { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:96:25 [INFO] [stderr] | [INFO] [stderr] 96 | pub fn is_connected(&mut self) -> Result { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/config.rs:35:19 [INFO] [stderr] | [INFO] [stderr] 35 | fn set_config(&self, config: &mut Config) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/config.rs:92:32 [INFO] [stderr] | [INFO] [stderr] 92 | fn set_rf(&mut self, rate: &DataRate, power: u8) -> Result<(), <::Inner as Device>::Error> { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `DataRate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/config.rs:111:33 [INFO] [stderr] | [INFO] [stderr] 111 | fn set_crc(&mut self, mode: &CrcMode) -> Result<(), <::Inner as Device>::Error> { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `CrcMode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/config.rs:116:46 [INFO] [stderr] | [INFO] [stderr] 116 | fn set_pipes_rx_enable(&mut self, bools: &[bool; PIPES_COUNT]) -> Result<(), <::Inner as Device>::Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `[bool; PIPES_COUNT]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/config.rs:175:39 [INFO] [stderr] | [INFO] [stderr] 175 | fn set_auto_ack(&mut self, bools: &[bool; PIPES_COUNT]) -> Result<(), <::Inner as Device>::Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `[bool; PIPES_COUNT]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: item `payload::Payload` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/payload.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | / impl Payload { [INFO] [stderr] 13 | | /// Copy a slice [INFO] [stderr] 14 | | pub fn new(source: &[u8]) -> Self { [INFO] [stderr] 15 | | let mut data = [0; 32]; [INFO] [stderr] ... | [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/rx.rs:46:21 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn is_empty(&mut self) -> Result { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/rx.rs:52:20 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn is_full(&mut self) -> Result { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/tx.rs:44:21 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn is_empty(&mut self) -> Result { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/tx.rs:51:20 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn is_full(&mut self) -> Result { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:96:25 [INFO] [stderr] | [INFO] [stderr] 96 | pub fn is_connected(&mut self) -> Result { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.32s [INFO] running `"docker" "inspect" "765a922e3e434c6f092be4567b675211867c59c030ef214235511d27e5bf4d7e"` [INFO] running `"docker" "rm" "-f" "765a922e3e434c6f092be4567b675211867c59c030ef214235511d27e5bf4d7e"` [INFO] [stdout] 765a922e3e434c6f092be4567b675211867c59c030ef214235511d27e5bf4d7e