[INFO] crate embedded-graphics 0.4.4 is already in cache
[INFO] extracting crate embedded-graphics 0.4.4 into work/ex/clippy-test-run/sources/stable/reg/embedded-graphics/0.4.4
[INFO] extracting crate embedded-graphics 0.4.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/embedded-graphics/0.4.4
[INFO] validating manifest of embedded-graphics-0.4.4 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of embedded-graphics-0.4.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing embedded-graphics-0.4.4
[INFO] finished frobbing embedded-graphics-0.4.4
[INFO] frobbed toml for embedded-graphics-0.4.4 written to work/ex/clippy-test-run/sources/stable/reg/embedded-graphics/0.4.4/Cargo.toml
[INFO] started frobbing embedded-graphics-0.4.4
[INFO] finished frobbing embedded-graphics-0.4.4
[INFO] frobbed toml for embedded-graphics-0.4.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/embedded-graphics/0.4.4/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting embedded-graphics-0.4.4 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/embedded-graphics/0.4.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 3fc852b1bf965028ff25b8974b45cbcf79b54ed81561fe8b53d77a6cf880806e
[INFO] running `"docker" "start" "-a" "3fc852b1bf965028ff25b8974b45cbcf79b54ed81561fe8b53d77a6cf880806e"`
[INFO] [stderr]     Checking embedded-graphics v0.4.4 (/opt/crater/workdir)
[INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes
[INFO] [stderr]    --> src/fonts/font12x16.rs:157:9
[INFO] [stderr]     |
[INFO] [stderr] 157 |         #[cfg_attr(rustfmt, rustfmt_skip)]
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::deprecated_cfg_attr)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr
[INFO] [stderr] 
[INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes
[INFO] [stderr]    --> src/fonts/font6x12.rs:160:9
[INFO] [stderr]     |
[INFO] [stderr] 160 |         #[cfg_attr(rustfmt, rustfmt_skip)]
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr
[INFO] [stderr] 
[INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes
[INFO] [stderr]    --> src/fonts/font6x8.rs:301:9
[INFO] [stderr]     |
[INFO] [stderr] 301 |         #[cfg_attr(rustfmt, rustfmt_skip)]
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr
[INFO] [stderr] 
[INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes
[INFO] [stderr]    --> src/fonts/font8x16.rs:192:9
[INFO] [stderr]     |
[INFO] [stderr] 192 |         #[cfg_attr(rustfmt, rustfmt_skip)]
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr
[INFO] [stderr] 
[INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes
[INFO] [stderr]    --> src/fonts/font12x16.rs:157:9
[INFO] [stderr]     |
[INFO] [stderr] 157 |         #[cfg_attr(rustfmt, rustfmt_skip)]
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::deprecated_cfg_attr)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr
[INFO] [stderr] 
[INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes
[INFO] [stderr]    --> src/fonts/font6x12.rs:160:9
[INFO] [stderr]     |
[INFO] [stderr] 160 |         #[cfg_attr(rustfmt, rustfmt_skip)]
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr
[INFO] [stderr] 
[INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes
[INFO] [stderr]    --> src/fonts/font6x8.rs:301:9
[INFO] [stderr]     |
[INFO] [stderr] 301 |         #[cfg_attr(rustfmt, rustfmt_skip)]
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr
[INFO] [stderr] 
[INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes
[INFO] [stderr]    --> src/fonts/font8x16.rs:192:9
[INFO] [stderr]     |
[INFO] [stderr] 192 |         #[cfg_attr(rustfmt, rustfmt_skip)]
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/fonts/font_builder.rs:218:13
[INFO] [stderr]     |
[INFO] [stderr] 218 |             pixel
[INFO] [stderr]     |             ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/fonts/font_builder.rs:165:25
[INFO] [stderr]     |
[INFO] [stderr] 165 |               let pixel = loop {
[INFO] [stderr]     |  _________________________^
[INFO] [stderr] 166 | |                 // Char _code_ offset from first char, most often a space
[INFO] [stderr] 167 | |                 // E.g. first char = ' ' (32), target char = '!' (33), offset = 33 - 32 = 1
[INFO] [stderr] 168 | |                 let char_offset = Conf::char_offset(current_char);
[INFO] [stderr] ...   |
[INFO] [stderr] 215 | |                 }
[INFO] [stderr] 216 | |             };
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/primitives/line.rs:88:16
[INFO] [stderr]    |
[INFO] [stderr] 88 |           } else {
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 89 | |             if x0 > x1 {
[INFO] [stderr] 90 | |                 (x1, y1, x0, y0)
[INFO] [stderr] 91 | |             } else {
[INFO] [stderr] 92 | |                 (x0, y0, x1, y1)
[INFO] [stderr] 93 | |             }
[INFO] [stderr] 94 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 88 |         } else if x0 > x1 {
[INFO] [stderr] 89 |     (x1, y1, x0, y0)
[INFO] [stderr] 90 | } else {
[INFO] [stderr] 91 |     (x0, y0, x1, y1)
[INFO] [stderr] 92 | };
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/fonts/font_builder.rs:218:13
[INFO] [stderr]     |
[INFO] [stderr] 218 |             pixel
[INFO] [stderr]     |             ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/fonts/font_builder.rs:165:25
[INFO] [stderr]     |
[INFO] [stderr] 165 |               let pixel = loop {
[INFO] [stderr]     |  _________________________^
[INFO] [stderr] 166 | |                 // Char _code_ offset from first char, most often a space
[INFO] [stderr] 167 | |                 // E.g. first char = ' ' (32), target char = '!' (33), offset = 33 - 32 = 1
[INFO] [stderr] 168 | |                 let char_offset = Conf::char_offset(current_char);
[INFO] [stderr] ...   |
[INFO] [stderr] 215 | |                 }
[INFO] [stderr] 216 | |             };
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/primitives/line.rs:88:16
[INFO] [stderr]    |
[INFO] [stderr] 88 |           } else {
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 89 | |             if x0 > x1 {
[INFO] [stderr] 90 | |                 (x1, y1, x0, y0)
[INFO] [stderr] 91 | |             } else {
[INFO] [stderr] 92 | |                 (x0, y0, x1, y1)
[INFO] [stderr] 93 | |             }
[INFO] [stderr] 94 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 88 |         } else if x0 > x1 {
[INFO] [stderr] 89 |     (x1, y1, x0, y0)
[INFO] [stderr] 90 | } else {
[INFO] [stderr] 91 |     (x0, y0, x1, y1)
[INFO] [stderr] 92 | };
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/coord.rs:26:31
[INFO] [stderr]    |
[INFO] [stderr] 26 |         pub fn clamp_positive(&self) -> Self {
[INFO] [stderr]    |                               ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/coord.rs:40:20
[INFO] [stderr]    |
[INFO] [stderr] 40 |         pub fn abs(&self) -> Self {
[INFO] [stderr]    |                    ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/fonts/font_builder.rs:50:20
[INFO] [stderr]    |
[INFO] [stderr] 50 |             style: self.style.clone(),
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.style`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/fonts/font_builder.rs:73:16
[INFO] [stderr]    |
[INFO] [stderr] 73 |             if self.text.len() > 0 {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.text.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/fonts/font_builder.rs:189:45
[INFO] [stderr]     |
[INFO] [stderr] 189 |                     self.style.stroke_color.unwrap_or(1.into()) // white
[INFO] [stderr]     |                                             ^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| 1.into())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/fonts/font_builder.rs:191:43
[INFO] [stderr]     |
[INFO] [stderr] 191 |                     self.style.fill_color.unwrap_or(0.into()) // black
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| 0.into())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
[INFO] [stderr]    --> src/fonts/font_builder.rs:209:45
[INFO] [stderr]     |
[INFO] [stderr] 209 |                         self.current_char = self.text.chars().skip(self.idx).next();
[INFO] [stderr]     |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::iter_skip_next)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/fonts/font_builder.rs:252:15
[INFO] [stderr]     |
[INFO] [stderr] 252 |             ..self.clone()
[INFO] [stderr]     |               ^^^^^^^^^^^^ help: try dereferencing it: `*self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/image/image16bpp.rs:108:29
[INFO] [stderr]     |
[INFO] [stderr] 108 |             let bit_value = (self.im.imagedata[(offset + 1) as usize] as u16) << 8
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.im.imagedata[(offset + 1) as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/image/image16bpp.rs:109:19
[INFO] [stderr]     |
[INFO] [stderr] 109 |                 | self.im.imagedata[offset as usize] as u16;
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.im.imagedata[offset as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/image/image16bpp.rs:156:16
[INFO] [stderr]     |
[INFO] [stderr] 156 |             ..*self.clone()
[INFO] [stderr]     |                ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 156 |             ..*&(*self).clone()
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 156 |             ..*&image::image16bpp::Image16BPP<'a, C>::clone(self)
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/image/image1bpp.rs:153:16
[INFO] [stderr]     |
[INFO] [stderr] 153 |             ..*self.clone()
[INFO] [stderr]     |                ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 153 |             ..*&(*self).clone()
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 153 |             ..*&image::image1bpp::Image1BPP<'a, C>::clone(self)
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/image/image8bpp.rs:147:16
[INFO] [stderr]     |
[INFO] [stderr] 147 |             ..*self.clone()
[INFO] [stderr]     |                ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 147 |             ..*&(*self).clone()
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 147 |             ..*&image::image8bpp::Image8BPP<'a, C>::clone(self)
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/pixelcolor.rs:81:23
[INFO] [stderr]    |
[INFO] [stderr] 81 |         PixelColorU16(other as u16)
[INFO] [stderr]    |                       ^^^^^^^^^^^^ help: try: `u16::from(other)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/pixelcolor.rs:111:23
[INFO] [stderr]     |
[INFO] [stderr] 111 |         PixelColorU32(other as u32)
[INFO] [stderr]     |                       ^^^^^^^^^^^^ help: try: `u32::from(other)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/pixelcolor.rs:117:23
[INFO] [stderr]     |
[INFO] [stderr] 117 |         PixelColorU32(other as u32)
[INFO] [stderr]     |                       ^^^^^^^^^^^^ help: try: `u32::from(other)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this block may be rewritten with the `?` operator
[INFO] [stderr]    --> src/primitives/circle.rs:105:9
[INFO] [stderr]     |
[INFO] [stderr] 105 | /         if self.style.stroke_color.is_none() {
[INFO] [stderr] 106 | |             return None;
[INFO] [stderr] 107 | |         }
[INFO] [stderr]     | |_________^ help: replace_it_with: `self.style.stroke_color?;`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::question_mark)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/primitives/circle.rs:112:43
[INFO] [stderr]     |
[INFO] [stderr] 112 |         let radius = self.radius as i32 - self.style.stroke_width as i32 + 1;
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.style.stroke_width)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/primitives/circle.rs:191:15
[INFO] [stderr]     |
[INFO] [stderr] 191 |             ..self.clone()
[INFO] [stderr]     |               ^^^^^^^^^^^^ help: try dereferencing it: `*self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/primitives/line.rs:171:13
[INFO] [stderr]     |
[INFO] [stderr] 171 |             self.slow = self.slow + self.increment;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.slow += self.increment`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/primitives/line.rs:214:15
[INFO] [stderr]     |
[INFO] [stderr] 214 |             ..self.clone()
[INFO] [stderr]     |               ^^^^^^^^^^^^ help: try dereferencing it: `*self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/primitives/rect.rs:122:32
[INFO] [stderr]     |
[INFO] [stderr] 122 |             let border_width = self.style.stroke_width as i32;
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.style.stroke_width)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/primitives/rect.rs:195:15
[INFO] [stderr]     |
[INFO] [stderr] 195 |             ..self.clone()
[INFO] [stderr]     |               ^^^^^^^^^^^^ help: try dereferencing it: `*self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 3 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `embedded-graphics`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/coord.rs:26:31
[INFO] [stderr]    |
[INFO] [stderr] 26 |         pub fn clamp_positive(&self) -> Self {
[INFO] [stderr]    |                               ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/coord.rs:40:20
[INFO] [stderr]    |
[INFO] [stderr] 40 |         pub fn abs(&self) -> Self {
[INFO] [stderr]    |                    ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/fonts/font12x16.rs:64:35
[INFO] [stderr]    |
[INFO] [stderr] 64 |                 .with_stroke(Some(1u8.into()))
[INFO] [stderr]    |                                   ^^^^^^^^^^ help: consider removing `.into()`: `1u8`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/fonts/font12x16.rs:96:35
[INFO] [stderr]    |
[INFO] [stderr] 96 |                 .with_stroke(Some(1u8.into()))
[INFO] [stderr]    |                                   ^^^^^^^^^^ help: consider removing `.into()`: `1u8`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/fonts/font12x16.rs:128:35
[INFO] [stderr]     |
[INFO] [stderr] 128 |                 .with_stroke(Some(1u8.into()))
[INFO] [stderr]     |                                   ^^^^^^^^^^ help: consider removing `.into()`: `1u8`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/fonts/font12x16.rs:182:35
[INFO] [stderr]     |
[INFO] [stderr] 182 |                 .with_stroke(Some(1u8.into()))
[INFO] [stderr]     |                                   ^^^^^^^^^^ help: consider removing `.into()`: `1u8`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/fonts/font12x16.rs:190:35
[INFO] [stderr]     |
[INFO] [stderr] 190 |                 .with_stroke(Some(1u8.into()))
[INFO] [stderr]     |                                   ^^^^^^^^^^ help: consider removing `.into()`: `1u8`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/fonts/font12x16.rs:198:35
[INFO] [stderr]     |
[INFO] [stderr] 198 |                 .with_stroke(Some(1u8.into()))
[INFO] [stderr]     |                                   ^^^^^^^^^^ help: consider removing `.into()`: `1u8`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/fonts/font12x16.rs:206:35
[INFO] [stderr]     |
[INFO] [stderr] 206 |                 .with_stroke(Some(1u8.into()))
[INFO] [stderr]     |                                   ^^^^^^^^^^ help: consider removing `.into()`: `1u8`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/fonts/font6x12.rs:64:35
[INFO] [stderr]    |
[INFO] [stderr] 64 |                 .with_stroke(Some(1u8.into()))
[INFO] [stderr]    |                                   ^^^^^^^^^^ help: consider removing `.into()`: `1u8`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/fonts/font6x12.rs:97:35
[INFO] [stderr]    |
[INFO] [stderr] 97 |                 .with_stroke(Some(1u8.into()))
[INFO] [stderr]    |                                   ^^^^^^^^^^ help: consider removing `.into()`: `1u8`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/fonts/font6x12.rs:130:35
[INFO] [stderr]     |
[INFO] [stderr] 130 |                 .with_stroke(Some(1u8.into()))
[INFO] [stderr]     |                                   ^^^^^^^^^^ help: consider removing `.into()`: `1u8`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/fonts/font6x12.rs:186:35
[INFO] [stderr]     |
[INFO] [stderr] 186 |                 .with_stroke(Some(1u8.into()))
[INFO] [stderr]     |                                   ^^^^^^^^^^ help: consider removing `.into()`: `1u8`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/fonts/font6x12.rs:194:35
[INFO] [stderr]     |
[INFO] [stderr] 194 |                 .with_stroke(Some(1u8.into()))
[INFO] [stderr]     |                                   ^^^^^^^^^^ help: consider removing `.into()`: `1u8`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/fonts/font6x12.rs:202:35
[INFO] [stderr]     |
[INFO] [stderr] 202 |                 .with_stroke(Some(1u8.into()))
[INFO] [stderr]     |                                   ^^^^^^^^^^ help: consider removing `.into()`: `1u8`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/fonts/font6x12.rs:210:35
[INFO] [stderr]     |
[INFO] [stderr] 210 |                 .with_stroke(Some(1u8.into()))
[INFO] [stderr]     |                                   ^^^^^^^^^^ help: consider removing `.into()`: `1u8`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/fonts/font6x8.rs:80:35
[INFO] [stderr]    |
[INFO] [stderr] 80 |                 .with_stroke(Some(1u8.into()))
[INFO] [stderr]    |                                   ^^^^^^^^^^ help: consider removing `.into()`: `1u8`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/fonts/font6x8.rs:81:33
[INFO] [stderr]    |
[INFO] [stderr] 81 |                 .with_fill(Some(0u8.into()))
[INFO] [stderr]    |                                 ^^^^^^^^^^ help: consider removing `.into()`: `0u8`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/fonts/font6x8.rs:88:35
[INFO] [stderr]    |
[INFO] [stderr] 88 |                 .with_stroke(Some(1u8.into()))
[INFO] [stderr]    |                                   ^^^^^^^^^^ help: consider removing `.into()`: `1u8`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/fonts/font6x8.rs:95:33
[INFO] [stderr]    |
[INFO] [stderr] 95 |                 .with_fill(Some(0u8.into()))
[INFO] [stderr]    |                                 ^^^^^^^^^^ help: consider removing `.into()`: `0u8`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/fonts/font6x8.rs:109:35
[INFO] [stderr]     |
[INFO] [stderr] 109 |                 .with_stroke(Some(1u8.into()))
[INFO] [stderr]     |                                   ^^^^^^^^^^ help: consider removing `.into()`: `1u8`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/fonts/font6x8.rs:142:35
[INFO] [stderr]     |
[INFO] [stderr] 142 |                 .with_stroke(Some(0u8.into()))
[INFO] [stderr]     |                                   ^^^^^^^^^^ help: consider removing `.into()`: `0u8`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/fonts/font6x8.rs:143:33
[INFO] [stderr]     |
[INFO] [stderr] 143 |                 .with_fill(Some(1u8.into()))
[INFO] [stderr]     |                                 ^^^^^^^^^^ help: consider removing `.into()`: `1u8`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/fonts/font6x8.rs:177:35
[INFO] [stderr]     |
[INFO] [stderr] 177 |                 .with_stroke(Some(0u8.into()))
[INFO] [stderr]     |                                   ^^^^^^^^^^ help: consider removing `.into()`: `0u8`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/fonts/font6x8.rs:178:33
[INFO] [stderr]     |
[INFO] [stderr] 178 |                 .with_fill(Some(1u8.into()))
[INFO] [stderr]     |                                 ^^^^^^^^^^ help: consider removing `.into()`: `1u8`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/fonts/font6x8.rs:185:35
[INFO] [stderr]     |
[INFO] [stderr] 185 |                 .with_stroke(Some(1u8.into()))
[INFO] [stderr]     |                                   ^^^^^^^^^^ help: consider removing `.into()`: `1u8`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/fonts/font6x8.rs:186:33
[INFO] [stderr]     |
[INFO] [stderr] 186 |                 .with_fill(Some(0u8.into()))
[INFO] [stderr]     |                                 ^^^^^^^^^^ help: consider removing `.into()`: `0u8`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/fonts/font6x8.rs:205:35
[INFO] [stderr]     |
[INFO] [stderr] 205 |                 .with_stroke(Some(1u8.into()))
[INFO] [stderr]     |                                   ^^^^^^^^^^ help: consider removing `.into()`: `1u8`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/fonts/font6x8.rs:238:35
[INFO] [stderr]     |
[INFO] [stderr] 238 |                 .with_stroke(Some(1u8.into()))
[INFO] [stderr]     |                                   ^^^^^^^^^^ help: consider removing `.into()`: `1u8`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/fonts/font6x8.rs:271:35
[INFO] [stderr]     |
[INFO] [stderr] 271 |                 .with_stroke(Some(1u8.into()))
[INFO] [stderr]     |                                   ^^^^^^^^^^ help: consider removing `.into()`: `1u8`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/fonts/font6x8.rs:327:35
[INFO] [stderr]     |
[INFO] [stderr] 327 |                 .with_stroke(Some(1u8.into()))
[INFO] [stderr]     |                                   ^^^^^^^^^^ help: consider removing `.into()`: `1u8`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/fonts/font6x8.rs:335:35
[INFO] [stderr]     |
[INFO] [stderr] 335 |                 .with_stroke(Some(1u8.into()))
[INFO] [stderr]     |                                   ^^^^^^^^^^ help: consider removing `.into()`: `1u8`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/fonts/font6x8.rs:343:35
[INFO] [stderr]     |
[INFO] [stderr] 343 |                 .with_stroke(Some(1u8.into()))
[INFO] [stderr]     |                                   ^^^^^^^^^^ help: consider removing `.into()`: `1u8`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/fonts/font8x16.rs:67:35
[INFO] [stderr]    |
[INFO] [stderr] 67 |                 .with_stroke(Some(1u8.into()))
[INFO] [stderr]    |                                   ^^^^^^^^^^ help: consider removing `.into()`: `1u8`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/fonts/font8x16.rs:99:35
[INFO] [stderr]    |
[INFO] [stderr] 99 |                 .with_stroke(Some(1u8.into()))
[INFO] [stderr]    |                                   ^^^^^^^^^^ help: consider removing `.into()`: `1u8`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/fonts/font8x16.rs:131:35
[INFO] [stderr]     |
[INFO] [stderr] 131 |                 .with_stroke(Some(1u8.into()))
[INFO] [stderr]     |                                   ^^^^^^^^^^ help: consider removing `.into()`: `1u8`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/fonts/font8x16.rs:163:35
[INFO] [stderr]     |
[INFO] [stderr] 163 |                 .with_stroke(Some(1u8.into()))
[INFO] [stderr]     |                                   ^^^^^^^^^^ help: consider removing `.into()`: `1u8`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/fonts/font8x16.rs:217:35
[INFO] [stderr]     |
[INFO] [stderr] 217 |                 .with_stroke(Some(1u8.into()))
[INFO] [stderr]     |                                   ^^^^^^^^^^ help: consider removing `.into()`: `1u8`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/fonts/font8x16.rs:225:35
[INFO] [stderr]     |
[INFO] [stderr] 225 |                 .with_stroke(Some(1u8.into()))
[INFO] [stderr]     |                                   ^^^^^^^^^^ help: consider removing `.into()`: `1u8`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/fonts/font8x16.rs:233:35
[INFO] [stderr]     |
[INFO] [stderr] 233 |                 .with_stroke(Some(1u8.into()))
[INFO] [stderr]     |                                   ^^^^^^^^^^ help: consider removing `.into()`: `1u8`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/fonts/font_builder.rs:50:20
[INFO] [stderr]    |
[INFO] [stderr] 50 |             style: self.style.clone(),
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.style`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/fonts/font_builder.rs:73:16
[INFO] [stderr]    |
[INFO] [stderr] 73 |             if self.text.len() > 0 {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.text.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/fonts/font_builder.rs:189:45
[INFO] [stderr]     |
[INFO] [stderr] 189 |                     self.style.stroke_color.unwrap_or(1.into()) // white
[INFO] [stderr]     |                                             ^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| 1.into())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/fonts/font_builder.rs:191:43
[INFO] [stderr]     |
[INFO] [stderr] 191 |                     self.style.fill_color.unwrap_or(0.into()) // black
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| 0.into())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
[INFO] [stderr]    --> src/fonts/font_builder.rs:209:45
[INFO] [stderr]     |
[INFO] [stderr] 209 |                         self.current_char = self.text.chars().skip(self.idx).next();
[INFO] [stderr]     |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::iter_skip_next)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/fonts/font_builder.rs:252:15
[INFO] [stderr]     |
[INFO] [stderr] 252 |             ..self.clone()
[INFO] [stderr]     |               ^^^^^^^^^^^^ help: try dereferencing it: `*self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/image/image16bpp.rs:108:29
[INFO] [stderr]     |
[INFO] [stderr] 108 |             let bit_value = (self.im.imagedata[(offset + 1) as usize] as u16) << 8
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.im.imagedata[(offset + 1) as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/image/image16bpp.rs:109:19
[INFO] [stderr]     |
[INFO] [stderr] 109 |                 | self.im.imagedata[offset as usize] as u16;
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.im.imagedata[offset as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/image/image16bpp.rs:156:16
[INFO] [stderr]     |
[INFO] [stderr] 156 |             ..*self.clone()
[INFO] [stderr]     |                ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 156 |             ..*&(*self).clone()
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 156 |             ..*&image::image16bpp::Image16BPP<'a, C>::clone(self)
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/image/image1bpp.rs:153:16
[INFO] [stderr]     |
[INFO] [stderr] 153 |             ..*self.clone()
[INFO] [stderr]     |                ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 153 |             ..*&(*self).clone()
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 153 |             ..*&image::image1bpp::Image1BPP<'a, C>::clone(self)
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/image/image8bpp.rs:147:16
[INFO] [stderr]     |
[INFO] [stderr] 147 |             ..*self.clone()
[INFO] [stderr]     |                ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 147 |             ..*&(*self).clone()
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 147 |             ..*&image::image8bpp::Image8BPP<'a, C>::clone(self)
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/pixelcolor.rs:81:23
[INFO] [stderr]    |
[INFO] [stderr] 81 |         PixelColorU16(other as u16)
[INFO] [stderr]    |                       ^^^^^^^^^^^^ help: try: `u16::from(other)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/pixelcolor.rs:111:23
[INFO] [stderr]     |
[INFO] [stderr] 111 |         PixelColorU32(other as u32)
[INFO] [stderr]     |                       ^^^^^^^^^^^^ help: try: `u32::from(other)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/pixelcolor.rs:117:23
[INFO] [stderr]     |
[INFO] [stderr] 117 |         PixelColorU32(other as u32)
[INFO] [stderr]     |                       ^^^^^^^^^^^^ help: try: `u32::from(other)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this block may be rewritten with the `?` operator
[INFO] [stderr]    --> src/primitives/circle.rs:105:9
[INFO] [stderr]     |
[INFO] [stderr] 105 | /         if self.style.stroke_color.is_none() {
[INFO] [stderr] 106 | |             return None;
[INFO] [stderr] 107 | |         }
[INFO] [stderr]     | |_________^ help: replace_it_with: `self.style.stroke_color?;`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::question_mark)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/primitives/circle.rs:112:43
[INFO] [stderr]     |
[INFO] [stderr] 112 |         let radius = self.radius as i32 - self.style.stroke_width as i32 + 1;
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.style.stroke_width)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/primitives/circle.rs:191:15
[INFO] [stderr]     |
[INFO] [stderr] 191 |             ..self.clone()
[INFO] [stderr]     |               ^^^^^^^^^^^^ help: try dereferencing it: `*self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/primitives/line.rs:171:13
[INFO] [stderr]     |
[INFO] [stderr] 171 |             self.slow = self.slow + self.increment;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.slow += self.increment`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/primitives/line.rs:214:15
[INFO] [stderr]     |
[INFO] [stderr] 214 |             ..self.clone()
[INFO] [stderr]     |               ^^^^^^^^^^^^ help: try dereferencing it: `*self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/primitives/line.rs:318:13
[INFO] [stderr]     |
[INFO] [stderr] 318 |             (10, 10).into(),
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(10, 10)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/primitives/line.rs:319:13
[INFO] [stderr]     |
[INFO] [stderr] 319 |             (11, 9).into(),
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: consider removing `.into()`: `(11, 9)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/primitives/line.rs:320:13
[INFO] [stderr]     |
[INFO] [stderr] 320 |             (12, 9).into(),
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: consider removing `.into()`: `(12, 9)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/primitives/line.rs:321:13
[INFO] [stderr]     |
[INFO] [stderr] 321 |             (13, 8).into(),
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: consider removing `.into()`: `(13, 8)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/primitives/line.rs:322:13
[INFO] [stderr]     |
[INFO] [stderr] 322 |             (14, 8).into(),
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: consider removing `.into()`: `(14, 8)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/primitives/line.rs:323:13
[INFO] [stderr]     |
[INFO] [stderr] 323 |             (15, 7).into(),
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: consider removing `.into()`: `(15, 7)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/primitives/line.rs:332:25
[INFO] [stderr]     |
[INFO] [stderr] 332 |         let expected = [(0, 0).into(), (1, 1).into(), (2, 2).into()];
[INFO] [stderr]     |                         ^^^^^^^^^^^^^ help: consider removing `.into()`: `(0, 0)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/primitives/line.rs:332:40
[INFO] [stderr]     |
[INFO] [stderr] 332 |         let expected = [(0, 0).into(), (1, 1).into(), (2, 2).into()];
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^ help: consider removing `.into()`: `(1, 1)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/primitives/line.rs:332:55
[INFO] [stderr]     |
[INFO] [stderr] 332 |         let expected = [(0, 0).into(), (1, 1).into(), (2, 2).into()];
[INFO] [stderr]     |                                                       ^^^^^^^^^^^^^ help: consider removing `.into()`: `(2, 2)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/primitives/rect.rs:122:32
[INFO] [stderr]     |
[INFO] [stderr] 122 |             let border_width = self.style.stroke_width as i32;
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.style.stroke_width)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/primitives/rect.rs:195:15
[INFO] [stderr]     |
[INFO] [stderr] 195 |             ..self.clone()
[INFO] [stderr]     |               ^^^^^^^^^^^^ help: try dereferencing it: `*self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 3 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `embedded-graphics`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "3fc852b1bf965028ff25b8974b45cbcf79b54ed81561fe8b53d77a6cf880806e"`
[INFO] running `"docker" "rm" "-f" "3fc852b1bf965028ff25b8974b45cbcf79b54ed81561fe8b53d77a6cf880806e"`
[INFO] [stdout] 3fc852b1bf965028ff25b8974b45cbcf79b54ed81561fe8b53d77a6cf880806e