[INFO] crate edo 0.3.0 is already in cache [INFO] extracting crate edo 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/edo/0.3.0 [INFO] extracting crate edo 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/edo/0.3.0 [INFO] validating manifest of edo-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of edo-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing edo-0.3.0 [INFO] finished frobbing edo-0.3.0 [INFO] frobbed toml for edo-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/edo/0.3.0/Cargo.toml [INFO] started frobbing edo-0.3.0 [INFO] finished frobbing edo-0.3.0 [INFO] frobbed toml for edo-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/edo/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting edo-0.3.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/edo/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1112fb0b313a72621e556d195a37592dafe52af30339d220e658b11cb6e29ff3 [INFO] running `"docker" "start" "-a" "1112fb0b313a72621e556d195a37592dafe52af30339d220e658b11cb6e29ff3"` [INFO] [stderr] Checking edo v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/parse.rs:50:25 [INFO] [stderr] | [INFO] [stderr] 50 | arguments: args.unwrap_or(vec![]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parse.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | / pub fn parse<'a>(input: &'a str) -> Result, EdoError> { [INFO] [stderr] 71 | | match expressions(input.as_bytes()) { [INFO] [stderr] 72 | | IResult::Done(_, expressions) => Ok(expressions), [INFO] [stderr] 73 | | IResult::Error(_) => [INFO] [stderr] ... | [INFO] [stderr] 77 | | } [INFO] [stderr] 78 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:144:49 [INFO] [stderr] | [INFO] [stderr] 144 | Some(value_producer) => match value_producer { [INFO] [stderr] | _________________________________________________^ [INFO] [stderr] 145 | | &ValueProducer::Handler(ref handler) => match handler(arguments.clone()) { [INFO] [stderr] 146 | | Ok(string) => string, [INFO] [stderr] 147 | | Err(error_string) => { [INFO] [stderr] ... | [INFO] [stderr] 152 | | &ValueProducer::Static(ref value) => value.clone(), [INFO] [stderr] 153 | | }, [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 144 | Some(value_producer) => match *value_producer { [INFO] [stderr] 145 | ValueProducer::Handler(ref handler) => match handler(arguments.clone()) { [INFO] [stderr] 146 | Ok(string) => string, [INFO] [stderr] 147 | Err(error_string) => { [INFO] [stderr] 148 | errors.push(error_string); [INFO] [stderr] 149 | "".to_string() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/parse.rs:50:25 [INFO] [stderr] | [INFO] [stderr] 50 | arguments: args.unwrap_or(vec![]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parse.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | / pub fn parse<'a>(input: &'a str) -> Result, EdoError> { [INFO] [stderr] 71 | | match expressions(input.as_bytes()) { [INFO] [stderr] 72 | | IResult::Done(_, expressions) => Ok(expressions), [INFO] [stderr] 73 | | IResult::Error(_) => [INFO] [stderr] ... | [INFO] [stderr] 77 | | } [INFO] [stderr] 78 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:144:49 [INFO] [stderr] | [INFO] [stderr] 144 | Some(value_producer) => match value_producer { [INFO] [stderr] | _________________________________________________^ [INFO] [stderr] 145 | | &ValueProducer::Handler(ref handler) => match handler(arguments.clone()) { [INFO] [stderr] 146 | | Ok(string) => string, [INFO] [stderr] 147 | | Err(error_string) => { [INFO] [stderr] ... | [INFO] [stderr] 152 | | &ValueProducer::Static(ref value) => value.clone(), [INFO] [stderr] 153 | | }, [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 144 | Some(value_producer) => match *value_producer { [INFO] [stderr] 145 | ValueProducer::Handler(ref handler) => match handler(arguments.clone()) { [INFO] [stderr] 146 | Ok(string) => string, [INFO] [stderr] 147 | Err(error_string) => { [INFO] [stderr] 148 | errors.push(error_string); [INFO] [stderr] 149 | "".to_string() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.19s [INFO] running `"docker" "inspect" "1112fb0b313a72621e556d195a37592dafe52af30339d220e658b11cb6e29ff3"` [INFO] running `"docker" "rm" "-f" "1112fb0b313a72621e556d195a37592dafe52af30339d220e658b11cb6e29ff3"` [INFO] [stdout] 1112fb0b313a72621e556d195a37592dafe52af30339d220e658b11cb6e29ff3