[INFO] crate easy_ffi 0.1.0 is already in cache [INFO] extracting crate easy_ffi 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/easy_ffi/0.1.0 [INFO] extracting crate easy_ffi 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/easy_ffi/0.1.0 [INFO] validating manifest of easy_ffi-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of easy_ffi-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing easy_ffi-0.1.0 [INFO] finished frobbing easy_ffi-0.1.0 [INFO] frobbed toml for easy_ffi-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/easy_ffi/0.1.0/Cargo.toml [INFO] started frobbing easy_ffi-0.1.0 [INFO] finished frobbing easy_ffi-0.1.0 [INFO] frobbed toml for easy_ffi-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/easy_ffi/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting easy_ffi-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/easy_ffi/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 24e07ff3d32ed5d02db8411d88ac767b2b17a1d0c78f3a58a912832659ef6455 [INFO] running `"docker" "start" "-a" "24e07ff3d32ed5d02db8411d88ac767b2b17a1d0c78f3a58a912832659ef6455"` [INFO] [stderr] Checking easy_ffi v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: lint `private_no_mangle_fns` has been removed: `no longer an warning, #[no_mangle] functions always exported` [INFO] [stderr] --> src/lib.rs:144:14 [INFO] [stderr] | [INFO] [stderr] 144 | #![allow(private_no_mangle_fns)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint `private_no_mangle_fns` has been removed: `no longer an warning, #[no_mangle] functions always exported` [INFO] [stderr] --> src/lib.rs:144:14 [INFO] [stderr] | [INFO] [stderr] 144 | #![allow(private_no_mangle_fns)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:129:38 [INFO] [stderr] | [INFO] [stderr] 129 | .map_err(|e| ::std::result::Result::Err(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `::std::result::Result::Err` [INFO] [stderr] ... [INFO] [stderr] 160 | / my_ffi_fn! ( [INFO] [stderr] 161 | | /// Foo: do stuff [INFO] [stderr] 162 | | fn foo(i: i32) -> Result { [INFO] [stderr] 163 | | match i { [INFO] [stderr] ... | [INFO] [stderr] 168 | | } [INFO] [stderr] 169 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:130:55 [INFO] [stderr] | [INFO] [stderr] 130 | .and_then(|ok| ok.map_err(|e| ::std::result::Result::Ok(e))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `::std::result::Result::Ok` [INFO] [stderr] ... [INFO] [stderr] 160 | / my_ffi_fn! ( [INFO] [stderr] 161 | | /// Foo: do stuff [INFO] [stderr] 162 | | fn foo(i: i32) -> Result { [INFO] [stderr] 163 | | match i { [INFO] [stderr] ... | [INFO] [stderr] 168 | | } [INFO] [stderr] 169 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.52s [INFO] running `"docker" "inspect" "24e07ff3d32ed5d02db8411d88ac767b2b17a1d0c78f3a58a912832659ef6455"` [INFO] running `"docker" "rm" "-f" "24e07ff3d32ed5d02db8411d88ac767b2b17a1d0c78f3a58a912832659ef6455"` [INFO] [stdout] 24e07ff3d32ed5d02db8411d88ac767b2b17a1d0c78f3a58a912832659ef6455