[INFO] crate dtoa-short 0.3.2 is already in cache [INFO] extracting crate dtoa-short 0.3.2 into work/ex/clippy-test-run/sources/stable/reg/dtoa-short/0.3.2 [INFO] extracting crate dtoa-short 0.3.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dtoa-short/0.3.2 [INFO] validating manifest of dtoa-short-0.3.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dtoa-short-0.3.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dtoa-short-0.3.2 [INFO] finished frobbing dtoa-short-0.3.2 [INFO] frobbed toml for dtoa-short-0.3.2 written to work/ex/clippy-test-run/sources/stable/reg/dtoa-short/0.3.2/Cargo.toml [INFO] started frobbing dtoa-short-0.3.2 [INFO] finished frobbing dtoa-short-0.3.2 [INFO] frobbed toml for dtoa-short-0.3.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dtoa-short/0.3.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dtoa-short-0.3.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dtoa-short/0.3.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2048d27fa29e6b7d52b3e9b9203842d9044e60fcf95f2f30e087218226b3f456 [INFO] running `"docker" "start" "-a" "2048d27fa29e6b7d52b3e9b9203842d9044e60fcf95f2f30e087218226b3f456"` [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Compiling num-iter v0.1.37 [INFO] [stderr] Checking dtoa-short v0.3.2 (/opt/crater/workdir) [INFO] [stderr] error[E0602]: unknown lint: `clippy::into_iter_on_array` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into_iter_on_array` [INFO] [stderr] [INFO] [stderr] error[E0602]: unknown lint: `clippy::into_iter_on_array` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into_iter_on_array` [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0602`. [INFO] [stderr] error: Could not compile `num-iter`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error[E0602]: unknown lint: `clippy::into_iter_on_array` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into_iter_on_array` [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0602`. [INFO] [stderr] error: Could not compile `num-traits`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:179:12 [INFO] [stderr] | [INFO] [stderr] 179 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 180 | | if buf[0] == b'0' && buf[1] != b'.' { [INFO] [stderr] 181 | | &buf[1..real_end] [INFO] [stderr] 182 | | } else { [INFO] [stderr] 183 | | &buf[0..real_end] [INFO] [stderr] 184 | | } [INFO] [stderr] 185 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 179 | } else if buf[0] == b'0' && buf[1] != b'.' { [INFO] [stderr] 180 | &buf[1..real_end] [INFO] [stderr] 181 | } else { [INFO] [stderr] 182 | &buf[0..real_end] [INFO] [stderr] 183 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0602`. [INFO] [stderr] error: Could not compile `num-integer`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:64:53 [INFO] [stderr] | [INFO] [stderr] 64 | let (result, notation) = restrict_prec(&mut buf[0..len + 1], prec); [INFO] [stderr] | ^^^^^^^^^^ help: use: `0..=len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 34 [INFO] [stderr] --> src/lib.rs:69:1 [INFO] [stderr] | [INFO] [stderr] 69 | / fn restrict_prec(buf: &mut [u8], prec: usize) -> (&[u8], Notation) { [INFO] [stderr] 70 | | let len = buf.len(); [INFO] [stderr] 71 | | debug_assert!(len <= BUFFER_SIZE + 1, "dtoa may have changed its buffer size"); [INFO] [stderr] 72 | | // Put a leading zero to capture any carry. [INFO] [stderr] ... | [INFO] [stderr] 191 | | (result, notation) [INFO] [stderr] 192 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `buf` [INFO] [stderr] --> src/lib.rs:87:14 [INFO] [stderr] | [INFO] [stderr] 87 | for i in 1..len { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 87 | for (i, ) in buf.iter().enumerate().take(len).skip(1) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `buf`. [INFO] [stderr] --> src/lib.rs:141:18 [INFO] [stderr] | [INFO] [stderr] 141 | for i in new_coeff_end..pos_dot { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 141 | for in buf.iter_mut().take(pos_dot).skip(new_coeff_end) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "2048d27fa29e6b7d52b3e9b9203842d9044e60fcf95f2f30e087218226b3f456"` [INFO] running `"docker" "rm" "-f" "2048d27fa29e6b7d52b3e9b9203842d9044e60fcf95f2f30e087218226b3f456"` [INFO] [stdout] 2048d27fa29e6b7d52b3e9b9203842d9044e60fcf95f2f30e087218226b3f456