[INFO] crate drc 0.1.2 is already in cache [INFO] extracting crate drc 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/drc/0.1.2 [INFO] extracting crate drc 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/drc/0.1.2 [INFO] validating manifest of drc-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of drc-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing drc-0.1.2 [INFO] finished frobbing drc-0.1.2 [INFO] frobbed toml for drc-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/drc/0.1.2/Cargo.toml [INFO] started frobbing drc-0.1.2 [INFO] finished frobbing drc-0.1.2 [INFO] frobbed toml for drc-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/drc/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting drc-0.1.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/drc/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e21407c8053503e0594f0df5594c012ec555119621dc02af00ee927f01fa8ba5 [INFO] running `"docker" "start" "-a" "e21407c8053503e0594f0df5594c012ec555119621dc02af00ee927f01fa8ba5"` [INFO] [stderr] Checking drc v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/weak.rs:391:20 [INFO] [stderr] | [INFO] [stderr] 391 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 392 | | if weak == 2 [INFO] [stderr] 393 | | /* now it is 1 */ [INFO] [stderr] 394 | | { [INFO] [stderr] ... | [INFO] [stderr] 400 | | } [INFO] [stderr] 401 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 391 | } else if weak == 2 [INFO] [stderr] 392 | /* now it is 1 */ [INFO] [stderr] 393 | { [INFO] [stderr] 394 | // Drop the contained `WeakArc`. [INFO] [stderr] 395 | drop(self.take_weak_arc()); [INFO] [stderr] 396 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/weak.rs:391:20 [INFO] [stderr] | [INFO] [stderr] 391 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 392 | | if weak == 2 [INFO] [stderr] 393 | | /* now it is 1 */ [INFO] [stderr] 394 | | { [INFO] [stderr] ... | [INFO] [stderr] 400 | | } [INFO] [stderr] 401 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 391 | } else if weak == 2 [INFO] [stderr] 392 | /* now it is 1 */ [INFO] [stderr] 393 | { [INFO] [stderr] 394 | // Drop the contained `WeakArc`. [INFO] [stderr] 395 | drop(self.take_weak_arc()); [INFO] [stderr] 396 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/drc.rs:1073:5 [INFO] [stderr] | [INFO] [stderr] 1073 | / fn ne(&self, other: &Drc) -> bool { [INFO] [stderr] 1074 | | **self != **other [INFO] [stderr] 1075 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/drc.rs:1073:5 [INFO] [stderr] | [INFO] [stderr] 1073 | / fn ne(&self, other: &Drc) -> bool { [INFO] [stderr] 1074 | | **self != **other [INFO] [stderr] 1075 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 54 [INFO] [stderr] --> src/drc.rs:1933:5 [INFO] [stderr] | [INFO] [stderr] 1933 | / fn make_mut() { [INFO] [stderr] 1934 | | // Test case for way of working that does not alter the Drc. [INFO] [stderr] 1935 | | { [INFO] [stderr] 1936 | | let mut drc = Drc::new(17usize); [INFO] [stderr] ... | [INFO] [stderr] 2313 | | } [INFO] [stderr] 2314 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/drc.rs:2355:13 [INFO] [stderr] | [INFO] [stderr] 2355 | let foo = Drc::new(Foo(&cell)); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/weak.rs:644:13 [INFO] [stderr] | [INFO] [stderr] 644 | let foo = Drc::new(Foo(&cell)); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.81s [INFO] running `"docker" "inspect" "e21407c8053503e0594f0df5594c012ec555119621dc02af00ee927f01fa8ba5"` [INFO] running `"docker" "rm" "-f" "e21407c8053503e0594f0df5594c012ec555119621dc02af00ee927f01fa8ba5"` [INFO] [stdout] e21407c8053503e0594f0df5594c012ec555119621dc02af00ee927f01fa8ba5