[INFO] crate discrete 0.2.0 is already in cache [INFO] extracting crate discrete 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/discrete/0.2.0 [INFO] extracting crate discrete 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/discrete/0.2.0 [INFO] validating manifest of discrete-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of discrete-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing discrete-0.2.0 [INFO] finished frobbing discrete-0.2.0 [INFO] frobbed toml for discrete-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/discrete/0.2.0/Cargo.toml [INFO] started frobbing discrete-0.2.0 [INFO] finished frobbing discrete-0.2.0 [INFO] frobbed toml for discrete-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/discrete/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting discrete-0.2.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/discrete/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] de2cf1d3b3e16de86032dd7fbb0a493751134c0d5812a76358f25027fc3bde96 [INFO] running `"docker" "start" "-a" "de2cf1d3b3e16de86032dd7fbb0a493751134c0d5812a76358f25027fc3bde96"` [INFO] [stderr] Checking discrete v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/context.rs:383:25 [INFO] [stderr] | [INFO] [stderr] 383 | assert_eq!(pos, ((vec![(0, 2), (0, 2)], 1, (1, 2)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `dim`. [INFO] [stderr] --> src/dimension_n.rs:21:18 [INFO] [stderr] | [INFO] [stderr] 21 | for i in 0..dim.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 21 | for in &dim { [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `dim`. [INFO] [stderr] --> src/dimension_n.rs:36:18 [INFO] [stderr] | [INFO] [stderr] 36 | for i in 0..dim.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 36 | for in &dim { [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `dim`. [INFO] [stderr] --> src/dimension_n.rs:57:18 [INFO] [stderr] | [INFO] [stderr] 57 | for i in 0..dim.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 57 | for in &dim { [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/dimension_n.rs:104:14 [INFO] [stderr] | [INFO] [stderr] 104 | *pos.get_mut(i).unwrap() = p_i; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `pos[i]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping `pos.1` and `pos.0` manually [INFO] [stderr] --> src/neq_pair.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | / let tmp = pos.1; [INFO] [stderr] 91 | | pos.1 = pos.0; [INFO] [stderr] 92 | | pos.0 = tmp; [INFO] [stderr] | |_______________________^ help: try: `std::mem::swap(&mut pos.1, &mut pos.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = note: or maybe you should use `std::mem::replace`? [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/permutation.rs:25:18 [INFO] [stderr] | [INFO] [stderr] 25 | for x in 1..dim + 1 { [INFO] [stderr] | ^^^^^^^^^^ help: use: `1..=dim` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/permutation.rs:39:18 [INFO] [stderr] | [INFO] [stderr] 39 | for x in 1..of.count(dim) + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `1..=of.count(dim)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/permutation.rs:104:23 [INFO] [stderr] | [INFO] [stderr] 104 | for (j, x) in (1..dim + 1).enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `(1..=dim)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/permutation.rs:131:23 [INFO] [stderr] | [INFO] [stderr] 131 | for (j, x) in (1..of_count + 1).enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(1..=of_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `v` [INFO] [stderr] --> src/context.rs:41:18 [INFO] [stderr] | [INFO] [stderr] 41 | for j in 0..v.len() { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 41 | for (j, ) in v.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `v` [INFO] [stderr] --> src/context.rs:61:18 [INFO] [stderr] | [INFO] [stderr] 61 | for j in 0..v.len() { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 61 | for (j, ) in v.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `dim`. [INFO] [stderr] --> src/context.rs:126:18 [INFO] [stderr] | [INFO] [stderr] 126 | for i in 0..dim.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 126 | for in &dim { [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `dim` [INFO] [stderr] --> src/context.rs:145:18 [INFO] [stderr] | [INFO] [stderr] 145 | for j in 0..dim.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 145 | for (j, ) in dim.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `v` [INFO] [stderr] --> src/context.rs:180:26 [INFO] [stderr] | [INFO] [stderr] 180 | for j in 0..v.len() { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 180 | for (j, ) in v.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `dim` [INFO] [stderr] --> src/context.rs:196:18 [INFO] [stderr] | [INFO] [stderr] 196 | for j in 0..dim.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 196 | for (j, ) in dim.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `dim` [INFO] [stderr] --> src/context.rs:230:18 [INFO] [stderr] | [INFO] [stderr] 230 | for j in 0..dim.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 230 | for (j, ) in dim.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `v` [INFO] [stderr] --> src/context.rs:279:26 [INFO] [stderr] | [INFO] [stderr] 279 | for j in 0..v.len() { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 279 | for (j, ) in v.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `dim` [INFO] [stderr] --> src/context.rs:300:18 [INFO] [stderr] | [INFO] [stderr] 300 | for j in 0..dim.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 300 | for (j, ) in dim.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `dim`. [INFO] [stderr] --> src/directed_context.rs:67:18 [INFO] [stderr] | [INFO] [stderr] 67 | for i in 0..dim.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 67 | for in &dim { [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping `pos.0[pos.1]` and `pos.2` manually [INFO] [stderr] --> src/directed_context.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | / let tmp = pos.0[pos.1]; [INFO] [stderr] 129 | | pos.0[pos.1] = pos.2; [INFO] [stderr] 130 | | pos.2 = tmp; [INFO] [stderr] | |_______________________^ help: try: `std::mem::swap(&mut pos.0[pos.1], &mut pos.2)` [INFO] [stderr] | [INFO] [stderr] = note: or maybe you should use `std::mem::replace`? [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> examples/necklace.rs:64:37 [INFO] [stderr] | [INFO] [stderr] 64 | if count < 500 || counter % 100000 == 0 { [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> examples/necklace.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | let ref dim = vec![base; n]; [INFO] [stderr] | ----^^^^^^^----------------- help: try: `let dim = &$ crate :: vec :: from_elem ( $ elem , $ n );` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> examples/pair_of_pairs.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | let ref n = 150; [INFO] [stderr] | ----^^^^^------- help: try: `let n = &150;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> examples/test.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | let ref dim = vec![vec![2, 2], vec![2, 2]]; [INFO] [stderr] | ----^^^^^^^-------------------------------- help: try: `let dim = &< [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] );` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `object` [INFO] [stderr] --> examples/directed_context.rs:65:18 [INFO] [stderr] | [INFO] [stderr] 65 | for i in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 65 | for (i, ) in object.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> examples/pair_of_powersets.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | let ref n = 10; [INFO] [stderr] | ----^^^^^------ help: try: `let n = &10;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> examples/world_agent.rs:84:14 [INFO] [stderr] | [INFO] [stderr] 84 | fn desc(pos: &(Select<(Vec, usize, usize), Vec>, Vec)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/power_set.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | let ref dim = 6; [INFO] [stderr] | ----^^^^^^^----- help: try: `let dim = &6;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/power_set.rs:150:13 [INFO] [stderr] | [INFO] [stderr] 150 | let ref dim = 4; [INFO] [stderr] | ----^^^^^^^----- help: try: `let dim = &4;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `dim`. [INFO] [stderr] --> src/dimension_n.rs:21:18 [INFO] [stderr] | [INFO] [stderr] 21 | for i in 0..dim.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 21 | for in &dim { [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `dim`. [INFO] [stderr] --> src/dimension_n.rs:36:18 [INFO] [stderr] | [INFO] [stderr] 36 | for i in 0..dim.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 36 | for in &dim { [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `dim`. [INFO] [stderr] --> src/dimension_n.rs:57:18 [INFO] [stderr] | [INFO] [stderr] 57 | for i in 0..dim.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 57 | for in &dim { [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/dimension_n.rs:104:14 [INFO] [stderr] | [INFO] [stderr] 104 | *pos.get_mut(i).unwrap() = p_i; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `pos[i]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/dimension_n.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | let ref dim = vec![3, 3]; [INFO] [stderr] | ----^^^^^^^-------------- help: try: `let dim = &< [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] );` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/dimension_n.rs:160:13 [INFO] [stderr] | [INFO] [stderr] 160 | let ref dim = vec![3, 4]; [INFO] [stderr] | ----^^^^^^^-------------- help: try: `let dim = &< [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] );` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/pair.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | let ref dim = 4; [INFO] [stderr] | ----^^^^^^^----- help: try: `let dim = &4;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/pair.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | let ref dim = vec![2, 2]; [INFO] [stderr] | ----^^^^^^^-------------- help: try: `let dim = &< [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] );` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/eq_pair.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | let ref n = 4; [INFO] [stderr] | ----^^^^^----- help: try: `let n = &4;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping `pos.1` and `pos.0` manually [INFO] [stderr] --> src/neq_pair.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | / let tmp = pos.1; [INFO] [stderr] 91 | | pos.1 = pos.0; [INFO] [stderr] 92 | | pos.0 = tmp; [INFO] [stderr] | |_______________________^ help: try: `std::mem::swap(&mut pos.1, &mut pos.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = note: or maybe you should use `std::mem::replace`? [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/neq_pair.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | let ref dim = 4; [INFO] [stderr] | ----^^^^^^^----- help: try: `let dim = &4;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/neq_pair.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | let ref dim = vec![2, 2]; [INFO] [stderr] | ----^^^^^^^-------------- help: try: `let dim = &< [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] );` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/permutation.rs:25:18 [INFO] [stderr] | [INFO] [stderr] 25 | for x in 1..dim + 1 { [INFO] [stderr] | ^^^^^^^^^^ help: use: `1..=dim` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/permutation.rs:39:18 [INFO] [stderr] | [INFO] [stderr] 39 | for x in 1..of.count(dim) + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `1..=of.count(dim)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/permutation.rs:104:23 [INFO] [stderr] | [INFO] [stderr] 104 | for (j, x) in (1..dim + 1).enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `(1..=dim)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/permutation.rs:131:23 [INFO] [stderr] | [INFO] [stderr] 131 | for (j, x) in (1..of_count + 1).enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `(1..=of_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/permutation.rs:168:13 [INFO] [stderr] | [INFO] [stderr] 168 | let ref dim = 4; [INFO] [stderr] | ----^^^^^^^----- help: try: `let dim = &4;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/permutation.rs:180:13 [INFO] [stderr] | [INFO] [stderr] 180 | let ref dim = 3; [INFO] [stderr] | ----^^^^^^^----- help: try: `let dim = &3;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `v` [INFO] [stderr] --> src/context.rs:41:18 [INFO] [stderr] | [INFO] [stderr] 41 | for j in 0..v.len() { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 41 | for (j, ) in v.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `v` [INFO] [stderr] --> src/context.rs:61:18 [INFO] [stderr] | [INFO] [stderr] 61 | for j in 0..v.len() { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 61 | for (j, ) in v.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `dim`. [INFO] [stderr] --> src/context.rs:126:18 [INFO] [stderr] | [INFO] [stderr] 126 | for i in 0..dim.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 126 | for in &dim { [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `dim` [INFO] [stderr] --> src/context.rs:145:18 [INFO] [stderr] | [INFO] [stderr] 145 | for j in 0..dim.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 145 | for (j, ) in dim.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `v` [INFO] [stderr] --> src/context.rs:180:26 [INFO] [stderr] | [INFO] [stderr] 180 | for j in 0..v.len() { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 180 | for (j, ) in v.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `dim` [INFO] [stderr] --> src/context.rs:196:18 [INFO] [stderr] | [INFO] [stderr] 196 | for j in 0..dim.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 196 | for (j, ) in dim.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `dim` [INFO] [stderr] --> src/context.rs:230:18 [INFO] [stderr] | [INFO] [stderr] 230 | for j in 0..dim.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 230 | for (j, ) in dim.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `v` [INFO] [stderr] --> src/context.rs:279:26 [INFO] [stderr] | [INFO] [stderr] 279 | for j in 0..v.len() { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 279 | for (j, ) in v.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `dim` [INFO] [stderr] --> src/context.rs:300:18 [INFO] [stderr] | [INFO] [stderr] 300 | for j in 0..dim.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 300 | for (j, ) in dim.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/context.rs:341:13 [INFO] [stderr] | [INFO] [stderr] 341 | let ref dim = vec![2, 2, 2]; [INFO] [stderr] | ----^^^^^^^----------------- help: try: `let dim = &< [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] );` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/context.rs:355:13 [INFO] [stderr] | [INFO] [stderr] 355 | let ref dim = vec![3]; [INFO] [stderr] | ----^^^^^^^----------- help: try: `let dim = &< [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] );` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/context.rs:360:13 [INFO] [stderr] | [INFO] [stderr] 360 | let ref dim = vec![3, 3]; [INFO] [stderr] | ----^^^^^^^-------------- help: try: `let dim = &< [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] );` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `dim`. [INFO] [stderr] --> src/directed_context.rs:67:18 [INFO] [stderr] | [INFO] [stderr] 67 | for i in 0..dim.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 67 | for in &dim { [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping `pos.0[pos.1]` and `pos.2` manually [INFO] [stderr] --> src/directed_context.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | / let tmp = pos.0[pos.1]; [INFO] [stderr] 129 | | pos.0[pos.1] = pos.2; [INFO] [stderr] 130 | | pos.2 = tmp; [INFO] [stderr] | |_______________________^ help: try: `std::mem::swap(&mut pos.0[pos.1], &mut pos.2)` [INFO] [stderr] | [INFO] [stderr] = note: or maybe you should use `std::mem::replace`? [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/directed_context.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | let ref dim = vec![2, 2, 2]; [INFO] [stderr] | ----^^^^^^^----------------- help: try: `let dim = &< [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] );` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.19s [INFO] running `"docker" "inspect" "de2cf1d3b3e16de86032dd7fbb0a493751134c0d5812a76358f25027fc3bde96"` [INFO] running `"docker" "rm" "-f" "de2cf1d3b3e16de86032dd7fbb0a493751134c0d5812a76358f25027fc3bde96"` [INFO] [stdout] de2cf1d3b3e16de86032dd7fbb0a493751134c0d5812a76358f25027fc3bde96