[INFO] crate digits 1.1.0 is already in cache [INFO] extracting crate digits 1.1.0 into work/ex/clippy-test-run/sources/stable/reg/digits/1.1.0 [INFO] extracting crate digits 1.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/digits/1.1.0 [INFO] validating manifest of digits-1.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of digits-1.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing digits-1.1.0 [INFO] finished frobbing digits-1.1.0 [INFO] frobbed toml for digits-1.1.0 written to work/ex/clippy-test-run/sources/stable/reg/digits/1.1.0/Cargo.toml [INFO] started frobbing digits-1.1.0 [INFO] finished frobbing digits-1.1.0 [INFO] frobbed toml for digits-1.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/digits/1.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting digits-1.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/digits/1.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fbfe94944c710b86762627c25994021c13457849ce6be6ab9e59d8e87f2c1dbf [INFO] running `"docker" "start" "-a" "fbfe94944c710b86762627c25994021c13457849ce6be6ab9e59d8e87f2c1dbf"` [INFO] [stderr] Checking array_tool v0.4.1 [INFO] [stderr] Checking digits v1.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:415:44 [INFO] [stderr] | [INFO] [stderr] 415 | if number.is_empty() { return Digits { mapping: mapping, digit: 0, left: None }; }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `mapping` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:415:44 [INFO] [stderr] | [INFO] [stderr] 415 | if number.is_empty() { return Digits { mapping: mapping, digit: 0, left: None }; }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `mapping` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:481:14 [INFO] [stderr] | [INFO] [stderr] 481 | Digits { mapping: mapping, digit: 1, left: None } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `mapping` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:497:14 [INFO] [stderr] | [INFO] [stderr] 497 | Digits { mapping: mapping, digit: 0, left: None } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `mapping` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:481:14 [INFO] [stderr] | [INFO] [stderr] 481 | Digits { mapping: mapping, digit: 1, left: None } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `mapping` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:497:14 [INFO] [stderr] | [INFO] [stderr] 497 | Digits { mapping: mapping, digit: 0, left: None } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `mapping` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/internal/carry_add.rs:36:8 [INFO] [stderr] | [INFO] [stderr] 36 | if !(cap.1 == 0) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `cap.1 != 0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lib.rs:1082:8 [INFO] [stderr] | [INFO] [stderr] 1082 | if a.left.is_some() && !b.left.is_some() && !a.left.clone().unwrap().is_zero() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `a.left.is_some() && b.left.is_none() && !a.left.clone().unwrap().is_zero()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lib.rs:1085:8 [INFO] [stderr] | [INFO] [stderr] 1085 | if !a.left.is_some() && b.left.is_some() && !b.left.unwrap().is_zero() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `a.left.is_none() && b.left.is_some() && !b.left.unwrap().is_zero()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/internal/carry_add.rs:36:8 [INFO] [stderr] | [INFO] [stderr] 36 | if !(cap.1 == 0) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `cap.1 != 0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/internal/carry_add.rs:68:15 [INFO] [stderr] | [INFO] [stderr] 68 | let bnine = nine.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try removing the `clone` call: `nine` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/internal/step_map.rs:126:1 [INFO] [stderr] | [INFO] [stderr] 126 | / fn it_produces_correct_steps_for_zero_neighbors_in_base4(){ [INFO] [stderr] 127 | | let base4 = BaseCustom::::new("0123".chars().collect()); [INFO] [stderr] 128 | | let num = Digits::new(base4, "".to_string()); [INFO] [stderr] 129 | | let mut step_iter = StepMap::new(num, 0); [INFO] [stderr] ... | [INFO] [stderr] 161 | | assert_eq!(step_iter.next().unwrap().to_s(), "1020202020202021".to_string()); [INFO] [stderr] 162 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/internal/step_map.rs:165:1 [INFO] [stderr] | [INFO] [stderr] 165 | / fn it_produces_correct_steps_for_one_neighbor_in_base4(){ [INFO] [stderr] 166 | | let base4 = BaseCustom::::new("0123".chars().collect()); [INFO] [stderr] 167 | | let num = Digits::new(base4, "".to_string()); [INFO] [stderr] 168 | | let mut step_iter = StepMap::new(num, 1); [INFO] [stderr] ... | [INFO] [stderr] 194 | | assert_eq!(step_iter.next().unwrap().to_s(), "1002002002003".to_string()); [INFO] [stderr] 195 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lib.rs:1082:8 [INFO] [stderr] | [INFO] [stderr] 1082 | if a.left.is_some() && !b.left.is_some() && !a.left.clone().unwrap().is_zero() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `a.left.is_some() && b.left.is_none() && !a.left.clone().unwrap().is_zero()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lib.rs:1085:8 [INFO] [stderr] | [INFO] [stderr] 1085 | if !a.left.is_some() && b.left.is_some() && !b.left.unwrap().is_zero() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `a.left.is_none() && b.left.is_some() && !b.left.unwrap().is_zero()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> tests/lib.rs:134:32 [INFO] [stderr] | [INFO] [stderr] 134 | let num = builder.new_mapped(&vec![1,0,5,5,5,5,5,5,5,2,1,1,1,1]).ok().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1,0,5,5,5,5,5,5,5,2,1,1,1,1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> tests/lib.rs:142:32 [INFO] [stderr] | [INFO] [stderr] 142 | let num = builder.new_mapped(&vec![1,0,2,1,1,1,1]).ok().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1,0,2,1,1,1,1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> tests/lib.rs:150:32 [INFO] [stderr] | [INFO] [stderr] 150 | let num = builder.new_mapped(&vec![1,0,2,1]).ok().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1,0,2,1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> tests/lib.rs:158:32 [INFO] [stderr] | [INFO] [stderr] 158 | let num = builder.new_mapped(&vec![15]).ok().unwrap(); [INFO] [stderr] | ^^^^^^^^^ help: you can use a slice directly: `&[15]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> tests/lib.rs:160:32 [INFO] [stderr] | [INFO] [stderr] 160 | let num = builder.new_mapped(&vec![16]); [INFO] [stderr] | ^^^^^^^^^ help: you can use a slice directly: `&[16]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.40s [INFO] running `"docker" "inspect" "fbfe94944c710b86762627c25994021c13457849ce6be6ab9e59d8e87f2c1dbf"` [INFO] running `"docker" "rm" "-f" "fbfe94944c710b86762627c25994021c13457849ce6be6ab9e59d8e87f2c1dbf"` [INFO] [stdout] fbfe94944c710b86762627c25994021c13457849ce6be6ab9e59d8e87f2c1dbf