[INFO] crate dessert-derive 0.1.2 is already in cache [INFO] extracting crate dessert-derive 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/dessert-derive/0.1.2 [INFO] extracting crate dessert-derive 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dessert-derive/0.1.2 [INFO] validating manifest of dessert-derive-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dessert-derive-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dessert-derive-0.1.2 [INFO] finished frobbing dessert-derive-0.1.2 [INFO] frobbed toml for dessert-derive-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/dessert-derive/0.1.2/Cargo.toml [INFO] started frobbing dessert-derive-0.1.2 [INFO] finished frobbing dessert-derive-0.1.2 [INFO] frobbed toml for dessert-derive-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dessert-derive/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dessert-derive-0.1.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dessert-derive/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7dec2d6b48e8a24bcd2c9a919cb5d163115f0832b35a2574822180968d2aec1a [INFO] running `"docker" "start" "-a" "7dec2d6b48e8a24bcd2c9a919cb5d163115f0832b35a2574822180968d2aec1a"` [INFO] [stderr] Checking dessert-derive v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:27:17 [INFO] [stderr] | [INFO] [stderr] 27 | / match tpl { [INFO] [stderr] 28 | | &syn::NestedMeta::Meta(syn::Meta::Word(ins)) => {tname = ins;}, [INFO] [stderr] 29 | | _ => () [INFO] [stderr] 30 | | }; [INFO] [stderr] | |_________________^ help: try this: `if let &syn::NestedMeta::Meta(syn::Meta::Word(ins)) = tpl {tname = ins;}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:27:17 [INFO] [stderr] | [INFO] [stderr] 27 | / match tpl { [INFO] [stderr] 28 | | &syn::NestedMeta::Meta(syn::Meta::Word(ins)) => {tname = ins;}, [INFO] [stderr] 29 | | _ => () [INFO] [stderr] 30 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 27 | match *tpl { [INFO] [stderr] 28 | syn::NestedMeta::Meta(syn::Meta::Word(ins)) => {tname = ins;}, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:39:20 [INFO] [stderr] | [INFO] [stderr] 39 | if ident.to_string() == "via"{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `*ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:27:17 [INFO] [stderr] | [INFO] [stderr] 27 | / match tpl { [INFO] [stderr] 28 | | &syn::NestedMeta::Meta(syn::Meta::Word(ins)) => {tname = ins;}, [INFO] [stderr] 29 | | _ => () [INFO] [stderr] 30 | | }; [INFO] [stderr] | |_________________^ help: try this: `if let &syn::NestedMeta::Meta(syn::Meta::Word(ins)) = tpl {tname = ins;}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:27:17 [INFO] [stderr] | [INFO] [stderr] 27 | / match tpl { [INFO] [stderr] 28 | | &syn::NestedMeta::Meta(syn::Meta::Word(ins)) => {tname = ins;}, [INFO] [stderr] 29 | | _ => () [INFO] [stderr] 30 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 27 | match *tpl { [INFO] [stderr] 28 | syn::NestedMeta::Meta(syn::Meta::Word(ins)) => {tname = ins;}, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:39:20 [INFO] [stderr] | [INFO] [stderr] 39 | if ident.to_string() == "via"{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `*ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:95:17 [INFO] [stderr] | [INFO] [stderr] 95 | / match tpl { [INFO] [stderr] 96 | | &syn::NestedMeta::Meta(syn::Meta::Word(ins)) => {tname = ins;}, [INFO] [stderr] 97 | | _ => () [INFO] [stderr] 98 | | }; [INFO] [stderr] | |_________________^ help: try this: `if let &syn::NestedMeta::Meta(syn::Meta::Word(ins)) = tpl {tname = ins;}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:95:17 [INFO] [stderr] | [INFO] [stderr] 95 | / match tpl { [INFO] [stderr] 96 | | &syn::NestedMeta::Meta(syn::Meta::Word(ins)) => {tname = ins;}, [INFO] [stderr] 97 | | _ => () [INFO] [stderr] 98 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 95 | match *tpl { [INFO] [stderr] 96 | syn::NestedMeta::Meta(syn::Meta::Word(ins)) => {tname = ins;}, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:107:20 [INFO] [stderr] | [INFO] [stderr] 107 | if ident.to_string() == "via"{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `*ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:95:17 [INFO] [stderr] | [INFO] [stderr] 95 | / match tpl { [INFO] [stderr] 96 | | &syn::NestedMeta::Meta(syn::Meta::Word(ins)) => {tname = ins;}, [INFO] [stderr] 97 | | _ => () [INFO] [stderr] 98 | | }; [INFO] [stderr] | |_________________^ help: try this: `if let &syn::NestedMeta::Meta(syn::Meta::Word(ins)) = tpl {tname = ins;}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:95:17 [INFO] [stderr] | [INFO] [stderr] 95 | / match tpl { [INFO] [stderr] 96 | | &syn::NestedMeta::Meta(syn::Meta::Word(ins)) => {tname = ins;}, [INFO] [stderr] 97 | | _ => () [INFO] [stderr] 98 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 95 | match *tpl { [INFO] [stderr] 96 | syn::NestedMeta::Meta(syn::Meta::Word(ins)) => {tname = ins;}, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:107:20 [INFO] [stderr] | [INFO] [stderr] 107 | if ident.to_string() == "via"{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `*ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.69s [INFO] running `"docker" "inspect" "7dec2d6b48e8a24bcd2c9a919cb5d163115f0832b35a2574822180968d2aec1a"` [INFO] running `"docker" "rm" "-f" "7dec2d6b48e8a24bcd2c9a919cb5d163115f0832b35a2574822180968d2aec1a"` [INFO] [stdout] 7dec2d6b48e8a24bcd2c9a919cb5d163115f0832b35a2574822180968d2aec1a