[INFO] crate delegatemethod 0.2.2 is already in cache [INFO] extracting crate delegatemethod 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/delegatemethod/0.2.2 [INFO] extracting crate delegatemethod 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/delegatemethod/0.2.2 [INFO] validating manifest of delegatemethod-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of delegatemethod-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing delegatemethod-0.2.2 [INFO] finished frobbing delegatemethod-0.2.2 [INFO] frobbed toml for delegatemethod-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/delegatemethod/0.2.2/Cargo.toml [INFO] started frobbing delegatemethod-0.2.2 [INFO] finished frobbing delegatemethod-0.2.2 [INFO] frobbed toml for delegatemethod-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/delegatemethod/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting delegatemethod-0.2.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/delegatemethod/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ddf85a685b78466f90288a11e0470148afa43d8973534ff930b146d1524105ed [INFO] running `"docker" "start" "-a" "ddf85a685b78466f90288a11e0470148afa43d8973534ff930b146d1524105ed"` [INFO] [stderr] Checking delegatemethod v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:173:21 [INFO] [stderr] | [INFO] [stderr] 173 | pub fn noop(&self) {} [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:175:9 [INFO] [stderr] | [INFO] [stderr] 175 | / pub fn str_to_owned<'a>(str: &'a str) -> String { [INFO] [stderr] 176 | | str.to_owned() [INFO] [stderr] 177 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:179:20 [INFO] [stderr] | [INFO] [stderr] 179 | pub fn get(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:183:24 [INFO] [stderr] | [INFO] [stderr] 183 | pub fn get_add(&self, val: usize) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:54:47 [INFO] [stderr] | [INFO] [stderr] 54 | ($fld) ($fldty) ($fcn) (fn) ($($($lt),*),*) ($($args)*) ($(-> $r)*) ($($($aty : ?Sized $(+ $ayb_rest $(:: $ayb_rest_ext)*)*),*)*) [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 55 | | ($fld as $fldty : $($resttt)*) ($($tailtt)*));}; [INFO] [stderr] 56 | | [INFO] [stderr] 57 | | {@impl_expansion ($($headtt:tt)*) [INFO] [stderr] ... | [INFO] [stderr] 150 | | {delegate_method!(@ impl_expansion_impl ($($headtt)*) [INFO] [stderr] 151 | | ($($kwtt)* $fcn $($gp)* ($($a : $at),*) $($r)* { <$fldty>::$fcn($($a),*) }) [INFO] [stderr] | |________________________________________________________________________________^ [INFO] [stderr] ... [INFO] [stderr] 217 | / delegate_method! { [INFO] [stderr] 218 | | impl Outer { [INFO] [stderr] 219 | | inner as Inner: [INFO] [stderr] 220 | | fn new_inner() -> Inner; [INFO] [stderr] ... | [INFO] [stderr] 233 | | } [INFO] [stderr] 234 | | } [INFO] [stderr] | |_________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:254:20 [INFO] [stderr] | [INFO] [stderr] 254 | assert_eq!(x.clone().to_data(), 36); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:255:20 [INFO] [stderr] | [INFO] [stderr] 255 | assert_eq!(x.clone().to_data_add(4), 40); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:257:20 [INFO] [stderr] | [INFO] [stderr] 257 | assert_eq!(x.clone().to_data_ignore_unsized(Box::new(3)), 36); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.64s [INFO] running `"docker" "inspect" "ddf85a685b78466f90288a11e0470148afa43d8973534ff930b146d1524105ed"` [INFO] running `"docker" "rm" "-f" "ddf85a685b78466f90288a11e0470148afa43d8973534ff930b146d1524105ed"` [INFO] [stdout] ddf85a685b78466f90288a11e0470148afa43d8973534ff930b146d1524105ed