[INFO] crate dces 0.1.1 is already in cache [INFO] extracting crate dces 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/dces/0.1.1 [INFO] extracting crate dces 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dces/0.1.1 [INFO] validating manifest of dces-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dces-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dces-0.1.1 [INFO] finished frobbing dces-0.1.1 [INFO] frobbed toml for dces-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/dces/0.1.1/Cargo.toml [INFO] started frobbing dces-0.1.1 [INFO] finished frobbing dces-0.1.1 [INFO] frobbed toml for dces-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dces/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dces-0.1.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dces/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bff852b8d4072b8eb930ff5032ee3d336d7717f565dfee96b30f6de9c05a7822 [INFO] running `"docker" "start" "-a" "bff852b8d4072b8eb930ff5032ee3d336d7717f565dfee96b30f6de9c05a7822"` [INFO] [stderr] Checking dces v0.1.1 (/opt/crater/workdir) [INFO] [stderr] error: usage of `contains_key` followed by `insert` on a `BTreeMap` [INFO] [stderr] --> src/system/mod.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | / if !self.priorities.contains_key(&priority) { [INFO] [stderr] 101 | | self.priorities.insert(priority, vec![system_id]); [INFO] [stderr] 102 | | return [INFO] [stderr] 103 | | } [INFO] [stderr] | |_________^ help: consider using: `self.priorities.entry(priority)` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:3:9 [INFO] [stderr] | [INFO] [stderr] 3 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::map_entry)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] error: redundant closure found [INFO] [stderr] --> src/system/mod.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | |es| Ok(es), [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Ok` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:3:9 [INFO] [stderr] | [INFO] [stderr] 3 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::redundant_closure)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: redundant closure found [INFO] [stderr] --> src/system/mod.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | |es| Ok(es), [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Ok` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: methods called `new` usually return `Self` [INFO] [stderr] --> src/world/mod.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn new() -> World { [INFO] [stderr] 28 | | World::from_container(VecEntityContainer::default()) [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:3:9 [INFO] [stderr] | [INFO] [stderr] 3 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::new_ret_no_self)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] error: you seem to want to iterate on a map's values [INFO] [stderr] --> src/world/mod.rs:88:26 [INFO] [stderr] | [INFO] [stderr] 88 | for (_, prio) in priorities { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:3:9 [INFO] [stderr] | [INFO] [stderr] 3 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::for_kv_map)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 88 | for prio in priorities.values() { [INFO] [stderr] | ^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `dces`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/system/tests.rs:33:16 [INFO] [stderr] | [INFO] [stderr] 33 | assert_eq!(esm.entity_systems.get(&0).unwrap().priority, 5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&esm.entity_systems[&0]` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:3:9 [INFO] [stderr] | [INFO] [stderr] 3 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::get_unwrap)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: usage of `contains_key` followed by `insert` on a `BTreeMap` [INFO] [stderr] --> src/system/mod.rs:100:9 [INFO] [stderr] | [INFO] [stderr] 100 | / if !self.priorities.contains_key(&priority) { [INFO] [stderr] 101 | | self.priorities.insert(priority, vec![system_id]); [INFO] [stderr] 102 | | return [INFO] [stderr] 103 | | } [INFO] [stderr] | |_________^ help: consider using: `self.priorities.entry(priority)` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:3:9 [INFO] [stderr] | [INFO] [stderr] 3 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::map_entry)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] error: redundant closure found [INFO] [stderr] --> src/system/mod.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | |es| Ok(es), [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Ok` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:3:9 [INFO] [stderr] | [INFO] [stderr] 3 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::redundant_closure)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: redundant closure found [INFO] [stderr] --> src/system/mod.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | |es| Ok(es), [INFO] [stderr] | ^^^^^^^^^^^ help: remove closure as shown: `Ok` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: methods called `new` usually return `Self` [INFO] [stderr] --> src/world/mod.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn new() -> World { [INFO] [stderr] 28 | | World::from_container(VecEntityContainer::default()) [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:3:9 [INFO] [stderr] | [INFO] [stderr] 3 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::new_ret_no_self)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] error: you seem to want to iterate on a map's values [INFO] [stderr] --> src/world/mod.rs:88:26 [INFO] [stderr] | [INFO] [stderr] 88 | for (_, prio) in priorities { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:3:9 [INFO] [stderr] | [INFO] [stderr] 3 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::for_kv_map)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 88 | for prio in priorities.values() { [INFO] [stderr] | ^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `dces`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "bff852b8d4072b8eb930ff5032ee3d336d7717f565dfee96b30f6de9c05a7822"` [INFO] running `"docker" "rm" "-f" "bff852b8d4072b8eb930ff5032ee3d336d7717f565dfee96b30f6de9c05a7822"` [INFO] [stdout] bff852b8d4072b8eb930ff5032ee3d336d7717f565dfee96b30f6de9c05a7822