[INFO] crate dbus-serialize 0.1.2 is already in cache [INFO] extracting crate dbus-serialize 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/dbus-serialize/0.1.2 [INFO] extracting crate dbus-serialize 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dbus-serialize/0.1.2 [INFO] validating manifest of dbus-serialize-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dbus-serialize-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dbus-serialize-0.1.2 [INFO] finished frobbing dbus-serialize-0.1.2 [INFO] frobbed toml for dbus-serialize-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/dbus-serialize/0.1.2/Cargo.toml [INFO] started frobbing dbus-serialize-0.1.2 [INFO] finished frobbing dbus-serialize-0.1.2 [INFO] frobbed toml for dbus-serialize-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dbus-serialize/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dbus-serialize-0.1.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/dbus-serialize/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ecc55ebce5631bf528a4fd877584890b0b32e2f4ef4901ebc2ef2906c0249627 [INFO] running `"docker" "start" "-a" "ecc55ebce5631bf528a4fd877584890b0b32e2f4ef4901ebc2ef2906c0249627"` [INFO] [stderr] Checking dbus-serialize v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | objects: objects, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `objects` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | objects: objects, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `objects` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | map: map, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | map: map, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoder.rs:336:21 [INFO] [stderr] | [INFO] [stderr] 336 | foo: foo, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `foo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoder.rs:337:21 [INFO] [stderr] | [INFO] [stderr] 337 | bar: bar, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `bar` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoder.rs:338:21 [INFO] [stderr] | [INFO] [stderr] 338 | baz: baz [INFO] [stderr] | ^^^^^^^^ help: replace it with: `baz` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoder.rs:352:13 [INFO] [stderr] | [INFO] [stderr] 352 | objects: objects, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `objects` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | objects: objects, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `objects` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | objects: objects, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `objects` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | map: map, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | map: map, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoder.rs:336:21 [INFO] [stderr] | [INFO] [stderr] 336 | foo: foo, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `foo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoder.rs:337:21 [INFO] [stderr] | [INFO] [stderr] 337 | bar: bar, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `bar` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoder.rs:338:21 [INFO] [stderr] | [INFO] [stderr] 338 | baz: baz [INFO] [stderr] | ^^^^^^^^ help: replace it with: `baz` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoder.rs:352:13 [INFO] [stderr] | [INFO] [stderr] 352 | objects: objects, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `objects` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/decoder.rs:146:18 [INFO] [stderr] | [INFO] [stderr] 146 | _ => return Err(DecodeError::BadSignature) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(DecodeError::BadSignature)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/decoder.rs:146:18 [INFO] [stderr] | [INFO] [stderr] 146 | _ => return Err(DecodeError::BadSignature) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(DecodeError::BadSignature)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/types.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / match self { [INFO] [stderr] 31 | | &BasicValue::Byte(_) => "y", [INFO] [stderr] 32 | | &BasicValue::Boolean(_) => "b", [INFO] [stderr] 33 | | &BasicValue::Int16(_) => "n", [INFO] [stderr] ... | [INFO] [stderr] 41 | | &BasicValue::Signature(_) => "g", [INFO] [stderr] 42 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 30 | match *self { [INFO] [stderr] 31 | BasicValue::Byte(_) => "y", [INFO] [stderr] 32 | BasicValue::Boolean(_) => "b", [INFO] [stderr] 33 | BasicValue::Int16(_) => "n", [INFO] [stderr] 34 | BasicValue::Uint16(_) => "q", [INFO] [stderr] 35 | BasicValue::Int32(_) => "i", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/types.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | / match self { [INFO] [stderr] 158 | | &Value::BasicValue(ref x) => x.get_signature(), [INFO] [stderr] 159 | | &Value::Double(_) => "d", [INFO] [stderr] 160 | | &Value::Array(ref x) => &x.signature.0, [INFO] [stderr] ... | [INFO] [stderr] 163 | | &Value::Dictionary(ref x) => &x.signature.0 [INFO] [stderr] 164 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 157 | match *self { [INFO] [stderr] 158 | Value::BasicValue(ref x) => x.get_signature(), [INFO] [stderr] 159 | Value::Double(_) => "d", [INFO] [stderr] 160 | Value::Array(ref x) => &x.signature.0, [INFO] [stderr] 161 | Value::Variant(_) => "v", [INFO] [stderr] 162 | Value::Struct(ref x) => &x.signature.0, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/decoder.rs:22:19 [INFO] [stderr] | [INFO] [stderr] 22 | let val = match v { [INFO] [stderr] | ___________________^ [INFO] [stderr] 23 | | &BasicValue::Byte(x) => x as u64, [INFO] [stderr] 24 | | &BasicValue::Uint16(x) => x as u64, [INFO] [stderr] 25 | | &BasicValue::Uint32(x) => x as u64, [INFO] [stderr] 26 | | &BasicValue::Uint64(x) => x, [INFO] [stderr] 27 | | _ => return Err(DecodeError::BadSignature) [INFO] [stderr] 28 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 22 | let val = match *v { [INFO] [stderr] 23 | BasicValue::Byte(x) => x as u64, [INFO] [stderr] 24 | BasicValue::Uint16(x) => x as u64, [INFO] [stderr] 25 | BasicValue::Uint32(x) => x as u64, [INFO] [stderr] 26 | BasicValue::Uint64(x) => x, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:23:37 [INFO] [stderr] | [INFO] [stderr] 23 | &BasicValue::Byte(x) => x as u64, [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:24:39 [INFO] [stderr] | [INFO] [stderr] 24 | &BasicValue::Uint16(x) => x as u64, [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:25:39 [INFO] [stderr] | [INFO] [stderr] 25 | &BasicValue::Uint32(x) => x as u64, [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/decoder.rs:33:19 [INFO] [stderr] | [INFO] [stderr] 33 | let val = match v { [INFO] [stderr] | ___________________^ [INFO] [stderr] 34 | | &BasicValue::Int16(x) => x as i64, [INFO] [stderr] 35 | | &BasicValue::Int32(x) => x as i64, [INFO] [stderr] 36 | | &BasicValue::Int64(x) => x as i64, [INFO] [stderr] 37 | | _ => return Err(DecodeError::BadSignature) [INFO] [stderr] 38 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 33 | let val = match *v { [INFO] [stderr] 34 | BasicValue::Int16(x) => x as i64, [INFO] [stderr] 35 | BasicValue::Int32(x) => x as i64, [INFO] [stderr] 36 | BasicValue::Int64(x) => x as i64, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:34:38 [INFO] [stderr] | [INFO] [stderr] 34 | &BasicValue::Int16(x) => x as i64, [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:35:38 [INFO] [stderr] | [INFO] [stderr] 35 | &BasicValue::Int32(x) => x as i64, [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/decoder.rs:43:25 [INFO] [stderr] | [INFO] [stderr] 43 | let basic_val = match v { [INFO] [stderr] | _________________________^ [INFO] [stderr] 44 | | &Value::BasicValue(ref x) => x, [INFO] [stderr] 45 | | _ => return Err(DecodeError::BadSignature) [INFO] [stderr] 46 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 43 | let basic_val = match *v { [INFO] [stderr] 44 | Value::BasicValue(ref x) => x, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/decoder.rs:57:25 [INFO] [stderr] | [INFO] [stderr] 57 | let basic_val = match v { [INFO] [stderr] | _________________________^ [INFO] [stderr] 58 | | &Value::BasicValue(ref x) => x, [INFO] [stderr] 59 | | _ => return Err(DecodeError::BadSignature) [INFO] [stderr] 60 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 57 | let basic_val = match *v { [INFO] [stderr] 58 | Value::BasicValue(ref x) => x, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/decoder.rs:90:25 [INFO] [stderr] | [INFO] [stderr] 90 | let basic_val = match &self.value { [INFO] [stderr] | _________________________^ [INFO] [stderr] 91 | | &Value::BasicValue(ref x) => x, [INFO] [stderr] 92 | | _ => return Err(DecodeError::BadSignature) [INFO] [stderr] 93 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 90 | let basic_val = match self.value { [INFO] [stderr] 91 | Value::BasicValue(ref x) => x, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/decoder.rs:112:25 [INFO] [stderr] | [INFO] [stderr] 112 | let basic_val = match &self.value { [INFO] [stderr] | _________________________^ [INFO] [stderr] 113 | | &Value::BasicValue(ref x) => x, [INFO] [stderr] 114 | | _ => return Err(DecodeError::BadSignature) [INFO] [stderr] 115 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 112 | let basic_val = match self.value { [INFO] [stderr] 113 | Value::BasicValue(ref x) => x, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/decoder.rs:133:25 [INFO] [stderr] | [INFO] [stderr] 133 | let basic_val = match &self.value { [INFO] [stderr] | _________________________^ [INFO] [stderr] 134 | | &Value::BasicValue(ref x) => x, [INFO] [stderr] 135 | | _ => return Err(DecodeError::BadSignature) [INFO] [stderr] 136 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 133 | let basic_val = match self.value { [INFO] [stderr] 134 | Value::BasicValue(ref x) => x, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/decoder.rs:137:17 [INFO] [stderr] | [INFO] [stderr] 137 | let x = match basic_val { [INFO] [stderr] | _________________^ [INFO] [stderr] 138 | | &BasicValue::Boolean(x) => x, [INFO] [stderr] 139 | | _ => return Err(DecodeError::BadSignature) [INFO] [stderr] 140 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 137 | let x = match *basic_val { [INFO] [stderr] 138 | BasicValue::Boolean(x) => x, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/decoder.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | / match &self.value { [INFO] [stderr] 145 | | &Value::Double(x) => Ok(x), [INFO] [stderr] 146 | | _ => return Err(DecodeError::BadSignature) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 144 | match self.value { [INFO] [stderr] 145 | Value::Double(x) => Ok(x), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/decoder.rs:154:25 [INFO] [stderr] | [INFO] [stderr] 154 | let basic_val = match &self.value { [INFO] [stderr] | _________________________^ [INFO] [stderr] 155 | | &Value::BasicValue(ref x) => x, [INFO] [stderr] 156 | | _ => return Err(DecodeError::BadSignature) [INFO] [stderr] 157 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 154 | let basic_val = match self.value { [INFO] [stderr] 155 | Value::BasicValue(ref x) => x, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/decoder.rs:158:17 [INFO] [stderr] | [INFO] [stderr] 158 | let x = match basic_val { [INFO] [stderr] | _________________^ [INFO] [stderr] 159 | | &BasicValue::String(ref x) => x.to_string(), [INFO] [stderr] 160 | | &BasicValue::ObjectPath(ref x) => x.0.to_string(), [INFO] [stderr] 161 | | &BasicValue::Signature(ref x) => x.0.to_string(), [INFO] [stderr] 162 | | _ => return Err(DecodeError::BadSignature) [INFO] [stderr] 163 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 158 | let x = match *basic_val { [INFO] [stderr] 159 | BasicValue::String(ref x) => x.to_string(), [INFO] [stderr] 160 | BasicValue::ObjectPath(ref x) => x.0.to_string(), [INFO] [stderr] 161 | BasicValue::Signature(ref x) => x.0.to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `encoder::DBusEncoder` [INFO] [stderr] --> src/encoder.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | / pub fn new() -> DBusEncoder { [INFO] [stderr] 49 | | DBusEncoder { [INFO] [stderr] 50 | | val: Vec::new(), [INFO] [stderr] 51 | | key: None [INFO] [stderr] 52 | | } [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/encoder.rs:122:37 [INFO] [stderr] | [INFO] [stderr] 122 | self.val.push(Value::Double(v as f64)); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/types.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / match self { [INFO] [stderr] 31 | | &BasicValue::Byte(_) => "y", [INFO] [stderr] 32 | | &BasicValue::Boolean(_) => "b", [INFO] [stderr] 33 | | &BasicValue::Int16(_) => "n", [INFO] [stderr] ... | [INFO] [stderr] 41 | | &BasicValue::Signature(_) => "g", [INFO] [stderr] 42 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 30 | match *self { [INFO] [stderr] 31 | BasicValue::Byte(_) => "y", [INFO] [stderr] 32 | BasicValue::Boolean(_) => "b", [INFO] [stderr] 33 | BasicValue::Int16(_) => "n", [INFO] [stderr] 34 | BasicValue::Uint16(_) => "q", [INFO] [stderr] 35 | BasicValue::Int32(_) => "i", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/types.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | / match self { [INFO] [stderr] 158 | | &Value::BasicValue(ref x) => x.get_signature(), [INFO] [stderr] 159 | | &Value::Double(_) => "d", [INFO] [stderr] 160 | | &Value::Array(ref x) => &x.signature.0, [INFO] [stderr] ... | [INFO] [stderr] 163 | | &Value::Dictionary(ref x) => &x.signature.0 [INFO] [stderr] 164 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 157 | match *self { [INFO] [stderr] 158 | Value::BasicValue(ref x) => x.get_signature(), [INFO] [stderr] 159 | Value::Double(_) => "d", [INFO] [stderr] 160 | Value::Array(ref x) => &x.signature.0, [INFO] [stderr] 161 | Value::Variant(_) => "v", [INFO] [stderr] 162 | Value::Struct(ref x) => &x.signature.0, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/decoder.rs:22:19 [INFO] [stderr] | [INFO] [stderr] 22 | let val = match v { [INFO] [stderr] | ___________________^ [INFO] [stderr] 23 | | &BasicValue::Byte(x) => x as u64, [INFO] [stderr] 24 | | &BasicValue::Uint16(x) => x as u64, [INFO] [stderr] 25 | | &BasicValue::Uint32(x) => x as u64, [INFO] [stderr] 26 | | &BasicValue::Uint64(x) => x, [INFO] [stderr] 27 | | _ => return Err(DecodeError::BadSignature) [INFO] [stderr] 28 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 22 | let val = match *v { [INFO] [stderr] 23 | BasicValue::Byte(x) => x as u64, [INFO] [stderr] 24 | BasicValue::Uint16(x) => x as u64, [INFO] [stderr] 25 | BasicValue::Uint32(x) => x as u64, [INFO] [stderr] 26 | BasicValue::Uint64(x) => x, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:23:37 [INFO] [stderr] | [INFO] [stderr] 23 | &BasicValue::Byte(x) => x as u64, [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:24:39 [INFO] [stderr] | [INFO] [stderr] 24 | &BasicValue::Uint16(x) => x as u64, [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:25:39 [INFO] [stderr] | [INFO] [stderr] 25 | &BasicValue::Uint32(x) => x as u64, [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/decoder.rs:33:19 [INFO] [stderr] | [INFO] [stderr] 33 | let val = match v { [INFO] [stderr] | ___________________^ [INFO] [stderr] 34 | | &BasicValue::Int16(x) => x as i64, [INFO] [stderr] 35 | | &BasicValue::Int32(x) => x as i64, [INFO] [stderr] 36 | | &BasicValue::Int64(x) => x as i64, [INFO] [stderr] 37 | | _ => return Err(DecodeError::BadSignature) [INFO] [stderr] 38 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 33 | let val = match *v { [INFO] [stderr] 34 | BasicValue::Int16(x) => x as i64, [INFO] [stderr] 35 | BasicValue::Int32(x) => x as i64, [INFO] [stderr] 36 | BasicValue::Int64(x) => x as i64, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:34:38 [INFO] [stderr] | [INFO] [stderr] 34 | &BasicValue::Int16(x) => x as i64, [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/decoder.rs:35:38 [INFO] [stderr] | [INFO] [stderr] 35 | &BasicValue::Int32(x) => x as i64, [INFO] [stderr] | ^^^^^^^^ help: try: `i64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/decoder.rs:43:25 [INFO] [stderr] | [INFO] [stderr] 43 | let basic_val = match v { [INFO] [stderr] | _________________________^ [INFO] [stderr] 44 | | &Value::BasicValue(ref x) => x, [INFO] [stderr] 45 | | _ => return Err(DecodeError::BadSignature) [INFO] [stderr] 46 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 43 | let basic_val = match *v { [INFO] [stderr] 44 | Value::BasicValue(ref x) => x, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/decoder.rs:57:25 [INFO] [stderr] | [INFO] [stderr] 57 | let basic_val = match v { [INFO] [stderr] | _________________________^ [INFO] [stderr] 58 | | &Value::BasicValue(ref x) => x, [INFO] [stderr] 59 | | _ => return Err(DecodeError::BadSignature) [INFO] [stderr] 60 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 57 | let basic_val = match *v { [INFO] [stderr] 58 | Value::BasicValue(ref x) => x, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/decoder.rs:90:25 [INFO] [stderr] | [INFO] [stderr] 90 | let basic_val = match &self.value { [INFO] [stderr] | _________________________^ [INFO] [stderr] 91 | | &Value::BasicValue(ref x) => x, [INFO] [stderr] 92 | | _ => return Err(DecodeError::BadSignature) [INFO] [stderr] 93 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 90 | let basic_val = match self.value { [INFO] [stderr] 91 | Value::BasicValue(ref x) => x, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/decoder.rs:112:25 [INFO] [stderr] | [INFO] [stderr] 112 | let basic_val = match &self.value { [INFO] [stderr] | _________________________^ [INFO] [stderr] 113 | | &Value::BasicValue(ref x) => x, [INFO] [stderr] 114 | | _ => return Err(DecodeError::BadSignature) [INFO] [stderr] 115 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 112 | let basic_val = match self.value { [INFO] [stderr] 113 | Value::BasicValue(ref x) => x, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/decoder.rs:133:25 [INFO] [stderr] | [INFO] [stderr] 133 | let basic_val = match &self.value { [INFO] [stderr] | _________________________^ [INFO] [stderr] 134 | | &Value::BasicValue(ref x) => x, [INFO] [stderr] 135 | | _ => return Err(DecodeError::BadSignature) [INFO] [stderr] 136 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 133 | let basic_val = match self.value { [INFO] [stderr] 134 | Value::BasicValue(ref x) => x, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/decoder.rs:137:17 [INFO] [stderr] | [INFO] [stderr] 137 | let x = match basic_val { [INFO] [stderr] | _________________^ [INFO] [stderr] 138 | | &BasicValue::Boolean(x) => x, [INFO] [stderr] 139 | | _ => return Err(DecodeError::BadSignature) [INFO] [stderr] 140 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 137 | let x = match *basic_val { [INFO] [stderr] 138 | BasicValue::Boolean(x) => x, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/decoder.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | / match &self.value { [INFO] [stderr] 145 | | &Value::Double(x) => Ok(x), [INFO] [stderr] 146 | | _ => return Err(DecodeError::BadSignature) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 144 | match self.value { [INFO] [stderr] 145 | Value::Double(x) => Ok(x), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/decoder.rs:154:25 [INFO] [stderr] | [INFO] [stderr] 154 | let basic_val = match &self.value { [INFO] [stderr] | _________________________^ [INFO] [stderr] 155 | | &Value::BasicValue(ref x) => x, [INFO] [stderr] 156 | | _ => return Err(DecodeError::BadSignature) [INFO] [stderr] 157 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 154 | let basic_val = match self.value { [INFO] [stderr] 155 | Value::BasicValue(ref x) => x, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/decoder.rs:158:17 [INFO] [stderr] | [INFO] [stderr] 158 | let x = match basic_val { [INFO] [stderr] | _________________^ [INFO] [stderr] 159 | | &BasicValue::String(ref x) => x.to_string(), [INFO] [stderr] 160 | | &BasicValue::ObjectPath(ref x) => x.0.to_string(), [INFO] [stderr] 161 | | &BasicValue::Signature(ref x) => x.0.to_string(), [INFO] [stderr] 162 | | _ => return Err(DecodeError::BadSignature) [INFO] [stderr] 163 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 158 | let x = match *basic_val { [INFO] [stderr] 159 | BasicValue::String(ref x) => x.to_string(), [INFO] [stderr] 160 | BasicValue::ObjectPath(ref x) => x.0.to_string(), [INFO] [stderr] 161 | BasicValue::Signature(ref x) => x.0.to_string(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/decoder.rs:326:21 [INFO] [stderr] | [INFO] [stderr] 326 | let foo = try!(s.read_struct_field("foo", 0, |s: &mut S| { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/decoder.rs:329:21 [INFO] [stderr] | [INFO] [stderr] 329 | let bar = try!(s.read_struct_field("bar", 1, |s: &mut S| { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `baz` [INFO] [stderr] --> src/decoder.rs:332:21 [INFO] [stderr] | [INFO] [stderr] 332 | let baz = try!(s.read_struct_field("baz", 2, |s: &mut S| { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `encoder::DBusEncoder` [INFO] [stderr] --> src/encoder.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | / pub fn new() -> DBusEncoder { [INFO] [stderr] 49 | | DBusEncoder { [INFO] [stderr] 50 | | val: Vec::new(), [INFO] [stderr] 51 | | key: None [INFO] [stderr] 52 | | } [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/encoder.rs:122:37 [INFO] [stderr] | [INFO] [stderr] 122 | self.val.push(Value::Double(v as f64)); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.21s [INFO] running `"docker" "inspect" "ecc55ebce5631bf528a4fd877584890b0b32e2f4ef4901ebc2ef2906c0249627"` [INFO] running `"docker" "rm" "-f" "ecc55ebce5631bf528a4fd877584890b0b32e2f4ef4901ebc2ef2906c0249627"` [INFO] [stdout] ecc55ebce5631bf528a4fd877584890b0b32e2f4ef4901ebc2ef2906c0249627