[INFO] crate data_tracker 0.1.0 is already in cache [INFO] extracting crate data_tracker 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/data_tracker/0.1.0 [INFO] extracting crate data_tracker 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/data_tracker/0.1.0 [INFO] validating manifest of data_tracker-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of data_tracker-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing data_tracker-0.1.0 [INFO] finished frobbing data_tracker-0.1.0 [INFO] frobbed toml for data_tracker-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/data_tracker/0.1.0/Cargo.toml [INFO] started frobbing data_tracker-0.1.0 [INFO] finished frobbing data_tracker-0.1.0 [INFO] frobbed toml for data_tracker-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/data_tracker/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting data_tracker-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/data_tracker/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5e6b320603f3334beafb013ca78f003db14a4210f1fde58ad4d23fae85ca83c8 [INFO] running `"docker" "start" "-a" "5e6b320603f3334beafb013ca78f003db14a4210f1fde58ad4d23fae85ca83c8"` [INFO] [stderr] Checking data_tracker v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:155:13 [INFO] [stderr] | [INFO] [stderr] 155 | orig_copy: orig_copy, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `orig_copy` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:217:17 [INFO] [stderr] | [INFO] [stderr] 217 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:155:13 [INFO] [stderr] | [INFO] [stderr] 155 | orig_copy: orig_copy, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `orig_copy` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:217:17 [INFO] [stderr] | [INFO] [stderr] 217 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib.rs:95:56 [INFO] [stderr] | [INFO] [stderr] 95 | fn on_changed(&self, old_value: &T, new_value: &T) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lib.rs:95:56 [INFO] [stderr] | [INFO] [stderr] 95 | fn on_changed(&self, old_value: &T, new_value: &T) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:276:43 [INFO] [stderr] | [INFO] [stderr] 276 | let ref mut data = *cc2.lock().unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^------------------------ help: try: `let data = &mut (*cc2.lock().unwrap());` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:277:39 [INFO] [stderr] | [INFO] [stderr] 277 | *data = *data + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `*data += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:321:43 [INFO] [stderr] | [INFO] [stderr] 321 | let ref mut data = *cc2.lock().unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^------------------------ help: try: `let data = &mut (*cc2.lock().unwrap());` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:322:39 [INFO] [stderr] | [INFO] [stderr] 322 | *data = *data + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `*data += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/lib.rs:355:32 [INFO] [stderr] | [INFO] [stderr] 355 | let did_run = Arc::new(Mutex::new(false)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:362:43 [INFO] [stderr] | [INFO] [stderr] 362 | let ref mut data = *did_run_clone.lock().unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^---------------------------------- help: try: `let data = &mut (*did_run_clone.lock().unwrap());` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/lib.rs:370:17 [INFO] [stderr] | [INFO] [stderr] 370 | assert!(*did_run.lock().unwrap() == true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `*did_run.lock().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.85s [INFO] running `"docker" "inspect" "5e6b320603f3334beafb013ca78f003db14a4210f1fde58ad4d23fae85ca83c8"` [INFO] running `"docker" "rm" "-f" "5e6b320603f3334beafb013ca78f003db14a4210f1fde58ad4d23fae85ca83c8"` [INFO] [stdout] 5e6b320603f3334beafb013ca78f003db14a4210f1fde58ad4d23fae85ca83c8