[INFO] crate data-encoding-bin 0.2.1 is already in cache [INFO] extracting crate data-encoding-bin 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/data-encoding-bin/0.2.1 [INFO] extracting crate data-encoding-bin 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/data-encoding-bin/0.2.1 [INFO] validating manifest of data-encoding-bin-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of data-encoding-bin-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing data-encoding-bin-0.2.1 [INFO] finished frobbing data-encoding-bin-0.2.1 [INFO] frobbed toml for data-encoding-bin-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/data-encoding-bin/0.2.1/Cargo.toml [INFO] started frobbing data-encoding-bin-0.2.1 [INFO] finished frobbing data-encoding-bin-0.2.1 [INFO] frobbed toml for data-encoding-bin-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/data-encoding-bin/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting data-encoding-bin-0.2.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/data-encoding-bin/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3519815292d82ee773f487f152aa26724a3ea19fdf649792d2c5d9f5c5b7b403 [INFO] running `"docker" "start" "-a" "3519815292d82ee773f487f152aa26724a3ea19fdf649792d2c5d9f5c5b7b403"` [INFO] [stderr] Checking data-encoding-bin v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | / match self { [INFO] [stderr] 29 | | &ParseOpts(ref e) => e.fmt(f), [INFO] [stderr] 30 | | &ExtraArgs(ref a) => write!(f, "Unexpected arguments {:?}", a), [INFO] [stderr] 31 | | &Cmdline(ref m) => write!(f, "{}", m), [INFO] [stderr] ... | [INFO] [stderr] 36 | | &Write(ref e) => write!(f, "Write error: {}", e), [INFO] [stderr] 37 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 28 | match *self { [INFO] [stderr] 29 | ParseOpts(ref e) => e.fmt(f), [INFO] [stderr] 30 | ExtraArgs(ref a) => write!(f, "Unexpected arguments {:?}", a), [INFO] [stderr] 31 | Cmdline(ref m) => write!(f, "{}", m), [INFO] [stderr] 32 | Decode(ref e) => e.fmt(f), [INFO] [stderr] 33 | Builder(ref e) => e.fmt(f), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | / match self { [INFO] [stderr] 45 | | &ParseOpts(ref e) => e.description(), [INFO] [stderr] 46 | | &ExtraArgs(_) => "unexpected argument", [INFO] [stderr] 47 | | &Cmdline(_) => "invalid command-line", [INFO] [stderr] ... | [INFO] [stderr] 52 | | &Write(ref e) => e.description(), [INFO] [stderr] 53 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 44 | match *self { [INFO] [stderr] 45 | ParseOpts(ref e) => e.description(), [INFO] [stderr] 46 | ExtraArgs(_) => "unexpected argument", [INFO] [stderr] 47 | Cmdline(_) => "invalid command-line", [INFO] [stderr] 48 | Decode(ref e) => e.description(), [INFO] [stderr] 49 | Builder(ref e) => e.description(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:221:56 [INFO] [stderr] | [INFO] [stderr] 221 | spec.symbols = matches.opt_str("symbols") .ok_or(Error::Cmdline( [INFO] [stderr] | ________________________________________________________^ [INFO] [stderr] 222 | | "Base or symbols must be provided".into()))?; [INFO] [stderr] | |___________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 221 | spec.symbols = matches.opt_str("symbols") .ok_or_else(|| Error::Cmdline( [INFO] [stderr] 222 | "Base or symbols must be provided".into()))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:301:41 [INFO] [stderr] | [INFO] [stderr] 301 | let size = matches.opt_str("block").unwrap_or("15360".to_owned()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "15360".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | / match self { [INFO] [stderr] 29 | | &ParseOpts(ref e) => e.fmt(f), [INFO] [stderr] 30 | | &ExtraArgs(ref a) => write!(f, "Unexpected arguments {:?}", a), [INFO] [stderr] 31 | | &Cmdline(ref m) => write!(f, "{}", m), [INFO] [stderr] ... | [INFO] [stderr] 36 | | &Write(ref e) => write!(f, "Write error: {}", e), [INFO] [stderr] 37 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 28 | match *self { [INFO] [stderr] 29 | ParseOpts(ref e) => e.fmt(f), [INFO] [stderr] 30 | ExtraArgs(ref a) => write!(f, "Unexpected arguments {:?}", a), [INFO] [stderr] 31 | Cmdline(ref m) => write!(f, "{}", m), [INFO] [stderr] 32 | Decode(ref e) => e.fmt(f), [INFO] [stderr] 33 | Builder(ref e) => e.fmt(f), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | / match self { [INFO] [stderr] 45 | | &ParseOpts(ref e) => e.description(), [INFO] [stderr] 46 | | &ExtraArgs(_) => "unexpected argument", [INFO] [stderr] 47 | | &Cmdline(_) => "invalid command-line", [INFO] [stderr] ... | [INFO] [stderr] 52 | | &Write(ref e) => e.description(), [INFO] [stderr] 53 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 44 | match *self { [INFO] [stderr] 45 | ParseOpts(ref e) => e.description(), [INFO] [stderr] 46 | ExtraArgs(_) => "unexpected argument", [INFO] [stderr] 47 | Cmdline(_) => "invalid command-line", [INFO] [stderr] 48 | Decode(ref e) => e.description(), [INFO] [stderr] 49 | Builder(ref e) => e.description(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:221:56 [INFO] [stderr] | [INFO] [stderr] 221 | spec.symbols = matches.opt_str("symbols") .ok_or(Error::Cmdline( [INFO] [stderr] | ________________________________________________________^ [INFO] [stderr] 222 | | "Base or symbols must be provided".into()))?; [INFO] [stderr] | |___________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 221 | spec.symbols = matches.opt_str("symbols") .ok_or_else(|| Error::Cmdline( [INFO] [stderr] 222 | "Base or symbols must be provided".into()))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:301:41 [INFO] [stderr] | [INFO] [stderr] 301 | let size = matches.opt_str("block").unwrap_or("15360".to_owned()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "15360".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.59s [INFO] running `"docker" "inspect" "3519815292d82ee773f487f152aa26724a3ea19fdf649792d2c5d9f5c5b7b403"` [INFO] running `"docker" "rm" "-f" "3519815292d82ee773f487f152aa26724a3ea19fdf649792d2c5d9f5c5b7b403"` [INFO] [stdout] 3519815292d82ee773f487f152aa26724a3ea19fdf649792d2c5d9f5c5b7b403