[INFO] crate crossbeam-utils 0.6.2 is already in cache [INFO] extracting crate crossbeam-utils 0.6.2 into work/ex/clippy-test-run/sources/stable/reg/crossbeam-utils/0.6.2 [INFO] extracting crate crossbeam-utils 0.6.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/crossbeam-utils/0.6.2 [INFO] validating manifest of crossbeam-utils-0.6.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of crossbeam-utils-0.6.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing crossbeam-utils-0.6.2 [INFO] finished frobbing crossbeam-utils-0.6.2 [INFO] frobbed toml for crossbeam-utils-0.6.2 written to work/ex/clippy-test-run/sources/stable/reg/crossbeam-utils/0.6.2/Cargo.toml [INFO] started frobbing crossbeam-utils-0.6.2 [INFO] finished frobbing crossbeam-utils-0.6.2 [INFO] frobbed toml for crossbeam-utils-0.6.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/crossbeam-utils/0.6.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting crossbeam-utils-0.6.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/crossbeam-utils/0.6.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 02f3280b1ecdcebe0acb7ec39157daea84452c2d956515a16a2ea79771db447b [INFO] running `"docker" "start" "-a" "02f3280b1ecdcebe0acb7ec39157daea84452c2d956515a16a2ea79771db447b"` [INFO] [stderr] Checking crossbeam-utils v0.6.2 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/thread.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | panics [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/thread.rs:136:22 [INFO] [stderr] | [INFO] [stderr] 136 | let panics = handles [INFO] [stderr] | ______________________^ [INFO] [stderr] 137 | | .drain(..) [INFO] [stderr] 138 | | .filter_map(|handle| handle.lock().unwrap().take()) [INFO] [stderr] 139 | | .filter_map(|handle| handle.join().err()) [INFO] [stderr] 140 | | .collect(); [INFO] [stderr] | |______________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/thread.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | panics [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/thread.rs:136:22 [INFO] [stderr] | [INFO] [stderr] 136 | let panics = handles [INFO] [stderr] | ______________________^ [INFO] [stderr] 137 | | .drain(..) [INFO] [stderr] 138 | | .filter_map(|handle| handle.lock().unwrap().take()) [INFO] [stderr] 139 | | .filter_map(|handle| handle.join().err()) [INFO] [stderr] 140 | | .collect(); [INFO] [stderr] | |______________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `sync::parker::Parker` [INFO] [stderr] --> src/sync/parker.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | / pub fn new() -> Parker { [INFO] [stderr] 73 | | Parker { [INFO] [stderr] 74 | | unparker: Unparker { [INFO] [stderr] 75 | | inner: Arc::new(Inner { [INFO] [stderr] ... | [INFO] [stderr] 82 | | } [INFO] [stderr] 83 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 61 | impl Default for sync::parker::Parker { [INFO] [stderr] 62 | fn default() -> Self { [INFO] [stderr] 63 | Self::new() [INFO] [stderr] 64 | } [INFO] [stderr] 65 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/sync/parker.rs:267:21 [INFO] [stderr] | [INFO] [stderr] 267 | / match self.state.compare_exchange(NOTIFIED, EMPTY, SeqCst, SeqCst) { [INFO] [stderr] 268 | | Ok(_) => return, // got a notification [INFO] [stderr] 269 | | Err(_) => {} // spurious wakeup, go back to sleep [INFO] [stderr] 270 | | } [INFO] [stderr] | |_____________________^ help: try this: `if let Ok(_) = self.state.compare_exchange(NOTIFIED, EMPTY, SeqCst, SeqCst) { return }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `sync::parker::Parker` [INFO] [stderr] --> src/sync/parker.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | / pub fn new() -> Parker { [INFO] [stderr] 73 | | Parker { [INFO] [stderr] 74 | | unparker: Unparker { [INFO] [stderr] 75 | | inner: Arc::new(Inner { [INFO] [stderr] ... | [INFO] [stderr] 82 | | } [INFO] [stderr] 83 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 61 | impl Default for sync::parker::Parker { [INFO] [stderr] 62 | fn default() -> Self { [INFO] [stderr] 63 | Self::new() [INFO] [stderr] 64 | } [INFO] [stderr] 65 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/sync/parker.rs:267:21 [INFO] [stderr] | [INFO] [stderr] 267 | / match self.state.compare_exchange(NOTIFIED, EMPTY, SeqCst, SeqCst) { [INFO] [stderr] 268 | | Ok(_) => return, // got a notification [INFO] [stderr] 269 | | Err(_) => {} // spurious wakeup, go back to sleep [INFO] [stderr] 270 | | } [INFO] [stderr] | |_____________________^ help: try this: `if let Ok(_) = self.state.compare_exchange(NOTIFIED, EMPTY, SeqCst, SeqCst) { return }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/thread.rs:274:36 [INFO] [stderr] | [INFO] [stderr] 274 | self.builder.spawn(move || closure())? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `closure` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/thread.rs:274:36 [INFO] [stderr] | [INFO] [stderr] 274 | self.builder.spawn(move || closure())? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `closure` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error[E0432]: unresolved import `crossbeam_utils::atomic::AtomicCell` [INFO] [stderr] --> benches/atomic_cell.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use crossbeam_utils::atomic::AtomicCell; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `AtomicCell` in `atomic` [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/atomic_cell.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] Some errors occurred: E0432, E0554. [INFO] [stderr] For more information about an error, try `rustc --explain E0432`. [INFO] [stderr] error: Could not compile `crossbeam-utils`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> tests/parker.rs:15:46 [INFO] [stderr] | [INFO] [stderr] 15 | p.park_timeout(Duration::from_millis(u32::MAX as u64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(u32::MAX)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> tests/parker.rs:39:50 [INFO] [stderr] | [INFO] [stderr] 39 | p.park_timeout(Duration::from_millis(u32::MAX as u64)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(u32::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> tests/cache_padded.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | let b = a.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `a` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "02f3280b1ecdcebe0acb7ec39157daea84452c2d956515a16a2ea79771db447b"` [INFO] running `"docker" "rm" "-f" "02f3280b1ecdcebe0acb7ec39157daea84452c2d956515a16a2ea79771db447b"` [INFO] [stdout] 02f3280b1ecdcebe0acb7ec39157daea84452c2d956515a16a2ea79771db447b