[INFO] crate cranelift-entity 0.25.0 is already in cache [INFO] extracting crate cranelift-entity 0.25.0 into work/ex/clippy-test-run/sources/stable/reg/cranelift-entity/0.25.0 [INFO] extracting crate cranelift-entity 0.25.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cranelift-entity/0.25.0 [INFO] validating manifest of cranelift-entity-0.25.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cranelift-entity-0.25.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cranelift-entity-0.25.0 [INFO] finished frobbing cranelift-entity-0.25.0 [INFO] frobbed toml for cranelift-entity-0.25.0 written to work/ex/clippy-test-run/sources/stable/reg/cranelift-entity/0.25.0/Cargo.toml [INFO] started frobbing cranelift-entity-0.25.0 [INFO] finished frobbing cranelift-entity-0.25.0 [INFO] frobbed toml for cranelift-entity-0.25.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cranelift-entity/0.25.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cranelift-entity-0.25.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cranelift-entity/0.25.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f818a2f55348ed33f998794faa03b01641cfe0408626b61be2c0cb63f7d9904c [INFO] running `"docker" "start" "-a" "f818a2f55348ed33f998794faa03b01641cfe0408626b61be2c0cb63f7d9904c"` [INFO] [stderr] Checking cranelift-entity v0.25.0 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `new_without_default` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:41:11 [INFO] [stderr] | [INFO] [stderr] 41 | allow(new_without_default, new_without_default_derive) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::new_without_default` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `new_without_default_derive` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:41:32 [INFO] [stderr] | [INFO] [stderr] 41 | allow(new_without_default, new_without_default_derive) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::new_without_default_derive` [INFO] [stderr] [INFO] [stderr] warning: lint name `float_arithmetic` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | float_arithmetic, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change it to: `clippy::float_arithmetic` [INFO] [stderr] [INFO] [stderr] warning: lint name `mut_mut` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | mut_mut, [INFO] [stderr] | ^^^^^^^ help: change it to: `clippy::mut_mut` [INFO] [stderr] [INFO] [stderr] warning: lint name `nonminimal_bool` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | nonminimal_bool, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::nonminimal_bool` [INFO] [stderr] [INFO] [stderr] warning: lint name `option_map_unwrap_or` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | option_map_unwrap_or, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::option_map_unwrap_or` [INFO] [stderr] [INFO] [stderr] warning: lint name `option_map_unwrap_or_else` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | option_map_unwrap_or_else, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::option_map_unwrap_or_else` [INFO] [stderr] [INFO] [stderr] warning: lint name `print_stdout` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | print_stdout, [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::print_stdout` [INFO] [stderr] [INFO] [stderr] warning: lint name `unicode_not_nfc` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | unicode_not_nfc, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::unicode_not_nfc` [INFO] [stderr] [INFO] [stderr] warning: lint name `use_self` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | use_self [INFO] [stderr] | ^^^^^^^^ help: change it to: `clippy::use_self` [INFO] [stderr] [INFO] [stderr] warning: lint name `new_without_default` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:41:11 [INFO] [stderr] | [INFO] [stderr] 41 | allow(new_without_default, new_without_default_derive) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::new_without_default` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `new_without_default_derive` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:41:32 [INFO] [stderr] | [INFO] [stderr] 41 | allow(new_without_default, new_without_default_derive) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::new_without_default_derive` [INFO] [stderr] [INFO] [stderr] warning: lint name `float_arithmetic` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | float_arithmetic, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change it to: `clippy::float_arithmetic` [INFO] [stderr] [INFO] [stderr] warning: lint name `mut_mut` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | mut_mut, [INFO] [stderr] | ^^^^^^^ help: change it to: `clippy::mut_mut` [INFO] [stderr] [INFO] [stderr] warning: lint name `nonminimal_bool` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | nonminimal_bool, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::nonminimal_bool` [INFO] [stderr] [INFO] [stderr] warning: lint name `option_map_unwrap_or` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | option_map_unwrap_or, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::option_map_unwrap_or` [INFO] [stderr] [INFO] [stderr] warning: lint name `option_map_unwrap_or_else` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | option_map_unwrap_or_else, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::option_map_unwrap_or_else` [INFO] [stderr] [INFO] [stderr] warning: lint name `print_stdout` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | print_stdout, [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::print_stdout` [INFO] [stderr] [INFO] [stderr] warning: lint name `unicode_not_nfc` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | unicode_not_nfc, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::unicode_not_nfc` [INFO] [stderr] [INFO] [stderr] warning: lint name `use_self` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | use_self [INFO] [stderr] | ^^^^^^^^ help: change it to: `clippy::use_self` [INFO] [stderr] [INFO] [stderr] warning: lint name `new_without_default` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:41:11 [INFO] [stderr] | [INFO] [stderr] 41 | allow(new_without_default, new_without_default_derive) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::new_without_default` [INFO] [stderr] [INFO] [stderr] warning: lint name `new_without_default` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:41:11 [INFO] [stderr] | [INFO] [stderr] 41 | allow(new_without_default, new_without_default_derive) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::new_without_default` [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/list.rs:505:21 [INFO] [stderr] | [INFO] [stderr] 505 | assert!(sclass_size(sclass_for_length(l)) >= l + 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::int_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 505 | assert!(sclass_size(sclass_for_length(l)) > l); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 37 [INFO] [stderr] --> src/list.rs:578:5 [INFO] [stderr] | [INFO] [stderr] 578 | / fn push() { [INFO] [stderr] 579 | | let pool = &mut ListPool::::new(); [INFO] [stderr] 580 | | let mut list = EntityList::::default(); [INFO] [stderr] 581 | | [INFO] [stderr] ... | [INFO] [stderr] 631 | | ); [INFO] [stderr] 632 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in m.keys().enumerate()` or similar iterators [INFO] [stderr] --> src/primary.rs:279:20 [INFO] [stderr] | [INFO] [stderr] 279 | for key in m.keys() { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 30 [INFO] [stderr] --> src/sparse.rs:295:5 [INFO] [stderr] | [INFO] [stderr] 295 | / fn multiple_entries() { [INFO] [stderr] 296 | | let i0 = Inst::new(0); [INFO] [stderr] 297 | | let i1 = Inst::new(1); [INFO] [stderr] 298 | | let i2 = Inst::new(2); [INFO] [stderr] ... | [INFO] [stderr] 347 | | assert_eq!(v.len(), map.len()); [INFO] [stderr] 348 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.56s [INFO] running `"docker" "inspect" "f818a2f55348ed33f998794faa03b01641cfe0408626b61be2c0cb63f7d9904c"` [INFO] running `"docker" "rm" "-f" "f818a2f55348ed33f998794faa03b01641cfe0408626b61be2c0cb63f7d9904c"` [INFO] [stdout] f818a2f55348ed33f998794faa03b01641cfe0408626b61be2c0cb63f7d9904c