[INFO] crate coord_2d 0.2.0 is already in cache [INFO] extracting crate coord_2d 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/coord_2d/0.2.0 [INFO] extracting crate coord_2d 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/coord_2d/0.2.0 [INFO] validating manifest of coord_2d-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of coord_2d-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing coord_2d-0.2.0 [INFO] finished frobbing coord_2d-0.2.0 [INFO] frobbed toml for coord_2d-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/coord_2d/0.2.0/Cargo.toml [INFO] started frobbing coord_2d-0.2.0 [INFO] finished frobbing coord_2d-0.2.0 [INFO] frobbed toml for coord_2d-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/coord_2d/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting coord_2d-0.2.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/coord_2d/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 98c6eb0783211847bbd5219d5605f29c5812c8489b80b752c95ea77f482cbda5 [INFO] running `"docker" "start" "-a" "98c6eb0783211847bbd5219d5605f29c5812c8489b80b752c95ea77f482cbda5"` [INFO] [stderr] Checking coord_2d v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/coord_arithmetic.rs:430:17 [INFO] [stderr] | [INFO] [stderr] 430 | let _ = &a + Coord::new(0, 0); [INFO] [stderr] | --^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `a` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/coord_arithmetic.rs:431:17 [INFO] [stderr] | [INFO] [stderr] 431 | let _ = a + &Coord::new(0, 0); [INFO] [stderr] | ^^^^----------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `Coord::new(0, 0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/coord_arithmetic.rs:432:17 [INFO] [stderr] | [INFO] [stderr] 432 | let _ = &a + &Coord::new(0, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 432 | let _ = a + Coord::new(0, 0); [INFO] [stderr] | ^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/coord_arithmetic.rs:434:17 [INFO] [stderr] | [INFO] [stderr] 434 | let _ = &a + Size::new(0, 0); [INFO] [stderr] | --^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/coord_arithmetic.rs:435:17 [INFO] [stderr] | [INFO] [stderr] 435 | let _ = a + &Size::new(0, 0); [INFO] [stderr] | ^^^^---------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `Size::new(0, 0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/coord_arithmetic.rs:436:17 [INFO] [stderr] | [INFO] [stderr] 436 | let _ = &a + &Size::new(0, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 436 | let _ = a + Size::new(0, 0); [INFO] [stderr] | ^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/coord_arithmetic.rs:438:17 [INFO] [stderr] | [INFO] [stderr] 438 | let _ = &Size::new(0, 0) + a; [INFO] [stderr] | ----------------^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `Size::new(0, 0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/coord_arithmetic.rs:439:17 [INFO] [stderr] | [INFO] [stderr] 439 | let _ = Size::new(0, 0) + &a; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/coord_arithmetic.rs:440:17 [INFO] [stderr] | [INFO] [stderr] 440 | let _ = &Size::new(0, 0) + &a; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 440 | let _ = Size::new(0, 0) + a; [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^ [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/coord_arithmetic.rs:441:9 [INFO] [stderr] | [INFO] [stderr] 441 | let _ = a += Size::new(0, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/coord_arithmetic.rs:442:9 [INFO] [stderr] | [INFO] [stderr] 442 | let _ = a += Coord::new(0, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/coord_arithmetic.rs:443:9 [INFO] [stderr] | [INFO] [stderr] 443 | let _ = a += &Size::new(0, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/coord_arithmetic.rs:444:9 [INFO] [stderr] | [INFO] [stderr] 444 | let _ = a += &Coord::new(0, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.00s [INFO] running `"docker" "inspect" "98c6eb0783211847bbd5219d5605f29c5812c8489b80b752c95ea77f482cbda5"` [INFO] running `"docker" "rm" "-f" "98c6eb0783211847bbd5219d5605f29c5812c8489b80b752c95ea77f482cbda5"` [INFO] [stdout] 98c6eb0783211847bbd5219d5605f29c5812c8489b80b752c95ea77f482cbda5