[INFO] crate conniecs-derive 0.1.2 is already in cache
[INFO] extracting crate conniecs-derive 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/conniecs-derive/0.1.2
[INFO] extracting crate conniecs-derive 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/conniecs-derive/0.1.2
[INFO] validating manifest of conniecs-derive-0.1.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of conniecs-derive-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing conniecs-derive-0.1.2
[INFO] finished frobbing conniecs-derive-0.1.2
[INFO] frobbed toml for conniecs-derive-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/conniecs-derive/0.1.2/Cargo.toml
[INFO] started frobbing conniecs-derive-0.1.2
[INFO] finished frobbing conniecs-derive-0.1.2
[INFO] frobbed toml for conniecs-derive-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/conniecs-derive/0.1.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting conniecs-derive-0.1.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/conniecs-derive/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e8458409dda802460a15de815e4e15feaf5c295db01b9f260e08e966c36bf734
[INFO] running `"docker" "start" "-a" "e8458409dda802460a15de815e4e15feaf5c295db01b9f260e08e966c36bf734"`
[INFO] [stderr]     Checking conniecs-derive v0.1.2 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/system.rs:317:9
[INFO] [stderr]     |
[INFO] [stderr] 317 |         iv
[INFO] [stderr]     |         ^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/system.rs:316:18
[INFO] [stderr]     |
[INFO] [stderr] 316 |         let iv = parse_u64(&time[..len - 2]);
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/lib.rs:30:5
[INFO] [stderr]    |
[INFO] [stderr] 30 |     result
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/lib.rs:26:18
[INFO] [stderr]    |
[INFO] [stderr] 26 |     let result = gen.parse().unwrap();
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/system.rs:317:9
[INFO] [stderr]     |
[INFO] [stderr] 317 |         iv
[INFO] [stderr]     |         ^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/system.rs:316:18
[INFO] [stderr]     |
[INFO] [stderr] 316 |         let iv = parse_u64(&time[..len - 2]);
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/lib.rs:30:5
[INFO] [stderr]    |
[INFO] [stderr] 30 |     result
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/lib.rs:26:18
[INFO] [stderr]    |
[INFO] [stderr] 26 |     let result = gen.parse().unwrap();
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/aspect.rs:57:5
[INFO] [stderr]    |
[INFO] [stderr] 57 | /     match attr {
[INFO] [stderr] 58 | |         &MetaItem::List(_, ref items) => {
[INFO] [stderr] 59 | |             read_aspect(items, all, none);
[INFO] [stderr] 60 | |             None
[INFO] [stderr] ...  |
[INFO] [stderr] 65 | |         _ => improper_format(),
[INFO] [stderr] 66 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 57 |     match *attr {
[INFO] [stderr] 58 |         MetaItem::List(_, ref items) => {
[INFO] [stderr] 59 |             read_aspect(items, all, none);
[INFO] [stderr] 60 |             None
[INFO] [stderr] 61 |         }
[INFO] [stderr] 62 |         MetaItem::NameValue(_, Lit::Str(ref path, _)) => {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/aspect.rs:94:5
[INFO] [stderr]    |
[INFO] [stderr] 94 | /     match item {
[INFO] [stderr] 95 | |         &MetaItem::List(_, ref items) => items,
[INFO] [stderr] 96 | |         _ => improper_format(),
[INFO] [stderr] 97 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 94 |     match *item {
[INFO] [stderr] 95 |         MetaItem::List(_, ref items) => items,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/aspect.rs:101:5
[INFO] [stderr]     |
[INFO] [stderr] 101 | /     match item {
[INFO] [stderr] 102 | |         &MetaItem::Word(ref ident) => ident,
[INFO] [stderr] 103 | |         _ => improper_format(),
[INFO] [stderr] 104 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 101 |     match *item {
[INFO] [stderr] 102 |         MetaItem::Word(ref ident) => ident,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/aspect.rs:108:5
[INFO] [stderr]     |
[INFO] [stderr] 108 | /     match item {
[INFO] [stderr] 109 | |         &NestedMetaItem::MetaItem(ref item) => item,
[INFO] [stderr] 110 | |         &NestedMetaItem::Literal(_) => improper_format(),
[INFO] [stderr] 111 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 108 |     match *item {
[INFO] [stderr] 109 |         NestedMetaItem::MetaItem(ref item) => item,
[INFO] [stderr] 110 |         NestedMetaItem::Literal(_) => improper_format(),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/system.rs:18:9
[INFO] [stderr]    |
[INFO] [stderr] 18 | /         match attr.name() {
[INFO] [stderr] 19 | |             "system_type" => kind = read_systy(&attr.value),
[INFO] [stderr] 20 | |             _ => (),
[INFO] [stderr] 21 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let "system_type" = attr.name() { kind = read_systy(&attr.value) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/system.rs:294:5
[INFO] [stderr]     |
[INFO] [stderr] 294 | /     match attr {
[INFO] [stderr] 295 | |         &MetaItem::NameValue(_, Lit::Str(ref time, _)) => parse_iv_time(time),
[INFO] [stderr] 296 | |         &MetaItem::NameValue(_, Lit::Int(time, _)) => frame_iv(time),
[INFO] [stderr] 297 | |         &MetaItem::List(_, ref items) => parse_explicit_iv(items),
[INFO] [stderr] 298 | |         _ => improper_interval_fmt(),
[INFO] [stderr] 299 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 294 |     match *attr {
[INFO] [stderr] 295 |         MetaItem::NameValue(_, Lit::Str(ref time, _)) => parse_iv_time(time),
[INFO] [stderr] 296 |         MetaItem::NameValue(_, Lit::Int(time, _)) => frame_iv(time),
[INFO] [stderr] 297 |         MetaItem::List(_, ref items) => parse_explicit_iv(items),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/system.rs:318:30
[INFO] [stderr]     |
[INFO] [stderr] 318 |     } else if time.ends_with("s") && len > 1 {
[INFO] [stderr]     |                              ^^^ help: try using a char instead: `'s'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/system.rs:336:22
[INFO] [stderr]     |
[INFO] [stderr] 336 |               let iv = match lit {
[INFO] [stderr]     |  ______________________^
[INFO] [stderr] 337 | |                 &Lit::Str(ref time, _) => parse_u64(time),
[INFO] [stderr] 338 | |                 &Lit::Int(iv, _) => iv,
[INFO] [stderr] 339 | |                 _ => improper_interval_fmt(),
[INFO] [stderr] 340 | |             };
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 336 |             let iv = match *lit {
[INFO] [stderr] 337 |                 Lit::Str(ref time, _) => parse_u64(time),
[INFO] [stderr] 338 |                 Lit::Int(iv, _) => iv,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/system.rs:532:5
[INFO] [stderr]     |
[INFO] [stderr] 532 | /     match item {
[INFO] [stderr] 533 | |         &MetaItem::List(_, ref items) => read_data_items(items),
[INFO] [stderr] 534 | |         _ => improper_data_fmt(),
[INFO] [stderr] 535 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 532 |     match *item {
[INFO] [stderr] 533 |         MetaItem::List(_, ref items) => read_data_items(items),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/systems.rs:12:9
[INFO] [stderr]    |
[INFO] [stderr] 12 | /         match attr.name() {
[INFO] [stderr] 13 | |             "data" => cs_data = Some(read_data(&attr.value)),
[INFO] [stderr] 14 | |             _ => (),
[INFO] [stderr] 15 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let "data" = attr.name() { cs_data = Some(read_data(&attr.value)) }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:108:5
[INFO] [stderr]     |
[INFO] [stderr] 108 | /     match attr {
[INFO] [stderr] 109 | |         &syn::MetaItem::Word(ref word) => word.to_string(),
[INFO] [stderr] 110 | |         &syn::MetaItem::List(_, ref items) => {
[INFO] [stderr] 111 | |             if items.len() != 1 {
[INFO] [stderr] ...   |
[INFO] [stderr] 129 | |         }
[INFO] [stderr] 130 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 108 |     match *attr {
[INFO] [stderr] 109 |         syn::MetaItem::Word(ref word) => word.to_string(),
[INFO] [stderr] 110 |         syn::MetaItem::List(_, ref items) => {
[INFO] [stderr] 111 |             if items.len() != 1 {
[INFO] [stderr] 112 |                 fail();
[INFO] [stderr] 113 |                 unreachable!();
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/aspect.rs:57:5
[INFO] [stderr]    |
[INFO] [stderr] 57 | /     match attr {
[INFO] [stderr] 58 | |         &MetaItem::List(_, ref items) => {
[INFO] [stderr] 59 | |             read_aspect(items, all, none);
[INFO] [stderr] 60 | |             None
[INFO] [stderr] ...  |
[INFO] [stderr] 65 | |         _ => improper_format(),
[INFO] [stderr] 66 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 57 |     match *attr {
[INFO] [stderr] 58 |         MetaItem::List(_, ref items) => {
[INFO] [stderr] 59 |             read_aspect(items, all, none);
[INFO] [stderr] 60 |             None
[INFO] [stderr] 61 |         }
[INFO] [stderr] 62 |         MetaItem::NameValue(_, Lit::Str(ref path, _)) => {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/aspect.rs:94:5
[INFO] [stderr]    |
[INFO] [stderr] 94 | /     match item {
[INFO] [stderr] 95 | |         &MetaItem::List(_, ref items) => items,
[INFO] [stderr] 96 | |         _ => improper_format(),
[INFO] [stderr] 97 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 94 |     match *item {
[INFO] [stderr] 95 |         MetaItem::List(_, ref items) => items,
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/aspect.rs:101:5
[INFO] [stderr]     |
[INFO] [stderr] 101 | /     match item {
[INFO] [stderr] 102 | |         &MetaItem::Word(ref ident) => ident,
[INFO] [stderr] 103 | |         _ => improper_format(),
[INFO] [stderr] 104 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 101 |     match *item {
[INFO] [stderr] 102 |         MetaItem::Word(ref ident) => ident,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/aspect.rs:108:5
[INFO] [stderr]     |
[INFO] [stderr] 108 | /     match item {
[INFO] [stderr] 109 | |         &NestedMetaItem::MetaItem(ref item) => item,
[INFO] [stderr] 110 | |         &NestedMetaItem::Literal(_) => improper_format(),
[INFO] [stderr] 111 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 108 |     match *item {
[INFO] [stderr] 109 |         NestedMetaItem::MetaItem(ref item) => item,
[INFO] [stderr] 110 |         NestedMetaItem::Literal(_) => improper_format(),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/system.rs:18:9
[INFO] [stderr]    |
[INFO] [stderr] 18 | /         match attr.name() {
[INFO] [stderr] 19 | |             "system_type" => kind = read_systy(&attr.value),
[INFO] [stderr] 20 | |             _ => (),
[INFO] [stderr] 21 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let "system_type" = attr.name() { kind = read_systy(&attr.value) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/system.rs:294:5
[INFO] [stderr]     |
[INFO] [stderr] 294 | /     match attr {
[INFO] [stderr] 295 | |         &MetaItem::NameValue(_, Lit::Str(ref time, _)) => parse_iv_time(time),
[INFO] [stderr] 296 | |         &MetaItem::NameValue(_, Lit::Int(time, _)) => frame_iv(time),
[INFO] [stderr] 297 | |         &MetaItem::List(_, ref items) => parse_explicit_iv(items),
[INFO] [stderr] 298 | |         _ => improper_interval_fmt(),
[INFO] [stderr] 299 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 294 |     match *attr {
[INFO] [stderr] 295 |         MetaItem::NameValue(_, Lit::Str(ref time, _)) => parse_iv_time(time),
[INFO] [stderr] 296 |         MetaItem::NameValue(_, Lit::Int(time, _)) => frame_iv(time),
[INFO] [stderr] 297 |         MetaItem::List(_, ref items) => parse_explicit_iv(items),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/system.rs:318:30
[INFO] [stderr]     |
[INFO] [stderr] 318 |     } else if time.ends_with("s") && len > 1 {
[INFO] [stderr]     |                              ^^^ help: try using a char instead: `'s'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/system.rs:336:22
[INFO] [stderr]     |
[INFO] [stderr] 336 |               let iv = match lit {
[INFO] [stderr]     |  ______________________^
[INFO] [stderr] 337 | |                 &Lit::Str(ref time, _) => parse_u64(time),
[INFO] [stderr] 338 | |                 &Lit::Int(iv, _) => iv,
[INFO] [stderr] 339 | |                 _ => improper_interval_fmt(),
[INFO] [stderr] 340 | |             };
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 336 |             let iv = match *lit {
[INFO] [stderr] 337 |                 Lit::Str(ref time, _) => parse_u64(time),
[INFO] [stderr] 338 |                 Lit::Int(iv, _) => iv,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/system.rs:532:5
[INFO] [stderr]     |
[INFO] [stderr] 532 | /     match item {
[INFO] [stderr] 533 | |         &MetaItem::List(_, ref items) => read_data_items(items),
[INFO] [stderr] 534 | |         _ => improper_data_fmt(),
[INFO] [stderr] 535 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 532 |     match *item {
[INFO] [stderr] 533 |         MetaItem::List(_, ref items) => read_data_items(items),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/systems.rs:12:9
[INFO] [stderr]    |
[INFO] [stderr] 12 | /         match attr.name() {
[INFO] [stderr] 13 | |             "data" => cs_data = Some(read_data(&attr.value)),
[INFO] [stderr] 14 | |             _ => (),
[INFO] [stderr] 15 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let "data" = attr.name() { cs_data = Some(read_data(&attr.value)) }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:108:5
[INFO] [stderr]     |
[INFO] [stderr] 108 | /     match attr {
[INFO] [stderr] 109 | |         &syn::MetaItem::Word(ref word) => word.to_string(),
[INFO] [stderr] 110 | |         &syn::MetaItem::List(_, ref items) => {
[INFO] [stderr] 111 | |             if items.len() != 1 {
[INFO] [stderr] ...   |
[INFO] [stderr] 129 | |         }
[INFO] [stderr] 130 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 108 |     match *attr {
[INFO] [stderr] 109 |         syn::MetaItem::Word(ref word) => word.to_string(),
[INFO] [stderr] 110 |         syn::MetaItem::List(_, ref items) => {
[INFO] [stderr] 111 |             if items.len() != 1 {
[INFO] [stderr] 112 |                 fail();
[INFO] [stderr] 113 |                 unreachable!();
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.52s
[INFO] running `"docker" "inspect" "e8458409dda802460a15de815e4e15feaf5c295db01b9f260e08e966c36bf734"`
[INFO] running `"docker" "rm" "-f" "e8458409dda802460a15de815e4e15feaf5c295db01b9f260e08e966c36bf734"`
[INFO] [stdout] e8458409dda802460a15de815e4e15feaf5c295db01b9f260e08e966c36bf734