[INFO] crate conftaal 0.1.1 is already in cache [INFO] extracting crate conftaal 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/conftaal/0.1.1 [INFO] extracting crate conftaal 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/conftaal/0.1.1 [INFO] validating manifest of conftaal-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of conftaal-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing conftaal-0.1.1 [INFO] finished frobbing conftaal-0.1.1 [INFO] frobbed toml for conftaal-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/conftaal/0.1.1/Cargo.toml [INFO] started frobbing conftaal-0.1.1 [INFO] finished frobbing conftaal-0.1.1 [INFO] frobbed toml for conftaal-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/conftaal/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting conftaal-0.1.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/conftaal/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 449bb2aca5a5308e70b3dfab8d2f1a138274e41c144e983b9838afa515852460 [INFO] running `"docker" "start" "-a" "449bb2aca5a5308e70b3dfab8d2f1a138274e41c144e983b9838afa515852460"` [INFO] [stderr] Checking conftaal v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/error.rs:16:4 [INFO] [stderr] | [INFO] [stderr] 16 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/mod.rs:93:6 [INFO] [stderr] | [INFO] [stderr] 93 | op_source: op_source, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `op_source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/mod.rs:158:4 [INFO] [stderr] | [INFO] [stderr] 158 | op_source: op_source, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `op_source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/mod.rs:160:5 [INFO] [stderr] | [INFO] [stderr] 160 | op: op, [INFO] [stderr] | ^^^^^^ help: replace it with: `op` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/error.rs:16:4 [INFO] [stderr] | [INFO] [stderr] 16 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/mod.rs:93:6 [INFO] [stderr] | [INFO] [stderr] 93 | op_source: op_source, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `op_source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/mod.rs:158:4 [INFO] [stderr] | [INFO] [stderr] 158 | op_source: op_source, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `op_source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parse/mod.rs:160:5 [INFO] [stderr] | [INFO] [stderr] 160 | op: op, [INFO] [stderr] | ^^^^^^ help: replace it with: `op` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/expression.rs:31:3 [INFO] [stderr] | [INFO] [stderr] 31 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 32 | | &Op::UnaryOp{op, ..} => Operator::Unary(op), [INFO] [stderr] 33 | | &Op::BinaryOp{op, ..} => Operator::Binary(op), [INFO] [stderr] 34 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 31 | match *self { [INFO] [stderr] 32 | Op::UnaryOp{op, ..} => Operator::Unary(op), [INFO] [stderr] 33 | Op::BinaryOp{op, ..} => Operator::Binary(op), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/parse/consume.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | ).unwrap_or(self.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parse/error.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn error<'a>(location: &'a [u8], message: String) -> Error<'a> { [INFO] [stderr] 14 | | Error{ [INFO] [stderr] 15 | | message: Message{ [INFO] [stderr] 16 | | message: message, [INFO] [stderr] ... | [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/parse/whitespace.rs:7:6 [INFO] [stderr] | [INFO] [stderr] 7 | }).unwrap_or(src.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| src.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/parse/whitespace.rs:10:59 [INFO] [stderr] | [INFO] [stderr] 10 | let comment_end = src.iter().position(|&b| b == b'\n').unwrap_or(src.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| src.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parse/end.rs:55:3 [INFO] [stderr] | [INFO] [stderr] 55 | if let &End::MatchingBracket(b, _) = self { [INFO] [stderr] | _________^ [INFO] [stderr] 56 | | e.notes = vec![Message{ [INFO] [stderr] 57 | | message: format!("... to match this `{}'", b), [INFO] [stderr] 58 | | location: Some(b.as_bytes()) [INFO] [stderr] 59 | | }]; [INFO] [stderr] 60 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 55 | if let End::MatchingBracket(b, _) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parse/end.rs:71:27 [INFO] [stderr] | [INFO] [stderr] 71 | skip_whitespace(source, match self { &End::ElementEnd => false, _ => true }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 71 | skip_whitespace(source, match *self { End::ElementEnd => false, _ => true }); [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/parse/mod.rs:33:6 [INFO] [stderr] | [INFO] [stderr] 33 | -> Result<(Vec>>, Vec>>), Error<'a>> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parse/mod.rs:78:27 [INFO] [stderr] | [INFO] [stderr] 78 | fn parse_expression_atom<'b>(&mut self, end: &OptionalEnd<'a>) -> Result>, Error<'a>> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parse/mod.rs:84:4 [INFO] [stderr] | [INFO] [stderr] 84 | if let &mut Expression::Op{ref mut parenthesized, ..} = &mut expr { [INFO] [stderr] | _____________^ [INFO] [stderr] 85 | | *parenthesized = true; [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 84 | if let Expression::Op{ref mut parenthesized, ..} = *(&mut expr) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/expression.rs:31:3 [INFO] [stderr] | [INFO] [stderr] 31 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 32 | | &Op::UnaryOp{op, ..} => Operator::Unary(op), [INFO] [stderr] 33 | | &Op::BinaryOp{op, ..} => Operator::Binary(op), [INFO] [stderr] 34 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 31 | match *self { [INFO] [stderr] 32 | Op::UnaryOp{op, ..} => Operator::Unary(op), [INFO] [stderr] 33 | Op::BinaryOp{op, ..} => Operator::Binary(op), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/parse/consume.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | ).unwrap_or(self.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parse/error.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn error<'a>(location: &'a [u8], message: String) -> Error<'a> { [INFO] [stderr] 14 | | Error{ [INFO] [stderr] 15 | | message: Message{ [INFO] [stderr] 16 | | message: message, [INFO] [stderr] ... | [INFO] [stderr] 20 | | } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/parse/whitespace.rs:7:6 [INFO] [stderr] | [INFO] [stderr] 7 | }).unwrap_or(src.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| src.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/parse/whitespace.rs:10:59 [INFO] [stderr] | [INFO] [stderr] 10 | let comment_end = src.iter().position(|&b| b == b'\n').unwrap_or(src.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| src.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/parse/whitespace.rs:36:14 [INFO] [stderr] | [INFO] [stderr] 36 | let mut s = " ".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b" "` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/parse/whitespace.rs:40:14 [INFO] [stderr] | [INFO] [stderr] 40 | let mut s = "a ".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"a "` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/parse/whitespace.rs:44:14 [INFO] [stderr] | [INFO] [stderr] 44 | let mut s = "".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parse/end.rs:55:3 [INFO] [stderr] | [INFO] [stderr] 55 | if let &End::MatchingBracket(b, _) = self { [INFO] [stderr] | _________^ [INFO] [stderr] 56 | | e.notes = vec![Message{ [INFO] [stderr] 57 | | message: format!("... to match this `{}'", b), [INFO] [stderr] 58 | | location: Some(b.as_bytes()) [INFO] [stderr] 59 | | }]; [INFO] [stderr] 60 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 55 | if let End::MatchingBracket(b, _) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parse/end.rs:71:27 [INFO] [stderr] | [INFO] [stderr] 71 | skip_whitespace(source, match self { &End::ElementEnd => false, _ => true }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 71 | skip_whitespace(source, match *self { End::ElementEnd => false, _ => true }); [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/parse/mod.rs:33:6 [INFO] [stderr] | [INFO] [stderr] 33 | -> Result<(Vec>>, Vec>>), Error<'a>> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/parse/mod.rs:78:27 [INFO] [stderr] | [INFO] [stderr] 78 | fn parse_expression_atom<'b>(&mut self, end: &OptionalEnd<'a>) -> Result>, Error<'a>> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parse/mod.rs:84:4 [INFO] [stderr] | [INFO] [stderr] 84 | if let &mut Expression::Op{ref mut parenthesized, ..} = &mut expr { [INFO] [stderr] | _____________^ [INFO] [stderr] 85 | | *parenthesized = true; [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 84 | if let Expression::Op{ref mut parenthesized, ..} = *(&mut expr) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> tools/parse.rs:10:22 [INFO] [stderr] | [INFO] [stderr] 10 | fn format_list(list: &Vec>) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Rc]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> tools/parse.rs:10:22 [INFO] [stderr] | [INFO] [stderr] 10 | fn format_list(list: &Vec>) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Rc]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.01s [INFO] running `"docker" "inspect" "449bb2aca5a5308e70b3dfab8d2f1a138274e41c144e983b9838afa515852460"` [INFO] running `"docker" "rm" "-f" "449bb2aca5a5308e70b3dfab8d2f1a138274e41c144e983b9838afa515852460"` [INFO] [stdout] 449bb2aca5a5308e70b3dfab8d2f1a138274e41c144e983b9838afa515852460