[INFO] crate config-parser 0.1.2 is already in cache [INFO] extracting crate config-parser 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/config-parser/0.1.2 [INFO] extracting crate config-parser 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/config-parser/0.1.2 [INFO] validating manifest of config-parser-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of config-parser-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing config-parser-0.1.2 [INFO] finished frobbing config-parser-0.1.2 [INFO] frobbed toml for config-parser-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/config-parser/0.1.2/Cargo.toml [INFO] started frobbing config-parser-0.1.2 [INFO] finished frobbing config-parser-0.1.2 [INFO] frobbed toml for config-parser-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/config-parser/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting config-parser-0.1.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/config-parser/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 95b567924f8f73849d6cf762c94e3b1b1a1b8fea9f2e83ee04f670899fb3ee63 [INFO] running `"docker" "start" "-a" "95b567924f8f73849d6cf762c94e3b1b1a1b8fea9f2e83ee04f670899fb3ee63"` [INFO] [stderr] Checking config-parser v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | params: params, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | inner: inner [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | name: name [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | col: col, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `col` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | expected: expected [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `expected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | col: col, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `col` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:81:51 [INFO] [stderr] | [INFO] [stderr] 81 | let mut state = LexerState { line: 1, col: 0, input: input, mode: LexerMode::None, escaped: false, tmp: String::new(), tokens: vec![], force_next: None}; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | tokens: tokens, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:35:23 [INFO] [stderr] | [INFO] [stderr] 35 | OwningChars { s: s, pos: 0 } [INFO] [stderr] | ^^^^ help: replace it with: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | params: params, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | inner: inner [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | name: name [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | col: col, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `col` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/error.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | expected: expected [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `expected` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | col: col, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `col` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:81:51 [INFO] [stderr] | [INFO] [stderr] 81 | let mut state = LexerState { line: 1, col: 0, input: input, mode: LexerMode::None, escaped: false, tmp: String::new(), tokens: vec![], force_next: None}; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | tokens: tokens, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:35:23 [INFO] [stderr] | [INFO] [stderr] 35 | OwningChars { s: s, pos: 0 } [INFO] [stderr] | ^^^^ help: replace it with: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: item `config::ConfigBlock` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/config.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | / impl ConfigBlock { [INFO] [stderr] 12 | | /// Creates a new ConfigBlock. This probably isn't very useful to you. [INFO] [stderr] 13 | | pub fn new(name: String, params: Vec, inner: Vec) -> ConfigBlock { [INFO] [stderr] 14 | | ConfigBlock { [INFO] [stderr] ... | [INFO] [stderr] 61 | | } [INFO] [stderr] 62 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lexer.rs:84:20 [INFO] [stderr] | [INFO] [stderr] 84 | let mode = state.mode.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `state.mode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lexer.rs:204:5 [INFO] [stderr] | [INFO] [stderr] 204 | / loop { [INFO] [stderr] 205 | | let c = match next_char(state) { [INFO] [stderr] 206 | | Some(c) => c, [INFO] [stderr] 207 | | None => break [INFO] [stderr] ... | [INFO] [stderr] 282 | | } [INFO] [stderr] 283 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(c) = next_char(state) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lexer.rs:259:17 [INFO] [stderr] | [INFO] [stderr] 259 | / match lookahead(state) { [INFO] [stderr] 260 | | Some('/') => { [INFO] [stderr] 261 | | if level <= 1 { [INFO] [stderr] 262 | | next(state).unwrap(); // pop the next char [INFO] [stderr] ... | [INFO] [stderr] 268 | | _ => {} [INFO] [stderr] 269 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 259 | if let Some('/') = lookahead(state) { [INFO] [stderr] 260 | if level <= 1 { [INFO] [stderr] 261 | next(state).unwrap(); // pop the next char [INFO] [stderr] 262 | ps = PreProcState::Default [INFO] [stderr] 263 | } else { [INFO] [stderr] 264 | ps = PreProcState::MultiComment(level - 1) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lexer.rs:272:17 [INFO] [stderr] | [INFO] [stderr] 272 | / match lookahead(state) { [INFO] [stderr] 273 | | Some('*') => { [INFO] [stderr] 274 | | ps = PreProcState::MultiComment(level + 1); [INFO] [stderr] 275 | | }, [INFO] [stderr] 276 | | _ => {} [INFO] [stderr] 277 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 272 | if let Some('*') = lookahead(state) { [INFO] [stderr] 273 | ps = PreProcState::MultiComment(level + 1); [INFO] [stderr] 274 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/parser.rs:121:13 [INFO] [stderr] | [INFO] [stderr] 121 | let v = match &state.force_next { [INFO] [stderr] | _____________^ [INFO] [stderr] 122 | | &Some(ref t) => Some(t.clone()), [INFO] [stderr] 123 | | &None => state.tokens.next() [INFO] [stderr] 124 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 121 | let v = match state.force_next { [INFO] [stderr] 122 | Some(ref t) => Some(t.clone()), [INFO] [stderr] 123 | None => state.tokens.next() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: item `config::ConfigBlock` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/config.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | / impl ConfigBlock { [INFO] [stderr] 12 | | /// Creates a new ConfigBlock. This probably isn't very useful to you. [INFO] [stderr] 13 | | pub fn new(name: String, params: Vec, inner: Vec) -> ConfigBlock { [INFO] [stderr] 14 | | ConfigBlock { [INFO] [stderr] ... | [INFO] [stderr] 61 | | } [INFO] [stderr] 62 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lexer.rs:84:20 [INFO] [stderr] | [INFO] [stderr] 84 | let mode = state.mode.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `state.mode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lexer.rs:204:5 [INFO] [stderr] | [INFO] [stderr] 204 | / loop { [INFO] [stderr] 205 | | let c = match next_char(state) { [INFO] [stderr] 206 | | Some(c) => c, [INFO] [stderr] 207 | | None => break [INFO] [stderr] ... | [INFO] [stderr] 282 | | } [INFO] [stderr] 283 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(c) = next_char(state) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lexer.rs:259:17 [INFO] [stderr] | [INFO] [stderr] 259 | / match lookahead(state) { [INFO] [stderr] 260 | | Some('/') => { [INFO] [stderr] 261 | | if level <= 1 { [INFO] [stderr] 262 | | next(state).unwrap(); // pop the next char [INFO] [stderr] ... | [INFO] [stderr] 268 | | _ => {} [INFO] [stderr] 269 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 259 | if let Some('/') = lookahead(state) { [INFO] [stderr] 260 | if level <= 1 { [INFO] [stderr] 261 | next(state).unwrap(); // pop the next char [INFO] [stderr] 262 | ps = PreProcState::Default [INFO] [stderr] 263 | } else { [INFO] [stderr] 264 | ps = PreProcState::MultiComment(level - 1) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lexer.rs:272:17 [INFO] [stderr] | [INFO] [stderr] 272 | / match lookahead(state) { [INFO] [stderr] 273 | | Some('*') => { [INFO] [stderr] 274 | | ps = PreProcState::MultiComment(level + 1); [INFO] [stderr] 275 | | }, [INFO] [stderr] 276 | | _ => {} [INFO] [stderr] 277 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 272 | if let Some('*') = lookahead(state) { [INFO] [stderr] 273 | ps = PreProcState::MultiComment(level + 1); [INFO] [stderr] 274 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/parser.rs:121:13 [INFO] [stderr] | [INFO] [stderr] 121 | let v = match &state.force_next { [INFO] [stderr] | _____________^ [INFO] [stderr] 122 | | &Some(ref t) => Some(t.clone()), [INFO] [stderr] 123 | | &None => state.tokens.next() [INFO] [stderr] 124 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 121 | let v = match state.force_next { [INFO] [stderr] 122 | Some(ref t) => Some(t.clone()), [INFO] [stderr] 123 | None => state.tokens.next() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.14s [INFO] running `"docker" "inspect" "95b567924f8f73849d6cf762c94e3b1b1a1b8fea9f2e83ee04f670899fb3ee63"` [INFO] running `"docker" "rm" "-f" "95b567924f8f73849d6cf762c94e3b1b1a1b8fea9f2e83ee04f670899fb3ee63"` [INFO] [stdout] 95b567924f8f73849d6cf762c94e3b1b1a1b8fea9f2e83ee04f670899fb3ee63