[INFO] crate colorful 0.1.0 is already in cache [INFO] extracting crate colorful 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/colorful/0.1.0 [INFO] extracting crate colorful 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/colorful/0.1.0 [INFO] validating manifest of colorful-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of colorful-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing colorful-0.1.0 [INFO] finished frobbing colorful-0.1.0 [INFO] frobbed toml for colorful-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/colorful/0.1.0/Cargo.toml [INFO] started frobbing colorful-0.1.0 [INFO] finished frobbing colorful-0.1.0 [INFO] frobbed toml for colorful-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/colorful/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting colorful-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/colorful/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 267ea59d3ba7dd0f1f450252d5a9cb2d1d8e8e5da859e185c84046a124e941ad [INFO] running `"docker" "start" "-a" "267ea59d3ba7dd0f1f450252d5a9cb2d1d8e8e5da859e185c84046a124e941ad"` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] Checking colorful v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:157:14 [INFO] [stderr] | [INFO] [stderr] 157 | let (r, g, b) = c.unpack(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:157:17 [INFO] [stderr] | [INFO] [stderr] 157 | let (r, g, b) = c.unpack(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:157:20 [INFO] [stderr] | [INFO] [stderr] 157 | let (r, g, b) = c.unpack(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:162:14 [INFO] [stderr] | [INFO] [stderr] 162 | let (r, g, b) = c.unpack(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:162:17 [INFO] [stderr] | [INFO] [stderr] 162 | let (r, g, b) = c.unpack(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:162:20 [INFO] [stderr] | [INFO] [stderr] 162 | let (r, g, b) = c.unpack(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:157:14 [INFO] [stderr] | [INFO] [stderr] 157 | let (r, g, b) = c.unpack(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:157:17 [INFO] [stderr] | [INFO] [stderr] 157 | let (r, g, b) = c.unpack(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:157:20 [INFO] [stderr] | [INFO] [stderr] 157 | let (r, g, b) = c.unpack(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:162:14 [INFO] [stderr] | [INFO] [stderr] 162 | let (r, g, b) = c.unpack(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:162:17 [INFO] [stderr] | [INFO] [stderr] 162 | let (r, g, b) = c.unpack(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:162:20 [INFO] [stderr] | [INFO] [stderr] 162 | let (r, g, b) = c.unpack(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt::Display` [INFO] [stderr] --> src/core/colors.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::fmt::Display; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt::Formatter` [INFO] [stderr] --> src/core/colors.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::fmt::Formatter; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt::Result as FmtResult` [INFO] [stderr] --> src/core/colors.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::fmt::Result as FmtResult; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt::Display` [INFO] [stderr] --> src/core/colors.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::fmt::Display; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt::Formatter` [INFO] [stderr] --> src/core/colors.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::fmt::Formatter; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt::Result as FmtResult` [INFO] [stderr] --> src/core/colors.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::fmt::Result as FmtResult; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/core/colors.rs:579:9 [INFO] [stderr] | [INFO] [stderr] 579 | let mut red: f32; [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/core/colors.rs:580:9 [INFO] [stderr] | [INFO] [stderr] 580 | let mut green: f32; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/core/colors.rs:581:9 [INFO] [stderr] | [INFO] [stderr] 581 | let mut blue: f32; [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/core/colors.rs:267:9 [INFO] [stderr] | [INFO] [stderr] 267 | / format!("{}", [INFO] [stderr] 268 | | match self { [INFO] [stderr] 269 | | Color::Black => "0", [INFO] [stderr] 270 | | Color::Red => "1", [INFO] [stderr] ... | [INFO] [stderr] 525 | | } [INFO] [stderr] 526 | | ) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 2 | $ crate :: fmt :: format ( match self { [INFO] [stderr] 3 | Color::Black => "0", [INFO] [stderr] 4 | Color::Red => "1", [INFO] [stderr] 5 | Color::Green => "2", [INFO] [stderr] 6 | Color::Yellow => "3", [INFO] [stderr] 7 | Color::Blue => "4", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/core/colors.rs:551:19 [INFO] [stderr] | [INFO] [stderr] 551 | pub fn unpack(&self) -> (u8, u8, u8) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/core/colors.rs:597:54 [INFO] [stderr] | [INFO] [stderr] 597 | green = 255.0 * hue_2_rgb(var_1, var_2, &mut hsl.h.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `hsl.h` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/core/colors.rs:647:17 [INFO] [stderr] | [INFO] [stderr] 647 | let c = format!("{}", color.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `to_string()` is enough: `color.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/core/colors.rs:649:20 [INFO] [stderr] | [INFO] [stderr] 649 | color: format!("{}", color.to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `to_string()` is enough: `color.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/core/colors.rs:650:33 [INFO] [stderr] | [INFO] [stderr] 650 | mode: if c.contains(";") { [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/core/style.rs:14:19 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn to_str(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/core/style.rs:25:22 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn to_string(&self) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:125:19 [INFO] [stderr] | [INFO] [stderr] 125 | text: String::from(self.to_str()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `self.to_str()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:133:19 [INFO] [stderr] | [INFO] [stderr] 133 | text: String::from(self.to_str()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `self.to_str()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:141:19 [INFO] [stderr] | [INFO] [stderr] 141 | text: String::from(self.to_str()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `self.to_str()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:149:19 [INFO] [stderr] | [INFO] [stderr] 149 | text: String::from(self.to_str()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `self.to_str()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:167:19 [INFO] [stderr] | [INFO] [stderr] 167 | text: String::from(self.to_str()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `self.to_str()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:227:13 [INFO] [stderr] | [INFO] [stderr] 227 | / match &self.fg_color { [INFO] [stderr] 228 | | Some(v) => { [INFO] [stderr] 229 | | is_colored = true; [INFO] [stderr] 230 | | match v.mode { [INFO] [stderr] ... | [INFO] [stderr] 241 | | _ => {} [INFO] [stderr] 242 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 227 | if let Some(v) = &self.fg_color { [INFO] [stderr] 228 | is_colored = true; [INFO] [stderr] 229 | match v.mode { [INFO] [stderr] 230 | ColorMode::SIMPLE => { [INFO] [stderr] 231 | f.write_str(Symbol::Simple256Foreground.to_str())?; [INFO] [stderr] 232 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:243:13 [INFO] [stderr] | [INFO] [stderr] 243 | / match &self.bg_color { [INFO] [stderr] 244 | | Some(v) => { [INFO] [stderr] 245 | | if is_colored { [INFO] [stderr] 246 | | f.write_str(Symbol::Mode.to_str())?; [INFO] [stderr] ... | [INFO] [stderr] 261 | | _ => {} [INFO] [stderr] 262 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 243 | if let Some(v) = &self.bg_color { [INFO] [stderr] 244 | if is_colored { [INFO] [stderr] 245 | f.write_str(Symbol::Mode.to_str())?; [INFO] [stderr] 246 | } else { [INFO] [stderr] 247 | is_colored = true; [INFO] [stderr] 248 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:264:13 [INFO] [stderr] | [INFO] [stderr] 264 | / match &self.styles { [INFO] [stderr] 265 | | Some(v) => { [INFO] [stderr] 266 | | if !is_colored { // pure style without color [INFO] [stderr] 267 | | write!(f, "{}{}", Symbol::Esc, Symbol::LeftBrackets)?; [INFO] [stderr] ... | [INFO] [stderr] 274 | | _ => {} [INFO] [stderr] 275 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 264 | if let Some(v) = &self.styles { [INFO] [stderr] 265 | if !is_colored { // pure style without color [INFO] [stderr] 266 | write!(f, "{}{}", Symbol::Esc, Symbol::LeftBrackets)?; [INFO] [stderr] 267 | } else { [INFO] [stderr] 268 | f.write_str(Symbol::Semicolon.to_str())?; [INFO] [stderr] 269 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/lib.rs:271:44 [INFO] [stderr] | [INFO] [stderr] 271 | let t: Vec = v.into_iter().map(|x| x.to_string()).collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/core/colors.rs:579:9 [INFO] [stderr] | [INFO] [stderr] 579 | let mut red: f32; [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/core/colors.rs:580:9 [INFO] [stderr] | [INFO] [stderr] 580 | let mut green: f32; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/core/colors.rs:581:9 [INFO] [stderr] | [INFO] [stderr] 581 | let mut blue: f32; [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/core/colors.rs:267:9 [INFO] [stderr] | [INFO] [stderr] 267 | / format!("{}", [INFO] [stderr] 268 | | match self { [INFO] [stderr] 269 | | Color::Black => "0", [INFO] [stderr] 270 | | Color::Red => "1", [INFO] [stderr] ... | [INFO] [stderr] 525 | | } [INFO] [stderr] 526 | | ) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 2 | $ crate :: fmt :: format ( match self { [INFO] [stderr] 3 | Color::Black => "0", [INFO] [stderr] 4 | Color::Red => "1", [INFO] [stderr] 5 | Color::Green => "2", [INFO] [stderr] 6 | Color::Yellow => "3", [INFO] [stderr] 7 | Color::Blue => "4", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/core/colors.rs:551:19 [INFO] [stderr] | [INFO] [stderr] 551 | pub fn unpack(&self) -> (u8, u8, u8) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/core/colors.rs:597:54 [INFO] [stderr] | [INFO] [stderr] 597 | green = 255.0 * hue_2_rgb(var_1, var_2, &mut hsl.h.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `hsl.h` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/core/colors.rs:647:17 [INFO] [stderr] | [INFO] [stderr] 647 | let c = format!("{}", color.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `to_string()` is enough: `color.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/core/colors.rs:649:20 [INFO] [stderr] | [INFO] [stderr] 649 | color: format!("{}", color.to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `to_string()` is enough: `color.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/core/colors.rs:650:33 [INFO] [stderr] | [INFO] [stderr] 650 | mode: if c.contains(";") { [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/core/style.rs:14:19 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn to_str(&self) -> &'static str { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/core/style.rs:25:22 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn to_string(&self) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:125:19 [INFO] [stderr] | [INFO] [stderr] 125 | text: String::from(self.to_str()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `self.to_str()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:133:19 [INFO] [stderr] | [INFO] [stderr] 133 | text: String::from(self.to_str()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `self.to_str()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:141:19 [INFO] [stderr] | [INFO] [stderr] 141 | text: String::from(self.to_str()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `self.to_str()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:149:19 [INFO] [stderr] | [INFO] [stderr] 149 | text: String::from(self.to_str()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `self.to_str()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:167:19 [INFO] [stderr] | [INFO] [stderr] 167 | text: String::from(self.to_str()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `self.to_str()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:227:13 [INFO] [stderr] | [INFO] [stderr] 227 | / match &self.fg_color { [INFO] [stderr] 228 | | Some(v) => { [INFO] [stderr] 229 | | is_colored = true; [INFO] [stderr] 230 | | match v.mode { [INFO] [stderr] ... | [INFO] [stderr] 241 | | _ => {} [INFO] [stderr] 242 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 227 | if let Some(v) = &self.fg_color { [INFO] [stderr] 228 | is_colored = true; [INFO] [stderr] 229 | match v.mode { [INFO] [stderr] 230 | ColorMode::SIMPLE => { [INFO] [stderr] 231 | f.write_str(Symbol::Simple256Foreground.to_str())?; [INFO] [stderr] 232 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:243:13 [INFO] [stderr] | [INFO] [stderr] 243 | / match &self.bg_color { [INFO] [stderr] 244 | | Some(v) => { [INFO] [stderr] 245 | | if is_colored { [INFO] [stderr] 246 | | f.write_str(Symbol::Mode.to_str())?; [INFO] [stderr] ... | [INFO] [stderr] 261 | | _ => {} [INFO] [stderr] 262 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 243 | if let Some(v) = &self.bg_color { [INFO] [stderr] 244 | if is_colored { [INFO] [stderr] 245 | f.write_str(Symbol::Mode.to_str())?; [INFO] [stderr] 246 | } else { [INFO] [stderr] 247 | is_colored = true; [INFO] [stderr] 248 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:264:13 [INFO] [stderr] | [INFO] [stderr] 264 | / match &self.styles { [INFO] [stderr] 265 | | Some(v) => { [INFO] [stderr] 266 | | if !is_colored { // pure style without color [INFO] [stderr] 267 | | write!(f, "{}{}", Symbol::Esc, Symbol::LeftBrackets)?; [INFO] [stderr] ... | [INFO] [stderr] 274 | | _ => {} [INFO] [stderr] 275 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 264 | if let Some(v) = &self.styles { [INFO] [stderr] 265 | if !is_colored { // pure style without color [INFO] [stderr] 266 | write!(f, "{}{}", Symbol::Esc, Symbol::LeftBrackets)?; [INFO] [stderr] 267 | } else { [INFO] [stderr] 268 | f.write_str(Symbol::Semicolon.to_str())?; [INFO] [stderr] 269 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/lib.rs:271:44 [INFO] [stderr] | [INFO] [stderr] 271 | let t: Vec = v.into_iter().map(|x| x.to_string()).collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.27s [INFO] running `"docker" "inspect" "267ea59d3ba7dd0f1f450252d5a9cb2d1d8e8e5da859e185c84046a124e941ad"` [INFO] running `"docker" "rm" "-f" "267ea59d3ba7dd0f1f450252d5a9cb2d1d8e8e5da859e185c84046a124e941ad"` [INFO] [stdout] 267ea59d3ba7dd0f1f450252d5a9cb2d1d8e8e5da859e185c84046a124e941ad