[INFO] crate cluExtIO 0.1.2 is already in cache [INFO] extracting crate cluExtIO 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/cluExtIO/0.1.2 [INFO] extracting crate cluExtIO 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cluExtIO/0.1.2 [INFO] validating manifest of cluExtIO-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cluExtIO-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cluExtIO-0.1.2 [INFO] finished frobbing cluExtIO-0.1.2 [INFO] frobbed toml for cluExtIO-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/cluExtIO/0.1.2/Cargo.toml [INFO] started frobbing cluExtIO-0.1.2 [INFO] finished frobbing cluExtIO-0.1.2 [INFO] frobbed toml for cluExtIO-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cluExtIO/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cluExtIO-0.1.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cluExtIO/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6bdcce357144b100f25d7e189b2b8e64be2718bda6ef760c3590dd8ede4be738 [INFO] running `"docker" "start" "-a" "6bdcce357144b100f25d7e189b2b8e64be2718bda6ef760c3590dd8ede4be738"` [INFO] [stderr] Checking cluExtIO v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/write/union/write.rs:37:36 [INFO] [stderr] | [INFO] [stderr] 37 | Ok(s2) => return Ok({ [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 38 | | if s2 >= s { [INFO] [stderr] 39 | | s [INFO] [stderr] 40 | | }else { [INFO] [stderr] 41 | | s2 [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | }), [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 37 | Ok(s2) => Ok({ [INFO] [stderr] 38 | if s2 >= s { [INFO] [stderr] 39 | s [INFO] [stderr] 40 | }else { [INFO] [stderr] 41 | s2 [INFO] [stderr] 42 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/write/union/write.rs:44:31 [INFO] [stderr] | [INFO] [stderr] 44 | a => return a, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/write/union/write.rs:47:21 [INFO] [stderr] | [INFO] [stderr] 47 | a => return a, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/write/union/write.rs:37:36 [INFO] [stderr] | [INFO] [stderr] 37 | Ok(s2) => return Ok({ [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 38 | | if s2 >= s { [INFO] [stderr] 39 | | s [INFO] [stderr] 40 | | }else { [INFO] [stderr] 41 | | s2 [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | }), [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 37 | Ok(s2) => Ok({ [INFO] [stderr] 38 | if s2 >= s { [INFO] [stderr] 39 | s [INFO] [stderr] 40 | }else { [INFO] [stderr] 41 | s2 [INFO] [stderr] 42 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/write/union/write.rs:44:31 [INFO] [stderr] | [INFO] [stderr] 44 | a => return a, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/write/union/write.rs:47:21 [INFO] [stderr] | [INFO] [stderr] 47 | a => return a, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: crate `cluExtIO` should have a snake case name such as `clu_ext_io` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/write/mutex/mod.rs:30:6 [INFO] [stderr] | [INFO] [stderr] 30 | / fn _lock<'a>(&'a self) -> MutexGuard<'a, T> { [INFO] [stderr] 31 | | match self.0.lock() { [INFO] [stderr] 32 | | Ok(a) => a, [INFO] [stderr] 33 | | Err(e) => e.into_inner(), [INFO] [stderr] 34 | | } [INFO] [stderr] 35 | | } [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `write::empty::EmptyWrite` [INFO] [stderr] --> src/write/empty.rs:15:2 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 16 | | EmptyWrite [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: crate `cluExtIO` should have a snake case name such as `clu_ext_io` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/write/mutex/mod.rs:30:6 [INFO] [stderr] | [INFO] [stderr] 30 | / fn _lock<'a>(&'a self) -> MutexGuard<'a, T> { [INFO] [stderr] 31 | | match self.0.lock() { [INFO] [stderr] 32 | | Ok(a) => a, [INFO] [stderr] 33 | | Err(e) => e.into_inner(), [INFO] [stderr] 34 | | } [INFO] [stderr] 35 | | } [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `write::empty::EmptyWrite` [INFO] [stderr] --> src/write/empty.rs:15:2 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 16 | | EmptyWrite [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.47s [INFO] running `"docker" "inspect" "6bdcce357144b100f25d7e189b2b8e64be2718bda6ef760c3590dd8ede4be738"` [INFO] running `"docker" "rm" "-f" "6bdcce357144b100f25d7e189b2b8e64be2718bda6ef760c3590dd8ede4be738"` [INFO] [stdout] 6bdcce357144b100f25d7e189b2b8e64be2718bda6ef760c3590dd8ede4be738