[INFO] crate clioptions 0.1.0 is already in cache [INFO] extracting crate clioptions 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/clioptions/0.1.0 [INFO] extracting crate clioptions 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/clioptions/0.1.0 [INFO] validating manifest of clioptions-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of clioptions-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing clioptions-0.1.0 [INFO] finished frobbing clioptions-0.1.0 [INFO] frobbed toml for clioptions-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/clioptions/0.1.0/Cargo.toml [INFO] started frobbing clioptions-0.1.0 [INFO] finished frobbing clioptions-0.1.0 [INFO] frobbed toml for clioptions-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/clioptions/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting clioptions-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/clioptions/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] af9d8ca4696f93ceb79d540d1e44be1c30c7bf125f15d0ac479391454661dc69 [INFO] running `"docker" "start" "-a" "af9d8ca4696f93ceb79d540d1e44be1c30c7bf125f15d0ac479391454661dc69"` [INFO] [stderr] warning: unused manifest key: lib.crate_lib [INFO] [stderr] Checking clioptions v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:35:8 [INFO] [stderr] | [INFO] [stderr] 35 | arg [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:31:18 [INFO] [stderr] | [INFO] [stderr] 31 | let arg = match a { [INFO] [stderr] | __________________^ [INFO] [stderr] 32 | | Some(a) => a, [INFO] [stderr] 33 | | None => String::new() [INFO] [stderr] 34 | | }; [INFO] [stderr] | |________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | arg [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:41:19 [INFO] [stderr] | [INFO] [stderr] 41 | let arg = match a { [INFO] [stderr] | ___________________^ [INFO] [stderr] 42 | | Some(a) => a, [INFO] [stderr] 43 | | None => self.program.clone() [INFO] [stderr] 44 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:35:8 [INFO] [stderr] | [INFO] [stderr] 35 | arg [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:31:18 [INFO] [stderr] | [INFO] [stderr] 31 | let arg = match a { [INFO] [stderr] | __________________^ [INFO] [stderr] 32 | | Some(a) => a, [INFO] [stderr] 33 | | None => String::new() [INFO] [stderr] 34 | | }; [INFO] [stderr] | |________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | arg [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:41:19 [INFO] [stderr] | [INFO] [stderr] 41 | let arg = match a { [INFO] [stderr] | ___________________^ [INFO] [stderr] 42 | | Some(a) => a, [INFO] [stderr] 43 | | None => self.program.clone() [INFO] [stderr] 44 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.48s [INFO] running `"docker" "inspect" "af9d8ca4696f93ceb79d540d1e44be1c30c7bf125f15d0ac479391454661dc69"` [INFO] running `"docker" "rm" "-f" "af9d8ca4696f93ceb79d540d1e44be1c30c7bf125f15d0ac479391454661dc69"` [INFO] [stdout] af9d8ca4696f93ceb79d540d1e44be1c30c7bf125f15d0ac479391454661dc69