[INFO] crate citadel 0.2.0 is already in cache
[INFO] extracting crate citadel 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/citadel/0.2.0
[INFO] extracting crate citadel 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/citadel/0.2.0
[INFO] validating manifest of citadel-0.2.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of citadel-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing citadel-0.2.0
[INFO] finished frobbing citadel-0.2.0
[INFO] frobbed toml for citadel-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/citadel/0.2.0/Cargo.toml
[INFO] started frobbing citadel-0.2.0
[INFO] finished frobbing citadel-0.2.0
[INFO] frobbed toml for citadel-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/citadel/0.2.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting citadel-0.2.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/citadel/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 77a46641a2e531efec6135e18d75775d99e6eb50cac2e8d98e117b4ba66e78d8
[INFO] running `"docker" "start" "-a" "77a46641a2e531efec6135e18d75775d99e6eb50cac2e8d98e117b4ba66e78d8"`
[INFO] [stderr]     Checking citadel v0.2.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/access/stat.rs:20:5
[INFO] [stderr]    |
[INFO] [stderr] 20 |     return collector;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `collector`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/access/encompassing.rs:49:5
[INFO] [stderr]    |
[INFO] [stderr] 49 |     return collected;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `collected`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/prelude.rs:38:9
[INFO] [stderr]    |
[INFO] [stderr] 38 |         return collector.clone();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `collector.clone()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/access/stat.rs:20:5
[INFO] [stderr]    |
[INFO] [stderr] 20 |     return collector;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `collector`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/access/encompassing.rs:49:5
[INFO] [stderr]    |
[INFO] [stderr] 49 |     return collected;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `collected`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `super::*`
[INFO] [stderr]  --> src/modify/mod.rs:9:9
[INFO] [stderr]   |
[INFO] [stderr] 9 |     use super::*;
[INFO] [stderr]   |         ^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/prelude.rs:38:9
[INFO] [stderr]    |
[INFO] [stderr] 38 |         return collector.clone();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `collector.clone()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `counter` is used to index `list`
[INFO] [stderr]   --> src/access/stat.rs:14:20
[INFO] [stderr]    |
[INFO] [stderr] 14 |     for counter in 0 .. list.len() {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 14 |     for (counter, <item>) in list.iter().enumerate() {
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/access/stat.rs:16:28
[INFO] [stderr]    |
[INFO] [stderr] 16 |             collector.push(counter.clone() as i32);
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `counter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/access/encompassing.rs:27:13
[INFO] [stderr]    |
[INFO] [stderr] 27 |             nesting_level = nesting_level + 1;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `nesting_level += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/access/encompassing.rs:35:17
[INFO] [stderr]    |
[INFO] [stderr] 35 |                 nesting_level = nesting_level - 1;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `nesting_level -= 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/access/encompassing.rs:36:23
[INFO] [stderr]    |
[INFO] [stderr] 36 |             } else if current_collection.len() > 0 {//If it's collecting, and is now 0, a scope is complete
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!current_collection.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `index` is only used to index `list`.
[INFO] [stderr]   --> src/prelude.rs:15:18
[INFO] [stderr]    |
[INFO] [stderr] 15 |     for index in bound1 .. bound2 + 1 {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 15 |     for <item> in list.iter().take(bound2 + 1).skip(bound1) {
[INFO] [stderr]    |         ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/prelude.rs:15:18
[INFO] [stderr]    |
[INFO] [stderr] 15 |     for index in bound1 .. bound2 + 1 {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^ help: use: `bound1..=bound2`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `counter` is used to index `list`
[INFO] [stderr]   --> src/access/stat.rs:14:20
[INFO] [stderr]    |
[INFO] [stderr] 14 |     for counter in 0 .. list.len() {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 14 |     for (counter, <item>) in list.iter().enumerate() {
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/access/stat.rs:16:28
[INFO] [stderr]    |
[INFO] [stderr] 16 |             collector.push(counter.clone() as i32);
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `counter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/access/encompassing.rs:27:13
[INFO] [stderr]    |
[INFO] [stderr] 27 |             nesting_level = nesting_level + 1;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `nesting_level += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/access/encompassing.rs:35:17
[INFO] [stderr]    |
[INFO] [stderr] 35 |                 nesting_level = nesting_level - 1;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `nesting_level -= 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/access/encompassing.rs:36:23
[INFO] [stderr]    |
[INFO] [stderr] 36 |             } else if current_collection.len() > 0 {//If it's collecting, and is now 0, a scope is complete
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!current_collection.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `index` is only used to index `list`.
[INFO] [stderr]   --> src/prelude.rs:15:18
[INFO] [stderr]    |
[INFO] [stderr] 15 |     for index in bound1 .. bound2 + 1 {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 15 |     for <item> in list.iter().take(bound2 + 1).skip(bound1) {
[INFO] [stderr]    |         ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/prelude.rs:15:18
[INFO] [stderr]    |
[INFO] [stderr] 15 |     for index in bound1 .. bound2 + 1 {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^ help: use: `bound1..=bound2`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.65s
[INFO] running `"docker" "inspect" "77a46641a2e531efec6135e18d75775d99e6eb50cac2e8d98e117b4ba66e78d8"`
[INFO] running `"docker" "rm" "-f" "77a46641a2e531efec6135e18d75775d99e6eb50cac2e8d98e117b4ba66e78d8"`
[INFO] [stdout] 77a46641a2e531efec6135e18d75775d99e6eb50cac2e8d98e117b4ba66e78d8