[INFO] crate char_stream 0.1.8 is already in cache [INFO] extracting crate char_stream 0.1.8 into work/ex/clippy-test-run/sources/stable/reg/char_stream/0.1.8 [INFO] extracting crate char_stream 0.1.8 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/char_stream/0.1.8 [INFO] validating manifest of char_stream-0.1.8 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of char_stream-0.1.8 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing char_stream-0.1.8 [INFO] finished frobbing char_stream-0.1.8 [INFO] frobbed toml for char_stream-0.1.8 written to work/ex/clippy-test-run/sources/stable/reg/char_stream/0.1.8/Cargo.toml [INFO] started frobbing char_stream-0.1.8 [INFO] finished frobbing char_stream-0.1.8 [INFO] frobbed toml for char_stream-0.1.8 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/char_stream/0.1.8/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting char_stream-0.1.8 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/char_stream/0.1.8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5319bc18cf1365489e0b94e722e6e524af828f03797a80cf68523887a05556b3 [INFO] running `"docker" "start" "-a" "5319bc18cf1365489e0b94e722e6e524af828f03797a80cf68523887a05556b3"` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] Compiling libc v0.2.48 [INFO] [stderr] Checking char_stream v0.1.8 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internals/char_vec.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | chars: chars, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `chars` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internals/char_vec.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | back_index: back_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `back_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internals/file.rs:18:17 [INFO] [stderr] | [INFO] [stderr] 18 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internals/file.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/internals/stdin.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | stdin: stdin, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stdin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/wend_iter.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | chars: chars [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `chars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error[E0602]: unknown lint: `clippy::into_iter_on_array` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into_iter_on_array` [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0602`. [INFO] [stderr] error: Could not compile `libc`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/internals/char_vec.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | / let mut back_index = None; [INFO] [stderr] 12 | | if len > 0 { [INFO] [stderr] 13 | | back_index = Some(len - 1); [INFO] [stderr] 14 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let back_index = if len > 0 { Some(len - 1) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/internals/char_vec.rs:41:16 [INFO] [stderr] | [INFO] [stderr] 41 | if let None = self.back_index { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 42 | | return None; [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________- help: try this: `if self.back_index.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/internals/char_vec.rs:56:16 [INFO] [stderr] | [INFO] [stderr] 56 | if let None = self.back_index { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 57 | | return None; [INFO] [stderr] 58 | | } [INFO] [stderr] | |_________- help: try this: `if self.back_index.is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/internals/file.rs:73:20 [INFO] [stderr] | [INFO] [stderr] 73 | if let None = char_vec.peek() { [INFO] [stderr] | _____________- ^^^^ [INFO] [stderr] 74 | | need_read = true; [INFO] [stderr] 75 | | } [INFO] [stderr] | |_____________- help: try this: `if char_vec.peek().is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/internals/file.rs:86:16 [INFO] [stderr] | [INFO] [stderr] 86 | if let Ok(_) = self.reader.read_line(&mut buffer) { [INFO] [stderr] | _________- ^^^^^ [INFO] [stderr] 87 | | let char_vec = InternalCharVec::new(buffer.chars().collect()); [INFO] [stderr] 88 | | self.buf = Some(char_vec); [INFO] [stderr] 89 | | }else{ [INFO] [stderr] 90 | | self.is_eof = true; [INFO] [stderr] 91 | | } [INFO] [stderr] | |_________- help: try this: `if self.reader.read_line(&mut buffer).is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/internals/stdin.rs:34:20 [INFO] [stderr] | [INFO] [stderr] 34 | if let None = char_vec.peek() { [INFO] [stderr] | _____________- ^^^^ [INFO] [stderr] 35 | | self.need_read = true; [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____________- help: try this: `if char_vec.peek().is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/internals/stdin.rs:64:16 [INFO] [stderr] | [INFO] [stderr] 64 | if let Err(_) = self.stdin.read_line(&mut input) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 65 | | self.is_eof = true; [INFO] [stderr] 66 | | self.buf = None; [INFO] [stderr] 67 | | self.need_read = false; [INFO] [stderr] 68 | | return; [INFO] [stderr] 69 | | } [INFO] [stderr] | |_________- help: try this: `if self.stdin.read_line(&mut input).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/wend_iter.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match self { [INFO] [stderr] 22 | | &mut WendIterator::Chars { ref mut chars } => { [INFO] [stderr] 23 | | chars.next() [INFO] [stderr] 24 | | }, [INFO] [stderr] 25 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 21 | match *self { [INFO] [stderr] 22 | WendIterator::Chars { ref mut chars } => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/wend_iter.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | / match self { [INFO] [stderr] 32 | | &mut WendIterator::Chars { ref mut chars } => { [INFO] [stderr] 33 | | chars.next_back() [INFO] [stderr] 34 | | }, [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 31 | match *self { [INFO] [stderr] 32 | WendIterator::Chars { ref mut chars } => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:194:9 [INFO] [stderr] | [INFO] [stderr] 194 | / match self { [INFO] [stderr] 195 | | &mut CharStream::Chars { ref mut chars } => { [INFO] [stderr] 196 | | chars.peek() [INFO] [stderr] 197 | | }, [INFO] [stderr] ... | [INFO] [stderr] 203 | | }, [INFO] [stderr] 204 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 194 | match *self { [INFO] [stderr] 195 | CharStream::Chars { ref mut chars } => { [INFO] [stderr] 196 | chars.peek() [INFO] [stderr] 197 | }, [INFO] [stderr] 198 | CharStream::File { ref mut file } => { [INFO] [stderr] 199 | file.peek() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/lib.rs:227:16 [INFO] [stderr] | [INFO] [stderr] 227 | if let None = self.peek() { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 228 | | return None; [INFO] [stderr] 229 | | } [INFO] [stderr] | |_________- help: try this: `if self.peek().is_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:269:22 [INFO] [stderr] | [INFO] [stderr] 269 | pub fn to_string(&mut self) -> String { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/lib.rs:272:29 [INFO] [stderr] | [INFO] [stderr] 272 | while let Some(c) = self.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for c in self { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:319:9 [INFO] [stderr] | [INFO] [stderr] 319 | / match self { [INFO] [stderr] 320 | | &mut CharStream::Chars { ref mut chars } => { [INFO] [stderr] 321 | | chars.next() [INFO] [stderr] 322 | | }, [INFO] [stderr] ... | [INFO] [stderr] 328 | | }, [INFO] [stderr] 329 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 319 | match *self { [INFO] [stderr] 320 | CharStream::Chars { ref mut chars } => { [INFO] [stderr] 321 | chars.next() [INFO] [stderr] 322 | }, [INFO] [stderr] 323 | CharStream::File { ref mut file } => { [INFO] [stderr] 324 | file.next() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "5319bc18cf1365489e0b94e722e6e524af828f03797a80cf68523887a05556b3"` [INFO] running `"docker" "rm" "-f" "5319bc18cf1365489e0b94e722e6e524af828f03797a80cf68523887a05556b3"` [INFO] [stdout] 5319bc18cf1365489e0b94e722e6e524af828f03797a80cf68523887a05556b3