[INFO] crate cdrom_crc 0.1.0 is already in cache [INFO] extracting crate cdrom_crc 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/cdrom_crc/0.1.0 [INFO] extracting crate cdrom_crc 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cdrom_crc/0.1.0 [INFO] validating manifest of cdrom_crc-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cdrom_crc-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cdrom_crc-0.1.0 [INFO] finished frobbing cdrom_crc-0.1.0 [INFO] frobbed toml for cdrom_crc-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/cdrom_crc/0.1.0/Cargo.toml [INFO] started frobbing cdrom_crc-0.1.0 [INFO] finished frobbing cdrom_crc-0.1.0 [INFO] frobbed toml for cdrom_crc-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cdrom_crc/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cdrom_crc-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cdrom_crc/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 74846272b797b5e9b7109ba012d011343a460ecbe3fbc0765024e5bed24eaa57 [INFO] running `"docker" "start" "-a" "74846272b797b5e9b7109ba012d011343a460ecbe3fbc0765024e5bed24eaa57"` [INFO] [stderr] Checking cdrom_crc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:639:5 [INFO] [stderr] | [INFO] [stderr] 639 | return ((s) & CRC16_BITMASK) ^ CRC16_XOR_OUTPUT; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `((s) & CRC16_BITMASK) ^ CRC16_XOR_OUTPUT` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:639:5 [INFO] [stderr] | [INFO] [stderr] 639 | return ((s) & CRC16_BITMASK) ^ CRC16_XOR_OUTPUT; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `((s) & CRC16_BITMASK) ^ CRC16_XOR_OUTPUT` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:617:24 [INFO] [stderr] | [INFO] [stderr] 617 | s = TABLE[15][(p[ 0] as u16 ^ (s >> 8)) as u8 as usize] ^ [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(p[ 0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:618:24 [INFO] [stderr] | [INFO] [stderr] 618 | TABLE[14][(p[ 1] as u16 ^ (s >> 0)) as u8 as usize] ^ [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(p[ 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `s` [INFO] [stderr] --> src/lib.rs:618:39 [INFO] [stderr] | [INFO] [stderr] 618 | TABLE[14][(p[ 1] as u16 ^ (s >> 0)) as u8 as usize] ^ [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:636:23 [INFO] [stderr] | [INFO] [stderr] 636 | s = TABLE[0][(*p as u16 ^ (s >> 8)) as usize] ^ (s << 8); [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(*p)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:617:24 [INFO] [stderr] | [INFO] [stderr] 617 | s = TABLE[15][(p[ 0] as u16 ^ (s >> 8)) as u8 as usize] ^ [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(p[ 0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:618:24 [INFO] [stderr] | [INFO] [stderr] 618 | TABLE[14][(p[ 1] as u16 ^ (s >> 0)) as u8 as usize] ^ [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(p[ 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `s` [INFO] [stderr] --> src/lib.rs:618:39 [INFO] [stderr] | [INFO] [stderr] 618 | TABLE[14][(p[ 1] as u16 ^ (s >> 0)) as u8 as usize] ^ [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:636:23 [INFO] [stderr] | [INFO] [stderr] 636 | s = TABLE[0][(*p as u16 ^ (s >> 8)) as usize] ^ (s << 8); [INFO] [stderr] | ^^^^^^^^^ help: try: `u16::from(*p)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.85s [INFO] running `"docker" "inspect" "74846272b797b5e9b7109ba012d011343a460ecbe3fbc0765024e5bed24eaa57"` [INFO] running `"docker" "rm" "-f" "74846272b797b5e9b7109ba012d011343a460ecbe3fbc0765024e5bed24eaa57"` [INFO] [stdout] 74846272b797b5e9b7109ba012d011343a460ecbe3fbc0765024e5bed24eaa57