[INFO] crate cassowary 0.3.0 is already in cache [INFO] extracting crate cassowary 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/cassowary/0.3.0 [INFO] extracting crate cassowary 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cassowary/0.3.0 [INFO] validating manifest of cassowary-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cassowary-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cassowary-0.3.0 [INFO] finished frobbing cassowary-0.3.0 [INFO] frobbed toml for cassowary-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/cassowary/0.3.0/Cargo.toml [INFO] started frobbing cassowary-0.3.0 [INFO] finished frobbing cassowary-0.3.0 [INFO] frobbed toml for cassowary-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cassowary/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cassowary-0.3.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cassowary/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 367ba8baaf8a0a0d08653df5bb391a2dd2ad3d598bc3e885d8d9ad19032841d4 [INFO] running `"docker" "start" "-a" "367ba8baaf8a0a0d08653df5bb391a2dd2ad3d598bc3e885d8d9ad19032841d4"` [INFO] [stderr] Checking cassowary v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:262:13 [INFO] [stderr] | [INFO] [stderr] 262 | variable: variable, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `variable` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:263:13 [INFO] [stderr] | [INFO] [stderr] 263 | coefficient: coefficient [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `coefficient` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:295:13 [INFO] [stderr] | [INFO] [stderr] 295 | terms: terms, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `terms` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:296:13 [INFO] [stderr] | [INFO] [stderr] 296 | constant: constant [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `constant` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:404:13 [INFO] [stderr] | [INFO] [stderr] 404 | op: op, [INFO] [stderr] | ^^^^^^ help: replace it with: `op` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:405:13 [INFO] [stderr] | [INFO] [stderr] 405 | strength: strength [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `strength` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:499:13 [INFO] [stderr] | [INFO] [stderr] 499 | constant: constant [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `constant` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:262:13 [INFO] [stderr] | [INFO] [stderr] 262 | variable: variable, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `variable` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:263:13 [INFO] [stderr] | [INFO] [stderr] 263 | coefficient: coefficient [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `coefficient` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:295:13 [INFO] [stderr] | [INFO] [stderr] 295 | terms: terms, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `terms` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:296:13 [INFO] [stderr] | [INFO] [stderr] 296 | constant: constant [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `constant` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:404:13 [INFO] [stderr] | [INFO] [stderr] 404 | op: op, [INFO] [stderr] | ^^^^^^ help: replace it with: `op` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:405:13 [INFO] [stderr] | [INFO] [stderr] 405 | strength: strength [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `strength` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:499:13 [INFO] [stderr] | [INFO] [stderr] 499 | constant: constant [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `constant` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solver_impl.rs:287:9 [INFO] [stderr] | [INFO] [stderr] 287 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/solver_impl.rs:471:9 [INFO] [stderr] | [INFO] [stderr] 471 | / if tag.marker.type_() == SymbolType::Slack || tag.marker.type_() == SymbolType::Error { [INFO] [stderr] 472 | | if row.coefficient_for(tag.marker) < 0.0 { [INFO] [stderr] 473 | | return tag.marker; [INFO] [stderr] 474 | | } [INFO] [stderr] 475 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 471 | if (tag.marker.type_() == SymbolType::Slack || tag.marker.type_() == SymbolType::Error) && row.coefficient_for(tag.marker) < 0.0 { [INFO] [stderr] 472 | return tag.marker; [INFO] [stderr] 473 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/solver_impl.rs:476:9 [INFO] [stderr] | [INFO] [stderr] 476 | / if tag.other.type_() == SymbolType::Slack || tag.other.type_() == SymbolType::Error { [INFO] [stderr] 477 | | if row.coefficient_for(tag.other) < 0.0 { [INFO] [stderr] 478 | | return tag.other; [INFO] [stderr] 479 | | } [INFO] [stderr] 480 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 476 | if (tag.other.type_() == SymbolType::Slack || tag.other.type_() == SymbolType::Error) && row.coefficient_for(tag.other) < 0.0 { [INFO] [stderr] 477 | return tag.other; [INFO] [stderr] 478 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solver_impl.rs:287:9 [INFO] [stderr] | [INFO] [stderr] 287 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/solver_impl.rs:471:9 [INFO] [stderr] | [INFO] [stderr] 471 | / if tag.marker.type_() == SymbolType::Slack || tag.marker.type_() == SymbolType::Error { [INFO] [stderr] 472 | | if row.coefficient_for(tag.marker) < 0.0 { [INFO] [stderr] 473 | | return tag.marker; [INFO] [stderr] 474 | | } [INFO] [stderr] 475 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 471 | if (tag.marker.type_() == SymbolType::Slack || tag.marker.type_() == SymbolType::Error) && row.coefficient_for(tag.marker) < 0.0 { [INFO] [stderr] 472 | return tag.marker; [INFO] [stderr] 473 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/solver_impl.rs:476:9 [INFO] [stderr] | [INFO] [stderr] 476 | / if tag.other.type_() == SymbolType::Slack || tag.other.type_() == SymbolType::Error { [INFO] [stderr] 477 | | if row.coefficient_for(tag.other) < 0.0 { [INFO] [stderr] 478 | | return tag.other; [INFO] [stderr] 479 | | } [INFO] [stderr] 480 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 476 | if (tag.other.type_() == SymbolType::Slack || tag.other.type_() == SymbolType::Error) && row.coefficient_for(tag.other) < 0.0 { [INFO] [stderr] 477 | return tag.other; [INFO] [stderr] 478 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `solver_impl::Solver` [INFO] [stderr] --> src/solver_impl.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | / pub fn new() -> Solver { [INFO] [stderr] 56 | | Solver { [INFO] [stderr] 57 | | cns: HashMap::new(), [INFO] [stderr] 58 | | var_data: HashMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 53 | impl Default for solver_impl::Solver { [INFO] [stderr] 54 | fn default() -> Self { [INFO] [stderr] 55 | Self::new() [INFO] [stderr] 56 | } [INFO] [stderr] 57 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/solver_impl.rs:150:16 [INFO] [stderr] | [INFO] [stderr] 150 | if let None = self.rows.remove(&tag.marker) { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 151 | | let (leaving, mut row) = try!(self.get_marker_leaving_row(tag.marker) [INFO] [stderr] 152 | | .ok_or( [INFO] [stderr] 153 | | RemoveConstraintError::InternalSolverError( [INFO] [stderr] ... | [INFO] [stderr] 156 | | self.substitute(tag.marker, &row); [INFO] [stderr] 157 | | } [INFO] [stderr] | |_________- help: try this: `if self.rows.remove(&tag.marker).is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/solver_impl.rs:200:66 [INFO] [stderr] | [INFO] [stderr] 200 | let cn = Constraint::new(Expression::from_term(Term::new(v.clone(), 1.0)), [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/solver_impl.rs:204:27 [INFO] [stderr] | [INFO] [stderr] 204 | self.edits.insert(v.clone(), EditInfo { [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/solver_impl.rs:205:18 [INFO] [stderr] | [INFO] [stderr] 205 | tag: self.cns[&cn].clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.cns[&cn]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/solver_impl.rs:229:40 [INFO] [stderr] | [INFO] [stderr] 229 | pub fn has_edit_variable(&self, v: &Variable) -> bool { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Variable` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/solver_impl.rs:262:13 [INFO] [stderr] | [INFO] [stderr] 262 | / { [INFO] [stderr] 263 | | [INFO] [stderr] 264 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/solver_impl.rs:255:13 [INFO] [stderr] | [INFO] [stderr] 255 | / { [INFO] [stderr] 256 | | [INFO] [stderr] 257 | | } else if self.rows.get_mut(&info_tag_other) [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/solver_impl.rs:314:20 [INFO] [stderr] | [INFO] [stderr] 314 | if old_value != new_value { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(old_value - new_value).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/solver_impl.rs:314:20 [INFO] [stderr] | [INFO] [stderr] 314 | if old_value != new_value { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/solver_impl.rs:517:25 [INFO] [stderr] | [INFO] [stderr] 517 | for (_, row) in &mut self.rows { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 517 | for row in self.rows.values_mut() { [INFO] [stderr] | ^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `solver_impl::Solver` [INFO] [stderr] --> src/solver_impl.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | / pub fn new() -> Solver { [INFO] [stderr] 56 | | Solver { [INFO] [stderr] 57 | | cns: HashMap::new(), [INFO] [stderr] 58 | | var_data: HashMap::new(), [INFO] [stderr] ... | [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 53 | impl Default for solver_impl::Solver { [INFO] [stderr] 54 | fn default() -> Self { [INFO] [stderr] 55 | Self::new() [INFO] [stderr] 56 | } [INFO] [stderr] 57 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | (self as f64).bitor(r) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(self)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/operators.rs:40:27 [INFO] [stderr] | [INFO] [stderr] 40 | PartialConstraint(self.into(), r) [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:54:20 [INFO] [stderr] | [INFO] [stderr] 54 | self.bitor(rhs as f64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(rhs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:91:18 [INFO] [stderr] | [INFO] [stderr] 91 | self.add(v as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | (self as f64).add(v) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:163:18 [INFO] [stderr] | [INFO] [stderr] 163 | self.sub(v as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/solver_impl.rs:150:16 [INFO] [stderr] | [INFO] [stderr] 150 | if let None = self.rows.remove(&tag.marker) { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 151 | | let (leaving, mut row) = try!(self.get_marker_leaving_row(tag.marker) [INFO] [stderr] 152 | | .ok_or( [INFO] [stderr] 153 | | RemoveConstraintError::InternalSolverError( [INFO] [stderr] ... | [INFO] [stderr] 156 | | self.substitute(tag.marker, &row); [INFO] [stderr] 157 | | } [INFO] [stderr] | |_________- help: try this: `if self.rows.remove(&tag.marker).is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:177:9 [INFO] [stderr] | [INFO] [stderr] 177 | (self as f64).sub(v) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/solver_impl.rs:200:66 [INFO] [stderr] | [INFO] [stderr] 200 | let cn = Constraint::new(Expression::from_term(Term::new(v.clone(), 1.0)), [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:229:18 [INFO] [stderr] | [INFO] [stderr] 229 | self.mul(v as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/solver_impl.rs:204:27 [INFO] [stderr] | [INFO] [stderr] 204 | self.edits.insert(v.clone(), EditInfo { [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/solver_impl.rs:205:18 [INFO] [stderr] | [INFO] [stderr] 205 | tag: self.cns[&cn].clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.cns[&cn]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:243:9 [INFO] [stderr] | [INFO] [stderr] 243 | (self as f64).mul(v) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:257:18 [INFO] [stderr] | [INFO] [stderr] 257 | self.div(v as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:274:18 [INFO] [stderr] | [INFO] [stderr] 274 | self.mul(v as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/solver_impl.rs:229:40 [INFO] [stderr] | [INFO] [stderr] 229 | pub fn has_edit_variable(&self, v: &Variable) -> bool { [INFO] [stderr] | ^^^^^^^^^ help: consider passing by value instead: `Variable` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:289:9 [INFO] [stderr] | [INFO] [stderr] 289 | (self as f64).mul(t) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:304:18 [INFO] [stderr] | [INFO] [stderr] 304 | self.div(v as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:318:18 [INFO] [stderr] | [INFO] [stderr] 318 | self.add(v as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/solver_impl.rs:262:13 [INFO] [stderr] | [INFO] [stderr] 262 | / { [INFO] [stderr] 263 | | [INFO] [stderr] 264 | | } else { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/solver_impl.rs:255:13 [INFO] [stderr] | [INFO] [stderr] 255 | / { [INFO] [stderr] 256 | | [INFO] [stderr] 257 | | } else if self.rows.get_mut(&info_tag_other) [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:332:9 [INFO] [stderr] | [INFO] [stderr] 332 | (self as f64).add(t) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:377:18 [INFO] [stderr] | [INFO] [stderr] 377 | self.sub(v as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:391:9 [INFO] [stderr] | [INFO] [stderr] 391 | (self as f64).sub(t) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/solver_impl.rs:314:20 [INFO] [stderr] | [INFO] [stderr] 314 | if old_value != new_value { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(old_value - new_value).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/solver_impl.rs:314:20 [INFO] [stderr] | [INFO] [stderr] 314 | if old_value != new_value { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:435:18 [INFO] [stderr] | [INFO] [stderr] 435 | self.mul(v as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:453:9 [INFO] [stderr] | [INFO] [stderr] 453 | (self as f64).mul(e) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:471:18 [INFO] [stderr] | [INFO] [stderr] 471 | self.div(v as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:486:18 [INFO] [stderr] | [INFO] [stderr] 486 | self.add(v as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:501:9 [INFO] [stderr] | [INFO] [stderr] 501 | (self as f64).add(e) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:533:18 [INFO] [stderr] | [INFO] [stderr] 533 | self.sub(v as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:549:9 [INFO] [stderr] | [INFO] [stderr] 549 | (self as f64).sub(e) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/solver_impl.rs:517:25 [INFO] [stderr] | [INFO] [stderr] 517 | for (_, row) in &mut self.rows { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 517 | for row in self.rows.values_mut() { [INFO] [stderr] | ^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Variable` [INFO] [stderr] --> src/lib.rs:245:5 [INFO] [stderr] | [INFO] [stderr] 245 | / pub fn new() -> Variable { [INFO] [stderr] 246 | | Variable(VARIABLE_ID.fetch_add(1, ::std::sync::atomic::Ordering::Relaxed)) [INFO] [stderr] 247 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 241 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | (self as f64).bitor(r) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(self)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/operators.rs:40:27 [INFO] [stderr] | [INFO] [stderr] 40 | PartialConstraint(self.into(), r) [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:54:20 [INFO] [stderr] | [INFO] [stderr] 54 | self.bitor(rhs as f64) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(rhs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:91:18 [INFO] [stderr] | [INFO] [stderr] 91 | self.add(v as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | (self as f64).add(v) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:163:18 [INFO] [stderr] | [INFO] [stderr] 163 | self.sub(v as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:177:9 [INFO] [stderr] | [INFO] [stderr] 177 | (self as f64).sub(v) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:229:18 [INFO] [stderr] | [INFO] [stderr] 229 | self.mul(v as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:243:9 [INFO] [stderr] | [INFO] [stderr] 243 | (self as f64).mul(v) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:257:18 [INFO] [stderr] | [INFO] [stderr] 257 | self.div(v as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:274:18 [INFO] [stderr] | [INFO] [stderr] 274 | self.mul(v as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:289:9 [INFO] [stderr] | [INFO] [stderr] 289 | (self as f64).mul(t) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:304:18 [INFO] [stderr] | [INFO] [stderr] 304 | self.div(v as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:318:18 [INFO] [stderr] | [INFO] [stderr] 318 | self.add(v as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:332:9 [INFO] [stderr] | [INFO] [stderr] 332 | (self as f64).add(t) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:377:18 [INFO] [stderr] | [INFO] [stderr] 377 | self.sub(v as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/lib.rs:535:23 [INFO] [stderr] | [INFO] [stderr] 535 | for (_, v) in &mut self.cells { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 535 | for v in self.cells.values_mut() { [INFO] [stderr] | ^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:391:9 [INFO] [stderr] | [INFO] [stderr] 391 | (self as f64).sub(t) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/lib.rs:546:23 [INFO] [stderr] | [INFO] [stderr] 546 | for (_, v) in &mut self.cells { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 546 | for v in self.cells.values_mut() { [INFO] [stderr] | ^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:435:18 [INFO] [stderr] | [INFO] [stderr] 435 | self.mul(v as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:453:9 [INFO] [stderr] | [INFO] [stderr] 453 | (self as f64).mul(e) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:471:18 [INFO] [stderr] | [INFO] [stderr] 471 | self.div(v as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:486:18 [INFO] [stderr] | [INFO] [stderr] 486 | self.add(v as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:501:9 [INFO] [stderr] | [INFO] [stderr] 501 | (self as f64).add(e) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:533:18 [INFO] [stderr] | [INFO] [stderr] 533 | self.sub(v as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/operators.rs:549:9 [INFO] [stderr] | [INFO] [stderr] 549 | (self as f64).sub(e) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Variable` [INFO] [stderr] --> src/lib.rs:245:5 [INFO] [stderr] | [INFO] [stderr] 245 | / pub fn new() -> Variable { [INFO] [stderr] 246 | | Variable(VARIABLE_ID.fetch_add(1, ::std::sync::atomic::Ordering::Relaxed)) [INFO] [stderr] 247 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 241 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: Could not compile `cassowary`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/lib.rs:535:23 [INFO] [stderr] | [INFO] [stderr] 535 | for (_, v) in &mut self.cells { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 535 | for v in self.cells.values_mut() { [INFO] [stderr] | ^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/lib.rs:546:23 [INFO] [stderr] | [INFO] [stderr] 546 | for (_, v) in &mut self.cells { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 546 | for v in self.cells.values_mut() { [INFO] [stderr] | ^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `cassowary`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "367ba8baaf8a0a0d08653df5bb391a2dd2ad3d598bc3e885d8d9ad19032841d4"` [INFO] running `"docker" "rm" "-f" "367ba8baaf8a0a0d08653df5bb391a2dd2ad3d598bc3e885d8d9ad19032841d4"` [INFO] [stdout] 367ba8baaf8a0a0d08653df5bb391a2dd2ad3d598bc3e885d8d9ad19032841d4