[INFO] crate cargo-version 0.1.2 is already in cache [INFO] extracting crate cargo-version 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/cargo-version/0.1.2 [INFO] extracting crate cargo-version 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-version/0.1.2 [INFO] validating manifest of cargo-version-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cargo-version-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cargo-version-0.1.2 [INFO] finished frobbing cargo-version-0.1.2 [INFO] frobbed toml for cargo-version-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/cargo-version/0.1.2/Cargo.toml [INFO] started frobbing cargo-version-0.1.2 [INFO] finished frobbing cargo-version-0.1.2 [INFO] frobbed toml for cargo-version-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-version/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cargo-version-0.1.2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-version/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b27fea7e9e4b2ea27003d77dcd93474ee2c10d1cdf7b4406097383caaa542b1a [INFO] running `"docker" "start" "-a" "b27fea7e9e4b2ea27003d77dcd93474ee2c10d1cdf7b4406097383caaa542b1a"` [INFO] [stderr] Checking cargo-version v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bump_level.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | return Err(BumpLevelError::InvalidInput(String::from(s))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(BumpLevelError::InvalidInput(String::from(s)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bump_level.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | return Err(BumpLevelError::InvalidInput(String::from(s))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(BumpLevelError::InvalidInput(String::from(s)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bump_level.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | / match Version::parse(s) { [INFO] [stderr] 33 | | Ok(version) => return Ok(BumpLevel::Specific(version)), [INFO] [stderr] 34 | | _ => {} [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________^ help: try this: `if let Ok(version) = Version::parse(s) { return Ok(BumpLevel::Specific(version)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bump_level.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | / match Version::parse(s) { [INFO] [stderr] 33 | | Ok(version) => return Ok(BumpLevel::Specific(version)), [INFO] [stderr] 34 | | _ => {} [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________^ help: try this: `if let Ok(version) = Version::parse(s) { return Ok(BumpLevel::Specific(version)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/toml.rs:38:46 [INFO] [stderr] | [INFO] [stderr] 38 | let file = try!(File::open(path).map(|file| BufReader::new(file))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BufReader::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/toml.rs:52:60 [INFO] [stderr] | [INFO] [stderr] 52 | let input_file = try!(File::open(path_ref).map(|file| BufReader::new(file))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BufReader::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/toml.rs:38:46 [INFO] [stderr] | [INFO] [stderr] 38 | let file = try!(File::open(path).map(|file| BufReader::new(file))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BufReader::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/toml.rs:52:60 [INFO] [stderr] | [INFO] [stderr] 52 | let input_file = try!(File::open(path_ref).map(|file| BufReader::new(file))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BufReader::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:41:23 [INFO] [stderr] | [INFO] [stderr] 41 | .map(|output| output.stdout.len() > 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!output.stdout.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:41:23 [INFO] [stderr] | [INFO] [stderr] 41 | .map(|output| output.stdout.len() > 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!output.stdout.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.19s [INFO] running `"docker" "inspect" "b27fea7e9e4b2ea27003d77dcd93474ee2c10d1cdf7b4406097383caaa542b1a"` [INFO] running `"docker" "rm" "-f" "b27fea7e9e4b2ea27003d77dcd93474ee2c10d1cdf7b4406097383caaa542b1a"` [INFO] [stdout] b27fea7e9e4b2ea27003d77dcd93474ee2c10d1cdf7b4406097383caaa542b1a