[INFO] crate cargo-fancy 0.1.0 is already in cache [INFO] extracting crate cargo-fancy 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/cargo-fancy/0.1.0 [INFO] extracting crate cargo-fancy 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-fancy/0.1.0 [INFO] validating manifest of cargo-fancy-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cargo-fancy-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cargo-fancy-0.1.0 [INFO] finished frobbing cargo-fancy-0.1.0 [INFO] frobbed toml for cargo-fancy-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/cargo-fancy/0.1.0/Cargo.toml [INFO] started frobbing cargo-fancy-0.1.0 [INFO] finished frobbing cargo-fancy-0.1.0 [INFO] frobbed toml for cargo-fancy-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-fancy/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cargo-fancy-0.1.0 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cargo-fancy/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6340af23a96bbd40c1cfe009869d3699e6375ff8c203a24fdc7f750deaafd30d [INFO] running `"docker" "start" "-a" "6340af23a96bbd40c1cfe009869d3699e6375ff8c203a24fdc7f750deaafd30d"` [INFO] [stderr] Checking cargo-fancy v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:241:9 [INFO] [stderr] | [INFO] [stderr] 241 | cx: cx, [INFO] [stderr] | ^^^^^^ help: replace it with: `cx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(self.stdout, "")` [INFO] [stderr] --> src/main.rs:413:17 [INFO] [stderr] | [INFO] [stderr] 413 | writeln!(self.stdout, "").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(self.stdout)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:241:9 [INFO] [stderr] | [INFO] [stderr] 241 | cx: cx, [INFO] [stderr] | ^^^^^^ help: replace it with: `cx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(self.stdout, "")` [INFO] [stderr] --> src/main.rs:413:17 [INFO] [stderr] | [INFO] [stderr] 413 | writeln!(self.stdout, "").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(self.stdout)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:47:45 [INFO] [stderr] | [INFO] [stderr] 47 | .and_then(|s| s.find("\"").map(|i| &s[..i])) [INFO] [stderr] | ^^^^ help: try using a char instead: `'\"'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:130:49 [INFO] [stderr] | [INFO] [stderr] 130 | to_write.extend_from_slice(&buf[..i + 1]); [INFO] [stderr] | ^^^^^^^ help: use: `..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `cnt` [INFO] [stderr] --> src/main.rs:184:21 [INFO] [stderr] | [INFO] [stderr] 184 | (cnt >> 0) as u8, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:218:39 [INFO] [stderr] | [INFO] [stderr] 218 | .unwrap_or(OsString::from("rustc"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| OsString::from("rustc"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:256:16 [INFO] [stderr] | [INFO] [stderr] 256 | if v.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:329:20 [INFO] [stderr] | [INFO] [stderr] 329 | if msg.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `msg.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:336:30 [INFO] [stderr] | [INFO] [stderr] 336 | let a = ((msg[1] as u32) << 24) | [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(msg[1])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:337:30 [INFO] [stderr] | [INFO] [stderr] 337 | ((msg[2] as u32) << 16) | [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(msg[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:338:30 [INFO] [stderr] | [INFO] [stderr] 338 | ((msg[3] as u32) << 8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(msg[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(msg[4] as u32)` [INFO] [stderr] --> src/main.rs:339:29 [INFO] [stderr] | [INFO] [stderr] 339 | ((msg[4] as u32) << 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:339:30 [INFO] [stderr] | [INFO] [stderr] 339 | ((msg[4] as u32) << 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(msg[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:350:21 [INFO] [stderr] | [INFO] [stderr] 350 | / let mut do_print = true; [INFO] [stderr] 351 | | if String::from_utf8_lossy(&msg).contains("Compiling") { [INFO] [stderr] 352 | | do_print = false; [INFO] [stderr] 353 | | } [INFO] [stderr] | |_____________________^ help: it is more idiomatic to write: `let do_print = if String::from_utf8_lossy(&msg).contains("Compiling") { false } else { true };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:379:32 [INFO] [stderr] | [INFO] [stderr] 379 | .unwrap_or(self.lines.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.lines.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:406:46 [INFO] [stderr] | [INFO] [stderr] 406 | if stdout_done && stderr_done && self.on_screen.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.on_screen.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:47:45 [INFO] [stderr] | [INFO] [stderr] 47 | .and_then(|s| s.find("\"").map(|i| &s[..i])) [INFO] [stderr] | ^^^^ help: try using a char instead: `'\"'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:130:49 [INFO] [stderr] | [INFO] [stderr] 130 | to_write.extend_from_slice(&buf[..i + 1]); [INFO] [stderr] | ^^^^^^^ help: use: `..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `cnt` [INFO] [stderr] --> src/main.rs:184:21 [INFO] [stderr] | [INFO] [stderr] 184 | (cnt >> 0) as u8, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:218:39 [INFO] [stderr] | [INFO] [stderr] 218 | .unwrap_or(OsString::from("rustc"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| OsString::from("rustc"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:256:16 [INFO] [stderr] | [INFO] [stderr] 256 | if v.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `v.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:329:20 [INFO] [stderr] | [INFO] [stderr] 329 | if msg.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `msg.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:336:30 [INFO] [stderr] | [INFO] [stderr] 336 | let a = ((msg[1] as u32) << 24) | [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(msg[1])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:337:30 [INFO] [stderr] | [INFO] [stderr] 337 | ((msg[2] as u32) << 16) | [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(msg[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:338:30 [INFO] [stderr] | [INFO] [stderr] 338 | ((msg[3] as u32) << 8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(msg[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(msg[4] as u32)` [INFO] [stderr] --> src/main.rs:339:29 [INFO] [stderr] | [INFO] [stderr] 339 | ((msg[4] as u32) << 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:339:30 [INFO] [stderr] | [INFO] [stderr] 339 | ((msg[4] as u32) << 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(msg[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:350:21 [INFO] [stderr] | [INFO] [stderr] 350 | / let mut do_print = true; [INFO] [stderr] 351 | | if String::from_utf8_lossy(&msg).contains("Compiling") { [INFO] [stderr] 352 | | do_print = false; [INFO] [stderr] 353 | | } [INFO] [stderr] | |_____________________^ help: it is more idiomatic to write: `let do_print = if String::from_utf8_lossy(&msg).contains("Compiling") { false } else { true };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:379:32 [INFO] [stderr] | [INFO] [stderr] 379 | .unwrap_or(self.lines.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.lines.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:406:46 [INFO] [stderr] | [INFO] [stderr] 406 | if stdout_done && stderr_done && self.on_screen.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.on_screen.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.13s [INFO] running `"docker" "inspect" "6340af23a96bbd40c1cfe009869d3699e6375ff8c203a24fdc7f750deaafd30d"` [INFO] running `"docker" "rm" "-f" "6340af23a96bbd40c1cfe009869d3699e6375ff8c203a24fdc7f750deaafd30d"` [INFO] [stdout] 6340af23a96bbd40c1cfe009869d3699e6375ff8c203a24fdc7f750deaafd30d