[INFO] crate canal 0.1.3 is already in cache
[INFO] extracting crate canal 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/canal/0.1.3
[INFO] extracting crate canal 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/canal/0.1.3
[INFO] validating manifest of canal-0.1.3 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of canal-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing canal-0.1.3
[INFO] finished frobbing canal-0.1.3
[INFO] frobbed toml for canal-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/canal/0.1.3/Cargo.toml
[INFO] started frobbing canal-0.1.3
[INFO] finished frobbing canal-0.1.3
[INFO] frobbed toml for canal-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/canal/0.1.3/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting canal-0.1.3 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/canal/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 13cdb9e3d76d06ddd0c256e89b9a7b7e5c62ed17979254501e38e5f8b5f4a904
[INFO] running `"docker" "start" "-a" "13cdb9e3d76d06ddd0c256e89b9a7b7e5c62ed17979254501e38e5f8b5f4a904"`
[INFO] [stderr]     Checking canal v0.1.3 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/broadcast/mod.rs:65:21
[INFO] [stderr]    |
[INFO] [stderr] 65 |         Broadcast { inner: inner }
[INFO] [stderr]    |                     ^^^^^^^^^^^^ help: replace it with: `inner`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/mpmc/mpmc_bounded_queue.rs:95:13
[INFO] [stderr]    |
[INFO] [stderr] 95 |             buffer: buffer,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `buffer`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/mpmc/mod.rs:95:25
[INFO] [stderr]    |
[INFO] [stderr] 95 |     let rc = Receiver { inner: inner };
[INFO] [stderr]    |                         ^^^^^^^^^^^^ help: replace it with: `inner`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/broadcast/mod.rs:65:21
[INFO] [stderr]    |
[INFO] [stderr] 65 |         Broadcast { inner: inner }
[INFO] [stderr]    |                     ^^^^^^^^^^^^ help: replace it with: `inner`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/mpmc/mpmc_bounded_queue.rs:95:13
[INFO] [stderr]    |
[INFO] [stderr] 95 |             buffer: buffer,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: replace it with: `buffer`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/mpmc/mod.rs:95:25
[INFO] [stderr]    |
[INFO] [stderr] 95 |     let rc = Receiver { inner: inner };
[INFO] [stderr]    |                         ^^^^^^^^^^^^ help: replace it with: `inner`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `broadcast::Broadcast<T>`
[INFO] [stderr]   --> src/broadcast/mod.rs:63:5
[INFO] [stderr]    |
[INFO] [stderr] 63 | /     pub fn new() -> Broadcast<T> {
[INFO] [stderr] 64 | |         let inner = Arc::new(Inner { senders: Mutex::new(Vec::new()) });
[INFO] [stderr] 65 | |         Broadcast { inner: inner }
[INFO] [stderr] 66 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 61 | impl Default for broadcast::Broadcast<T> {
[INFO] [stderr] 62 |     fn default() -> Self {
[INFO] [stderr] 63 |         Self::new()
[INFO] [stderr] 64 |     }
[INFO] [stderr] 65 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/mpmc/mutex_linked_list.rs:36:19
[INFO] [stderr]    |
[INFO] [stderr] 36 |             lock: Mutex::new(true),
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::mutex_atomic)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `mpmc::mutex_linked_list::MutexLinkedList<T>`
[INFO] [stderr]   --> src/mpmc/mutex_linked_list.rs:50:5
[INFO] [stderr]    |
[INFO] [stderr] 50 | /     pub fn new() -> MutexLinkedList<T> {
[INFO] [stderr] 51 | |         MutexLinkedList {
[INFO] [stderr] 52 | |             inner: Arc::new(ListInner::new()),
[INFO] [stderr] 53 | |         }
[INFO] [stderr] 54 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 48 | impl Default for mpmc::mutex_linked_list::MutexLinkedList<T> {
[INFO] [stderr] 49 |     fn default() -> Self {
[INFO] [stderr] 50 |         Self::new()
[INFO] [stderr] 51 |     }
[INFO] [stderr] 52 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/mpmc/mutex_linked_list.rs:82:25
[INFO] [stderr]    |
[INFO] [stderr] 82 |             let _lock = self.lock.lock();
[INFO] [stderr]    |                         ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/mpmc/mutex_linked_list.rs:84:24
[INFO] [stderr]    |
[INFO] [stderr] 84 |             let prev = self.head.borrow().clone();
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.head.borrow()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/mpmc/mutex_linked_list.rs:93:25
[INFO] [stderr]    |
[INFO] [stderr] 93 |             let _lock = self.lock.lock();
[INFO] [stderr]    |                         ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/mpmc/channel.rs:112:25
[INFO] [stderr]     |
[INFO] [stderr] 112 | /                         loop {
[INFO] [stderr] 113 | |                             match self.queue.pop() {
[INFO] [stderr] 114 | |                                 Some(..) => {}
[INFO] [stderr] 115 | |                                 None => break,
[INFO] [stderr] 116 | |                             }
[INFO] [stderr] 117 | |                         }
[INFO] [stderr]     | |_________________________^ help: try: `while let Some(..) = self.queue.pop() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/mpmc/channel.rs:232:13
[INFO] [stderr]     |
[INFO] [stderr] 232 | /             loop {
[INFO] [stderr] 233 | |                 match self.queue.pop() {
[INFO] [stderr] 234 | |                     Some(..) => { steals += 1; }
[INFO] [stderr] 235 | |                     None => break,
[INFO] [stderr] 236 | |                 }
[INFO] [stderr] 237 | |             }
[INFO] [stderr]     | |_____________^ help: try: `while let Some(..) = self.queue.pop() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `broadcast::Broadcast<T>`
[INFO] [stderr]   --> src/broadcast/mod.rs:63:5
[INFO] [stderr]    |
[INFO] [stderr] 63 | /     pub fn new() -> Broadcast<T> {
[INFO] [stderr] 64 | |         let inner = Arc::new(Inner { senders: Mutex::new(Vec::new()) });
[INFO] [stderr] 65 | |         Broadcast { inner: inner }
[INFO] [stderr] 66 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 61 | impl Default for broadcast::Broadcast<T> {
[INFO] [stderr] 62 |     fn default() -> Self {
[INFO] [stderr] 63 |         Self::new()
[INFO] [stderr] 64 |     }
[INFO] [stderr] 65 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/mpmc/mutex_linked_list.rs:36:19
[INFO] [stderr]    |
[INFO] [stderr] 36 |             lock: Mutex::new(true),
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::mutex_atomic)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `mpmc::mutex_linked_list::MutexLinkedList<T>`
[INFO] [stderr]   --> src/mpmc/mutex_linked_list.rs:50:5
[INFO] [stderr]    |
[INFO] [stderr] 50 | /     pub fn new() -> MutexLinkedList<T> {
[INFO] [stderr] 51 | |         MutexLinkedList {
[INFO] [stderr] 52 | |             inner: Arc::new(ListInner::new()),
[INFO] [stderr] 53 | |         }
[INFO] [stderr] 54 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 48 | impl Default for mpmc::mutex_linked_list::MutexLinkedList<T> {
[INFO] [stderr] 49 |     fn default() -> Self {
[INFO] [stderr] 50 |         Self::new()
[INFO] [stderr] 51 |     }
[INFO] [stderr] 52 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/mpmc/mutex_linked_list.rs:82:25
[INFO] [stderr]    |
[INFO] [stderr] 82 |             let _lock = self.lock.lock();
[INFO] [stderr]    |                         ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/mpmc/mutex_linked_list.rs:84:24
[INFO] [stderr]    |
[INFO] [stderr] 84 |             let prev = self.head.borrow().clone();
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.head.borrow()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>.
[INFO] [stderr]   --> src/mpmc/mutex_linked_list.rs:93:25
[INFO] [stderr]    |
[INFO] [stderr] 93 |             let _lock = self.lock.lock();
[INFO] [stderr]    |                         ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/mpmc/channel.rs:112:25
[INFO] [stderr]     |
[INFO] [stderr] 112 | /                         loop {
[INFO] [stderr] 113 | |                             match self.queue.pop() {
[INFO] [stderr] 114 | |                                 Some(..) => {}
[INFO] [stderr] 115 | |                                 None => break,
[INFO] [stderr] 116 | |                             }
[INFO] [stderr] 117 | |                         }
[INFO] [stderr]     | |_________________________^ help: try: `while let Some(..) = self.queue.pop() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/mpmc/channel.rs:232:13
[INFO] [stderr]     |
[INFO] [stderr] 232 | /             loop {
[INFO] [stderr] 233 | |                 match self.queue.pop() {
[INFO] [stderr] 234 | |                     Some(..) => { steals += 1; }
[INFO] [stderr] 235 | |                     None => break,
[INFO] [stderr] 236 | |                 }
[INFO] [stderr] 237 | |             }
[INFO] [stderr]     | |_____________^ help: try: `while let Some(..) = self.queue.pop() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.10s
[INFO] running `"docker" "inspect" "13cdb9e3d76d06ddd0c256e89b9a7b7e5c62ed17979254501e38e5f8b5f4a904"`
[INFO] running `"docker" "rm" "-f" "13cdb9e3d76d06ddd0c256e89b9a7b7e5c62ed17979254501e38e5f8b5f4a904"`
[INFO] [stdout] 13cdb9e3d76d06ddd0c256e89b9a7b7e5c62ed17979254501e38e5f8b5f4a904