[INFO] crate cachedir 0.1.1 is already in cache [INFO] extracting crate cachedir 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/cachedir/0.1.1 [INFO] extracting crate cachedir 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cachedir/0.1.1 [INFO] validating manifest of cachedir-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of cachedir-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing cachedir-0.1.1 [INFO] finished frobbing cachedir-0.1.1 [INFO] frobbed toml for cachedir-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/cachedir/0.1.1/Cargo.toml [INFO] started frobbing cachedir-0.1.1 [INFO] finished frobbing cachedir-0.1.1 [INFO] frobbed toml for cachedir-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cachedir/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting cachedir-0.1.1 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/cachedir/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bb82b43012435538b307fdf7865443fb4f3d600bacda7d78a8715713ad89595c [INFO] running `"docker" "start" "-a" "bb82b43012435538b307fdf7865443fb4f3d600bacda7d78a8715713ad89595c"` [INFO] [stderr] Checking cachedir v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/sys_cache/unix_cache.rs:37:40 [INFO] [stderr] | [INFO] [stderr] 37 | } else { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 38 | | if cfg!(not(target_os = "macos")) { [INFO] [stderr] 39 | | Some(path.join(".cache")) [INFO] [stderr] 40 | | } else { [INFO] [stderr] 41 | | Some(path.join("Library/Caches")) [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 37 | } else if cfg!(not(target_os = "macos")) { [INFO] [stderr] 38 | Some(path.join(".cache")) [INFO] [stderr] 39 | } else { [INFO] [stderr] 40 | Some(path.join("Library/Caches")) [INFO] [stderr] 41 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/sys_cache/mod.rs:124:16 [INFO] [stderr] | [INFO] [stderr] 124 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 125 | | if !parent_cache_dir.is_dir() { [INFO] [stderr] 126 | | last_io_error = io::ErrorKind::AlreadyExists; [INFO] [stderr] 127 | | attempted_paths_error.push_str( [INFO] [stderr] ... | [INFO] [stderr] 142 | | } [INFO] [stderr] 143 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 124 | } else if !parent_cache_dir.is_dir() { [INFO] [stderr] 125 | last_io_error = io::ErrorKind::AlreadyExists; [INFO] [stderr] 126 | attempted_paths_error.push_str( [INFO] [stderr] 127 | &format!("\n[AlreadyExists]: Parent cache path is not a directory: {}", [INFO] [stderr] 128 | parent_cache_dir.display()) [INFO] [stderr] 129 | ); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/sys_cache/unix_cache.rs:33:25 [INFO] [stderr] | [INFO] [stderr] 33 | let cache_dir = env::home_dir() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/sys_cache/unix_cache.rs:37:40 [INFO] [stderr] | [INFO] [stderr] 37 | } else { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 38 | | if cfg!(not(target_os = "macos")) { [INFO] [stderr] 39 | | Some(path.join(".cache")) [INFO] [stderr] 40 | | } else { [INFO] [stderr] 41 | | Some(path.join("Library/Caches")) [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 37 | } else if cfg!(not(target_os = "macos")) { [INFO] [stderr] 38 | Some(path.join(".cache")) [INFO] [stderr] 39 | } else { [INFO] [stderr] 40 | Some(path.join("Library/Caches")) [INFO] [stderr] 41 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/sys_cache/mod.rs:124:16 [INFO] [stderr] | [INFO] [stderr] 124 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 125 | | if !parent_cache_dir.is_dir() { [INFO] [stderr] 126 | | last_io_error = io::ErrorKind::AlreadyExists; [INFO] [stderr] 127 | | attempted_paths_error.push_str( [INFO] [stderr] ... | [INFO] [stderr] 142 | | } [INFO] [stderr] 143 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 124 | } else if !parent_cache_dir.is_dir() { [INFO] [stderr] 125 | last_io_error = io::ErrorKind::AlreadyExists; [INFO] [stderr] 126 | attempted_paths_error.push_str( [INFO] [stderr] 127 | &format!("\n[AlreadyExists]: Parent cache path is not a directory: {}", [INFO] [stderr] 128 | parent_cache_dir.display()) [INFO] [stderr] 129 | ); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/sys_cache/unix_cache.rs:33:25 [INFO] [stderr] | [INFO] [stderr] 33 | let cache_dir = env::home_dir() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the PathBuf [INFO] [stderr] --> src/traits_impls.rs:71:19 [INFO] [stderr] | [INFO] [stderr] 71 | self.path.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into-iter-on-array` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `cachedir`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the PathBuf [INFO] [stderr] --> src/traits_impls.rs:71:19 [INFO] [stderr] | [INFO] [stderr] 71 | self.path.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into-iter-on-array` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `cachedir`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "bb82b43012435538b307fdf7865443fb4f3d600bacda7d78a8715713ad89595c"` [INFO] running `"docker" "rm" "-f" "bb82b43012435538b307fdf7865443fb4f3d600bacda7d78a8715713ad89595c"` [INFO] [stdout] bb82b43012435538b307fdf7865443fb4f3d600bacda7d78a8715713ad89595c