[INFO] crate brotli-no-stdlib 1.0.4 is already in cache [INFO] extracting crate brotli-no-stdlib 1.0.4 into work/ex/clippy-test-run/sources/stable/reg/brotli-no-stdlib/1.0.4 [INFO] extracting crate brotli-no-stdlib 1.0.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/brotli-no-stdlib/1.0.4 [INFO] validating manifest of brotli-no-stdlib-1.0.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of brotli-no-stdlib-1.0.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing brotli-no-stdlib-1.0.4 [INFO] finished frobbing brotli-no-stdlib-1.0.4 [INFO] frobbed toml for brotli-no-stdlib-1.0.4 written to work/ex/clippy-test-run/sources/stable/reg/brotli-no-stdlib/1.0.4/Cargo.toml [INFO] started frobbing brotli-no-stdlib-1.0.4 [INFO] finished frobbing brotli-no-stdlib-1.0.4 [INFO] frobbed toml for brotli-no-stdlib-1.0.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/brotli-no-stdlib/1.0.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting brotli-no-stdlib-1.0.4 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/brotli-no-stdlib/1.0.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c84dc1aa8646fe4c97ce289a9284a4900369e9a63b98087db154bfca123f761a [INFO] running `"docker" "start" "-a" "c84dc1aa8646fe4c97ce289a9284a4900369e9a63b98087db154bfca123f761a"` [INFO] [stderr] warning: An explicit [[bin]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other binary targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a binary target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/src/bin/integration_tests.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a binary target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autobins = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] Checking alloc-no-stdlib v1.0.0 [INFO] [stderr] Checking brotli-no-stdlib v1.0.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/state.rs:236:13 [INFO] [stderr] | [INFO] [stderr] 236 | alloc_u8 : alloc_u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `alloc_u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/state.rs:237:13 [INFO] [stderr] | [INFO] [stderr] 237 | alloc_u32 : alloc_u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `alloc_u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/state.rs:238:13 [INFO] [stderr] | [INFO] [stderr] 238 | alloc_hc : alloc_hc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `alloc_hc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/state.rs:236:13 [INFO] [stderr] | [INFO] [stderr] 236 | alloc_u8 : alloc_u8, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `alloc_u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/state.rs:237:13 [INFO] [stderr] | [INFO] [stderr] 237 | alloc_u32 : alloc_u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `alloc_u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/state.rs:238:13 [INFO] [stderr] | [INFO] [stderr] 238 | alloc_hc : alloc_hc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `alloc_hc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dictionary/mod.rs:5:10 [INFO] [stderr] | [INFO] [stderr] 5 | 93696, 100864, 104704, 106752, 108928, 113536, 115968, 118528, 119872, 121280, [INFO] [stderr] | ^^^^^^ help: consider: `100_864` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dictionary/mod.rs:5:18 [INFO] [stderr] | [INFO] [stderr] 5 | 93696, 100864, 104704, 106752, 108928, 113536, 115968, 118528, 119872, 121280, [INFO] [stderr] | ^^^^^^ help: consider: `104_704` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dictionary/mod.rs:5:26 [INFO] [stderr] | [INFO] [stderr] 5 | 93696, 100864, 104704, 106752, 108928, 113536, 115968, 118528, 119872, 121280, [INFO] [stderr] | ^^^^^^ help: consider: `106_752` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dictionary/mod.rs:5:34 [INFO] [stderr] | [INFO] [stderr] 5 | 93696, 100864, 104704, 106752, 108928, 113536, 115968, 118528, 119872, 121280, [INFO] [stderr] | ^^^^^^ help: consider: `108_928` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dictionary/mod.rs:5:42 [INFO] [stderr] | [INFO] [stderr] 5 | 93696, 100864, 104704, 106752, 108928, 113536, 115968, 118528, 119872, 121280, [INFO] [stderr] | ^^^^^^ help: consider: `113_536` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dictionary/mod.rs:5:50 [INFO] [stderr] | [INFO] [stderr] 5 | 93696, 100864, 104704, 106752, 108928, 113536, 115968, 118528, 119872, 121280, [INFO] [stderr] | ^^^^^^ help: consider: `115_968` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dictionary/mod.rs:5:58 [INFO] [stderr] | [INFO] [stderr] 5 | 93696, 100864, 104704, 106752, 108928, 113536, 115968, 118528, 119872, 121280, [INFO] [stderr] | ^^^^^^ help: consider: `118_528` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dictionary/mod.rs:5:66 [INFO] [stderr] | [INFO] [stderr] 5 | 93696, 100864, 104704, 106752, 108928, 113536, 115968, 118528, 119872, 121280, [INFO] [stderr] | ^^^^^^ help: consider: `119_872` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dictionary/mod.rs:5:74 [INFO] [stderr] | [INFO] [stderr] 5 | 93696, 100864, 104704, 106752, 108928, 113536, 115968, 118528, 119872, 121280, [INFO] [stderr] | ^^^^^^ help: consider: `121_280` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dictionary/mod.rs:6:3 [INFO] [stderr] | [INFO] [stderr] 6 | 122016 [INFO] [stderr] | ^^^^^^ help: consider: `122_016` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dictionary/mod.rs:22:35 [INFO] [stderr] | [INFO] [stderr] 22 | pub const kBrotliDictionary : [u8;122784] = [ [INFO] [stderr] | ^^^^^^ help: consider: `122_784` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | 0x00000001, 0x00000003, 0x00000007, 0x0000000F, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | 0x00000001, 0x00000003, 0x00000007, 0x0000000F, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:19:29 [INFO] [stderr] | [INFO] [stderr] 19 | 0x00000001, 0x00000003, 0x00000007, 0x0000000F, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0007` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:19:41 [INFO] [stderr] | [INFO] [stderr] 19 | 0x00000001, 0x00000003, 0x00000007, 0x0000000F, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_000F` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | 0x0000001F, 0x0000003F, 0x0000007F, 0x000000FF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_001F` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:20:17 [INFO] [stderr] | [INFO] [stderr] 20 | 0x0000001F, 0x0000003F, 0x0000007F, 0x000000FF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_003F` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:20:29 [INFO] [stderr] | [INFO] [stderr] 20 | 0x0000001F, 0x0000003F, 0x0000007F, 0x000000FF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_007F` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:20:41 [INFO] [stderr] | [INFO] [stderr] 20 | 0x0000001F, 0x0000003F, 0x0000007F, 0x000000FF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | 0x000001FF, 0x000003FF, 0x000007FF, 0x00000FFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_01FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:21:17 [INFO] [stderr] | [INFO] [stderr] 21 | 0x000001FF, 0x000003FF, 0x000007FF, 0x00000FFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_03FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:21:29 [INFO] [stderr] | [INFO] [stderr] 21 | 0x000001FF, 0x000003FF, 0x000007FF, 0x00000FFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_07FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:21:41 [INFO] [stderr] | [INFO] [stderr] 21 | 0x000001FF, 0x000003FF, 0x000007FF, 0x00000FFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0FFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | 0x00001FFF, 0x00003FFF, 0x00007FFF, 0x0000FFFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_1FFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:22:17 [INFO] [stderr] | [INFO] [stderr] 22 | 0x00001FFF, 0x00003FFF, 0x00007FFF, 0x0000FFFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_3FFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:22:29 [INFO] [stderr] | [INFO] [stderr] 22 | 0x00001FFF, 0x00003FFF, 0x00007FFF, 0x0000FFFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_7FFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:22:41 [INFO] [stderr] | [INFO] [stderr] 22 | 0x00001FFF, 0x00003FFF, 0x00007FFF, 0x0000FFFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | 0x0001FFFF, 0x0003FFFF, 0x0007FFFF, 0x000FFFFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0001_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | 0x0001FFFF, 0x0003FFFF, 0x0007FFFF, 0x000FFFFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0003_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:23:29 [INFO] [stderr] | [INFO] [stderr] 23 | 0x0001FFFF, 0x0003FFFF, 0x0007FFFF, 0x000FFFFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0007_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:23:41 [INFO] [stderr] | [INFO] [stderr] 23 | 0x0001FFFF, 0x0003FFFF, 0x0007FFFF, 0x000FFFFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x000F_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | 0x001FFFFF, 0x003FFFFF, 0x007FFFFF, 0x00FFFFFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x001F_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | 0x001FFFFF, 0x003FFFFF, 0x007FFFFF, 0x00FFFFFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x003F_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:24:29 [INFO] [stderr] | [INFO] [stderr] 24 | 0x001FFFFF, 0x003FFFFF, 0x007FFFFF, 0x00FFFFFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x007F_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:24:41 [INFO] [stderr] | [INFO] [stderr] 24 | 0x001FFFFF, 0x003FFFFF, 0x007FFFFF, 0x00FFFFFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00FF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | 0x01FFFFFF, 0x03FFFFFF, 0x07FFFFFF, 0x0FFFFFFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x01FF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:25:17 [INFO] [stderr] | [INFO] [stderr] 25 | 0x01FFFFFF, 0x03FFFFFF, 0x07FFFFFF, 0x0FFFFFFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x03FF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:25:29 [INFO] [stderr] | [INFO] [stderr] 25 | 0x01FFFFFF, 0x03FFFFFF, 0x07FFFFFF, 0x0FFFFFFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x07FF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:25:41 [INFO] [stderr] | [INFO] [stderr] 25 | 0x01FFFFFF, 0x03FFFFFF, 0x07FFFFFF, 0x0FFFFFFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0FFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | 0x1FFFFFFF, 0x3FFFFFFF, 0x7FFFFFFF, 0xFFFFFFFF [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1FFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:26:17 [INFO] [stderr] | [INFO] [stderr] 26 | 0x1FFFFFFF, 0x3FFFFFFF, 0x7FFFFFFF, 0xFFFFFFFF [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3FFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:26:29 [INFO] [stderr] | [INFO] [stderr] 26 | 0x1FFFFFFF, 0x3FFFFFFF, 0x7FFFFFFF, 0xFFFFFFFF [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7FFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:26:41 [INFO] [stderr] | [INFO] [stderr] 26 | 0x1FFFFFFF, 0x3FFFFFFF, 0x7FFFFFFF, 0xFFFFFFFF [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | return !((0xffffffffu32) << n); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `!((0xffffffffu32) << n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | return kBitMask[n as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `kBitMask[n as usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:34:15 [INFO] [stderr] | [INFO] [stderr] 34 | return !((0xffffffffu32) << n); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xffff_ffffu32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | / return BrotliBitReader { [INFO] [stderr] 50 | | val_ : 0, [INFO] [stderr] 51 | | bit_pos_ : 0, [INFO] [stderr] 52 | | next_in : 0, [INFO] [stderr] 53 | | avail_in : 0, [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 49 | BrotliBitReader { [INFO] [stderr] 50 | val_ : 0, [INFO] [stderr] 51 | bit_pos_ : 0, [INFO] [stderr] 52 | next_in : 0, [INFO] [stderr] 53 | avail_in : 0, [INFO] [stderr] 54 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | / return BrotliBitReaderState { [INFO] [stderr] 68 | | val_ : 0, [INFO] [stderr] 69 | | bit_pos_ : 0, [INFO] [stderr] 70 | | next_in : 0, [INFO] [stderr] 71 | | avail_in : 0, [INFO] [stderr] 72 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 67 | BrotliBitReaderState { [INFO] [stderr] 68 | val_ : 0, [INFO] [stderr] 69 | bit_pos_ : 0, [INFO] [stderr] 70 | next_in : 0, [INFO] [stderr] 71 | avail_in : 0, [INFO] [stderr] 72 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:79:3 [INFO] [stderr] | [INFO] [stderr] 79 | / return BrotliBitReaderState { val_ : from.val_, [INFO] [stderr] 80 | | bit_pos_ : from.bit_pos_, [INFO] [stderr] 81 | | next_in : from.next_in, [INFO] [stderr] 82 | | avail_in : from.avail_in }; [INFO] [stderr] | |_________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 79 | BrotliBitReaderState { val_ : from.val_, [INFO] [stderr] 80 | bit_pos_ : from.bit_pos_, [INFO] [stderr] 81 | next_in : from.next_in, [INFO] [stderr] 82 | avail_in : from.avail_in } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:95:3 [INFO] [stderr] | [INFO] [stderr] 95 | return ((::core::mem::size_of::() as u32) << 3) - br.bit_pos_; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `((::core::mem::size_of::() as u32) << 3) - br.bit_pos_` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:101:3 [INFO] [stderr] | [INFO] [stderr] 101 | return br.avail_in + (BrotliGetAvailableBits(br) >> 3); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `br.avail_in + (BrotliGetAvailableBits(br) >> 3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:108:3 [INFO] [stderr] | [INFO] [stderr] 108 | return br.avail_in >= num; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `br.avail_in >= num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:117:3 [INFO] [stderr] | [INFO] [stderr] 117 | return (two_byte[0] as u16) | ((two_byte[1] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(two_byte[0] as u16) | ((two_byte[1] as u16) << 8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:124:3 [INFO] [stderr] | [INFO] [stderr] 124 | / return (four_byte[0] as u32) | ((four_byte[1] as u32) << 8) [INFO] [stderr] 125 | | | ((four_byte[2] as u32) << 16) | ((four_byte[3] as u32) << 24); [INFO] [stderr] | |______________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 124 | (four_byte[0] as u32) | ((four_byte[1] as u32) << 8) [INFO] [stderr] 125 | | ((four_byte[2] as u32) << 16) | ((four_byte[3] as u32) << 24) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:132:3 [INFO] [stderr] | [INFO] [stderr] 132 | / return (eight_byte[0] as u64) | ((eight_byte[1] as u64) << 8) [INFO] [stderr] 133 | | | ((eight_byte[2] as u64) << 16) | ((eight_byte[3] as u64) << 24) [INFO] [stderr] 134 | | | ((eight_byte[4] as u64) << 32) | ((eight_byte[5] as u64) << 40) [INFO] [stderr] 135 | | | ((eight_byte[6] as u64) << 48) | ((eight_byte[7] as u64) << 56); [INFO] [stderr] | |________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 132 | (eight_byte[0] as u64) | ((eight_byte[1] as u64) << 8) [INFO] [stderr] 133 | | ((eight_byte[2] as u64) << 16) | ((eight_byte[3] as u64) << 24) [INFO] [stderr] 134 | | ((eight_byte[4] as u64) << 32) | ((eight_byte[5] as u64) << 40) [INFO] [stderr] 135 | | ((eight_byte[6] as u64) << 48) | ((eight_byte[7] as u64) << 56) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bit_reader/mod.rs:164:10 [INFO] [stderr] | [INFO] [stderr] 164 | } else { [INFO] [stderr] | __________^ [INFO] [stderr] 165 | | if (BROTLI_ALIGNED_READ == 0 && (n_bits <= 8)) { [INFO] [stderr] 166 | | if (br.bit_pos_ >= 24) { [INFO] [stderr] 167 | | br.val_ >>= 24; [INFO] [stderr] ... | [INFO] [stderr] 181 | | } [INFO] [stderr] 182 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 164 | } else if (BROTLI_ALIGNED_READ == 0 && (n_bits <= 8)) { [INFO] [stderr] 165 | if (br.bit_pos_ >= 24) { [INFO] [stderr] 166 | br.val_ >>= 24; [INFO] [stderr] 167 | br.bit_pos_ ^= 24; // here same as -= 24 because of the if condition [INFO] [stderr] 168 | br.val_ |= (BrotliLoad32LE(input, br.next_in) << 8) as u64; [INFO] [stderr] 169 | br.avail_in -= 3; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bit_reader/mod.rs:173:12 [INFO] [stderr] | [INFO] [stderr] 173 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 174 | | if br.bit_pos_ >= 16 { [INFO] [stderr] 175 | | br.val_ >>= 16; [INFO] [stderr] 176 | | br.bit_pos_ ^= 16; /* here same as -= 16 because of the if condition */ [INFO] [stderr] ... | [INFO] [stderr] 180 | | } [INFO] [stderr] 181 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 173 | } else if br.bit_pos_ >= 16 { [INFO] [stderr] 174 | br.val_ >>= 16; [INFO] [stderr] 175 | br.bit_pos_ ^= 16; /* here same as -= 16 because of the if condition */ [INFO] [stderr] 176 | br.val_ |= (BrotliLoad16LE(input, br.next_in) as reg_t) << 16; [INFO] [stderr] 177 | br.avail_in -= BROTLI_SHORT_FILL_BIT_WINDOW_READ; [INFO] [stderr] 178 | br.next_in += BROTLI_SHORT_FILL_BIT_WINDOW_READ; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bit_reader/mod.rs:213:10 [INFO] [stderr] | [INFO] [stderr] 213 | } else { [INFO] [stderr] | __________^ [INFO] [stderr] 214 | | if /*BROTLI_ALIGNED_READ == false && */n_bits <= 8 { // !BROTLI_ALIGNED_READ && IS_CONSTANT(n_bits) && (n_bits <= 8)) { [INFO] [stderr] 215 | | if br.bit_pos_ >= 24 { [INFO] [stderr] 216 | | br.val_ >>= 24; [INFO] [stderr] ... | [INFO] [stderr] 230 | | } [INFO] [stderr] 231 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 213 | } else if /*BROTLI_ALIGNED_READ == false && */n_bits <= 8 { // !BROTLI_ALIGNED_READ && IS_CONSTANT(n_bits) && (n_bits <= 8)) { [INFO] [stderr] 214 | if br.bit_pos_ >= 24 { [INFO] [stderr] 215 | br.val_ >>= 24; [INFO] [stderr] 216 | br.bit_pos_ ^= 24; /* here same as -= 24 because of the if condition */ [INFO] [stderr] 217 | br.val_ |= (BrotliLoad32LE(input, br.next_in) as reg_t) << 8; [INFO] [stderr] 218 | br.avail_in -= 3; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bit_reader/mod.rs:204:12 [INFO] [stderr] | [INFO] [stderr] 204 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 205 | | if br.bit_pos_ >= 32 { [INFO] [stderr] 206 | | br.val_ >>= 32; [INFO] [stderr] 207 | | br.bit_pos_ ^= 32; /* here same as -= 32 because of the if condition */ [INFO] [stderr] ... | [INFO] [stderr] 211 | | } [INFO] [stderr] 212 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 204 | } else if br.bit_pos_ >= 32 { [INFO] [stderr] 205 | br.val_ >>= 32; [INFO] [stderr] 206 | br.bit_pos_ ^= 32; /* here same as -= 32 because of the if condition */ [INFO] [stderr] 207 | br.val_ |= (BrotliLoad32LE(input, br.next_in) as reg_t) << 32; [INFO] [stderr] 208 | br.avail_in -= BROTLI_SHORT_FILL_BIT_WINDOW_READ; [INFO] [stderr] 209 | br.next_in += BROTLI_SHORT_FILL_BIT_WINDOW_READ; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bit_reader/mod.rs:222:12 [INFO] [stderr] | [INFO] [stderr] 222 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 223 | | if br.bit_pos_ >= 16 { [INFO] [stderr] 224 | | br.val_ >>= 16; [INFO] [stderr] 225 | | br.bit_pos_ ^= 16; /* here same as -= 16 because of the if condition */ [INFO] [stderr] ... | [INFO] [stderr] 229 | | } [INFO] [stderr] 230 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 222 | } else if br.bit_pos_ >= 16 { [INFO] [stderr] 223 | br.val_ >>= 16; [INFO] [stderr] 224 | br.bit_pos_ ^= 16; /* here same as -= 16 because of the if condition */ [INFO] [stderr] 225 | br.val_ |= (BrotliLoad16LE(input, br.next_in) as reg_t) << 16; [INFO] [stderr] 226 | br.avail_in -= BROTLI_SHORT_FILL_BIT_WINDOW_READ; [INFO] [stderr] 227 | br.next_in += BROTLI_SHORT_FILL_BIT_WINDOW_READ; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:254:3 [INFO] [stderr] | [INFO] [stderr] 254 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:261:3 [INFO] [stderr] | [INFO] [stderr] 261 | return br.val_ >> br.bit_pos_; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `br.val_ >> br.bit_pos_` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:270:3 [INFO] [stderr] | [INFO] [stderr] 270 | return (BrotliGetBitsUnmasked(br) & (0xffffffffu32 as reg_t)) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(BrotliGetBitsUnmasked(br) & (0xffffffffu32 as reg_t)) as u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:270:40 [INFO] [stderr] | [INFO] [stderr] 270 | return (BrotliGetBitsUnmasked(br) & (0xffffffffu32 as reg_t)) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xffff_ffffu32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:277:3 [INFO] [stderr] | [INFO] [stderr] 277 | return (BrotliGetBitsUnmasked(br) as u32) & BitMask(n_bits); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(BrotliGetBitsUnmasked(br) as u32) & BitMask(n_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:285:3 [INFO] [stderr] | [INFO] [stderr] 285 | return (BrotliGetBitsUnmasked(br) as u32) & BitMask(n_bits); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(BrotliGetBitsUnmasked(br) as u32) & BitMask(n_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:298:3 [INFO] [stderr] | [INFO] [stderr] 298 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:340:5 [INFO] [stderr] | [INFO] [stderr] 340 | return val; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:348:5 [INFO] [stderr] | [INFO] [stderr] 348 | return low_val | (high_val << 16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `low_val | (high_val << 16)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:361:5 [INFO] [stderr] | [INFO] [stderr] 361 | return val; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:369:5 [INFO] [stderr] | [INFO] [stderr] 369 | return low_val | (high_val << 16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `low_val | (high_val << 16)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:383:3 [INFO] [stderr] | [INFO] [stderr] 383 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:394:3 [INFO] [stderr] | [INFO] [stderr] 394 | return pad_bits == 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `pad_bits == 0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:411:3 [INFO] [stderr] | [INFO] [stderr] 411 | return -1; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `-1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/bit_reader/mod.rs:405:43 [INFO] [stderr] | [INFO] [stderr] 405 | return ((BrotliGetBitsUnmasked(br) >> ((offset << 3)) as u32) & 0xFF) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:456:3 [INFO] [stderr] | [INFO] [stderr] 456 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/bit_reader/mod.rs:443:3 [INFO] [stderr] | [INFO] [stderr] 443 | / if BrotliGetAvailableBits(br) == 0 { [INFO] [stderr] 444 | | if !BrotliPullByte(br, input) { [INFO] [stderr] 445 | | return false; [INFO] [stderr] 446 | | } [INFO] [stderr] 447 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 443 | if BrotliGetAvailableBits(br) == 0 && !BrotliPullByte(br, input) { [INFO] [stderr] 444 | return false; [INFO] [stderr] 445 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/huffman/mod.rs:33:7 [INFO] [stderr] | [INFO] [stderr] 33 | return self.value == other.value && self.bits == other.bits; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.value == other.value && self.bits == other.bits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/huffman/mod.rs:39:6 [INFO] [stderr] | [INFO] [stderr] 39 | return HuffmanCode { value : 0, bits : 0}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HuffmanCode { value : 0, bits : 0}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/huffman/mod.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | return &mut self.codes.slice_mut()[start..]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&mut self.codes.slice_mut()[start..]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/huffman/mod.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | return & self.codes.slice()[start..]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `& self.codes.slice()[start..]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/huffman/mod.rs:103:7 [INFO] [stderr] | [INFO] [stderr] 103 | return ret; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/huffman/mod.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | / return HuffmanTreeGroup:: { [INFO] [stderr] 111 | | htrees : AllocU32::AllocatedMemory::default(), [INFO] [stderr] 112 | | codes : AllocHC::AllocatedMemory::default(), [INFO] [stderr] 113 | | alphabet_size : 0, [INFO] [stderr] 114 | | num_htrees : 0, [INFO] [stderr] 115 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 110 | HuffmanTreeGroup:: { [INFO] [stderr] 111 | htrees : AllocU32::AllocatedMemory::default(), [INFO] [stderr] 112 | codes : AllocHC::AllocatedMemory::default(), [INFO] [stderr] 113 | alphabet_size : 0, [INFO] [stderr] 114 | num_htrees : 0, [INFO] [stderr] 115 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/huffman/mod.rs:166:3 [INFO] [stderr] | [INFO] [stderr] 166 | return kReverseBits[num as usize] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `kReverseBits[num as usize] as u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/huffman/mod.rs:199:3 [INFO] [stderr] | [INFO] [stderr] 199 | return len - root_bits; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `len - root_bits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/huffman/mod.rs:373:3 [INFO] [stderr] | [INFO] [stderr] 373 | return total_size as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `total_size as u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/huffman/mod.rs:466:3 [INFO] [stderr] | [INFO] [stderr] 466 | return goal_size; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `goal_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state.rs:335:9 [INFO] [stderr] | [INFO] [stderr] 335 | return retval; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `retval` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state.rs:399:17 [INFO] [stderr] | [INFO] [stderr] 399 | return BrotliGetAvailableBits(&self.br) == 0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `BrotliGetAvailableBits(&self.br) == 0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state.rs:400:18 [INFO] [stderr] | [INFO] [stderr] 400 | _ => return false, [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state.rs:406:54 [INFO] [stderr] | [INFO] [stderr] 406 | BrotliRunningState::BROTLI_STATE_DONE => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state.rs:407:18 [INFO] [stderr] | [INFO] [stderr] 407 | _ => return false, [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transform.rs:252:3 [INFO] [stderr] | [INFO] [stderr] 252 | return 3; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transform.rs:304:5 [INFO] [stderr] | [INFO] [stderr] 304 | return idx; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | return BrotliResult::ResultFailure; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `BrotliResult::ResultFailure` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:122:3 [INFO] [stderr] | [INFO] [stderr] 122 | return 17; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `17` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:311:3 [INFO] [stderr] | [INFO] [stderr] 311 | return table_element.value as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `table_element.value as u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:319:3 [INFO] [stderr] | [INFO] [stderr] 319 | return DecodeSymbol(bit_reader::BrotliGet16BitsUnmasked(br, input), &table, br); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DecodeSymbol(bit_reader::BrotliGet16BitsUnmasked(br, input), &table, br)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:361:3 [INFO] [stderr] | [INFO] [stderr] 361 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:375:3 [INFO] [stderr] | [INFO] [stderr] 375 | return SafeDecodeSymbol(&table, br, result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `SafeDecodeSymbol(&table, br, result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:415:3 [INFO] [stderr] | [INFO] [stderr] 415 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/lib.rs:405:36 [INFO] [stderr] | [INFO] [stderr] 405 | let mask = bit_reader::BitMask((*bits - HUFFMAN_TABLE_BITS)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:424:3 [INFO] [stderr] | [INFO] [stderr] 424 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:470:3 [INFO] [stderr] | [INFO] [stderr] 470 | return BrotliResult::ResultSuccess; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `BrotliResult::ResultSuccess` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:604:3 [INFO] [stderr] | [INFO] [stderr] 604 | return BrotliResult::ResultSuccess; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `BrotliResult::ResultSuccess` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:656:3 [INFO] [stderr] | [INFO] [stderr] 656 | return BrotliResult::ResultSuccess; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `BrotliResult::ResultSuccess` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:710:3 [INFO] [stderr] | [INFO] [stderr] 710 | return BrotliResult::ResultSuccess; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `BrotliResult::ResultSuccess` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:875:3 [INFO] [stderr] | [INFO] [stderr] 875 | / return prefix::kBlockLengthPrefixCode[code as usize].offset as u32 [INFO] [stderr] 876 | | + bit_reader::BrotliReadBits(br, nbits, input); [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 875 | prefix::kBlockLengthPrefixCode[code as usize].offset as u32 [INFO] [stderr] 876 | + bit_reader::BrotliReadBits(br, nbits, input) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:893:7 [INFO] [stderr] | [INFO] [stderr] 893 | return (true, index); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(true, index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:895:10 [INFO] [stderr] | [INFO] [stderr] 895 | _ => return (true, block_length_index), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(true, block_length_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:919:5 [INFO] [stderr] | [INFO] [stderr] 919 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/lib.rs:921:1 [INFO] [stderr] | [INFO] [stderr] 921 | / macro_rules! SafeReadBlockLength ( [INFO] [stderr] 922 | | ($state : expr, $result : expr , $table : expr) => { [INFO] [stderr] 923 | | SafeReadBlockLengthFromIndex(&mut $state, &mut $result, [INFO] [stderr] 924 | | SafeReadBlockLengthIndex($state.substate_read_block_length, [INFO] [stderr] ... | [INFO] [stderr] 928 | | }; [INFO] [stderr] 929 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1060:3 [INFO] [stderr] | [INFO] [stderr] 1060 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1265:3 [INFO] [stderr] | [INFO] [stderr] 1265 | return retval; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `retval` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1321:3 [INFO] [stderr] | [INFO] [stderr] 1321 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1349:3 [INFO] [stderr] | [INFO] [stderr] 1349 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1382:3 [INFO] [stderr] | [INFO] [stderr] 1382 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1399:3 [INFO] [stderr] | [INFO] [stderr] 1399 | return DecodeCommandBlockSwitchInternal(true, s, input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DecodeCommandBlockSwitchInternal(true, s, input)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1416:3 [INFO] [stderr] | [INFO] [stderr] 1416 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1434:3 [INFO] [stderr] | [INFO] [stderr] 1434 | return DecodeDistanceBlockSwitchInternal(true, s, input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DecodeDistanceBlockSwitchInternal(true, s, input)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1470:3 [INFO] [stderr] | [INFO] [stderr] 1470 | return BrotliResult::ResultSuccess; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `BrotliResult::ResultSuccess` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1576:3 [INFO] [stderr] | [INFO] [stderr] 1576 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/lib.rs:1563:40 [INFO] [stderr] | [INFO] [stderr] 1563 | s.ringbuffer = s.alloc_u8.alloc_cell((s.ringbuffer_size as usize + [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 1564 | | kRingBufferWriteAheadSlack as usize + kBrotliMaxDictionaryWordLength as usize)); [INFO] [stderr] | |____________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1602:3 [INFO] [stderr] | [INFO] [stderr] 1602 | return BrotliResult::ResultSuccess; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `BrotliResult::ResultSuccess` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1616:48 [INFO] [stderr] | [INFO] [stderr] 1616 | const kDistanceShortCodeIndexOffset : u32= 0xaaafff1b; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xaaaf_ff1b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1619:49 [INFO] [stderr] | [INFO] [stderr] 1619 | const kDistanceShortCodeValueOffset : u32 = 0xfa5fa500; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xfa5f_a500` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1631:27 [INFO] [stderr] | [INFO] [stderr] 1631 | s.distance_code = 0x0fffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1639:5 [INFO] [stderr] | [INFO] [stderr] 1639 | return bit_reader::BrotliSafeReadBits(br, n_bits, val, input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `bit_reader::BrotliSafeReadBits(br, n_bits, val, input)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1642:5 [INFO] [stderr] | [INFO] [stderr] 1642 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1707:3 [INFO] [stderr] | [INFO] [stderr] 1707 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1670:33 [INFO] [stderr] | [INFO] [stderr] 1670 | if ((s.distance_code as u64 & 0xfffffffffffffff0) == 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_fff0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1755:3 [INFO] [stderr] | [INFO] [stderr] 1755 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:1745:10 [INFO] [stderr] | [INFO] [stderr] 1745 | } else { [INFO] [stderr] | __________^ [INFO] [stderr] 1746 | | if (!SafeReadBits(&mut s.br, v.insert_len_extra_bits as u32, &mut insert_len_extra, input)) || [INFO] [stderr] 1747 | | (!SafeReadBits(&mut s.br, v.copy_len_extra_bits as u32, &mut copy_length, input)) { [INFO] [stderr] 1748 | | bit_reader::BrotliBitReaderRestoreState(&mut s.br, &memento); [INFO] [stderr] 1749 | | return false; [INFO] [stderr] 1750 | | } [INFO] [stderr] 1751 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1745 | } else if (!SafeReadBits(&mut s.br, v.insert_len_extra_bits as u32, &mut insert_len_extra, input)) || [INFO] [stderr] 1746 | (!SafeReadBits(&mut s.br, v.copy_len_extra_bits as u32, &mut copy_length, input)) { [INFO] [stderr] 1747 | bit_reader::BrotliBitReaderRestoreState(&mut s.br, &memento); [INFO] [stderr] 1748 | return false; [INFO] [stderr] 1749 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1763:3 [INFO] [stderr] | [INFO] [stderr] 1763 | return bit_reader::BrotliWarmupBitReader(br, input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `bit_reader::BrotliWarmupBitReader(br, input)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1771:3 [INFO] [stderr] | [INFO] [stderr] 1771 | return bit_reader::BrotliCheckInputAmount(br, num); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `bit_reader::BrotliCheckInputAmount(br, num)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:2173:3 [INFO] [stderr] | [INFO] [stderr] 2173 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:2181:5 [INFO] [stderr] | [INFO] [stderr] 2181 | return ProcessCommandsInternal(false, s, input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ProcessCommandsInternal(false, s, input)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:2189:5 [INFO] [stderr] | [INFO] [stderr] 2189 | return ProcessCommandsInternal(true, s, input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ProcessCommandsInternal(true, s, input)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:2680:3 [INFO] [stderr] | [INFO] [stderr] 2680 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:2356:11 [INFO] [stderr] | [INFO] [stderr] 2356 | / if (s.is_metadata != 0 || s.is_uncompressed != 0) { [INFO] [stderr] 2357 | | if (!bit_reader::BrotliJumpToByteBoundary(&mut s.br)) { [INFO] [stderr] 2358 | | result = BROTLI_FAILURE(); [INFO] [stderr] 2359 | | break; [INFO] [stderr] 2360 | | } [INFO] [stderr] 2361 | | } [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 2356 | if (s.is_metadata != 0 || s.is_uncompressed != 0) && (!bit_reader::BrotliJumpToByteBoundary(&mut s.br)) { [INFO] [stderr] 2357 | result = BROTLI_FAILURE(); [INFO] [stderr] 2358 | break; [INFO] [stderr] 2359 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:2370:11 [INFO] [stderr] | [INFO] [stderr] 2370 | / if (s.ringbuffer.slice().len() == 0) { [INFO] [stderr] 2371 | | if (!BrotliAllocateRingBuffer(&mut s, local_input)) { [INFO] [stderr] 2372 | | result = BROTLI_FAILURE(); [INFO] [stderr] 2373 | | break; [INFO] [stderr] 2374 | | } [INFO] [stderr] 2375 | | } [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 2370 | if (s.ringbuffer.slice().len() == 0) && (!BrotliAllocateRingBuffer(&mut s, local_input)) { [INFO] [stderr] 2371 | result = BROTLI_FAILURE(); [INFO] [stderr] 2372 | break; [INFO] [stderr] 2373 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dictionary/mod.rs:5:10 [INFO] [stderr] | [INFO] [stderr] 5 | 93696, 100864, 104704, 106752, 108928, 113536, 115968, 118528, 119872, 121280, [INFO] [stderr] | ^^^^^^ help: consider: `100_864` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dictionary/mod.rs:5:18 [INFO] [stderr] | [INFO] [stderr] 5 | 93696, 100864, 104704, 106752, 108928, 113536, 115968, 118528, 119872, 121280, [INFO] [stderr] | ^^^^^^ help: consider: `104_704` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dictionary/mod.rs:5:26 [INFO] [stderr] | [INFO] [stderr] 5 | 93696, 100864, 104704, 106752, 108928, 113536, 115968, 118528, 119872, 121280, [INFO] [stderr] | ^^^^^^ help: consider: `106_752` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dictionary/mod.rs:5:34 [INFO] [stderr] | [INFO] [stderr] 5 | 93696, 100864, 104704, 106752, 108928, 113536, 115968, 118528, 119872, 121280, [INFO] [stderr] | ^^^^^^ help: consider: `108_928` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dictionary/mod.rs:5:42 [INFO] [stderr] | [INFO] [stderr] 5 | 93696, 100864, 104704, 106752, 108928, 113536, 115968, 118528, 119872, 121280, [INFO] [stderr] | ^^^^^^ help: consider: `113_536` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dictionary/mod.rs:5:50 [INFO] [stderr] | [INFO] [stderr] 5 | 93696, 100864, 104704, 106752, 108928, 113536, 115968, 118528, 119872, 121280, [INFO] [stderr] | ^^^^^^ help: consider: `115_968` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dictionary/mod.rs:5:58 [INFO] [stderr] | [INFO] [stderr] 5 | 93696, 100864, 104704, 106752, 108928, 113536, 115968, 118528, 119872, 121280, [INFO] [stderr] | ^^^^^^ help: consider: `118_528` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dictionary/mod.rs:5:66 [INFO] [stderr] | [INFO] [stderr] 5 | 93696, 100864, 104704, 106752, 108928, 113536, 115968, 118528, 119872, 121280, [INFO] [stderr] | ^^^^^^ help: consider: `119_872` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dictionary/mod.rs:5:74 [INFO] [stderr] | [INFO] [stderr] 5 | 93696, 100864, 104704, 106752, 108928, 113536, 115968, 118528, 119872, 121280, [INFO] [stderr] | ^^^^^^ help: consider: `121_280` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dictionary/mod.rs:6:3 [INFO] [stderr] | [INFO] [stderr] 6 | 122016 [INFO] [stderr] | ^^^^^^ help: consider: `122_016` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dictionary/mod.rs:22:35 [INFO] [stderr] | [INFO] [stderr] 22 | pub const kBrotliDictionary : [u8;122784] = [ [INFO] [stderr] | ^^^^^^ help: consider: `122_784` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | 0x00000001, 0x00000003, 0x00000007, 0x0000000F, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | 0x00000001, 0x00000003, 0x00000007, 0x0000000F, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:19:29 [INFO] [stderr] | [INFO] [stderr] 19 | 0x00000001, 0x00000003, 0x00000007, 0x0000000F, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0007` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:19:41 [INFO] [stderr] | [INFO] [stderr] 19 | 0x00000001, 0x00000003, 0x00000007, 0x0000000F, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_000F` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | 0x0000001F, 0x0000003F, 0x0000007F, 0x000000FF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_001F` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:20:17 [INFO] [stderr] | [INFO] [stderr] 20 | 0x0000001F, 0x0000003F, 0x0000007F, 0x000000FF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_003F` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:20:29 [INFO] [stderr] | [INFO] [stderr] 20 | 0x0000001F, 0x0000003F, 0x0000007F, 0x000000FF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_007F` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:20:41 [INFO] [stderr] | [INFO] [stderr] 20 | 0x0000001F, 0x0000003F, 0x0000007F, 0x000000FF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | 0x000001FF, 0x000003FF, 0x000007FF, 0x00000FFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_01FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:21:17 [INFO] [stderr] | [INFO] [stderr] 21 | 0x000001FF, 0x000003FF, 0x000007FF, 0x00000FFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_03FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:21:29 [INFO] [stderr] | [INFO] [stderr] 21 | 0x000001FF, 0x000003FF, 0x000007FF, 0x00000FFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_07FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:21:41 [INFO] [stderr] | [INFO] [stderr] 21 | 0x000001FF, 0x000003FF, 0x000007FF, 0x00000FFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0FFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | 0x00001FFF, 0x00003FFF, 0x00007FFF, 0x0000FFFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_1FFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:22:17 [INFO] [stderr] | [INFO] [stderr] 22 | 0x00001FFF, 0x00003FFF, 0x00007FFF, 0x0000FFFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_3FFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:22:29 [INFO] [stderr] | [INFO] [stderr] 22 | 0x00001FFF, 0x00003FFF, 0x00007FFF, 0x0000FFFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_7FFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:22:41 [INFO] [stderr] | [INFO] [stderr] 22 | 0x00001FFF, 0x00003FFF, 0x00007FFF, 0x0000FFFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | 0x0001FFFF, 0x0003FFFF, 0x0007FFFF, 0x000FFFFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0001_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | 0x0001FFFF, 0x0003FFFF, 0x0007FFFF, 0x000FFFFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0003_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:23:29 [INFO] [stderr] | [INFO] [stderr] 23 | 0x0001FFFF, 0x0003FFFF, 0x0007FFFF, 0x000FFFFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0007_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:23:41 [INFO] [stderr] | [INFO] [stderr] 23 | 0x0001FFFF, 0x0003FFFF, 0x0007FFFF, 0x000FFFFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x000F_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | 0x001FFFFF, 0x003FFFFF, 0x007FFFFF, 0x00FFFFFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x001F_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | 0x001FFFFF, 0x003FFFFF, 0x007FFFFF, 0x00FFFFFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x003F_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:24:29 [INFO] [stderr] | [INFO] [stderr] 24 | 0x001FFFFF, 0x003FFFFF, 0x007FFFFF, 0x00FFFFFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x007F_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:24:41 [INFO] [stderr] | [INFO] [stderr] 24 | 0x001FFFFF, 0x003FFFFF, 0x007FFFFF, 0x00FFFFFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00FF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | 0x01FFFFFF, 0x03FFFFFF, 0x07FFFFFF, 0x0FFFFFFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x01FF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:25:17 [INFO] [stderr] | [INFO] [stderr] 25 | 0x01FFFFFF, 0x03FFFFFF, 0x07FFFFFF, 0x0FFFFFFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x03FF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:25:29 [INFO] [stderr] | [INFO] [stderr] 25 | 0x01FFFFFF, 0x03FFFFFF, 0x07FFFFFF, 0x0FFFFFFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x07FF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:25:41 [INFO] [stderr] | [INFO] [stderr] 25 | 0x01FFFFFF, 0x03FFFFFF, 0x07FFFFFF, 0x0FFFFFFF, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0FFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | 0x1FFFFFFF, 0x3FFFFFFF, 0x7FFFFFFF, 0xFFFFFFFF [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1FFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:26:17 [INFO] [stderr] | [INFO] [stderr] 26 | 0x1FFFFFFF, 0x3FFFFFFF, 0x7FFFFFFF, 0xFFFFFFFF [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3FFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:26:29 [INFO] [stderr] | [INFO] [stderr] 26 | 0x1FFFFFFF, 0x3FFFFFFF, 0x7FFFFFFF, 0xFFFFFFFF [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7FFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:26:41 [INFO] [stderr] | [INFO] [stderr] 26 | 0x1FFFFFFF, 0x3FFFFFFF, 0x7FFFFFFF, 0xFFFFFFFF [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | return !((0xffffffffu32) << n); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `!((0xffffffffu32) << n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | return kBitMask[n as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `kBitMask[n as usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:34:15 [INFO] [stderr] | [INFO] [stderr] 34 | return !((0xffffffffu32) << n); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xffff_ffffu32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | / return BrotliBitReader { [INFO] [stderr] 50 | | val_ : 0, [INFO] [stderr] 51 | | bit_pos_ : 0, [INFO] [stderr] 52 | | next_in : 0, [INFO] [stderr] 53 | | avail_in : 0, [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 49 | BrotliBitReader { [INFO] [stderr] 50 | val_ : 0, [INFO] [stderr] 51 | bit_pos_ : 0, [INFO] [stderr] 52 | next_in : 0, [INFO] [stderr] 53 | avail_in : 0, [INFO] [stderr] 54 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | / return BrotliBitReaderState { [INFO] [stderr] 68 | | val_ : 0, [INFO] [stderr] 69 | | bit_pos_ : 0, [INFO] [stderr] 70 | | next_in : 0, [INFO] [stderr] 71 | | avail_in : 0, [INFO] [stderr] 72 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 67 | BrotliBitReaderState { [INFO] [stderr] 68 | val_ : 0, [INFO] [stderr] 69 | bit_pos_ : 0, [INFO] [stderr] 70 | next_in : 0, [INFO] [stderr] 71 | avail_in : 0, [INFO] [stderr] 72 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:79:3 [INFO] [stderr] | [INFO] [stderr] 79 | / return BrotliBitReaderState { val_ : from.val_, [INFO] [stderr] 80 | | bit_pos_ : from.bit_pos_, [INFO] [stderr] 81 | | next_in : from.next_in, [INFO] [stderr] 82 | | avail_in : from.avail_in }; [INFO] [stderr] | |_________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 79 | BrotliBitReaderState { val_ : from.val_, [INFO] [stderr] 80 | bit_pos_ : from.bit_pos_, [INFO] [stderr] 81 | next_in : from.next_in, [INFO] [stderr] 82 | avail_in : from.avail_in } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:95:3 [INFO] [stderr] | [INFO] [stderr] 95 | return ((::core::mem::size_of::() as u32) << 3) - br.bit_pos_; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `((::core::mem::size_of::() as u32) << 3) - br.bit_pos_` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:101:3 [INFO] [stderr] | [INFO] [stderr] 101 | return br.avail_in + (BrotliGetAvailableBits(br) >> 3); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `br.avail_in + (BrotliGetAvailableBits(br) >> 3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:108:3 [INFO] [stderr] | [INFO] [stderr] 108 | return br.avail_in >= num; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `br.avail_in >= num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:117:3 [INFO] [stderr] | [INFO] [stderr] 117 | return (two_byte[0] as u16) | ((two_byte[1] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(two_byte[0] as u16) | ((two_byte[1] as u16) << 8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:124:3 [INFO] [stderr] | [INFO] [stderr] 124 | / return (four_byte[0] as u32) | ((four_byte[1] as u32) << 8) [INFO] [stderr] 125 | | | ((four_byte[2] as u32) << 16) | ((four_byte[3] as u32) << 24); [INFO] [stderr] | |______________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 124 | (four_byte[0] as u32) | ((four_byte[1] as u32) << 8) [INFO] [stderr] 125 | | ((four_byte[2] as u32) << 16) | ((four_byte[3] as u32) << 24) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:132:3 [INFO] [stderr] | [INFO] [stderr] 132 | / return (eight_byte[0] as u64) | ((eight_byte[1] as u64) << 8) [INFO] [stderr] 133 | | | ((eight_byte[2] as u64) << 16) | ((eight_byte[3] as u64) << 24) [INFO] [stderr] 134 | | | ((eight_byte[4] as u64) << 32) | ((eight_byte[5] as u64) << 40) [INFO] [stderr] 135 | | | ((eight_byte[6] as u64) << 48) | ((eight_byte[7] as u64) << 56); [INFO] [stderr] | |________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 132 | (eight_byte[0] as u64) | ((eight_byte[1] as u64) << 8) [INFO] [stderr] 133 | | ((eight_byte[2] as u64) << 16) | ((eight_byte[3] as u64) << 24) [INFO] [stderr] 134 | | ((eight_byte[4] as u64) << 32) | ((eight_byte[5] as u64) << 40) [INFO] [stderr] 135 | | ((eight_byte[6] as u64) << 48) | ((eight_byte[7] as u64) << 56) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bit_reader/mod.rs:164:10 [INFO] [stderr] | [INFO] [stderr] 164 | } else { [INFO] [stderr] | __________^ [INFO] [stderr] 165 | | if (BROTLI_ALIGNED_READ == 0 && (n_bits <= 8)) { [INFO] [stderr] 166 | | if (br.bit_pos_ >= 24) { [INFO] [stderr] 167 | | br.val_ >>= 24; [INFO] [stderr] ... | [INFO] [stderr] 181 | | } [INFO] [stderr] 182 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 164 | } else if (BROTLI_ALIGNED_READ == 0 && (n_bits <= 8)) { [INFO] [stderr] 165 | if (br.bit_pos_ >= 24) { [INFO] [stderr] 166 | br.val_ >>= 24; [INFO] [stderr] 167 | br.bit_pos_ ^= 24; // here same as -= 24 because of the if condition [INFO] [stderr] 168 | br.val_ |= (BrotliLoad32LE(input, br.next_in) << 8) as u64; [INFO] [stderr] 169 | br.avail_in -= 3; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bit_reader/mod.rs:173:12 [INFO] [stderr] | [INFO] [stderr] 173 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 174 | | if br.bit_pos_ >= 16 { [INFO] [stderr] 175 | | br.val_ >>= 16; [INFO] [stderr] 176 | | br.bit_pos_ ^= 16; /* here same as -= 16 because of the if condition */ [INFO] [stderr] ... | [INFO] [stderr] 180 | | } [INFO] [stderr] 181 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 173 | } else if br.bit_pos_ >= 16 { [INFO] [stderr] 174 | br.val_ >>= 16; [INFO] [stderr] 175 | br.bit_pos_ ^= 16; /* here same as -= 16 because of the if condition */ [INFO] [stderr] 176 | br.val_ |= (BrotliLoad16LE(input, br.next_in) as reg_t) << 16; [INFO] [stderr] 177 | br.avail_in -= BROTLI_SHORT_FILL_BIT_WINDOW_READ; [INFO] [stderr] 178 | br.next_in += BROTLI_SHORT_FILL_BIT_WINDOW_READ; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bit_reader/mod.rs:213:10 [INFO] [stderr] | [INFO] [stderr] 213 | } else { [INFO] [stderr] | __________^ [INFO] [stderr] 214 | | if /*BROTLI_ALIGNED_READ == false && */n_bits <= 8 { // !BROTLI_ALIGNED_READ && IS_CONSTANT(n_bits) && (n_bits <= 8)) { [INFO] [stderr] 215 | | if br.bit_pos_ >= 24 { [INFO] [stderr] 216 | | br.val_ >>= 24; [INFO] [stderr] ... | [INFO] [stderr] 230 | | } [INFO] [stderr] 231 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 213 | } else if /*BROTLI_ALIGNED_READ == false && */n_bits <= 8 { // !BROTLI_ALIGNED_READ && IS_CONSTANT(n_bits) && (n_bits <= 8)) { [INFO] [stderr] 214 | if br.bit_pos_ >= 24 { [INFO] [stderr] 215 | br.val_ >>= 24; [INFO] [stderr] 216 | br.bit_pos_ ^= 24; /* here same as -= 24 because of the if condition */ [INFO] [stderr] 217 | br.val_ |= (BrotliLoad32LE(input, br.next_in) as reg_t) << 8; [INFO] [stderr] 218 | br.avail_in -= 3; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bit_reader/mod.rs:204:12 [INFO] [stderr] | [INFO] [stderr] 204 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 205 | | if br.bit_pos_ >= 32 { [INFO] [stderr] 206 | | br.val_ >>= 32; [INFO] [stderr] 207 | | br.bit_pos_ ^= 32; /* here same as -= 32 because of the if condition */ [INFO] [stderr] ... | [INFO] [stderr] 211 | | } [INFO] [stderr] 212 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 204 | } else if br.bit_pos_ >= 32 { [INFO] [stderr] 205 | br.val_ >>= 32; [INFO] [stderr] 206 | br.bit_pos_ ^= 32; /* here same as -= 32 because of the if condition */ [INFO] [stderr] 207 | br.val_ |= (BrotliLoad32LE(input, br.next_in) as reg_t) << 32; [INFO] [stderr] 208 | br.avail_in -= BROTLI_SHORT_FILL_BIT_WINDOW_READ; [INFO] [stderr] 209 | br.next_in += BROTLI_SHORT_FILL_BIT_WINDOW_READ; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/bit_reader/mod.rs:222:12 [INFO] [stderr] | [INFO] [stderr] 222 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 223 | | if br.bit_pos_ >= 16 { [INFO] [stderr] 224 | | br.val_ >>= 16; [INFO] [stderr] 225 | | br.bit_pos_ ^= 16; /* here same as -= 16 because of the if condition */ [INFO] [stderr] ... | [INFO] [stderr] 229 | | } [INFO] [stderr] 230 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 222 | } else if br.bit_pos_ >= 16 { [INFO] [stderr] 223 | br.val_ >>= 16; [INFO] [stderr] 224 | br.bit_pos_ ^= 16; /* here same as -= 16 because of the if condition */ [INFO] [stderr] 225 | br.val_ |= (BrotliLoad16LE(input, br.next_in) as reg_t) << 16; [INFO] [stderr] 226 | br.avail_in -= BROTLI_SHORT_FILL_BIT_WINDOW_READ; [INFO] [stderr] 227 | br.next_in += BROTLI_SHORT_FILL_BIT_WINDOW_READ; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:254:3 [INFO] [stderr] | [INFO] [stderr] 254 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:261:3 [INFO] [stderr] | [INFO] [stderr] 261 | return br.val_ >> br.bit_pos_; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `br.val_ >> br.bit_pos_` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:270:3 [INFO] [stderr] | [INFO] [stderr] 270 | return (BrotliGetBitsUnmasked(br) & (0xffffffffu32 as reg_t)) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(BrotliGetBitsUnmasked(br) & (0xffffffffu32 as reg_t)) as u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:270:40 [INFO] [stderr] | [INFO] [stderr] 270 | return (BrotliGetBitsUnmasked(br) & (0xffffffffu32 as reg_t)) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xffff_ffffu32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:277:3 [INFO] [stderr] | [INFO] [stderr] 277 | return (BrotliGetBitsUnmasked(br) as u32) & BitMask(n_bits); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(BrotliGetBitsUnmasked(br) as u32) & BitMask(n_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:285:3 [INFO] [stderr] | [INFO] [stderr] 285 | return (BrotliGetBitsUnmasked(br) as u32) & BitMask(n_bits); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(BrotliGetBitsUnmasked(br) as u32) & BitMask(n_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:298:3 [INFO] [stderr] | [INFO] [stderr] 298 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:340:5 [INFO] [stderr] | [INFO] [stderr] 340 | return val; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:348:5 [INFO] [stderr] | [INFO] [stderr] 348 | return low_val | (high_val << 16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `low_val | (high_val << 16)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:361:5 [INFO] [stderr] | [INFO] [stderr] 361 | return val; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:369:5 [INFO] [stderr] | [INFO] [stderr] 369 | return low_val | (high_val << 16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `low_val | (high_val << 16)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:383:3 [INFO] [stderr] | [INFO] [stderr] 383 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:394:3 [INFO] [stderr] | [INFO] [stderr] 394 | return pad_bits == 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `pad_bits == 0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:411:3 [INFO] [stderr] | [INFO] [stderr] 411 | return -1; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `-1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/bit_reader/mod.rs:405:43 [INFO] [stderr] | [INFO] [stderr] 405 | return ((BrotliGetBitsUnmasked(br) >> ((offset << 3)) as u32) & 0xFF) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_reader/mod.rs:456:3 [INFO] [stderr] | [INFO] [stderr] 456 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/bit_reader/mod.rs:443:3 [INFO] [stderr] | [INFO] [stderr] 443 | / if BrotliGetAvailableBits(br) == 0 { [INFO] [stderr] 444 | | if !BrotliPullByte(br, input) { [INFO] [stderr] 445 | | return false; [INFO] [stderr] 446 | | } [INFO] [stderr] 447 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 443 | if BrotliGetAvailableBits(br) == 0 && !BrotliPullByte(br, input) { [INFO] [stderr] 444 | return false; [INFO] [stderr] 445 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:478:37 [INFO] [stderr] | [INFO] [stderr] 478 | assert_eq!(bit_reader.val_, 0x2100000000000000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x2100_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:486:53 [INFO] [stderr] | [INFO] [stderr] 486 | let mut bit_reader = BrotliBitReader{val_ : 0x86e884e1ffff577b, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x86e8_84e1_ffff_577b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:492:37 [INFO] [stderr] | [INFO] [stderr] 492 | assert_eq!(bit_reader.val_, 0x86e884e1ffff577b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x86e8_84e1_ffff_577b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:501:56 [INFO] [stderr] | [INFO] [stderr] 501 | let mut bit_reader = BrotliBitReader{val_ : 0xe1e56a736e04fbf5, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xe1e5_6a73_6e04_fbf5` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:515:56 [INFO] [stderr] | [INFO] [stderr] 515 | let mut bit_reader = BrotliBitReader{val_ : 0x17f115ae26916f0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `0x017f_115a_e269_16f0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:529:56 [INFO] [stderr] | [INFO] [stderr] 529 | let mut bit_reader = BrotliBitReader{val_ : 0x5f43f252c027e447, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x5f43_f252_c027_e447` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:539:40 [INFO] [stderr] | [INFO] [stderr] 539 | assert_eq!(bit_reader.val_, 0xf05f43f252c027e4); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xf05f_43f2_52c0_27e4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:544:56 [INFO] [stderr] | [INFO] [stderr] 544 | let mut bit_reader = BrotliBitReader{val_ : 0x2f902339697460, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `0x002f_9023_3969_7460` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:548:32 [INFO] [stderr] | [INFO] [stderr] 548 | let mut val : u32 = 0x74eca3f0; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x74ec_a3f0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:554:40 [INFO] [stderr] | [INFO] [stderr] 554 | assert_eq!(bit_reader.val_, 0x2f902339697460); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `0x002f_9023_3969_7460` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:555:28 [INFO] [stderr] | [INFO] [stderr] 555 | assert_eq!(val, 0x74eca3f0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x74ec_a3f0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:562:57 [INFO] [stderr] | [INFO] [stderr] 562 | let mut bit_reader = BrotliBitReader{val_ : 0xf5917f07daaaeabb, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xf591_7f07_daaa_eabb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:581:57 [INFO] [stderr] | [INFO] [stderr] 581 | let mut bit_reader = BrotliBitReader{val_ : 0x27e33b2440d3feaf, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x27e3_3b24_40d3_feaf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:596:57 [INFO] [stderr] | [INFO] [stderr] 596 | let mut bit_reader = BrotliBitReader{val_ : 0xb3fc441e0181dc4, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `0x0b3f_c441_e018_1dc4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:608:57 [INFO] [stderr] | [INFO] [stderr] 608 | let mut bit_reader = BrotliBitReader{val_ : 0x655b1fe0dd6f1e78, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x655b_1fe0_dd6f_1e78` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bit_reader/mod.rs:613:29 [INFO] [stderr] | [INFO] [stderr] 613 | assert_eq!(ret, 0x38e030fc); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x38e0_30fc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/huffman/mod.rs:33:7 [INFO] [stderr] | [INFO] [stderr] 33 | return self.value == other.value && self.bits == other.bits; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.value == other.value && self.bits == other.bits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/huffman/mod.rs:39:6 [INFO] [stderr] | [INFO] [stderr] 39 | return HuffmanCode { value : 0, bits : 0}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HuffmanCode { value : 0, bits : 0}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/huffman/mod.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | return &mut self.codes.slice_mut()[start..]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&mut self.codes.slice_mut()[start..]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/huffman/mod.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | return & self.codes.slice()[start..]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `& self.codes.slice()[start..]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/huffman/mod.rs:103:7 [INFO] [stderr] | [INFO] [stderr] 103 | return ret; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/huffman/mod.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | / return HuffmanTreeGroup:: { [INFO] [stderr] 111 | | htrees : AllocU32::AllocatedMemory::default(), [INFO] [stderr] 112 | | codes : AllocHC::AllocatedMemory::default(), [INFO] [stderr] 113 | | alphabet_size : 0, [INFO] [stderr] 114 | | num_htrees : 0, [INFO] [stderr] 115 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 110 | HuffmanTreeGroup:: { [INFO] [stderr] 111 | htrees : AllocU32::AllocatedMemory::default(), [INFO] [stderr] 112 | codes : AllocHC::AllocatedMemory::default(), [INFO] [stderr] 113 | alphabet_size : 0, [INFO] [stderr] 114 | num_htrees : 0, [INFO] [stderr] 115 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/huffman/mod.rs:166:3 [INFO] [stderr] | [INFO] [stderr] 166 | return kReverseBits[num as usize] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `kReverseBits[num as usize] as u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/huffman/mod.rs:199:3 [INFO] [stderr] | [INFO] [stderr] 199 | return len - root_bits; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `len - root_bits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/huffman/mod.rs:373:3 [INFO] [stderr] | [INFO] [stderr] 373 | return total_size as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `total_size as u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/huffman/mod.rs:466:3 [INFO] [stderr] | [INFO] [stderr] 466 | return goal_size; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `goal_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state.rs:335:9 [INFO] [stderr] | [INFO] [stderr] 335 | return retval; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `retval` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state.rs:399:17 [INFO] [stderr] | [INFO] [stderr] 399 | return BrotliGetAvailableBits(&self.br) == 0, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `BrotliGetAvailableBits(&self.br) == 0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state.rs:400:18 [INFO] [stderr] | [INFO] [stderr] 400 | _ => return false, [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state.rs:406:54 [INFO] [stderr] | [INFO] [stderr] 406 | BrotliRunningState::BROTLI_STATE_DONE => return true, [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state.rs:407:18 [INFO] [stderr] | [INFO] [stderr] 407 | _ => return false, [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transform.rs:252:3 [INFO] [stderr] | [INFO] [stderr] 252 | return 3; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/transform.rs:304:5 [INFO] [stderr] | [INFO] [stderr] 304 | return idx; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/test.rs:33:3 [INFO] [stderr] | [INFO] [stderr] 33 | return (result, input_offset, output_offset); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(result, input_offset, output_offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test.rs:101:29 [INFO] [stderr] | [INFO] [stderr] 101 | assert_eq!(output_offset, 176128); [INFO] [stderr] | ^^^^^^ help: consider: `176_128` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test.rs:110:25 [INFO] [stderr] | [INFO] [stderr] 110 | for item in output[0..176128].iter_mut() { [INFO] [stderr] | ^^^^^^ help: consider: `176_128` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | return BrotliResult::ResultFailure; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `BrotliResult::ResultFailure` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:122:3 [INFO] [stderr] | [INFO] [stderr] 122 | return 17; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `17` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:311:3 [INFO] [stderr] | [INFO] [stderr] 311 | return table_element.value as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `table_element.value as u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:319:3 [INFO] [stderr] | [INFO] [stderr] 319 | return DecodeSymbol(bit_reader::BrotliGet16BitsUnmasked(br, input), &table, br); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DecodeSymbol(bit_reader::BrotliGet16BitsUnmasked(br, input), &table, br)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:361:3 [INFO] [stderr] | [INFO] [stderr] 361 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:375:3 [INFO] [stderr] | [INFO] [stderr] 375 | return SafeDecodeSymbol(&table, br, result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `SafeDecodeSymbol(&table, br, result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:415:3 [INFO] [stderr] | [INFO] [stderr] 415 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/lib.rs:405:36 [INFO] [stderr] | [INFO] [stderr] 405 | let mask = bit_reader::BitMask((*bits - HUFFMAN_TABLE_BITS)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:424:3 [INFO] [stderr] | [INFO] [stderr] 424 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:470:3 [INFO] [stderr] | [INFO] [stderr] 470 | return BrotliResult::ResultSuccess; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `BrotliResult::ResultSuccess` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:604:3 [INFO] [stderr] | [INFO] [stderr] 604 | return BrotliResult::ResultSuccess; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `BrotliResult::ResultSuccess` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:656:3 [INFO] [stderr] | [INFO] [stderr] 656 | return BrotliResult::ResultSuccess; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `BrotliResult::ResultSuccess` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:710:3 [INFO] [stderr] | [INFO] [stderr] 710 | return BrotliResult::ResultSuccess; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `BrotliResult::ResultSuccess` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:875:3 [INFO] [stderr] | [INFO] [stderr] 875 | / return prefix::kBlockLengthPrefixCode[code as usize].offset as u32 [INFO] [stderr] 876 | | + bit_reader::BrotliReadBits(br, nbits, input); [INFO] [stderr] | |_____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 875 | prefix::kBlockLengthPrefixCode[code as usize].offset as u32 [INFO] [stderr] 876 | + bit_reader::BrotliReadBits(br, nbits, input) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:893:7 [INFO] [stderr] | [INFO] [stderr] 893 | return (true, index); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(true, index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:895:10 [INFO] [stderr] | [INFO] [stderr] 895 | _ => return (true, block_length_index), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(true, block_length_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:919:5 [INFO] [stderr] | [INFO] [stderr] 919 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/lib.rs:921:1 [INFO] [stderr] | [INFO] [stderr] 921 | / macro_rules! SafeReadBlockLength ( [INFO] [stderr] 922 | | ($state : expr, $result : expr , $table : expr) => { [INFO] [stderr] 923 | | SafeReadBlockLengthFromIndex(&mut $state, &mut $result, [INFO] [stderr] 924 | | SafeReadBlockLengthIndex($state.substate_read_block_length, [INFO] [stderr] ... | [INFO] [stderr] 928 | | }; [INFO] [stderr] 929 | | ); [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1060:3 [INFO] [stderr] | [INFO] [stderr] 1060 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1265:3 [INFO] [stderr] | [INFO] [stderr] 1265 | return retval; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `retval` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1321:3 [INFO] [stderr] | [INFO] [stderr] 1321 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1349:3 [INFO] [stderr] | [INFO] [stderr] 1349 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1382:3 [INFO] [stderr] | [INFO] [stderr] 1382 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1399:3 [INFO] [stderr] | [INFO] [stderr] 1399 | return DecodeCommandBlockSwitchInternal(true, s, input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DecodeCommandBlockSwitchInternal(true, s, input)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1416:3 [INFO] [stderr] | [INFO] [stderr] 1416 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1434:3 [INFO] [stderr] | [INFO] [stderr] 1434 | return DecodeDistanceBlockSwitchInternal(true, s, input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DecodeDistanceBlockSwitchInternal(true, s, input)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1470:3 [INFO] [stderr] | [INFO] [stderr] 1470 | return BrotliResult::ResultSuccess; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `BrotliResult::ResultSuccess` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1576:3 [INFO] [stderr] | [INFO] [stderr] 1576 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/lib.rs:1563:40 [INFO] [stderr] | [INFO] [stderr] 1563 | s.ringbuffer = s.alloc_u8.alloc_cell((s.ringbuffer_size as usize + [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 1564 | | kRingBufferWriteAheadSlack as usize + kBrotliMaxDictionaryWordLength as usize)); [INFO] [stderr] | |____________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1602:3 [INFO] [stderr] | [INFO] [stderr] 1602 | return BrotliResult::ResultSuccess; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `BrotliResult::ResultSuccess` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1616:48 [INFO] [stderr] | [INFO] [stderr] 1616 | const kDistanceShortCodeIndexOffset : u32= 0xaaafff1b; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xaaaf_ff1b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1619:49 [INFO] [stderr] | [INFO] [stderr] 1619 | const kDistanceShortCodeValueOffset : u32 = 0xfa5fa500; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xfa5f_a500` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1631:27 [INFO] [stderr] | [INFO] [stderr] 1631 | s.distance_code = 0x0fffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1639:5 [INFO] [stderr] | [INFO] [stderr] 1639 | return bit_reader::BrotliSafeReadBits(br, n_bits, val, input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `bit_reader::BrotliSafeReadBits(br, n_bits, val, input)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1642:5 [INFO] [stderr] | [INFO] [stderr] 1642 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1707:3 [INFO] [stderr] | [INFO] [stderr] 1707 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1670:33 [INFO] [stderr] | [INFO] [stderr] 1670 | if ((s.distance_code as u64 & 0xfffffffffffffff0) == 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_fff0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1755:3 [INFO] [stderr] | [INFO] [stderr] 1755 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:1745:10 [INFO] [stderr] | [INFO] [stderr] 1745 | } else { [INFO] [stderr] | __________^ [INFO] [stderr] 1746 | | if (!SafeReadBits(&mut s.br, v.insert_len_extra_bits as u32, &mut insert_len_extra, input)) || [INFO] [stderr] 1747 | | (!SafeReadBits(&mut s.br, v.copy_len_extra_bits as u32, &mut copy_length, input)) { [INFO] [stderr] 1748 | | bit_reader::BrotliBitReaderRestoreState(&mut s.br, &memento); [INFO] [stderr] 1749 | | return false; [INFO] [stderr] 1750 | | } [INFO] [stderr] 1751 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1745 | } else if (!SafeReadBits(&mut s.br, v.insert_len_extra_bits as u32, &mut insert_len_extra, input)) || [INFO] [stderr] 1746 | (!SafeReadBits(&mut s.br, v.copy_len_extra_bits as u32, &mut copy_length, input)) { [INFO] [stderr] 1747 | bit_reader::BrotliBitReaderRestoreState(&mut s.br, &memento); [INFO] [stderr] 1748 | return false; [INFO] [stderr] 1749 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1763:3 [INFO] [stderr] | [INFO] [stderr] 1763 | return bit_reader::BrotliWarmupBitReader(br, input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `bit_reader::BrotliWarmupBitReader(br, input)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1771:3 [INFO] [stderr] | [INFO] [stderr] 1771 | return bit_reader::BrotliCheckInputAmount(br, num); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `bit_reader::BrotliCheckInputAmount(br, num)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:2173:3 [INFO] [stderr] | [INFO] [stderr] 2173 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:2181:5 [INFO] [stderr] | [INFO] [stderr] 2181 | return ProcessCommandsInternal(false, s, input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ProcessCommandsInternal(false, s, input)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:2189:5 [INFO] [stderr] | [INFO] [stderr] 2189 | return ProcessCommandsInternal(true, s, input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ProcessCommandsInternal(true, s, input)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:2680:3 [INFO] [stderr] | [INFO] [stderr] 2680 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:2356:11 [INFO] [stderr] | [INFO] [stderr] 2356 | / if (s.is_metadata != 0 || s.is_uncompressed != 0) { [INFO] [stderr] 2357 | | if (!bit_reader::BrotliJumpToByteBoundary(&mut s.br)) { [INFO] [stderr] 2358 | | result = BROTLI_FAILURE(); [INFO] [stderr] 2359 | | break; [INFO] [stderr] 2360 | | } [INFO] [stderr] 2361 | | } [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 2356 | if (s.is_metadata != 0 || s.is_uncompressed != 0) && (!bit_reader::BrotliJumpToByteBoundary(&mut s.br)) { [INFO] [stderr] 2357 | result = BROTLI_FAILURE(); [INFO] [stderr] 2358 | break; [INFO] [stderr] 2359 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:2370:11 [INFO] [stderr] | [INFO] [stderr] 2370 | / if (s.ringbuffer.slice().len() == 0) { [INFO] [stderr] 2371 | | if (!BrotliAllocateRingBuffer(&mut s, local_input)) { [INFO] [stderr] 2372 | | result = BROTLI_FAILURE(); [INFO] [stderr] 2373 | | break; [INFO] [stderr] 2374 | | } [INFO] [stderr] 2375 | | } [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 2370 | if (s.ringbuffer.slice().len() == 0) && (!BrotliAllocateRingBuffer(&mut s, local_input)) { [INFO] [stderr] 2371 | result = BROTLI_FAILURE(); [INFO] [stderr] 2372 | break; [INFO] [stderr] 2373 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:131:22 [INFO] [stderr] | [INFO] [stderr] 131 | mut value : &mut u32, [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:1271:45 [INFO] [stderr] | [INFO] [stderr] 1271 | mut s : &mut BlockTypeAndLengthState, [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:1272:45 [INFO] [stderr] | [INFO] [stderr] 1272 | mut br : &mut bit_reader::BrotliBitReader, [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:1332:45 [INFO] [stderr] | [INFO] [stderr] 1332 | mut s : &mut BrotliState src/lib.rs:1377:45 [INFO] [stderr] | [INFO] [stderr] 1377 | mut s : &mut BrotliState, input : &[u8]) -> bool { [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:1390:45 [INFO] [stderr] | [INFO] [stderr] 1390 | AllocHC : alloc::Allocator> (mut s : &mut BrotliState, input : &[u8]) { [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:1398:45 [INFO] [stderr] | [INFO] [stderr] 1398 | AllocHC : alloc::Allocator> (mut s : &mut BrotliState, input : &[u8]) -> bool { [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:1409:45 [INFO] [stderr] | [INFO] [stderr] 1409 | mut s : &mut BrotliState, input : &[u8]) -> bool { [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:1424:45 [INFO] [stderr] | [INFO] [stderr] 1424 | AllocHC : alloc::Allocator> (mut s : &mut BrotliState, input : &[u8]) { [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:1433:45 [INFO] [stderr] | [INFO] [stderr] 1433 | AllocHC : alloc::Allocator> (mut s : &mut BrotliState, input : &[u8]) -> bool { [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:1440:33 [INFO] [stderr] | [INFO] [stderr] 1440 | (available_out : &mut usize, mut output : &mut [u8], mut output_offset : &mut usize, [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:1440:57 [INFO] [stderr] | [INFO] [stderr] 1440 | (available_out : &mut usize, mut output : &mut [u8], mut output_offset : &mut usize, [INFO] [stderr] | ----^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:1441:20 [INFO] [stderr] | [INFO] [stderr] 1441 | mut total_out : &mut usize, s : &mut BrotliState) -> BrotliResult { [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:2198:3 [INFO] [stderr] | [INFO] [stderr] 2198 | mut available_in : &mut usize, input_offset : &mut usize, xinput : &[u8], // ugly that we are mutable [INFO] [stderr] | ----^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/transform.rs:284:9 [INFO] [stderr] | [INFO] [stderr] 284 | let mut uppercase = &mut dst[(idx - len) as usize ..]; [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:117:10 [INFO] [stderr] | [INFO] [stderr] 117 | return (two_byte[0] as u16) | ((two_byte[1] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(two_byte[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:117:34 [INFO] [stderr] | [INFO] [stderr] 117 | return (two_byte[0] as u16) | ((two_byte[1] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(two_byte[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:124:10 [INFO] [stderr] | [INFO] [stderr] 124 | return (four_byte[0] as u32) | ((four_byte[1] as u32) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(four_byte[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:124:35 [INFO] [stderr] | [INFO] [stderr] 124 | return (four_byte[0] as u32) | ((four_byte[1] as u32) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(four_byte[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:125:10 [INFO] [stderr] | [INFO] [stderr] 125 | | ((four_byte[2] as u32) << 16) | ((four_byte[3] as u32) << 24); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(four_byte[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:125:42 [INFO] [stderr] | [INFO] [stderr] 125 | | ((four_byte[2] as u32) << 16) | ((four_byte[3] as u32) << 24); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(four_byte[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:132:10 [INFO] [stderr] | [INFO] [stderr] 132 | return (eight_byte[0] as u64) | ((eight_byte[1] as u64) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(eight_byte[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:132:36 [INFO] [stderr] | [INFO] [stderr] 132 | return (eight_byte[0] as u64) | ((eight_byte[1] as u64) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(eight_byte[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:133:10 [INFO] [stderr] | [INFO] [stderr] 133 | | ((eight_byte[2] as u64) << 16) | ((eight_byte[3] as u64) << 24) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(eight_byte[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:133:43 [INFO] [stderr] | [INFO] [stderr] 133 | | ((eight_byte[2] as u64) << 16) | ((eight_byte[3] as u64) << 24) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(eight_byte[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:134:10 [INFO] [stderr] | [INFO] [stderr] 134 | | ((eight_byte[4] as u64) << 32) | ((eight_byte[5] as u64) << 40) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(eight_byte[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:134:43 [INFO] [stderr] | [INFO] [stderr] 134 | | ((eight_byte[4] as u64) << 32) | ((eight_byte[5] as u64) << 40) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(eight_byte[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:135:10 [INFO] [stderr] | [INFO] [stderr] 135 | | ((eight_byte[6] as u64) << 48) | ((eight_byte[7] as u64) << 56); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(eight_byte[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:135:43 [INFO] [stderr] | [INFO] [stderr] 135 | | ((eight_byte[6] as u64) << 48) | ((eight_byte[7] as u64) << 56); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(eight_byte[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:160:18 [INFO] [stderr] | [INFO] [stderr] 160 | br.val_ |= (BrotliLoad32LE(input, br.next_in) as reg_t) << 32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(BrotliLoad32LE(input, br.next_in))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:169:20 [INFO] [stderr] | [INFO] [stderr] 169 | br.val_ |= (BrotliLoad32LE(input, br.next_in) << 8) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(BrotliLoad32LE(input, br.next_in) << 8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:177:20 [INFO] [stderr] | [INFO] [stderr] 177 | br.val_ |= (BrotliLoad16LE(input, br.next_in) as reg_t) << 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(BrotliLoad16LE(input, br.next_in))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:208:20 [INFO] [stderr] | [INFO] [stderr] 208 | br.val_ |= (BrotliLoad32LE(input, br.next_in) as reg_t) << 32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(BrotliLoad32LE(input, br.next_in))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:218:20 [INFO] [stderr] | [INFO] [stderr] 218 | br.val_ |= (BrotliLoad32LE(input, br.next_in) as reg_t) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(BrotliLoad32LE(input, br.next_in))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:226:20 [INFO] [stderr] | [INFO] [stderr] 226 | br.val_ |= (BrotliLoad16LE(input, br.next_in) as reg_t) << 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(BrotliLoad16LE(input, br.next_in))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:247:16 [INFO] [stderr] | [INFO] [stderr] 247 | br.val_ |= (input[br.next_in as usize] as reg_t) << 56; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(input[br.next_in as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:249:16 [INFO] [stderr] | [INFO] [stderr] 249 | br.val_ |= (input[br.next_in as usize] as reg_t) << 24; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(input[br.next_in as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:270:39 [INFO] [stderr] | [INFO] [stderr] 270 | return (BrotliGetBitsUnmasked(br) & (0xffffffffu32 as reg_t)) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(0xffffffffu32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/bit_reader/mod.rs:403:11 [INFO] [stderr] | [INFO] [stderr] 403 | assert!((available_bits & 7) == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `available_bits.trailing_zeros() >= 3` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::verbose_bit_mask)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:409:12 [INFO] [stderr] | [INFO] [stderr] 409 | return input[br.next_in as usize + offset as usize] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(input[br.next_in as usize + offset as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: defining a method called `eq` on this type; consider implementing the `std::cmp::PartialEq` trait or choosing a less ambiguous name [INFO] [stderr] --> src/huffman/mod.rs:32:3 [INFO] [stderr] | [INFO] [stderr] 32 | / pub fn eq(&self, other: &Self) -> bool { [INFO] [stderr] 33 | | return self.value == other.value && self.bits == other.bits; [INFO] [stderr] 34 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/huffman/mod.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn eq(&self, other: &Self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/huffman/mod.rs:32:27 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn eq(&self, other: &Self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/huffman/mod.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | / pub fn get_tree_mut<'a>(self :&'a mut Self, index : u32) -> &'a mut [HuffmanCode] { [INFO] [stderr] 74 | | let start : usize = self.htrees.slice()[index as usize] as usize; [INFO] [stderr] 75 | | return &mut self.codes.slice_mut()[start..]; [INFO] [stderr] 76 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/huffman/mod.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | / pub fn get_tree<'a>(self :&'a Self, index : u32) -> &'a [HuffmanCode] { [INFO] [stderr] 79 | | let start : usize = self.htrees.slice()[index as usize] as usize; [INFO] [stderr] 80 | | return & self.codes.slice()[start..]; [INFO] [stderr] 81 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the variable `index` is used as a loop counter. Consider using `for (index, item) in self.htrees.slice().enumerate()` or similar iterators [INFO] [stderr] --> src/huffman/mod.rs:99:20 [INFO] [stderr] | [INFO] [stderr] 99 | for htree in self.htrees.slice() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/huffman/mod.rs:166:10 [INFO] [stderr] | [INFO] [stderr] 166 | return kReverseBits[num as usize] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(kReverseBits[num as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/huffman/mod.rs:192:13 [INFO] [stderr] | [INFO] [stderr] 192 | left -= count[len as usize] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(count[len as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/huffman/mod.rs:269:8 [INFO] [stderr] | [INFO] [stderr] 269 | if !(bits <= BROTLI_HUFFMAN_MAX_CODE_LENGTH_CODE_LENGTH as i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `bits > BROTLI_HUFFMAN_MAX_CODE_LENGTH_CODE_LENGTH as i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/huffman/mod.rs:217:15 [INFO] [stderr] | [INFO] [stderr] 217 | symbol += count[bits as usize] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(count[bits as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/huffman/mod.rs:257:32 [INFO] [stderr] | [INFO] [stderr] 257 | let mut bits_count : i32 = count[bits as usize] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(count[bits as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/huffman/mod.rs:323:8 [INFO] [stderr] | [INFO] [stderr] 323 | if !(bits <= table_bits) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `bits > table_bits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/huffman/mod.rs:311:32 [INFO] [stderr] | [INFO] [stderr] 311 | let mut bits_count : i32 = count[bits as usize] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(count[bits as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/huffman/mod.rs:313:16 [INFO] [stderr] | [INFO] [stderr] 313 | symbol = symbol_lists[(symbol_lists_offset as isize + symbol as isize) as usize] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(symbol_lists[(symbol_lists_offset as isize + symbol as isize) as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/huffman/mod.rs:362:16 [INFO] [stderr] | [INFO] [stderr] 362 | symbol = symbol_lists[(symbol_lists_offset as isize + symbol as isize) as usize] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(symbol_lists[(symbol_lists_offset as isize + symbol as isize) as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/huffman/mod.rs:415:7 [INFO] [stderr] | [INFO] [stderr] 415 | / let last : u16; [INFO] [stderr] 416 | | if val.len() > 3 { [INFO] [stderr] 417 | | last = val[3]; [INFO] [stderr] 418 | | } else { [INFO] [stderr] 419 | | last = 65535; [INFO] [stderr] 420 | | } [INFO] [stderr] | |_______^ help: it is more idiomatic to write: `let last = if val.len() > 3 { val[3] } else { 65535 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `mval` manually [INFO] [stderr] --> src/huffman/mod.rs:425:13 [INFO] [stderr] | [INFO] [stderr] 425 | / let t : u16 = mval[k]; [INFO] [stderr] 426 | | mval[k] = mval[i]; [INFO] [stderr] 427 | | mval[i] = t; [INFO] [stderr] | |_______________________^ help: try: `mval.swap(k, i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `table`. [INFO] [stderr] --> src/huffman/mod.rs:431:16 [INFO] [stderr] | [INFO] [stderr] 431 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 431 | for in table.iter_mut().take(4) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `mval` manually [INFO] [stderr] --> src/huffman/mod.rs:442:9 [INFO] [stderr] | [INFO] [stderr] 442 | / let t : u16 = mval[3]; [INFO] [stderr] 443 | | mval[3] = mval[2]; [INFO] [stderr] 444 | | mval[2] = t; [INFO] [stderr] | |___________________^ help: try: `mval.swap(3, 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `table` [INFO] [stderr] --> src/huffman/mod.rs:446:16 [INFO] [stderr] | [INFO] [stderr] 446 | for i in 0..7 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 446 | for (i, ) in table.iter_mut().enumerate().take(7) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/transform.rs:240:17 [INFO] [stderr] | [INFO] [stderr] 240 | if (p[0] >= 'a' as u8 && p[0] <= 'z' as u8) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/transform.rs:240:38 [INFO] [stderr] | [INFO] [stderr] 240 | if (p[0] >= 'a' as u8 && p[0] <= 'z' as u8) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'z' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/transform.rs:264:5 [INFO] [stderr] | [INFO] [stderr] 264 | / let mut skip : i32; [INFO] [stderr] 265 | | if t < kOmitFirst1 { [INFO] [stderr] 266 | | skip = 0; [INFO] [stderr] 267 | | } else { [INFO] [stderr] 268 | | skip = t as i32 - (kOmitFirst1 - 1) as i32; [INFO] [stderr] 269 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let skip = if t < kOmitFirst1 { 0 } else { t as i32 - (kOmitFirst1 - 1) as i32 };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/transform.rs:268:14 [INFO] [stderr] | [INFO] [stderr] 268 | skip = t as i32 - (kOmitFirst1 - 1) as i32; [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(t)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/transform.rs:268:25 [INFO] [stderr] | [INFO] [stderr] 268 | skip = t as i32 - (kOmitFirst1 - 1) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(kOmitFirst1 - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/transform.rs:277:14 [INFO] [stderr] | [INFO] [stderr] 277 | len -= t as i32; [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(t)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:179:5 [INFO] [stderr] | [INFO] [stderr] 179 | 'a, AllocU8 : alloc::Allocator, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:228:19 [INFO] [stderr] | [INFO] [stderr] 228 | while i < s.size_nibbles as i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(s.size_nibbles)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:233:24 [INFO] [stderr] | [INFO] [stderr] 233 | if (i + 1 == s.size_nibbles as i32 && s.size_nibbles > 4 && bits == 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(s.size_nibbles)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:277:19 [INFO] [stderr] | [INFO] [stderr] 277 | while i < s.size_nibbles as i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(s.size_nibbles)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:282:24 [INFO] [stderr] | [INFO] [stderr] 282 | if (i + 1 == s.size_nibbles as i32 && s.size_nibbles > 1 && bits == 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(s.size_nibbles)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:306:20 [INFO] [stderr] | [INFO] [stderr] 306 | table_index += table_element.value as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(table_element.value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:308:82 [INFO] [stderr] | [INFO] [stderr] 308 | + ((bits >> HUFFMAN_TABLE_BITS) & bit_reader::BitMask(nbits as u32))) as usize]; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(nbits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:310:34 [INFO] [stderr] | [INFO] [stderr] 310 | bit_reader::BrotliDropBits(br, table_element.bits as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(table_element.bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:311:10 [INFO] [stderr] | [INFO] [stderr] 311 | return table_element.value as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(table_element.value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: The function/method `bit_reader::BrotliGetAvailableBits` doesn't need a mutable reference [INFO] [stderr] --> src/lib.rs:327:63 [INFO] [stderr] | [INFO] [stderr] 327 | let mut available_bits = bit_reader::BrotliGetAvailableBits(&mut br); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:330:17 [INFO] [stderr] | [INFO] [stderr] 330 | *result = table[0].value as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(table[0].value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:339:9 [INFO] [stderr] | [INFO] [stderr] 339 | if (table_element.bits as u32 <= available_bits) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(table_element.bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:340:43 [INFO] [stderr] | [INFO] [stderr] 340 | bit_reader::BrotliDropBits(&mut br, table_element.bits as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(table_element.bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:341:17 [INFO] [stderr] | [INFO] [stderr] 341 | *result = table_element.value as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(table_element.value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:352:36 [INFO] [stderr] | [INFO] [stderr] 352 | val = (val & bit_reader::BitMask(table_element.bits as u32)) >> HUFFMAN_TABLE_BITS; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(table_element.bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:355:24 [INFO] [stderr] | [INFO] [stderr] 355 | if (available_bits < table_sub_element.bits as u32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(table_sub_element.bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:359:60 [INFO] [stderr] | [INFO] [stderr] 359 | bit_reader::BrotliDropBits(&mut br, HUFFMAN_TABLE_BITS + table_sub_element.bits as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(table_sub_element.bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:360:13 [INFO] [stderr] | [INFO] [stderr] 360 | *result = table_sub_element.value as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(table_sub_element.value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:389:11 [INFO] [stderr] | [INFO] [stderr] 389 | *bits = table_element.bits as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(table_element.bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:390:12 [INFO] [stderr] | [INFO] [stderr] 390 | *value = table_element.value as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(table_element.value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:400:3 [INFO] [stderr] | [INFO] [stderr] 400 | / let mut result = *value; [INFO] [stderr] 401 | | if *bits > HUFFMAN_TABLE_BITS { [INFO] [stderr] 402 | | mark_unlikely(); [INFO] [stderr] 403 | | let val = bit_reader::BrotliGet16BitsUnmasked(br, input); [INFO] [stderr] ... | [INFO] [stderr] 412 | | bit_reader::BrotliDropBits(br, *bits); [INFO] [stderr] 413 | | } [INFO] [stderr] | |___^ help: it is more idiomatic to write: `let result = if *bits > HUFFMAN_TABLE_BITS { ..; ext.value as u32 } else { ..; *value };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:409:36 [INFO] [stderr] | [INFO] [stderr] 409 | bit_reader::BrotliDropBits(br, ext.bits as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(ext.bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:410:14 [INFO] [stderr] | [INFO] [stderr] 410 | result = ext.value as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(ext.value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:433:5 [INFO] [stderr] | [INFO] [stderr] 433 | 'a, AllocU8 : alloc::Allocator, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:444:51 [INFO] [stderr] | [INFO] [stderr] 444 | for symbols_lists_item in s.symbols_lists_array[s.sub_loop_counter as usize .. [INFO] [stderr] | ___________________________________________________^ [INFO] [stderr] 445 | | num_symbols as usize + 1].iter_mut() { [INFO] [stderr] | |__________________________________________________________________________^ help: use: `s.sub_loop_counter as usize..=num_symbols as usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:462:45 [INFO] [stderr] | [INFO] [stderr] 462 | for other_item in s.symbols_lists_array[i as usize + 1 .. num_symbols as usize+ 1].iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `i as usize + 1..=num_symbols as usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/lib.rs:480:1 [INFO] [stderr] | [INFO] [stderr] 480 | / fn ProcessSingleCodeLength(code_len : u32, [INFO] [stderr] 481 | | symbol : &mut u32, repeat : &mut u32, space : &mut u32, [INFO] [stderr] 482 | | prev_code_len : &mut u32, symbol_lists : &mut [u16], symbol_list_index_offset : usize, [INFO] [stderr] 483 | | code_length_histo : &mut [u16], next_symbol : &mut [i32]) { [INFO] [stderr] ... | [INFO] [stderr] 494 | | (*symbol) += 1; [INFO] [stderr] 495 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> src/lib.rs:506:1 [INFO] [stderr] | [INFO] [stderr] 506 | / fn ProcessRepeatedCodeLength(code_len : u32, [INFO] [stderr] 507 | | mut repeat_delta : u32, alphabet_size : u32, symbol : &mut u32, [INFO] [stderr] 508 | | repeat : &mut u32, space : &mut u32, prev_code_len : &mut u32, [INFO] [stderr] 509 | | repeat_code_len : &mut u32, symbol_lists : &mut [u16], symbol_lists_index : usize, [INFO] [stderr] ... | [INFO] [stderr] 552 | | } [INFO] [stderr] 553 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:512:3 [INFO] [stderr] | [INFO] [stderr] 512 | / let mut new_len : u32 = 0; [INFO] [stderr] 513 | | if (code_len == kCodeLengthRepeatCode) { [INFO] [stderr] 514 | | new_len = *prev_code_len; [INFO] [stderr] 515 | | } [INFO] [stderr] | |___^ help: it is more idiomatic to write: `let new_len = if (code_len == kCodeLengthRepeatCode) { *prev_code_len } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:549:10 [INFO] [stderr] | [INFO] [stderr] 549 | (code_length_histo[*repeat_code_len as usize] as u32 + repeat_delta) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(code_length_histo[*repeat_code_len as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:557:5 [INFO] [stderr] | [INFO] [stderr] 557 | 'a, AllocU8 : alloc::Allocator, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:585:9 [INFO] [stderr] | [INFO] [stderr] 585 | bit_reader::BitMask(huffman::BROTLI_HUFFMAN_MAX_CODE_LENGTH_CODE_LENGTH as u32) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(bit_reader::BitMask(huffman::BROTLI_HUFFMAN_MAX_CODE_LENGTH_CODE_LENGTH as u32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:587:43 [INFO] [stderr] | [INFO] [stderr] 587 | bit_reader::BrotliDropBits(&mut s.br, p.bits as u32); /* Use 1..5 bits */ [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(p.bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:588:16 [INFO] [stderr] | [INFO] [stderr] 588 | code_len = p.value as u32; /* code_len == 0..17 */ [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(p.value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:608:5 [INFO] [stderr] | [INFO] [stderr] 608 | 'a, AllocU8 : alloc::Allocator, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:624:9 [INFO] [stderr] | [INFO] [stderr] 624 | if (p.bits as u32> available_bits) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(p.bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:631:16 [INFO] [stderr] | [INFO] [stderr] 631 | code_len = p.value as u32; /* code_len == 0..17 */ [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(p.value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:633:45 [INFO] [stderr] | [INFO] [stderr] 633 | bit_reader::BrotliDropBits(&mut s.br, p.bits as u32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(p.bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:641:28 [INFO] [stderr] | [INFO] [stderr] 641 | if (available_bits < p.bits as u32 + extra_bits) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(p.bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:648:45 [INFO] [stderr] | [INFO] [stderr] 648 | bit_reader::BrotliDropBits(&mut s.br, p.bits as u32 + extra_bits); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(p.bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:662:5 [INFO] [stderr] | [INFO] [stderr] 662 | 'a, AllocU8 : alloc::Allocator, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:683:11 [INFO] [stderr] | [INFO] [stderr] 683 | if (kCodeLengthPrefixLength[ix as usize] as u32 > available_bits) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(kCodeLengthPrefixLength[ix as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:692:19 [INFO] [stderr] | [INFO] [stderr] 692 | let v : u32 = kCodeLengthPrefixValue[ix as usize] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(kCodeLengthPrefixValue[ix as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:693:43 [INFO] [stderr] | [INFO] [stderr] 693 | bit_reader::BrotliDropBits(&mut s.br, kCodeLengthPrefixLength[ix as usize] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(kCodeLengthPrefixLength[ix as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:697:7 [INFO] [stderr] | [INFO] [stderr] 697 | space = space - (32 >> v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `space -= (32 >> v)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:727:5 [INFO] [stderr] | [INFO] [stderr] 727 | 'a, AllocU8 : alloc::Allocator, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:753:56 [INFO] [stderr] | [INFO] [stderr] 753 | for code_length_histo in s.code_length_histo[..huffman::BROTLI_HUFFMAN_MAX_CODE_LENGTH_CODE_LENGTH as usize + 1].iter_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `..=huffman::BROTLI_HUFFMAN_MAX_CODE_LENGTH_CODE_LENGTH as usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:798:9 [INFO] [stderr] | [INFO] [stderr] 798 | / match opt_table_size { [INFO] [stderr] 799 | | Some(opt_table_size_ref) => *opt_table_size_ref = table_size, [INFO] [stderr] 800 | | None => {}, [INFO] [stderr] 801 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(opt_table_size_ref) = opt_table_size { *opt_table_size_ref = table_size }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: The function/method `huffman::BrotliBuildCodeLengthsHuffmanTable` doesn't need a mutable reference [INFO] [stderr] --> src/lib.rs:815:53 [INFO] [stderr] | [INFO] [stderr] 815 | &mut s.code_length_code_lengths, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `huffman::BrotliBuildCodeLengthsHuffmanTable` doesn't need a mutable reference [INFO] [stderr] --> src/lib.rs:816:53 [INFO] [stderr] | [INFO] [stderr] 816 | &mut s.code_length_histo); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in s.next_symbol[..huffman::BROTLI_HUFFMAN_MAX_CODE_LENGTH as usize + 1].iter_mut().enumerate()` or similar iterators [INFO] [stderr] --> src/lib.rs:822:32 [INFO] [stderr] | [INFO] [stderr] 822 | for next_symbol_mut in s.next_symbol[..huffman::BROTLI_HUFFMAN_MAX_CODE_LENGTH as usize + 1].iter_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:822:46 [INFO] [stderr] | [INFO] [stderr] 822 | for next_symbol_mut in s.next_symbol[..huffman::BROTLI_HUFFMAN_MAX_CODE_LENGTH as usize + 1].iter_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `..=huffman::BROTLI_HUFFMAN_MAX_CODE_LENGTH as usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:841:9 [INFO] [stderr] | [INFO] [stderr] 841 | / match result { [INFO] [stderr] 842 | | BrotliResult::NeedsMoreInput => result = SafeReadSymbolCodeLengths(alphabet_size, s, input), [INFO] [stderr] 843 | | _ => {}, [INFO] [stderr] 844 | | } [INFO] [stderr] | |_________^ help: try this: `if let BrotliResult::NeedsMoreInput = result { result = SafeReadSymbolCodeLengths(alphabet_size, s, input) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:856:9 [INFO] [stderr] | [INFO] [stderr] 856 | / match opt_table_size { [INFO] [stderr] 857 | | Some(opt_table_size_ref) => *opt_table_size_ref = table_size, [INFO] [stderr] 858 | | None => {}, [INFO] [stderr] 859 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(opt_table_size_ref) = opt_table_size { *opt_table_size_ref = table_size }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:874:11 [INFO] [stderr] | [INFO] [stderr] 874 | nbits = prefix::kBlockLengthPrefixCode[code as usize].nbits as u32; /* nbits == 2..24 */ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(prefix::kBlockLengthPrefixCode[code as usize].nbits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:875:10 [INFO] [stderr] | [INFO] [stderr] 875 | return prefix::kBlockLengthPrefixCode[code as usize].offset as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(prefix::kBlockLengthPrefixCode[code as usize].offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:910:45 [INFO] [stderr] | [INFO] [stderr] 910 | if (!bit_reader::BrotliSafeReadBits(br, nbits as u32, &mut bits, input)) { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(nbits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:916:15 [INFO] [stderr] | [INFO] [stderr] 916 | *result = prefix::kBlockLengthPrefixCode[index as usize].offset as u32 + bits; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(prefix::kBlockLengthPrefixCode[index as usize].offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in mtf[0..(upper_bound as usize + 1usize)].iter_mut().enumerate()` or similar iterators [INFO] [stderr] --> src/lib.rs:950:15 [INFO] [stderr] | [INFO] [stderr] 950 | for item in mtf[0..(upper_bound as usize + 1usize)].iter_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:950:19 [INFO] [stderr] | [INFO] [stderr] 950 | for item in mtf[0..(upper_bound as usize + 1usize)].iter_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=upper_bound as usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:958:21 [INFO] [stderr] | [INFO] [stderr] 958 | let mut index = (*v_i) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from((*v_i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:960:20 [INFO] [stderr] | [INFO] [stderr] 960 | upper_bound |= (*v_i) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from((*v_i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:980:3 [INFO] [stderr] | [INFO] [stderr] 980 | 'a, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1020:30 [INFO] [stderr] | [INFO] [stderr] 1020 | result = ReadHuffmanCode(alphabet_size as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(alphabet_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:1056:3 [INFO] [stderr] | [INFO] [stderr] 1056 | / match result { [INFO] [stderr] 1057 | | BrotliResult::ResultSuccess => s.substate_tree_group = BrotliRunningTreeGroupState::BROTLI_STATE_TREE_GROUP_NONE, [INFO] [stderr] 1058 | | _ => {}, [INFO] [stderr] 1059 | | } [INFO] [stderr] | |___^ help: try this: `if let BrotliResult::ResultSuccess = result { s.substate_tree_group = BrotliRunningTreeGroupState::BROTLI_STATE_TREE_GROUP_NONE }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:1081:3 [INFO] [stderr] | [INFO] [stderr] 1081 | 'a, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:1154:9 [INFO] [stderr] | [INFO] [stderr] 1154 | / let mut rleCodeGoto : bool = false; [INFO] [stderr] 1155 | | if (code != 0xFFFF) { [INFO] [stderr] 1156 | | rleCodeGoto = true; [INFO] [stderr] 1157 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let rleCodeGoto = if (code != 0xFFFF) { true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:1230:3 [INFO] [stderr] | [INFO] [stderr] 1230 | 'a, AllocU8 : alloc::Allocator, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:1244:3 [INFO] [stderr] | [INFO] [stderr] 1244 | / let mut context_map_arg : AllocU8::AllocatedMemory; [INFO] [stderr] 1245 | | if is_dist_context_map { [INFO] [stderr] 1246 | | num_htrees = s.num_dist_htrees; [INFO] [stderr] 1247 | | context_map_arg = mem::replace(&mut s.dist_context_map, [INFO] [stderr] ... | [INFO] [stderr] 1252 | | AllocU8::AllocatedMemory::default()); [INFO] [stderr] 1253 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 1244 | let context_map_arg = if is_dist_context_map { ..; mem::replace(&mut s.dist_context_map, [INFO] [stderr] 1245 | AllocU8::AllocatedMemory::default()) } else { ..; mem::replace(&mut s.context_map, [INFO] [stderr] 1246 | AllocU8::AllocatedMemory::default()) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:1373:3 [INFO] [stderr] | [INFO] [stderr] 1373 | 'a, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:1387:3 [INFO] [stderr] | [INFO] [stderr] 1387 | 'a, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:1395:3 [INFO] [stderr] | [INFO] [stderr] 1395 | 'a, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:1405:3 [INFO] [stderr] | [INFO] [stderr] 1405 | 'a, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:1421:3 [INFO] [stderr] | [INFO] [stderr] 1421 | 'a, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:1430:3 [INFO] [stderr] | [INFO] [stderr] 1430 | 'a, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:1437:20 [INFO] [stderr] | [INFO] [stderr] 1437 | fn WriteRingBuffer<'a, AllocU8 : alloc::Allocator, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:1442:3 [INFO] [stderr] | [INFO] [stderr] 1442 | / let pos : usize; [INFO] [stderr] 1443 | | if s.pos > s.ringbuffer_size { [INFO] [stderr] 1444 | | pos = s.ringbuffer_size as usize; [INFO] [stderr] 1445 | | } else { [INFO] [stderr] 1446 | | pos = s.pos as usize; [INFO] [stderr] 1447 | | } [INFO] [stderr] | |___^ help: it is more idiomatic to write: `let pos = if s.pos > s.ringbuffer_size { s.ringbuffer_size as usize } else { s.pos as usize };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:1473:34 [INFO] [stderr] | [INFO] [stderr] 1473 | fn CopyUncompressedBlockToOutput<'a, AllocU8 : alloc::Allocator, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:1527:5 [INFO] [stderr] | [INFO] [stderr] 1527 | 'a, AllocU8 : alloc::Allocator, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:1565:6 [INFO] [stderr] | [INFO] [stderr] 1565 | if (s.ringbuffer.slice().len() == 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.ringbuffer.slice().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:1570:6 [INFO] [stderr] | [INFO] [stderr] 1570 | if (s.custom_dict.slice().len() > 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.custom_dict.slice().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:1580:25 [INFO] [stderr] | [INFO] [stderr] 1580 | pub fn ReadContextModes<'a, AllocU8 : alloc::Allocator, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:1605:35 [INFO] [stderr] | [INFO] [stderr] 1605 | pub fn TakeDistanceFromRingBuffer<'a, AllocU8 : alloc::Allocator, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:1647:29 [INFO] [stderr] | [INFO] [stderr] 1647 | pub fn ReadDistanceInternal<'a, AllocU8 : alloc::Allocator, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: The function/method `bit_reader::BrotliBitReaderRestoreState` doesn't need a mutable reference [INFO] [stderr] --> src/lib.rs:1694:62 [INFO] [stderr] | [INFO] [stderr] 1694 | bit_reader::BrotliBitReaderRestoreState(&mut s.br, &mut memento); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:1711:28 [INFO] [stderr] | [INFO] [stderr] 1711 | pub fn ReadCommandInternal<'a, AllocU8 : alloc::Allocator, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1734:21 [INFO] [stderr] | [INFO] [stderr] 1734 | s.distance_code = v.distance_code as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(v.distance_code)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1735:24 [INFO] [stderr] | [INFO] [stderr] 1735 | s.distance_context = v.context as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(v.context)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1738:20 [INFO] [stderr] | [INFO] [stderr] 1738 | *insert_length = v.insert_len_offset as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(v.insert_len_offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1742:64 [INFO] [stderr] | [INFO] [stderr] 1742 | insert_len_extra = bit_reader::BrotliReadBits(&mut s.br, v.insert_len_extra_bits as u32, input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(v.insert_len_extra_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1744:57 [INFO] [stderr] | [INFO] [stderr] 1744 | copy_length = bit_reader::BrotliReadBits(&mut s.br, v.copy_len_extra_bits as u32, input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(v.copy_len_extra_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1746:34 [INFO] [stderr] | [INFO] [stderr] 1746 | if (!SafeReadBits(&mut s.br, v.insert_len_extra_bits as u32, &mut insert_len_extra, input)) || [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(v.insert_len_extra_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1747:34 [INFO] [stderr] | [INFO] [stderr] 1747 | (!SafeReadBits(&mut s.br, v.copy_len_extra_bits as u32, &mut copy_length, input)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(v.copy_len_extra_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1752:40 [INFO] [stderr] | [INFO] [stderr] 1752 | s.copy_length = copy_length as i32 + v.copy_len_offset as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(v.copy_len_offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: The function/method `clone_from_slice` doesn't need a mutable reference [INFO] [stderr] --> src/lib.rs:1799:34 [INFO] [stderr] | [INFO] [stderr] 1799 | local_array.clone_from_slice(&mut data[off_src as usize .. off_src as usize + 16]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `clone_from_slice` doesn't need a mutable reference [INFO] [stderr] --> src/lib.rs:1800:70 [INFO] [stderr] | [INFO] [stderr] 1800 | data[off_dst as usize .. off_dst as usize + 16].clone_from_slice(&mut local_array); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 46 [INFO] [stderr] --> src/lib.rs:1818:1 [INFO] [stderr] | [INFO] [stderr] 1818 | / fn ProcessCommandsInternal< [INFO] [stderr] 1819 | | AllocU8 : alloc::Allocator, [INFO] [stderr] 1820 | | AllocU32 : alloc::Allocator, [INFO] [stderr] 1821 | | AllocHC : alloc::Allocator > (safe : bool, [INFO] [stderr] ... | [INFO] [stderr] 2173 | | return result; [INFO] [stderr] 2174 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:2027:22 [INFO] [stderr] | [INFO] [stderr] 2027 | if (i >= kBrotliMinDictionaryWordLength as i32 && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(kBrotliMinDictionaryWordLength)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:2028:22 [INFO] [stderr] | [INFO] [stderr] 2028 | i <= kBrotliMaxDictionaryWordLength as i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(kBrotliMaxDictionaryWordLength)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:2032:46 [INFO] [stderr] | [INFO] [stderr] 2032 | let mask = bit_reader::BitMask(shift as u32) as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(shift)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:2177:5 [INFO] [stderr] | [INFO] [stderr] 2177 | 'a, AllocU8 : alloc::Allocator, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:2185:5 [INFO] [stderr] | [INFO] [stderr] 2185 | 'a, AllocU8 : alloc::Allocator, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:2195:31 [INFO] [stderr] | [INFO] [stderr] 2195 | pub fn BrotliDecompressStream<'a, AllocU8 : alloc::Allocator, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 55 [INFO] [stderr] --> src/lib.rs:2195:1 [INFO] [stderr] | [INFO] [stderr] 2195 | / pub fn BrotliDecompressStream<'a, AllocU8 : alloc::Allocator, [INFO] [stderr] 2196 | | AllocU32 : alloc::Allocator, [INFO] [stderr] 2197 | | AllocHC : alloc::Allocator> ( [INFO] [stderr] 2198 | | mut available_in : &mut usize, input_offset : &mut usize, xinput : &[u8], // ugly that we are mutable [INFO] [stderr] ... | [INFO] [stderr] 2680 | | return result; [INFO] [stderr] 2681 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/lib.rs:2195:1 [INFO] [stderr] | [INFO] [stderr] 2195 | / pub fn BrotliDecompressStream<'a, AllocU8 : alloc::Allocator, [INFO] [stderr] 2196 | | AllocU32 : alloc::Allocator, [INFO] [stderr] 2197 | | AllocHC : alloc::Allocator> ( [INFO] [stderr] 2198 | | mut available_in : &mut usize, input_offset : &mut usize, xinput : &[u8], // ugly that we are mutable [INFO] [stderr] ... | [INFO] [stderr] 2680 | | return result; [INFO] [stderr] 2681 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:2205:36 [INFO] [stderr] | [INFO] [stderr] 2205 | let mut saved_buffer : [u8; 8] = s.buffer.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `s.buffer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:2236:16 [INFO] [stderr] | [INFO] [stderr] 2236 | if s.ringbuffer.slice().len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.ringbuffer.slice().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:2330:14 [INFO] [stderr] | [INFO] [stderr] 2330 | if (s.block_type_length_state.block_type_trees.slice().len() == 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.block_type_length_state.block_type_trees.slice().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:2370:14 [INFO] [stderr] | [INFO] [stderr] 2370 | if (s.ringbuffer.slice().len() == 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.ringbuffer.slice().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:2406:11 [INFO] [stderr] | [INFO] [stderr] 2406 | / match result { [INFO] [stderr] 2407 | | BrotliResult::ResultSuccess => s.state = BrotliRunningState::BROTLI_STATE_METABLOCK_DONE, [INFO] [stderr] 2408 | | _ => {}, [INFO] [stderr] 2409 | | } [INFO] [stderr] | |___________^ help: try this: `if let BrotliResult::ResultSuccess = result { s.state = BrotliRunningState::BROTLI_STATE_METABLOCK_DONE }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:2496:14 [INFO] [stderr] | [INFO] [stderr] 2496 | if (s.context_modes.slice().len() == 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.context_modes.slice().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the variable `j` is used as a loop counter. Consider using `for (j, item) in s.context_map.slice()[0 .. (s.block_type_length_state.num_block_types[0] as usize) << (kLiteralContextBits as usize)].iter().enumerate()` or similar iterators [INFO] [stderr] --> src/lib.rs:2522:35 [INFO] [stderr] | [INFO] [stderr] 2522 | for context_map_item in s.context_map.slice()[0 .. (s.block_type_length_state.num_block_types[0] as usize) << (kLiteralContextBits as usize)].iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:2553:17 [INFO] [stderr] | [INFO] [stderr] 2553 | if (s.literal_hgroup.codes.slice().len() == 0 || [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.literal_hgroup.codes.slice().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:2554:17 [INFO] [stderr] | [INFO] [stderr] 2554 | s.insert_copy_hgroup.codes.slice().len() == 0 || [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.insert_copy_hgroup.codes.slice().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:2555:17 [INFO] [stderr] | [INFO] [stderr] 2555 | s.distance_hgroup.codes.slice().len() == 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.distance_hgroup.codes.slice().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:2589:11 [INFO] [stderr] | [INFO] [stderr] 2589 | / match result { [INFO] [stderr] 2590 | | BrotliResult::NeedsMoreInput => result = SafeProcessCommands(s, local_input), [INFO] [stderr] 2591 | | _ => {}, [INFO] [stderr] 2592 | | } [INFO] [stderr] | |___________^ help: try this: `if let BrotliResult::NeedsMoreInput = result { result = SafeProcessCommands(s, local_input) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:2667:14 [INFO] [stderr] | [INFO] [stderr] 2667 | if (s.ringbuffer.slice().len() != 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.ringbuffer.slice().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/brot.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | return SystemTime::now(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `SystemTime::now()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/brot.rs:39:22 [INFO] [stderr] | [INFO] [stderr] 39 | Ok(delta) => return (delta, false), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(delta, false)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/brot.rs:40:14 [INFO] [stderr] | [INFO] [stderr] 40 | _ => return (Duration::new(0, 0), true), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Duration::new(0, 0), true)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/brot.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | return decompress_internal(r, w, 4096 * 1024, 4096 * 1024); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `decompress_internal(r, w, 4096 * 1024, 4096 * 1024)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/integration_tests.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | return ret; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ret` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/integration_tests.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | return Ok(bytes_to_read); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(bytes_to_read)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/integration_tests.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | return Ok(buf.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buf.len())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/integration_tests.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/brot.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | return SystemTime::now(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `SystemTime::now()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/brot.rs:39:22 [INFO] [stderr] | [INFO] [stderr] 39 | Ok(delta) => return (delta, false), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(delta, false)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/brot.rs:40:14 [INFO] [stderr] | [INFO] [stderr] 40 | _ => return (Duration::new(0, 0), true), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Duration::new(0, 0), true)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bin/brot.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | return decompress_internal(r, w, 4096 * 1024, 4096 * 1024); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `decompress_internal(r, w, 4096 * 1024, 4096 * 1024)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:131:22 [INFO] [stderr] | [INFO] [stderr] 131 | mut value : &mut u32, [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:1271:45 [INFO] [stderr] | [INFO] [stderr] 1271 | mut s : &mut BlockTypeAndLengthState, [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:1272:45 [INFO] [stderr] | [INFO] [stderr] 1272 | mut br : &mut bit_reader::BrotliBitReader, [INFO] [stderr] | ----^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:1332:45 [INFO] [stderr] | [INFO] [stderr] 1332 | mut s : &mut BrotliState src/lib.rs:1377:45 [INFO] [stderr] | [INFO] [stderr] 1377 | mut s : &mut BrotliState, input : &[u8]) -> bool { [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:1390:45 [INFO] [stderr] | [INFO] [stderr] 1390 | AllocHC : alloc::Allocator> (mut s : &mut BrotliState, input : &[u8]) { [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:1398:45 [INFO] [stderr] | [INFO] [stderr] 1398 | AllocHC : alloc::Allocator> (mut s : &mut BrotliState, input : &[u8]) -> bool { [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:1409:45 [INFO] [stderr] | [INFO] [stderr] 1409 | mut s : &mut BrotliState, input : &[u8]) -> bool { [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:1424:45 [INFO] [stderr] | [INFO] [stderr] 1424 | AllocHC : alloc::Allocator> (mut s : &mut BrotliState, input : &[u8]) { [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:1433:45 [INFO] [stderr] | [INFO] [stderr] 1433 | AllocHC : alloc::Allocator> (mut s : &mut BrotliState, input : &[u8]) -> bool { [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:1440:33 [INFO] [stderr] | [INFO] [stderr] 1440 | (available_out : &mut usize, mut output : &mut [u8], mut output_offset : &mut usize, [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:1440:57 [INFO] [stderr] | [INFO] [stderr] 1440 | (available_out : &mut usize, mut output : &mut [u8], mut output_offset : &mut usize, [INFO] [stderr] | ----^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:1441:20 [INFO] [stderr] | [INFO] [stderr] 1441 | mut total_out : &mut usize, s : &mut BrotliState) -> BrotliResult { [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:2198:3 [INFO] [stderr] | [INFO] [stderr] 2198 | mut available_in : &mut usize, input_offset : &mut usize, xinput : &[u8], // ugly that we are mutable [INFO] [stderr] | ----^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/transform.rs:284:9 [INFO] [stderr] | [INFO] [stderr] 284 | let mut uppercase = &mut dst[(idx - len) as usize ..]; [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:117:10 [INFO] [stderr] | [INFO] [stderr] 117 | return (two_byte[0] as u16) | ((two_byte[1] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(two_byte[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:117:34 [INFO] [stderr] | [INFO] [stderr] 117 | return (two_byte[0] as u16) | ((two_byte[1] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(two_byte[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:124:10 [INFO] [stderr] | [INFO] [stderr] 124 | return (four_byte[0] as u32) | ((four_byte[1] as u32) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(four_byte[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:124:35 [INFO] [stderr] | [INFO] [stderr] 124 | return (four_byte[0] as u32) | ((four_byte[1] as u32) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(four_byte[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:125:10 [INFO] [stderr] | [INFO] [stderr] 125 | | ((four_byte[2] as u32) << 16) | ((four_byte[3] as u32) << 24); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(four_byte[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:125:42 [INFO] [stderr] | [INFO] [stderr] 125 | | ((four_byte[2] as u32) << 16) | ((four_byte[3] as u32) << 24); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(four_byte[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:132:10 [INFO] [stderr] | [INFO] [stderr] 132 | return (eight_byte[0] as u64) | ((eight_byte[1] as u64) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(eight_byte[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:132:36 [INFO] [stderr] | [INFO] [stderr] 132 | return (eight_byte[0] as u64) | ((eight_byte[1] as u64) << 8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(eight_byte[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:133:10 [INFO] [stderr] | [INFO] [stderr] 133 | | ((eight_byte[2] as u64) << 16) | ((eight_byte[3] as u64) << 24) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(eight_byte[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:133:43 [INFO] [stderr] | [INFO] [stderr] 133 | | ((eight_byte[2] as u64) << 16) | ((eight_byte[3] as u64) << 24) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(eight_byte[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:134:10 [INFO] [stderr] | [INFO] [stderr] 134 | | ((eight_byte[4] as u64) << 32) | ((eight_byte[5] as u64) << 40) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(eight_byte[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:134:43 [INFO] [stderr] | [INFO] [stderr] 134 | | ((eight_byte[4] as u64) << 32) | ((eight_byte[5] as u64) << 40) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(eight_byte[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:135:10 [INFO] [stderr] | [INFO] [stderr] 135 | | ((eight_byte[6] as u64) << 48) | ((eight_byte[7] as u64) << 56); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(eight_byte[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:135:43 [INFO] [stderr] | [INFO] [stderr] 135 | | ((eight_byte[6] as u64) << 48) | ((eight_byte[7] as u64) << 56); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(eight_byte[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:160:18 [INFO] [stderr] | [INFO] [stderr] 160 | br.val_ |= (BrotliLoad32LE(input, br.next_in) as reg_t) << 32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(BrotliLoad32LE(input, br.next_in))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:169:20 [INFO] [stderr] | [INFO] [stderr] 169 | br.val_ |= (BrotliLoad32LE(input, br.next_in) << 8) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(BrotliLoad32LE(input, br.next_in) << 8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:177:20 [INFO] [stderr] | [INFO] [stderr] 177 | br.val_ |= (BrotliLoad16LE(input, br.next_in) as reg_t) << 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(BrotliLoad16LE(input, br.next_in))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:208:20 [INFO] [stderr] | [INFO] [stderr] 208 | br.val_ |= (BrotliLoad32LE(input, br.next_in) as reg_t) << 32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(BrotliLoad32LE(input, br.next_in))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:218:20 [INFO] [stderr] | [INFO] [stderr] 218 | br.val_ |= (BrotliLoad32LE(input, br.next_in) as reg_t) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(BrotliLoad32LE(input, br.next_in))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:226:20 [INFO] [stderr] | [INFO] [stderr] 226 | br.val_ |= (BrotliLoad16LE(input, br.next_in) as reg_t) << 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(BrotliLoad16LE(input, br.next_in))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:247:16 [INFO] [stderr] | [INFO] [stderr] 247 | br.val_ |= (input[br.next_in as usize] as reg_t) << 56; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(input[br.next_in as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:249:16 [INFO] [stderr] | [INFO] [stderr] 249 | br.val_ |= (input[br.next_in as usize] as reg_t) << 24; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(input[br.next_in as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:270:39 [INFO] [stderr] | [INFO] [stderr] 270 | return (BrotliGetBitsUnmasked(br) & (0xffffffffu32 as reg_t)) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(0xffffffffu32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/bit_reader/mod.rs:403:11 [INFO] [stderr] | [INFO] [stderr] 403 | assert!((available_bits & 7) == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `available_bits.trailing_zeros() >= 3` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::verbose_bit_mask)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/bit_reader/mod.rs:409:12 [INFO] [stderr] | [INFO] [stderr] 409 | return input[br.next_in as usize + offset as usize] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(input[br.next_in as usize + offset as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: The function/method `BrotliBuildSimpleHuffmanTable` doesn't need a mutable reference [INFO] [stderr] --> src/huffman/tests.rs:110:66 [INFO] [stderr] | [INFO] [stderr] 110 | let goal_size = BrotliBuildSimpleHuffmanTable(&mut table, 8, &mut val, 0); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `BrotliBuildSimpleHuffmanTable` doesn't need a mutable reference [INFO] [stderr] --> src/huffman/tests.rs:123:66 [INFO] [stderr] | [INFO] [stderr] 123 | let goal_size = BrotliBuildSimpleHuffmanTable(&mut table, 8, &mut val, 1); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `BrotliBuildSimpleHuffmanTable` doesn't need a mutable reference [INFO] [stderr] --> src/huffman/tests.rs:140:66 [INFO] [stderr] | [INFO] [stderr] 140 | let goal_size = BrotliBuildSimpleHuffmanTable(&mut table, 8, &mut val, 2); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `BrotliBuildSimpleHuffmanTable` doesn't need a mutable reference [INFO] [stderr] --> src/huffman/tests.rs:153:66 [INFO] [stderr] | [INFO] [stderr] 153 | let goal_size = BrotliBuildSimpleHuffmanTable(&mut table, 8, &mut val, 3); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `BrotliBuildSimpleHuffmanTable` doesn't need a mutable reference [INFO] [stderr] --> src/huffman/tests.rs:168:66 [INFO] [stderr] | [INFO] [stderr] 168 | let goal_size = BrotliBuildSimpleHuffmanTable(&mut table, 8, &mut val, 4); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: defining a method called `eq` on this type; consider implementing the `std::cmp::PartialEq` trait or choosing a less ambiguous name [INFO] [stderr] --> src/huffman/mod.rs:32:3 [INFO] [stderr] | [INFO] [stderr] 32 | / pub fn eq(&self, other: &Self) -> bool { [INFO] [stderr] 33 | | return self.value == other.value && self.bits == other.bits; [INFO] [stderr] 34 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/huffman/mod.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn eq(&self, other: &Self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/huffman/mod.rs:32:27 [INFO] [stderr] | [INFO] [stderr] 32 | pub fn eq(&self, other: &Self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/huffman/mod.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | / pub fn get_tree_mut<'a>(self :&'a mut Self, index : u32) -> &'a mut [HuffmanCode] { [INFO] [stderr] 74 | | let start : usize = self.htrees.slice()[index as usize] as usize; [INFO] [stderr] 75 | | return &mut self.codes.slice_mut()[start..]; [INFO] [stderr] 76 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/huffman/mod.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | / pub fn get_tree<'a>(self :&'a Self, index : u32) -> &'a [HuffmanCode] { [INFO] [stderr] 79 | | let start : usize = self.htrees.slice()[index as usize] as usize; [INFO] [stderr] 80 | | return & self.codes.slice()[start..]; [INFO] [stderr] 81 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the variable `index` is used as a loop counter. Consider using `for (index, item) in self.htrees.slice().enumerate()` or similar iterators [INFO] [stderr] --> src/huffman/mod.rs:99:20 [INFO] [stderr] | [INFO] [stderr] 99 | for htree in self.htrees.slice() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/huffman/mod.rs:166:10 [INFO] [stderr] | [INFO] [stderr] 166 | return kReverseBits[num as usize] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(kReverseBits[num as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/huffman/mod.rs:192:13 [INFO] [stderr] | [INFO] [stderr] 192 | left -= count[len as usize] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(count[len as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/huffman/mod.rs:269:8 [INFO] [stderr] | [INFO] [stderr] 269 | if !(bits <= BROTLI_HUFFMAN_MAX_CODE_LENGTH_CODE_LENGTH as i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `bits > BROTLI_HUFFMAN_MAX_CODE_LENGTH_CODE_LENGTH as i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/huffman/mod.rs:217:15 [INFO] [stderr] | [INFO] [stderr] 217 | symbol += count[bits as usize] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(count[bits as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/huffman/mod.rs:257:32 [INFO] [stderr] | [INFO] [stderr] 257 | let mut bits_count : i32 = count[bits as usize] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(count[bits as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/huffman/mod.rs:323:8 [INFO] [stderr] | [INFO] [stderr] 323 | if !(bits <= table_bits) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `bits > table_bits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/huffman/mod.rs:311:32 [INFO] [stderr] | [INFO] [stderr] 311 | let mut bits_count : i32 = count[bits as usize] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(count[bits as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/huffman/mod.rs:313:16 [INFO] [stderr] | [INFO] [stderr] 313 | symbol = symbol_lists[(symbol_lists_offset as isize + symbol as isize) as usize] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(symbol_lists[(symbol_lists_offset as isize + symbol as isize) as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/huffman/mod.rs:362:16 [INFO] [stderr] | [INFO] [stderr] 362 | symbol = symbol_lists[(symbol_lists_offset as isize + symbol as isize) as usize] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(symbol_lists[(symbol_lists_offset as isize + symbol as isize) as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/huffman/mod.rs:415:7 [INFO] [stderr] | [INFO] [stderr] 415 | / let last : u16; [INFO] [stderr] 416 | | if val.len() > 3 { [INFO] [stderr] 417 | | last = val[3]; [INFO] [stderr] 418 | | } else { [INFO] [stderr] 419 | | last = 65535; [INFO] [stderr] 420 | | } [INFO] [stderr] | |_______^ help: it is more idiomatic to write: `let last = if val.len() > 3 { val[3] } else { 65535 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `mval` manually [INFO] [stderr] --> src/huffman/mod.rs:425:13 [INFO] [stderr] | [INFO] [stderr] 425 | / let t : u16 = mval[k]; [INFO] [stderr] 426 | | mval[k] = mval[i]; [INFO] [stderr] 427 | | mval[i] = t; [INFO] [stderr] | |_______________________^ help: try: `mval.swap(k, i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_swap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `table`. [INFO] [stderr] --> src/huffman/mod.rs:431:16 [INFO] [stderr] | [INFO] [stderr] 431 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 431 | for in table.iter_mut().take(4) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this looks like you are swapping elements of `mval` manually [INFO] [stderr] --> src/huffman/mod.rs:442:9 [INFO] [stderr] | [INFO] [stderr] 442 | / let t : u16 = mval[3]; [INFO] [stderr] 443 | | mval[3] = mval[2]; [INFO] [stderr] 444 | | mval[2] = t; [INFO] [stderr] | |___________________^ help: try: `mval.swap(3, 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `table` [INFO] [stderr] --> src/huffman/mod.rs:446:16 [INFO] [stderr] | [INFO] [stderr] 446 | for i in 0..7 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 446 | for (i, ) in table.iter_mut().enumerate().take(7) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/transform.rs:240:17 [INFO] [stderr] | [INFO] [stderr] 240 | if (p[0] >= 'a' as u8 && p[0] <= 'z' as u8) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/transform.rs:240:38 [INFO] [stderr] | [INFO] [stderr] 240 | if (p[0] >= 'a' as u8 && p[0] <= 'z' as u8) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'z' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/transform.rs:264:5 [INFO] [stderr] | [INFO] [stderr] 264 | / let mut skip : i32; [INFO] [stderr] 265 | | if t < kOmitFirst1 { [INFO] [stderr] 266 | | skip = 0; [INFO] [stderr] 267 | | } else { [INFO] [stderr] 268 | | skip = t as i32 - (kOmitFirst1 - 1) as i32; [INFO] [stderr] 269 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let skip = if t < kOmitFirst1 { 0 } else { t as i32 - (kOmitFirst1 - 1) as i32 };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/transform.rs:268:14 [INFO] [stderr] | [INFO] [stderr] 268 | skip = t as i32 - (kOmitFirst1 - 1) as i32; [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(t)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/transform.rs:268:25 [INFO] [stderr] | [INFO] [stderr] 268 | skip = t as i32 - (kOmitFirst1 - 1) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(kOmitFirst1 - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/transform.rs:277:14 [INFO] [stderr] | [INFO] [stderr] 277 | len -= t as i32; [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(t)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/test.rs:48:28 [INFO] [stderr] | [INFO] [stderr] 48 | assert_eq!(output[i], 'X' as u8); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'X' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/test.rs:49:33 [INFO] [stderr] | [INFO] [stderr] 49 | assert_eq!(output[i + 10], 'Y' as u8); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'Y' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/test.rs:68:25 [INFO] [stderr] | [INFO] [stderr] 68 | assert_eq!(output[0], 'X' as u8); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'X' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:179:5 [INFO] [stderr] | [INFO] [stderr] 179 | 'a, AllocU8 : alloc::Allocator, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:228:19 [INFO] [stderr] | [INFO] [stderr] 228 | while i < s.size_nibbles as i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(s.size_nibbles)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:233:24 [INFO] [stderr] | [INFO] [stderr] 233 | if (i + 1 == s.size_nibbles as i32 && s.size_nibbles > 4 && bits == 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(s.size_nibbles)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:277:19 [INFO] [stderr] | [INFO] [stderr] 277 | while i < s.size_nibbles as i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(s.size_nibbles)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:282:24 [INFO] [stderr] | [INFO] [stderr] 282 | if (i + 1 == s.size_nibbles as i32 && s.size_nibbles > 1 && bits == 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(s.size_nibbles)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:306:20 [INFO] [stderr] | [INFO] [stderr] 306 | table_index += table_element.value as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(table_element.value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:308:82 [INFO] [stderr] | [INFO] [stderr] 308 | + ((bits >> HUFFMAN_TABLE_BITS) & bit_reader::BitMask(nbits as u32))) as usize]; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(nbits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:310:34 [INFO] [stderr] | [INFO] [stderr] 310 | bit_reader::BrotliDropBits(br, table_element.bits as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(table_element.bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:311:10 [INFO] [stderr] | [INFO] [stderr] 311 | return table_element.value as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(table_element.value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: The function/method `bit_reader::BrotliGetAvailableBits` doesn't need a mutable reference [INFO] [stderr] --> src/lib.rs:327:63 [INFO] [stderr] | [INFO] [stderr] 327 | let mut available_bits = bit_reader::BrotliGetAvailableBits(&mut br); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:330:17 [INFO] [stderr] | [INFO] [stderr] 330 | *result = table[0].value as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(table[0].value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:339:9 [INFO] [stderr] | [INFO] [stderr] 339 | if (table_element.bits as u32 <= available_bits) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(table_element.bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:340:43 [INFO] [stderr] | [INFO] [stderr] 340 | bit_reader::BrotliDropBits(&mut br, table_element.bits as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(table_element.bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:341:17 [INFO] [stderr] | [INFO] [stderr] 341 | *result = table_element.value as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(table_element.value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:352:36 [INFO] [stderr] | [INFO] [stderr] 352 | val = (val & bit_reader::BitMask(table_element.bits as u32)) >> HUFFMAN_TABLE_BITS; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(table_element.bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:355:24 [INFO] [stderr] | [INFO] [stderr] 355 | if (available_bits < table_sub_element.bits as u32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(table_sub_element.bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:359:60 [INFO] [stderr] | [INFO] [stderr] 359 | bit_reader::BrotliDropBits(&mut br, HUFFMAN_TABLE_BITS + table_sub_element.bits as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(table_sub_element.bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:360:13 [INFO] [stderr] | [INFO] [stderr] 360 | *result = table_sub_element.value as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(table_sub_element.value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:389:11 [INFO] [stderr] | [INFO] [stderr] 389 | *bits = table_element.bits as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(table_element.bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:390:12 [INFO] [stderr] | [INFO] [stderr] 390 | *value = table_element.value as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(table_element.value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:400:3 [INFO] [stderr] | [INFO] [stderr] 400 | / let mut result = *value; [INFO] [stderr] 401 | | if *bits > HUFFMAN_TABLE_BITS { [INFO] [stderr] 402 | | mark_unlikely(); [INFO] [stderr] 403 | | let val = bit_reader::BrotliGet16BitsUnmasked(br, input); [INFO] [stderr] ... | [INFO] [stderr] 412 | | bit_reader::BrotliDropBits(br, *bits); [INFO] [stderr] 413 | | } [INFO] [stderr] | |___^ help: it is more idiomatic to write: `let result = if *bits > HUFFMAN_TABLE_BITS { ..; ext.value as u32 } else { ..; *value };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:409:36 [INFO] [stderr] | [INFO] [stderr] 409 | bit_reader::BrotliDropBits(br, ext.bits as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(ext.bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:410:14 [INFO] [stderr] | [INFO] [stderr] 410 | result = ext.value as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(ext.value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:433:5 [INFO] [stderr] | [INFO] [stderr] 433 | 'a, AllocU8 : alloc::Allocator, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:444:51 [INFO] [stderr] | [INFO] [stderr] 444 | for symbols_lists_item in s.symbols_lists_array[s.sub_loop_counter as usize .. [INFO] [stderr] | ___________________________________________________^ [INFO] [stderr] 445 | | num_symbols as usize + 1].iter_mut() { [INFO] [stderr] | |__________________________________________________________________________^ help: use: `s.sub_loop_counter as usize..=num_symbols as usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:462:45 [INFO] [stderr] | [INFO] [stderr] 462 | for other_item in s.symbols_lists_array[i as usize + 1 .. num_symbols as usize+ 1].iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `i as usize + 1..=num_symbols as usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/lib.rs:480:1 [INFO] [stderr] | [INFO] [stderr] 480 | / fn ProcessSingleCodeLength(code_len : u32, [INFO] [stderr] 481 | | symbol : &mut u32, repeat : &mut u32, space : &mut u32, [INFO] [stderr] 482 | | prev_code_len : &mut u32, symbol_lists : &mut [u16], symbol_list_index_offset : usize, [INFO] [stderr] 483 | | code_length_histo : &mut [u16], next_symbol : &mut [i32]) { [INFO] [stderr] ... | [INFO] [stderr] 494 | | (*symbol) += 1; [INFO] [stderr] 495 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> src/lib.rs:506:1 [INFO] [stderr] | [INFO] [stderr] 506 | / fn ProcessRepeatedCodeLength(code_len : u32, [INFO] [stderr] 507 | | mut repeat_delta : u32, alphabet_size : u32, symbol : &mut u32, [INFO] [stderr] 508 | | repeat : &mut u32, space : &mut u32, prev_code_len : &mut u32, [INFO] [stderr] 509 | | repeat_code_len : &mut u32, symbol_lists : &mut [u16], symbol_lists_index : usize, [INFO] [stderr] ... | [INFO] [stderr] 552 | | } [INFO] [stderr] 553 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:512:3 [INFO] [stderr] | [INFO] [stderr] 512 | / let mut new_len : u32 = 0; [INFO] [stderr] 513 | | if (code_len == kCodeLengthRepeatCode) { [INFO] [stderr] 514 | | new_len = *prev_code_len; [INFO] [stderr] 515 | | } [INFO] [stderr] | |___^ help: it is more idiomatic to write: `let new_len = if (code_len == kCodeLengthRepeatCode) { *prev_code_len } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:549:10 [INFO] [stderr] | [INFO] [stderr] 549 | (code_length_histo[*repeat_code_len as usize] as u32 + repeat_delta) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(code_length_histo[*repeat_code_len as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:557:5 [INFO] [stderr] | [INFO] [stderr] 557 | 'a, AllocU8 : alloc::Allocator, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:585:9 [INFO] [stderr] | [INFO] [stderr] 585 | bit_reader::BitMask(huffman::BROTLI_HUFFMAN_MAX_CODE_LENGTH_CODE_LENGTH as u32) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(bit_reader::BitMask(huffman::BROTLI_HUFFMAN_MAX_CODE_LENGTH_CODE_LENGTH as u32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:587:43 [INFO] [stderr] | [INFO] [stderr] 587 | bit_reader::BrotliDropBits(&mut s.br, p.bits as u32); /* Use 1..5 bits */ [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(p.bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:588:16 [INFO] [stderr] | [INFO] [stderr] 588 | code_len = p.value as u32; /* code_len == 0..17 */ [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(p.value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:608:5 [INFO] [stderr] | [INFO] [stderr] 608 | 'a, AllocU8 : alloc::Allocator, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:624:9 [INFO] [stderr] | [INFO] [stderr] 624 | if (p.bits as u32> available_bits) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(p.bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:631:16 [INFO] [stderr] | [INFO] [stderr] 631 | code_len = p.value as u32; /* code_len == 0..17 */ [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(p.value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:633:45 [INFO] [stderr] | [INFO] [stderr] 633 | bit_reader::BrotliDropBits(&mut s.br, p.bits as u32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(p.bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:641:28 [INFO] [stderr] | [INFO] [stderr] 641 | if (available_bits < p.bits as u32 + extra_bits) { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(p.bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:648:45 [INFO] [stderr] | [INFO] [stderr] 648 | bit_reader::BrotliDropBits(&mut s.br, p.bits as u32 + extra_bits); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(p.bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:662:5 [INFO] [stderr] | [INFO] [stderr] 662 | 'a, AllocU8 : alloc::Allocator, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:683:11 [INFO] [stderr] | [INFO] [stderr] 683 | if (kCodeLengthPrefixLength[ix as usize] as u32 > available_bits) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(kCodeLengthPrefixLength[ix as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:692:19 [INFO] [stderr] | [INFO] [stderr] 692 | let v : u32 = kCodeLengthPrefixValue[ix as usize] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(kCodeLengthPrefixValue[ix as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:693:43 [INFO] [stderr] | [INFO] [stderr] 693 | bit_reader::BrotliDropBits(&mut s.br, kCodeLengthPrefixLength[ix as usize] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(kCodeLengthPrefixLength[ix as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:697:7 [INFO] [stderr] | [INFO] [stderr] 697 | space = space - (32 >> v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `space -= (32 >> v)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:727:5 [INFO] [stderr] | [INFO] [stderr] 727 | 'a, AllocU8 : alloc::Allocator, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:753:56 [INFO] [stderr] | [INFO] [stderr] 753 | for code_length_histo in s.code_length_histo[..huffman::BROTLI_HUFFMAN_MAX_CODE_LENGTH_CODE_LENGTH as usize + 1].iter_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `..=huffman::BROTLI_HUFFMAN_MAX_CODE_LENGTH_CODE_LENGTH as usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:798:9 [INFO] [stderr] | [INFO] [stderr] 798 | / match opt_table_size { [INFO] [stderr] 799 | | Some(opt_table_size_ref) => *opt_table_size_ref = table_size, [INFO] [stderr] 800 | | None => {}, [INFO] [stderr] 801 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(opt_table_size_ref) = opt_table_size { *opt_table_size_ref = table_size }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: The function/method `huffman::BrotliBuildCodeLengthsHuffmanTable` doesn't need a mutable reference [INFO] [stderr] --> src/lib.rs:815:53 [INFO] [stderr] | [INFO] [stderr] 815 | &mut s.code_length_code_lengths, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `huffman::BrotliBuildCodeLengthsHuffmanTable` doesn't need a mutable reference [INFO] [stderr] --> src/lib.rs:816:53 [INFO] [stderr] | [INFO] [stderr] 816 | &mut s.code_length_histo); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in s.next_symbol[..huffman::BROTLI_HUFFMAN_MAX_CODE_LENGTH as usize + 1].iter_mut().enumerate()` or similar iterators [INFO] [stderr] --> src/lib.rs:822:32 [INFO] [stderr] | [INFO] [stderr] 822 | for next_symbol_mut in s.next_symbol[..huffman::BROTLI_HUFFMAN_MAX_CODE_LENGTH as usize + 1].iter_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:822:46 [INFO] [stderr] | [INFO] [stderr] 822 | for next_symbol_mut in s.next_symbol[..huffman::BROTLI_HUFFMAN_MAX_CODE_LENGTH as usize + 1].iter_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `..=huffman::BROTLI_HUFFMAN_MAX_CODE_LENGTH as usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:841:9 [INFO] [stderr] | [INFO] [stderr] 841 | / match result { [INFO] [stderr] 842 | | BrotliResult::NeedsMoreInput => result = SafeReadSymbolCodeLengths(alphabet_size, s, input), [INFO] [stderr] 843 | | _ => {}, [INFO] [stderr] 844 | | } [INFO] [stderr] | |_________^ help: try this: `if let BrotliResult::NeedsMoreInput = result { result = SafeReadSymbolCodeLengths(alphabet_size, s, input) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:856:9 [INFO] [stderr] | [INFO] [stderr] 856 | / match opt_table_size { [INFO] [stderr] 857 | | Some(opt_table_size_ref) => *opt_table_size_ref = table_size, [INFO] [stderr] 858 | | None => {}, [INFO] [stderr] 859 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(opt_table_size_ref) = opt_table_size { *opt_table_size_ref = table_size }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:874:11 [INFO] [stderr] | [INFO] [stderr] 874 | nbits = prefix::kBlockLengthPrefixCode[code as usize].nbits as u32; /* nbits == 2..24 */ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(prefix::kBlockLengthPrefixCode[code as usize].nbits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:875:10 [INFO] [stderr] | [INFO] [stderr] 875 | return prefix::kBlockLengthPrefixCode[code as usize].offset as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(prefix::kBlockLengthPrefixCode[code as usize].offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:910:45 [INFO] [stderr] | [INFO] [stderr] 910 | if (!bit_reader::BrotliSafeReadBits(br, nbits as u32, &mut bits, input)) { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(nbits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:916:15 [INFO] [stderr] | [INFO] [stderr] 916 | *result = prefix::kBlockLengthPrefixCode[index as usize].offset as u32 + bits; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(prefix::kBlockLengthPrefixCode[index as usize].offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in mtf[0..(upper_bound as usize + 1usize)].iter_mut().enumerate()` or similar iterators [INFO] [stderr] --> src/lib.rs:950:15 [INFO] [stderr] | [INFO] [stderr] 950 | for item in mtf[0..(upper_bound as usize + 1usize)].iter_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:950:19 [INFO] [stderr] | [INFO] [stderr] 950 | for item in mtf[0..(upper_bound as usize + 1usize)].iter_mut() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=upper_bound as usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:958:21 [INFO] [stderr] | [INFO] [stderr] 958 | let mut index = (*v_i) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from((*v_i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:960:20 [INFO] [stderr] | [INFO] [stderr] 960 | upper_bound |= (*v_i) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from((*v_i))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:980:3 [INFO] [stderr] | [INFO] [stderr] 980 | 'a, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1020:30 [INFO] [stderr] | [INFO] [stderr] 1020 | result = ReadHuffmanCode(alphabet_size as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(alphabet_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:1056:3 [INFO] [stderr] | [INFO] [stderr] 1056 | / match result { [INFO] [stderr] 1057 | | BrotliResult::ResultSuccess => s.substate_tree_group = BrotliRunningTreeGroupState::BROTLI_STATE_TREE_GROUP_NONE, [INFO] [stderr] 1058 | | _ => {}, [INFO] [stderr] 1059 | | } [INFO] [stderr] | |___^ help: try this: `if let BrotliResult::ResultSuccess = result { s.substate_tree_group = BrotliRunningTreeGroupState::BROTLI_STATE_TREE_GROUP_NONE }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:1081:3 [INFO] [stderr] | [INFO] [stderr] 1081 | 'a, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:1154:9 [INFO] [stderr] | [INFO] [stderr] 1154 | / let mut rleCodeGoto : bool = false; [INFO] [stderr] 1155 | | if (code != 0xFFFF) { [INFO] [stderr] 1156 | | rleCodeGoto = true; [INFO] [stderr] 1157 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let rleCodeGoto = if (code != 0xFFFF) { true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:1230:3 [INFO] [stderr] | [INFO] [stderr] 1230 | 'a, AllocU8 : alloc::Allocator, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:1244:3 [INFO] [stderr] | [INFO] [stderr] 1244 | / let mut context_map_arg : AllocU8::AllocatedMemory; [INFO] [stderr] 1245 | | if is_dist_context_map { [INFO] [stderr] 1246 | | num_htrees = s.num_dist_htrees; [INFO] [stderr] 1247 | | context_map_arg = mem::replace(&mut s.dist_context_map, [INFO] [stderr] ... | [INFO] [stderr] 1252 | | AllocU8::AllocatedMemory::default()); [INFO] [stderr] 1253 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 1244 | let context_map_arg = if is_dist_context_map { ..; mem::replace(&mut s.dist_context_map, [INFO] [stderr] 1245 | AllocU8::AllocatedMemory::default()) } else { ..; mem::replace(&mut s.context_map, [INFO] [stderr] 1246 | AllocU8::AllocatedMemory::default()) }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:1373:3 [INFO] [stderr] | [INFO] [stderr] 1373 | 'a, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:1387:3 [INFO] [stderr] | [INFO] [stderr] 1387 | 'a, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:1395:3 [INFO] [stderr] | [INFO] [stderr] 1395 | 'a, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:1405:3 [INFO] [stderr] | [INFO] [stderr] 1405 | 'a, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:1421:3 [INFO] [stderr] | [INFO] [stderr] 1421 | 'a, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:1430:3 [INFO] [stderr] | [INFO] [stderr] 1430 | 'a, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:1437:20 [INFO] [stderr] | [INFO] [stderr] 1437 | fn WriteRingBuffer<'a, AllocU8 : alloc::Allocator, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:1442:3 [INFO] [stderr] | [INFO] [stderr] 1442 | / let pos : usize; [INFO] [stderr] 1443 | | if s.pos > s.ringbuffer_size { [INFO] [stderr] 1444 | | pos = s.ringbuffer_size as usize; [INFO] [stderr] 1445 | | } else { [INFO] [stderr] 1446 | | pos = s.pos as usize; [INFO] [stderr] 1447 | | } [INFO] [stderr] | |___^ help: it is more idiomatic to write: `let pos = if s.pos > s.ringbuffer_size { s.ringbuffer_size as usize } else { s.pos as usize };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:1473:34 [INFO] [stderr] | [INFO] [stderr] 1473 | fn CopyUncompressedBlockToOutput<'a, AllocU8 : alloc::Allocator, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:1527:5 [INFO] [stderr] | [INFO] [stderr] 1527 | 'a, AllocU8 : alloc::Allocator, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:1565:6 [INFO] [stderr] | [INFO] [stderr] 1565 | if (s.ringbuffer.slice().len() == 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.ringbuffer.slice().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:1570:6 [INFO] [stderr] | [INFO] [stderr] 1570 | if (s.custom_dict.slice().len() > 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.custom_dict.slice().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:1580:25 [INFO] [stderr] | [INFO] [stderr] 1580 | pub fn ReadContextModes<'a, AllocU8 : alloc::Allocator, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:1605:35 [INFO] [stderr] | [INFO] [stderr] 1605 | pub fn TakeDistanceFromRingBuffer<'a, AllocU8 : alloc::Allocator, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:1647:29 [INFO] [stderr] | [INFO] [stderr] 1647 | pub fn ReadDistanceInternal<'a, AllocU8 : alloc::Allocator, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: The function/method `bit_reader::BrotliBitReaderRestoreState` doesn't need a mutable reference [INFO] [stderr] --> src/lib.rs:1694:62 [INFO] [stderr] | [INFO] [stderr] 1694 | bit_reader::BrotliBitReaderRestoreState(&mut s.br, &mut memento); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:1711:28 [INFO] [stderr] | [INFO] [stderr] 1711 | pub fn ReadCommandInternal<'a, AllocU8 : alloc::Allocator, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1734:21 [INFO] [stderr] | [INFO] [stderr] 1734 | s.distance_code = v.distance_code as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(v.distance_code)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1735:24 [INFO] [stderr] | [INFO] [stderr] 1735 | s.distance_context = v.context as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from(v.context)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1738:20 [INFO] [stderr] | [INFO] [stderr] 1738 | *insert_length = v.insert_len_offset as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(v.insert_len_offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1742:64 [INFO] [stderr] | [INFO] [stderr] 1742 | insert_len_extra = bit_reader::BrotliReadBits(&mut s.br, v.insert_len_extra_bits as u32, input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(v.insert_len_extra_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1744:57 [INFO] [stderr] | [INFO] [stderr] 1744 | copy_length = bit_reader::BrotliReadBits(&mut s.br, v.copy_len_extra_bits as u32, input); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(v.copy_len_extra_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1746:34 [INFO] [stderr] | [INFO] [stderr] 1746 | if (!SafeReadBits(&mut s.br, v.insert_len_extra_bits as u32, &mut insert_len_extra, input)) || [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(v.insert_len_extra_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1747:34 [INFO] [stderr] | [INFO] [stderr] 1747 | (!SafeReadBits(&mut s.br, v.copy_len_extra_bits as u32, &mut copy_length, input)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(v.copy_len_extra_bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1752:40 [INFO] [stderr] | [INFO] [stderr] 1752 | s.copy_length = copy_length as i32 + v.copy_len_offset as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(v.copy_len_offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: The function/method `clone_from_slice` doesn't need a mutable reference [INFO] [stderr] --> src/lib.rs:1799:34 [INFO] [stderr] | [INFO] [stderr] 1799 | local_array.clone_from_slice(&mut data[off_src as usize .. off_src as usize + 16]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `clone_from_slice` doesn't need a mutable reference [INFO] [stderr] --> src/lib.rs:1800:70 [INFO] [stderr] | [INFO] [stderr] 1800 | data[off_dst as usize .. off_dst as usize + 16].clone_from_slice(&mut local_array); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 46 [INFO] [stderr] --> src/lib.rs:1818:1 [INFO] [stderr] | [INFO] [stderr] 1818 | / fn ProcessCommandsInternal< [INFO] [stderr] 1819 | | AllocU8 : alloc::Allocator, [INFO] [stderr] 1820 | | AllocU32 : alloc::Allocator, [INFO] [stderr] 1821 | | AllocHC : alloc::Allocator > (safe : bool, [INFO] [stderr] ... | [INFO] [stderr] 2173 | | return result; [INFO] [stderr] 2174 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:2027:22 [INFO] [stderr] | [INFO] [stderr] 2027 | if (i >= kBrotliMinDictionaryWordLength as i32 && [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(kBrotliMinDictionaryWordLength)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:2028:22 [INFO] [stderr] | [INFO] [stderr] 2028 | i <= kBrotliMaxDictionaryWordLength as i32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(kBrotliMaxDictionaryWordLength)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:2032:46 [INFO] [stderr] | [INFO] [stderr] 2032 | let mask = bit_reader::BitMask(shift as u32) as i32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(shift)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:2177:5 [INFO] [stderr] | [INFO] [stderr] 2177 | 'a, AllocU8 : alloc::Allocator, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:2185:5 [INFO] [stderr] | [INFO] [stderr] 2185 | 'a, AllocU8 : alloc::Allocator, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:2195:31 [INFO] [stderr] | [INFO] [stderr] 2195 | pub fn BrotliDecompressStream<'a, AllocU8 : alloc::Allocator, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 55 [INFO] [stderr] --> src/lib.rs:2195:1 [INFO] [stderr] | [INFO] [stderr] 2195 | / pub fn BrotliDecompressStream<'a, AllocU8 : alloc::Allocator, [INFO] [stderr] 2196 | | AllocU32 : alloc::Allocator, [INFO] [stderr] 2197 | | AllocHC : alloc::Allocator> ( [INFO] [stderr] 2198 | | mut available_in : &mut usize, input_offset : &mut usize, xinput : &[u8], // ugly that we are mutable [INFO] [stderr] ... | [INFO] [stderr] 2680 | | return result; [INFO] [stderr] 2681 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/lib.rs:2195:1 [INFO] [stderr] | [INFO] [stderr] 2195 | / pub fn BrotliDecompressStream<'a, AllocU8 : alloc::Allocator, [INFO] [stderr] 2196 | | AllocU32 : alloc::Allocator, [INFO] [stderr] 2197 | | AllocHC : alloc::Allocator> ( [INFO] [stderr] 2198 | | mut available_in : &mut usize, input_offset : &mut usize, xinput : &[u8], // ugly that we are mutable [INFO] [stderr] ... | [INFO] [stderr] 2680 | | return result; [INFO] [stderr] 2681 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:2205:36 [INFO] [stderr] | [INFO] [stderr] 2205 | let mut saved_buffer : [u8; 8] = s.buffer.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `s.buffer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:2236:16 [INFO] [stderr] | [INFO] [stderr] 2236 | if s.ringbuffer.slice().len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.ringbuffer.slice().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:2330:14 [INFO] [stderr] | [INFO] [stderr] 2330 | if (s.block_type_length_state.block_type_trees.slice().len() == 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.block_type_length_state.block_type_trees.slice().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:2370:14 [INFO] [stderr] | [INFO] [stderr] 2370 | if (s.ringbuffer.slice().len() == 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.ringbuffer.slice().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:2406:11 [INFO] [stderr] | [INFO] [stderr] 2406 | / match result { [INFO] [stderr] 2407 | | BrotliResult::ResultSuccess => s.state = BrotliRunningState::BROTLI_STATE_METABLOCK_DONE, [INFO] [stderr] 2408 | | _ => {}, [INFO] [stderr] 2409 | | } [INFO] [stderr] | |___________^ help: try this: `if let BrotliResult::ResultSuccess = result { s.state = BrotliRunningState::BROTLI_STATE_METABLOCK_DONE }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:2496:14 [INFO] [stderr] | [INFO] [stderr] 2496 | if (s.context_modes.slice().len() == 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.context_modes.slice().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the variable `j` is used as a loop counter. Consider using `for (j, item) in s.context_map.slice()[0 .. (s.block_type_length_state.num_block_types[0] as usize) << (kLiteralContextBits as usize)].iter().enumerate()` or similar iterators [INFO] [stderr] --> src/lib.rs:2522:35 [INFO] [stderr] | [INFO] [stderr] 2522 | for context_map_item in s.context_map.slice()[0 .. (s.block_type_length_state.num_block_types[0] as usize) << (kLiteralContextBits as usize)].iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:2553:17 [INFO] [stderr] | [INFO] [stderr] 2553 | if (s.literal_hgroup.codes.slice().len() == 0 || [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.literal_hgroup.codes.slice().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:2554:17 [INFO] [stderr] | [INFO] [stderr] 2554 | s.insert_copy_hgroup.codes.slice().len() == 0 || [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.insert_copy_hgroup.codes.slice().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:2555:17 [INFO] [stderr] | [INFO] [stderr] 2555 | s.distance_hgroup.codes.slice().len() == 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.distance_hgroup.codes.slice().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:2589:11 [INFO] [stderr] | [INFO] [stderr] 2589 | / match result { [INFO] [stderr] 2590 | | BrotliResult::NeedsMoreInput => result = SafeProcessCommands(s, local_input), [INFO] [stderr] 2591 | | _ => {}, [INFO] [stderr] 2592 | | } [INFO] [stderr] | |___________^ help: try this: `if let BrotliResult::NeedsMoreInput = result { result = SafeProcessCommands(s, local_input) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:2667:14 [INFO] [stderr] | [INFO] [stderr] 2667 | if (s.ringbuffer.slice().len() != 0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.ringbuffer.slice().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/bin/brot.rs:76:63 [INFO] [stderr] | [INFO] [stderr] 76 | pub fn decompress (r : &mut InputType, mut w : &mut OutputType) -> Result<(), io::Error> [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/bin/brot.rs:76:63 [INFO] [stderr] | [INFO] [stderr] 76 | pub fn decompress (r : &mut InputType, mut w : &mut OutputType) -> Result<(), io::Error> [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/bin/brot.rs:144:7 [INFO] [stderr] | [INFO] [stderr] 144 | total = total + delta; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total += delta` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/bin/integration_tests.rs:57:34 [INFO] [stderr] | [INFO] [stderr] 57 | assert_eq!(output.data[i], 'X' as u8); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'X' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/bin/integration_tests.rs:58:39 [INFO] [stderr] | [INFO] [stderr] 58 | assert_eq!(output.data[i + 10], 'Y' as u8); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'Y' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/bin/integration_tests.rs:77:34 [INFO] [stderr] | [INFO] [stderr] 77 | assert_eq!(output.data[i], 'X' as u8); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'X' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/bin/integration_tests.rs:78:39 [INFO] [stderr] | [INFO] [stderr] 78 | assert_eq!(output.data[i + 10], 'Y' as u8); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'Y' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/bin/integration_tests.rs:97:34 [INFO] [stderr] | [INFO] [stderr] 97 | assert_eq!(output.data[i], 'X' as u8); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'X' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/bin/integration_tests.rs:98:39 [INFO] [stderr] | [INFO] [stderr] 98 | assert_eq!(output.data[i + 10], 'Y' as u8); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'Y' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/bin/brot.rs:144:7 [INFO] [stderr] | [INFO] [stderr] 144 | total = total + delta; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total += delta` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 28.90s [INFO] running `"docker" "inspect" "c84dc1aa8646fe4c97ce289a9284a4900369e9a63b98087db154bfca123f761a"` [INFO] running `"docker" "rm" "-f" "c84dc1aa8646fe4c97ce289a9284a4900369e9a63b98087db154bfca123f761a"` [INFO] [stdout] c84dc1aa8646fe4c97ce289a9284a4900369e9a63b98087db154bfca123f761a